)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"487cb29bde05d6730362872a8e8223b0e76e6461","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to symlink host python packages into venv"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some python packages have C bindings which tend to be very"},{"line_number":10,"context_line":"particular about the version of their companion packages."},{"line_number":11,"context_line":"To ensure things run smoothly for stable releases, we opt to"},{"line_number":12,"context_line":"use the distro packages for these and symlink the appropriate"},{"line_number":13,"context_line":"library files and binding into the venv."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_9ea60855","line":10,"range":{"start_line":9,"start_character":26,"end_line":10,"end_character":56},"updated":"2018-12-10 13:16:31.000000000","message":"Feels to me like there are 3 moving parts here, some C libraries, some python C bindings for those libraries and some pure python libraries.\n\nI think from the description that this patch is trying to ensure that the C bindings and python libs are correctly matching - if so this could be made clearer in the commit message.\n\nBy extension is there any need to ensure that the python C bindings are linking against the correct underlying .so library? .... unless this is somehow implicit.","commit_id":"d4974695026e1fefeb64156cde5c5641394ec204"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1c49ed967e98e1f7d227161d04ed2628883a1ec8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to symlink host python packages into venv"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some python packages have C bindings which tend to be very"},{"line_number":10,"context_line":"particular about the version of their companion packages."},{"line_number":11,"context_line":"To ensure things run smoothly for stable releases, we opt to"},{"line_number":12,"context_line":"use the distro packages for these and symlink the appropriate"},{"line_number":13,"context_line":"library files and binding into the venv."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_8f681489","line":10,"range":{"start_line":9,"start_character":26,"end_line":10,"end_character":56},"in_reply_to":"3f79a3b5_9ea60855","updated":"2018-12-10 15:02:00.000000000","message":"All we\u0027re doing in this patch is providing a facility to symlink python packages from the host into the env like we do for ceph (in ceph-client) and libvirt (in os_nova). For both examples we have to use the python libraries which come with distro packages rather than build our own wheels - this is the simplest way to keep the versions matching between the python libraries (eg libvirt-python) and the counterpart C binaries (eg: libvirt-bin).\n\nIf this makes sense, could you suggest a rephrase that captures this?","commit_id":"d4974695026e1fefeb64156cde5c5641394ec204"}]}