)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1aaeb18a9c2046b9f3a88752bf6c6138bde3c6c0","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-02-03 23:43:39 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Save current network on /etc/systemd/network."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NetworkManager is masked on RHEL based systems, leaving the machine"},{"line_number":10,"context_line":"without external network access after a reboot."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This changes stores the current ipv4 configuration as a .network file"},{"line_number":13,"context_line":"for networkd, persisting the current network."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b7358fec_42903537","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":47},"updated":"2025-02-04 09:00:06.000000000","message":"Is networkmanager masked becasue systemd-networkd has been installed? It\u0027s not clear from the message here.","commit_id":"9ba668cf49f90996e33ada9428580031c68c9af8"},{"author":{"_account_id":37705,"name":"Hector Vido","display_name":"Hector Vido","email":"hector_vido@yahoo.com.br","username":"hectorvido"},"change_message_id":"7013d1bc8087fba8b95463f45a4efcdb5cc73ae1","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-02-03 23:43:39 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Save current network on /etc/systemd/network."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NetworkManager is masked on RHEL based systems, leaving the machine"},{"line_number":10,"context_line":"without external network access after a reboot."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This changes stores the current ipv4 configuration as a .network file"},{"line_number":13,"context_line":"for networkd, persisting the current network."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"94d37844_bceae679","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":47},"in_reply_to":"b7358fec_42903537","updated":"2025-02-04 12:54:12.000000000","message":"Exactly, after systemd-network installation, NetworkManager is masked and all configurations are ignored on the next boot.","commit_id":"9ba668cf49f90996e33ada9428580031c68c9af8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bbd4f31763777a0cf15a1e6364fdf20a30a2c774","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05f8052b_08e2913a","updated":"2025-02-04 12:32:46.000000000","message":"I think I would suggest here either to supply default network config manually, with stopping/masking NetworkManager or whatever tool can be used on the playbook level in pre_tasks, or use systemd_network overrides approach, like proposed here: https://review.opendev.org/c/openstack/ansible-role-systemd_networkd/+/940324\n\n\nAs this approach is going to have quite some side-effects depending on the OS and their version.","commit_id":"9ba668cf49f90996e33ada9428580031c68c9af8"},{"author":{"_account_id":37705,"name":"Hector Vido","display_name":"Hector Vido","email":"hector_vido@yahoo.com.br","username":"hectorvido"},"change_message_id":"c6d39db5d89c6fe6b2d91cf073b0c5b6ccf4b6de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ae4f4893_7740c94c","in_reply_to":"05f8052b_08e2913a","updated":"2025-02-04 17:26:17.000000000","message":"I think setting it manually is a good approach. I am just testing this with AIO installation, maybe we can do something only for AIO?\n\nI am not sure why systemd-networkd is replacing NetworkManager, the epel-release is enabled just to install it.","commit_id":"9ba668cf49f90996e33ada9428580031c68c9af8"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"3974aeabdad095ff2a2aada6d7ee246a583e421e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d720547c_4e201b7c","updated":"2025-04-02 14:49:43.000000000","message":"I still don\u0027t think we want to add the default network stuff in here.","commit_id":"c81199ae42e5d890446f46b1ca896e48ef60be92"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9ef9c6379ca69559163eff447b6324fd0a608a4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09522deb_3ed85735","updated":"2025-02-04 13:06:18.000000000","message":"In fact - is it actually this task which is stopping/masking networkmanager? https://github.com/openstack/openstack-ansible/blob/master/tests/roles/bootstrap-host/tasks/prepare_networking.yml#L35-L43","commit_id":"c81199ae42e5d890446f46b1ca896e48ef60be92"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"361914d8cb8c21a1cdeecb57bcf4dfe17eb17684","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aeb75749_97b268b9","updated":"2025-03-20 13:21:01.000000000","message":"oops, wrong patch, sorry","commit_id":"c81199ae42e5d890446f46b1ca896e48ef60be92"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f3974d08fe747b7c6c7f101eafe3d029fd3b9f5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbc82ccb_83edd4fe","updated":"2025-04-02 12:29:33.000000000","message":"recheck - intermittent failures","commit_id":"c81199ae42e5d890446f46b1ca896e48ef60be92"},{"author":{"_account_id":37705,"name":"Hector Vido","display_name":"Hector Vido","email":"hector_vido@yahoo.com.br","username":"hectorvido"},"change_message_id":"c6d39db5d89c6fe6b2d91cf073b0c5b6ccf4b6de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34b68443_a0f58056","in_reply_to":"09522deb_3ed85735","updated":"2025-02-04 17:26:17.000000000","message":"Yes, well, if you want - and I was able to - I can try to make everything working with NetworkManager, but I guess I will need to provision a more \"real\" Openstack instead of AIO version.","commit_id":"c81199ae42e5d890446f46b1ca896e48ef60be92"}],"tasks/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1aaeb18a9c2046b9f3a88752bf6c6138bde3c6c0","unresolved":true,"context_lines":[{"line_number":168,"context_line":"  ansible.builtin.set_fact:"},{"line_number":169,"context_line":"    systemd_networks: \u003e-"},{"line_number":170,"context_line":"      {{ systemd_networks + [{"},{"line_number":171,"context_line":"        \"interface\" : network.ansible_facts.ansible_default_ipv4.interface,"},{"line_number":172,"context_line":"        \"address\" : network.ansible_facts.ansible_default_ipv4.address,"},{"line_number":173,"context_line":"        \"netmask\" : network.ansible_facts.ansible_default_ipv4.netmask,"},{"line_number":174,"context_line":"        \"gateway\" : network.ansible_facts.ansible_default_ipv4.gateway,"},{"line_number":175,"context_line":"        \"dns\" : network.ansible_facts.ansible_dns.nameservers | first"},{"line_number":176,"context_line":"      }] }}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"- name: Create systemd-networkd network link(s)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f99e3ef_8f8817f9","line":175,"range":{"start_line":171,"start_character":0,"end_line":175,"end_character":69},"updated":"2025-02-04 09:00:06.000000000","message":"This will not work in all situations as a default route may not be present. An example from one of my compute nodes:\n\n```\n  root@compute101:~# ip r\n  10.48.0.0/16 via 10.48.1.5 dev br-mgmt\n  10.48.1.0/24 dev br-mgmt proto kernel scope link src 10.48.1.128\n  10.49.0.0/16 via 10.51.1.5 dev bond0.1951\n  10.51.0.0/16 via 10.51.1.5 dev bond0.1951\n  10.51.1.0/24 dev bond0.1951 proto kernel scope link src 10.51.1.128\n  10.52.0.0/16 via 10.52.1.5 dev enp24s0f0\n  10.52.1.0/24 dev enp24s0f0 proto kernel scope link src 10.52.1.128\n  10.54.0.0/16 via 10.54.1.5 dev bond0.1954\n  10.54.1.0/24 dev bond0.1954 proto kernel scope link src 10.54.1.128\n```","commit_id":"9ba668cf49f90996e33ada9428580031c68c9af8"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9136f8c09cbcf734881becb3812d31ac9d298796","unresolved":true,"context_lines":[{"line_number":168,"context_line":"  ansible.builtin.set_fact:"},{"line_number":169,"context_line":"    systemd_networks: \u003e-"},{"line_number":170,"context_line":"      {{ systemd_networks + [{"},{"line_number":171,"context_line":"        \"interface\" : network.ansible_facts.ansible_default_ipv4.interface,"},{"line_number":172,"context_line":"        \"address\" : network.ansible_facts.ansible_default_ipv4.address,"},{"line_number":173,"context_line":"        \"netmask\" : network.ansible_facts.ansible_default_ipv4.netmask,"},{"line_number":174,"context_line":"        \"gateway\" : network.ansible_facts.ansible_default_ipv4.gateway,"},{"line_number":175,"context_line":"        \"dns\" : network.ansible_facts.ansible_dns.nameservers | first"},{"line_number":176,"context_line":"      }] }}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"- name: Create systemd-networkd network link(s)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f1a118f_32dc1b0e","line":175,"range":{"start_line":171,"start_character":0,"end_line":175,"end_character":69},"in_reply_to":"0b1657f8_c71166ed","updated":"2025-02-04 13:04:56.000000000","message":"Ah well, if this is specific to an openstack-ansible AIO that gets set up using the scripts/bootstrap-aio.sh script then it might be better to put a fix in there to switch from networkmanager to systemd_networkd. There is a task here which does the network configuration https://github.com/openstack/openstack-ansible/blob/master/tests/roles/bootstrap-host/tasks/prepare_networking.yml#L45\n\nI would suggest that we do not make any changes inside the systemd_networkd role that make it change anything that is not part of the input systemd_networks variable. This role is used outside of openstack-ansible so we have to avoid code that has unexpected side-effects.","commit_id":"9ba668cf49f90996e33ada9428580031c68c9af8"},{"author":{"_account_id":37705,"name":"Hector Vido","display_name":"Hector Vido","email":"hector_vido@yahoo.com.br","username":"hectorvido"},"change_message_id":"7013d1bc8087fba8b95463f45a4efcdb5cc73ae1","unresolved":true,"context_lines":[{"line_number":168,"context_line":"  ansible.builtin.set_fact:"},{"line_number":169,"context_line":"    systemd_networks: \u003e-"},{"line_number":170,"context_line":"      {{ systemd_networks + [{"},{"line_number":171,"context_line":"        \"interface\" : network.ansible_facts.ansible_default_ipv4.interface,"},{"line_number":172,"context_line":"        \"address\" : network.ansible_facts.ansible_default_ipv4.address,"},{"line_number":173,"context_line":"        \"netmask\" : network.ansible_facts.ansible_default_ipv4.netmask,"},{"line_number":174,"context_line":"        \"gateway\" : network.ansible_facts.ansible_default_ipv4.gateway,"},{"line_number":175,"context_line":"        \"dns\" : network.ansible_facts.ansible_dns.nameservers | first"},{"line_number":176,"context_line":"      }] }}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"- name: Create systemd-networkd network link(s)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0b1657f8_c71166ed","line":175,"range":{"start_line":171,"start_character":0,"end_line":175,"end_character":69},"in_reply_to":"3f99e3ef_8f8817f9","updated":"2025-02-04 12:54:12.000000000","message":"True, any suggestion? This is most for all-in-one clusters.","commit_id":"9ba668cf49f90996e33ada9428580031c68c9af8"}],"templates/systemd-network.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9103c9b8be4841f487fc8b5f8924271ca00c08c8","unresolved":true,"context_lines":[{"line_number":60,"context_line":"{% if item.1.ipforward is defined %}"},{"line_number":61,"context_line":"IPForward\u003d{{ (item.1.ipforward | bool) | ternary(\u0027yes\u0027, \u0027no\u0027) }}"},{"line_number":62,"context_line":"{% endif %}"},{"line_number":63,"context_line":"{% if item.1.dns is defined %}"},{"line_number":64,"context_line":"DNS\u003d{{ item.1.dns }}"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[Link]"},{"line_number":68,"context_line":"{% if item.1.mtu is defined and item.1.mtu %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5a0c1183_9b6e1af3","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":11},"updated":"2025-02-04 15:06:23.000000000","message":"I\u0027d say it\u0027s a valid change to have. But can you propose it as a separate patch from defining the default network?\n\nAs while I\u0027m not sure about setting the default network, we should be able to set the DNS.\n\nAlso, the DNS should be a list, which would repeat the option multiple times:\nhttps://www.freedesktop.org/software/systemd/man/latest/systemd.network.html#DNS\u003d","commit_id":"c81199ae42e5d890446f46b1ca896e48ef60be92"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"109d1b35a16ee64364b83f971e006a99c790f7d8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{% if item.1.ipforward is defined %}"},{"line_number":61,"context_line":"IPForward\u003d{{ (item.1.ipforward | bool) | ternary(\u0027yes\u0027, \u0027no\u0027) }}"},{"line_number":62,"context_line":"{% endif %}"},{"line_number":63,"context_line":"{% if item.1.dns is defined %}"},{"line_number":64,"context_line":"DNS\u003d{{ item.1.dns }}"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[Link]"},{"line_number":68,"context_line":"{% if item.1.mtu is defined and item.1.mtu %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"957f4134_87ddb3e8","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":11},"in_reply_to":"5a0c1183_9b6e1af3","updated":"2026-06-11 01:19:13.000000000","message":"https://review.opendev.org/c/openstack/ansible-role-systemd_networkd/+/992768","commit_id":"c81199ae42e5d890446f46b1ca896e48ef60be92"}]}