)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5566667c561f7018217c165e8d94039a4d2931ae","unresolved":true,"context_lines":[{"line_number":10,"context_line":"is present, containers should be updated with"},{"line_number":11,"context_line":"the latest rpms."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This review mounts the updated images, checks"},{"line_number":14,"context_line":"the installed rpms and greps for the repos"},{"line_number":15,"context_line":"where the updated rpms are sourced."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"26ff43af_53dad160","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":38},"updated":"2021-07-08 16:10:01.000000000","message":"I suppose it\u0027s not correct anymore?","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5566667c561f7018217c165e8d94039a4d2931ae","unresolved":true,"context_lines":[{"line_number":11,"context_line":"the latest rpms."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This review mounts the updated images, checks"},{"line_number":14,"context_line":"the installed rpms and greps for the repos"},{"line_number":15,"context_line":"where the updated rpms are sourced."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie29c7c33c8d66bc3729c03c2d72cbdbf85ad443a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"1d20a0a1_66a648ee","line":15,"range":{"start_line":14,"start_character":37,"end_line":15,"end_character":35},"updated":"2021-07-08 16:10:01.000000000","message":"just curios, don\u0027t we miss updates from CentOS base repos?","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"}],"tasks/yum_update_buildah.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8baea9d56184708d96ea45864fcd57964a9294e1","unresolved":true,"context_lines":[{"line_number":172,"context_line":"- name: Capture the update repos and installed rpms"},{"line_number":173,"context_line":"  shell: \u003e"},{"line_number":174,"context_line":"    buildah run {{ from_image }}"},{"line_number":175,"context_line":"      bash -c \u0027dnf list installed \u003e /tmp/container_info.log\u0027"},{"line_number":176,"context_line":"  register: dnf_list"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"- name: Mount the image and extract the updated rpms"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"5a65bf64_f7307a44","line":175,"range":{"start_line":175,"start_character":33,"end_line":175,"end_character":60},"updated":"2021-06-01 15:12:44.000000000","message":"if you drop quotes, it will dump log to host file, not containers one","commit_id":"cb29fcb7e1fa2389cb17a318ecc44ec1bec298c9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8baea9d56184708d96ea45864fcd57964a9294e1","unresolved":true,"context_lines":[{"line_number":172,"context_line":"- name: Capture the update repos and installed rpms"},{"line_number":173,"context_line":"  shell: \u003e"},{"line_number":174,"context_line":"    buildah run {{ from_image }}"},{"line_number":175,"context_line":"      bash -c \u0027dnf list installed \u003e /tmp/container_info.log\u0027"},{"line_number":176,"context_line":"  register: dnf_list"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"- name: Mount the image and extract the updated rpms"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"c95ca067_a23eb884","line":175,"range":{"start_line":175,"start_character":6,"end_line":175,"end_character":15},"updated":"2021-06-01 15:12:44.000000000","message":"not sure \"bash -c\" will work, I don\u0027t think it\u0027s needed.","commit_id":"cb29fcb7e1fa2389cb17a318ecc44ec1bec298c9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8baea9d56184708d96ea45864fcd57964a9294e1","unresolved":true,"context_lines":[{"line_number":176,"context_line":"  register: dnf_list"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"- name: Mount the image and extract the updated rpms"},{"line_number":179,"context_line":"  shell: |"},{"line_number":180,"context_line":"     MNT\u003d$(buildah mount {{ from_image }});"},{"line_number":181,"context_line":"     cp $MNT/tmp/container_info.log {{ working_dir }};"},{"line_number":182,"context_line":"     buildah umount {{ from_image }};"},{"line_number":183,"context_line":"     UPDATE_LOG\u003d{{ working_dir }}/container_image_update_output.log"},{"line_number":184,"context_line":"     echo \"{{ target_image | default(source_image) }}{{ modified_append_tag }} INFO\" \u003e\u003e $UPDATE_LOG;"},{"line_number":185,"context_line":"     if [ -f \"{{ working_dir }}/container_info.log\" ]; then"},{"line_number":186,"context_line":"         {% for repo in repo_list %}"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ac1d566_b9d47489","line":183,"range":{"start_line":179,"start_character":3,"end_line":183,"end_character":67},"updated":"2021-06-01 15:12:44.000000000","message":"all this is not needed, log file will be on the host","commit_id":"cb29fcb7e1fa2389cb17a318ecc44ec1bec298c9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5566667c561f7018217c165e8d94039a4d2931ae","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- name: Touch files for logging"},{"line_number":167,"context_line":"  shell: |"},{"line_number":168,"context_line":"     if [ ! -f \"{{ working_dir }}/container_image_update_output.log\" ]; then"},{"line_number":169,"context_line":"         touch {{ working_dir }}/container_image_update_output.log;"},{"line_number":170,"context_line":"     fi"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"- name: Capture the update repos and installed rpms"},{"line_number":173,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"07d065a0_3dfd86e9","line":170,"range":{"start_line":168,"start_character":1,"end_line":170,"end_character":7},"updated":"2021-07-08 16:10:01.000000000","message":"I don\u0027t know why to create this file here, but you don\u0027t need to check if file exists. just \"touch file\", `touch` just changes access time in case file exists.","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1ec69a31c06cebb6317cceb192681cdb3543f1e7","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- name: Touch files for logging"},{"line_number":167,"context_line":"  shell: |"},{"line_number":168,"context_line":"     if [ ! -f \"{{ working_dir }}/container_image_update_output.log\" ]; then"},{"line_number":169,"context_line":"         touch {{ working_dir }}/container_image_update_output.log;"},{"line_number":170,"context_line":"     fi"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"- name: Capture the update repos and installed rpms"},{"line_number":173,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"fddc6c15_94e18d66","line":170,"range":{"start_line":168,"start_character":1,"end_line":170,"end_character":7},"in_reply_to":"07d065a0_3dfd86e9","updated":"2021-07-14 14:32:57.000000000","message":"Ack","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5566667c561f7018217c165e8d94039a4d2931ae","unresolved":true,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"- name: Extract the updated rpms"},{"line_number":178,"context_line":"  shell: |"},{"line_number":179,"context_line":"     if [ -f \"{{ working_dir }}/container_info.log\" ]; then"},{"line_number":180,"context_line":"         UPDATE_LOG\u003d{{ working_dir }}/container_image_update_output.log;"},{"line_number":181,"context_line":"         echo \"** {{ target_image | default(source_image) }}{{ modified_append_tag }} **\" \u003e\u003e $UPDATE_LOG;"},{"line_number":182,"context_line":"         {% for repo in repo_list %}"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"85b241d0_7ace9d59","line":179,"range":{"start_line":179,"start_character":5,"end_line":179,"end_character":53},"updated":"2021-07-08 16:10:01.000000000","message":"it\u0027s gonna be there according to task above, otherwise it will fail above and won\u0027t reach this task","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5566667c561f7018217c165e8d94039a4d2931ae","unresolved":true,"context_lines":[{"line_number":180,"context_line":"         UPDATE_LOG\u003d{{ working_dir }}/container_image_update_output.log;"},{"line_number":181,"context_line":"         echo \"** {{ target_image | default(source_image) }}{{ modified_append_tag }} **\" \u003e\u003e $UPDATE_LOG;"},{"line_number":182,"context_line":"         {% for repo in repo_list %}"},{"line_number":183,"context_line":"         cat {{ working_dir }}/container_info.log | grep -F \"@{{ repo|replace(\u0027 \u0027, \u0027\u0027) }}\" \u003e\u003e $UPDATE_LOG || true;"},{"line_number":184,"context_line":"         {% endfor %}"},{"line_number":185,"context_line":"         rm {{ working_dir }}/container_info.log"},{"line_number":186,"context_line":"     fi"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"770fc981_61a66c31","line":183,"range":{"start_line":183,"start_character":105,"end_line":183,"end_character":114},"updated":"2021-07-08 16:10:01.000000000","message":"not sure it\u0027s needed since we don\u0027t have \"set -o pipefail\" here, but not critical","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1ec69a31c06cebb6317cceb192681cdb3543f1e7","unresolved":true,"context_lines":[{"line_number":180,"context_line":"         UPDATE_LOG\u003d{{ working_dir }}/container_image_update_output.log;"},{"line_number":181,"context_line":"         echo \"** {{ target_image | default(source_image) }}{{ modified_append_tag }} **\" \u003e\u003e $UPDATE_LOG;"},{"line_number":182,"context_line":"         {% for repo in repo_list %}"},{"line_number":183,"context_line":"         cat {{ working_dir }}/container_info.log | grep -F \"@{{ repo|replace(\u0027 \u0027, \u0027\u0027) }}\" \u003e\u003e $UPDATE_LOG || true;"},{"line_number":184,"context_line":"         {% endfor %}"},{"line_number":185,"context_line":"         rm {{ working_dir }}/container_info.log"},{"line_number":186,"context_line":"     fi"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"c253efdf_c96107a1","line":183,"range":{"start_line":183,"start_character":105,"end_line":183,"end_character":114},"in_reply_to":"770fc981_61a66c31","updated":"2021-07-14 14:32:57.000000000","message":"Fails w/o it","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5566667c561f7018217c165e8d94039a4d2931ae","unresolved":true,"context_lines":[{"line_number":182,"context_line":"         {% for repo in repo_list %}"},{"line_number":183,"context_line":"         cat {{ working_dir }}/container_info.log | grep -F \"@{{ repo|replace(\u0027 \u0027, \u0027\u0027) }}\" \u003e\u003e $UPDATE_LOG || true;"},{"line_number":184,"context_line":"         {% endfor %}"},{"line_number":185,"context_line":"         rm {{ working_dir }}/container_info.log"},{"line_number":186,"context_line":"     fi"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"# NOTE(aschultz): remove --format docker when oci images are properly supported"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"2dcbc478_d47e70c3","line":185,"range":{"start_line":185,"start_character":9,"end_line":185,"end_character":48},"updated":"2021-07-08 16:10:01.000000000","message":"for safety better to use\n  \n  rm -f \"{{ working_dir }}/container_info.log\"","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4c30c9ef421f17024a5023e3d39197b45173fc3e","unresolved":false,"context_lines":[{"line_number":182,"context_line":"         {% for repo in repo_list %}"},{"line_number":183,"context_line":"         cat {{ working_dir }}/container_info.log | grep -F \"@{{ repo|replace(\u0027 \u0027, \u0027\u0027) }}\" \u003e\u003e $UPDATE_LOG || true;"},{"line_number":184,"context_line":"         {% endfor %}"},{"line_number":185,"context_line":"         rm {{ working_dir }}/container_info.log"},{"line_number":186,"context_line":"     fi"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"# NOTE(aschultz): remove --format docker when oci images are properly supported"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"7c3a20db_fe1f6137","line":185,"range":{"start_line":185,"start_character":9,"end_line":185,"end_character":48},"in_reply_to":"1eb39c4d_41adc192","updated":"2021-07-15 19:31:35.000000000","message":"I don\u0027t see it changed though, but not critical","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1ec69a31c06cebb6317cceb192681cdb3543f1e7","unresolved":false,"context_lines":[{"line_number":182,"context_line":"         {% for repo in repo_list %}"},{"line_number":183,"context_line":"         cat {{ working_dir }}/container_info.log | grep -F \"@{{ repo|replace(\u0027 \u0027, \u0027\u0027) }}\" \u003e\u003e $UPDATE_LOG || true;"},{"line_number":184,"context_line":"         {% endfor %}"},{"line_number":185,"context_line":"         rm {{ working_dir }}/container_info.log"},{"line_number":186,"context_line":"     fi"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"# NOTE(aschultz): remove --format docker when oci images are properly supported"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1eb39c4d_41adc192","line":185,"range":{"start_line":185,"start_character":9,"end_line":185,"end_character":48},"in_reply_to":"2dcbc478_d47e70c3","updated":"2021-07-14 14:32:57.000000000","message":"Ack","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"b5f5ee2f71cd3a0c8d702764ed61b04b64c3d6ce","unresolved":false,"context_lines":[{"line_number":182,"context_line":"         {% for repo in repo_list %}"},{"line_number":183,"context_line":"         cat {{ working_dir }}/container_info.log | grep -F \"@{{ repo|replace(\u0027 \u0027, \u0027\u0027) }}\" \u003e\u003e $UPDATE_LOG || true;"},{"line_number":184,"context_line":"         {% endfor %}"},{"line_number":185,"context_line":"         rm {{ working_dir }}/container_info.log"},{"line_number":186,"context_line":"     fi"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"# NOTE(aschultz): remove --format docker when oci images are properly supported"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"8fb30120_db7c5ef0","line":185,"range":{"start_line":185,"start_character":9,"end_line":185,"end_character":48},"in_reply_to":"7c3a20db_fe1f6137","updated":"2021-07-18 20:24:35.000000000","message":"Updated in patch revision 31","commit_id":"cb9292e98fb155b1cd7d599d0e171aa4e586a37f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"39e0d2a49d9b3681739a74211d2c4e8c6746695c","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"- name: Set working_dir"},{"line_number":163,"context_line":"  set_fact:"},{"line_number":164,"context_line":"    working_dir: \"/home/{{ undercloud_user | default(\u0027zuul\u0027) }}\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- name: Capture the update repos and installed rpms"},{"line_number":167,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"a4e29aa4_86ae196c","line":164,"range":{"start_line":164,"start_character":17,"end_line":164,"end_character":29},"updated":"2021-07-19 13:20:53.000000000","message":"Given this is a role, maybe the working_dir can be set in our defaults. As a default we\u0027d be able to set/change it as needed, to any location on the system.","commit_id":"a6b8c3bac0599767487eef25903cb75397a0eae0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0042b28637f1223257d159e3905fb1709bde9108","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"- name: Set working_dir"},{"line_number":163,"context_line":"  set_fact:"},{"line_number":164,"context_line":"    working_dir: \"/home/{{ undercloud_user | default(\u0027zuul\u0027) }}\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- name: Capture the update repos and installed rpms"},{"line_number":167,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"f46f16ab_369890c2","line":164,"range":{"start_line":164,"start_character":45,"end_line":164,"end_character":60},"updated":"2021-07-19 13:06:06.000000000","message":"This can be used as part of the hotfix workflow as well.  Have you tested this in a downstream context?","commit_id":"a6b8c3bac0599767487eef25903cb75397a0eae0"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"b12d005009465dab510f0a07e0198f066ca2cdc0","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"- name: Set working_dir"},{"line_number":163,"context_line":"  set_fact:"},{"line_number":164,"context_line":"    working_dir: \"/home/{{ undercloud_user | default(\u0027zuul\u0027) }}\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- name: Capture the update repos and installed rpms"},{"line_number":167,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ed82592c_b3da92dc","line":164,"range":{"start_line":164,"start_character":17,"end_line":164,"end_character":29},"in_reply_to":"a4e29aa4_86ae196c","updated":"2021-07-19 14:23:35.000000000","message":"this is just a logging/debug file. \nWe could create the file in /var/log","commit_id":"a6b8c3bac0599767487eef25903cb75397a0eae0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"edc5e2ed91450c1934df48babdbe3e45314b32c0","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"- name: Set working_dir"},{"line_number":163,"context_line":"  set_fact:"},{"line_number":164,"context_line":"    working_dir: \"/home/{{ undercloud_user | default(\u0027zuul\u0027) }}\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- name: Capture the update repos and installed rpms"},{"line_number":167,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"53b1c5ec_434ed174","line":164,"range":{"start_line":164,"start_character":17,"end_line":164,"end_character":29},"in_reply_to":"ed82592c_b3da92dc","updated":"2021-07-20 13:44:58.000000000","message":"+1 that would make more sense IMO.","commit_id":"a6b8c3bac0599767487eef25903cb75397a0eae0"}]}