)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bfe545742999e8092eb96ec2e9c9aff5d900afd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"304c37da_fd7dbfc4","updated":"2021-11-09 14:59:11.000000000","message":"I reverted back to patchset 17 since it was more valid imo","commit_id":"265076d105082557c9466578f84ec1191461333d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ee7410888f6477705802a86770385aee44d2fedc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"2ca498b7_e4230867","updated":"2021-11-09 14:59:24.000000000","message":"Let\u0027s introduce changes on top of it","commit_id":"265076d105082557c9466578f84ec1191461333d"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"2cd391e08b560433355951d4b2e2d60df483a318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"4a8c17a1_933261de","updated":"2021-12-27 23:01:45.000000000","message":"in general it looks fine, successfully deployed it on my AIO.\nBut i think we may want to add some tests for this role.","commit_id":"265076d105082557c9466578f84ec1191461333d"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":21,"context_line":"#vault_system_group_gid:"},{"line_number":22,"context_line":"#vault_system_user_uid:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"vault_listen_host: \"{{ ansible_host | default(\u00270.0.0.0\u0027) }}\""},{"line_number":25,"context_line":"vault_listen_proto: http"},{"line_number":26,"context_line":"vault_listen_port: 8200"},{"line_number":27,"context_line":"vault_cluster_port: 8201"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"cf260e69_09aafa6d","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":35},"updated":"2021-11-05 13:05:17.000000000","message":"This should be openstack_service_bind_address","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":33,"context_line":"vault_galera_user: vault"},{"line_number":34,"context_line":"vault_galera_address: \"{{ galera_address | default(\u0027127.0.0.1\u0027) }}\""},{"line_number":35,"context_line":"vault_galera_port: \"{{ galera_port | default(\u00273306\u0027) }}\""},{"line_number":36,"context_line":"vault_db_setup_host: \"{{ groups[\u0027utility_all\u0027][0] | default(\u0027localhost\u0027) }}\""},{"line_number":37,"context_line":"vault_db_setup_python_interpreter: \"{{  hostvars[groups[\u0027utility_all\u0027][0]][\u0027utility_venv_bin\u0027] | default(\u0027/usr/bin\u0027) }}/python\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Path to the certificates on the deploy host"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"73ad9e87_68237e9f","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":49},"updated":"2021-11-05 13:05:17.000000000","message":"This should be openstack_db_setup_host","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":34,"context_line":"vault_galera_address: \"{{ galera_address | default(\u0027127.0.0.1\u0027) }}\""},{"line_number":35,"context_line":"vault_galera_port: \"{{ galera_port | default(\u00273306\u0027) }}\""},{"line_number":36,"context_line":"vault_db_setup_host: \"{{ groups[\u0027utility_all\u0027][0] | default(\u0027localhost\u0027) }}\""},{"line_number":37,"context_line":"vault_db_setup_python_interpreter: \"{{  hostvars[groups[\u0027utility_all\u0027][0]][\u0027utility_venv_bin\u0027] | default(\u0027/usr/bin\u0027) }}/python\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Path to the certificates on the deploy host"},{"line_number":40,"context_line":"vault_tls_crt: \"\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"f71a04e7_ea54d6a3","line":37,"range":{"start_line":37,"start_character":40,"end_line":37,"end_character":94},"updated":"2021-11-05 13:05:17.000000000","message":"This should be openstack_db_setup_python_interpreter","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"}],"handlers/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Restart Vault"},{"line_number":17,"context_line":"  systemd:"},{"line_number":18,"context_line":"    name: vault"},{"line_number":19,"context_line":"    state: restarted"},{"line_number":20,"context_line":"    enabled: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ba74828b_4a56998f","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":9},"updated":"2021-11-05 13:05:17.000000000","message":"we use service is all roles. It doesn\u0027t matter actually, but better to be aligned with all other roles.","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    name: vault"},{"line_number":19,"context_line":"    state: restarted"},{"line_number":20,"context_line":"    enabled: true"},{"line_number":21,"context_line":"    daemon_reload: yes"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Refresh local facts"},{"line_number":24,"context_line":"  setup:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bb6a65d0_ba31448d","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":22},"updated":"2021-11-05 13:05:17.000000000","message":"why we do daemon-reload here?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    gather_subset: \"!all\""},{"line_number":27,"context_line":"  listen: Restart Vault"},{"line_number":28,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":29,"context_line":"  with_items: "},{"line_number":30,"context_line":"    - \"{{ ansible_play_hosts }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Set the vault existing cluster fact"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0adc553e_d3ce788a","line":29,"range":{"start_line":29,"start_character":13,"end_line":29,"end_character":14},"updated":"2021-11-05 13:05:17.000000000","message":"trailing whitespace","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  listen: Restart Vault"},{"line_number":36,"context_line":"  when: ansible_local[\u0027openstack_ansible\u0027][\u0027vault\u0027] is defined"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#- name: DEBUG inside Handler "},{"line_number":39,"context_line":"#  debug:"},{"line_number":40,"context_line":"#    var: vault_keys"},{"line_number":41,"context_line":"#  listen: Restart Vault"},{"line_number":42,"context_line":"#  when: vault_keys | length \u003e 0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Unseal Vault"},{"line_number":45,"context_line":"  command: \"vault operator unseal -tls-skip-verify -address\u003d{{ vault_listen_proto }}://{{ vault_listen_host }}:{{ vault_listen_port }} {{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3e203e9f_60e499a2","line":42,"range":{"start_line":38,"start_character":0,"end_line":42,"end_character":32},"updated":"2021-11-05 13:05:17.000000000","message":"let\u0027s drop commented out stuff","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  with_items: \"{{ vault_keys[:3] }}\""},{"line_number":47,"context_line":"  listen: Restart Vault"},{"line_number":48,"context_line":"  when: vault_keys | length \u003e 0"},{"line_number":49,"context_line":"  no_log: False"},{"line_number":50,"context_line":"  register: unseal"},{"line_number":51,"context_line":"  until: unseal is success"},{"line_number":52,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"83565c0d_ed161539","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":15},"updated":"2021-11-05 13:05:17.000000000","message":"we will expose secrets this way. it must be true.","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":51,"context_line":"  until: unseal is success"},{"line_number":52,"context_line":"  retries: 5"},{"line_number":53,"context_line":"  delay: 5"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"182f4263_7d56b4b6","line":54,"updated":"2021-11-05 13:05:17.000000000","message":"extra new line at the end of file","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"}],"tasks/db_setup.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":20,"context_line":"# repository. Once it merges there, the changes will automatically be proposed to"},{"line_number":21,"context_line":"# all the repositories which use it."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Setup Database Service (MariaDB)"},{"line_number":24,"context_line":"  delegate_to: \"{{ groups[\u0027utility_all\u0027][0] }}\""},{"line_number":25,"context_line":"  vars:"},{"line_number":26,"context_line":"    ansible_python_interpreter: \"{{ _oslodb_ansible_python_interpreter }}\""},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - common-mariadb"},{"line_number":29,"context_line":"  block:"},{"line_number":30,"context_line":"    - name: Create database for service"},{"line_number":31,"context_line":"      mysql_db:"},{"line_number":32,"context_line":"        login_user: \"{{ galera_root_user }}\""},{"line_number":33,"context_line":"        login_password: \"{{ galera_root_password }}\""},{"line_number":34,"context_line":"        login_host: \"{{ _oslodb_setup_endpoint | default(omit) }}\""},{"line_number":35,"context_line":"        login_port: \"{{ _oslodb_setup_port | default(omit) }}\""},{"line_number":36,"context_line":"        name: \"{{ item.name }}\""},{"line_number":37,"context_line":"        state: \"present\""},{"line_number":38,"context_line":"      loop: \"{{ _oslodb_databases }}\""},{"line_number":39,"context_line":"      no_log: true"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - name: Grant access to the database for the service"},{"line_number":42,"context_line":"      mysql_user:"},{"line_number":43,"context_line":"        login_user: \"{{ galera_root_user }}\""},{"line_number":44,"context_line":"        login_password: \"{{ galera_root_password }}\""},{"line_number":45,"context_line":"        login_host: \"{{ _oslodb_setup_endpoint | default(omit) }}\""},{"line_number":46,"context_line":"        login_port: \"{{ _oslodb_setup_port | default(omit) }}\""},{"line_number":47,"context_line":"        name: \"{{ item.1.username }}\""},{"line_number":48,"context_line":"        password: \"{{ item.1.password }}\""},{"line_number":49,"context_line":"        host: \"{{ item.1.host | default(\u0027%\u0027) }}\""},{"line_number":50,"context_line":"        priv: \"{{ item.0.name }}.*:{{ item.1.priv | default(\u0027ALL\u0027) }}\""},{"line_number":51,"context_line":"        state: \"present\""},{"line_number":52,"context_line":"      loop: \"{{ _oslodb_databases | subelements(\u0027users\u0027) }}\""},{"line_number":53,"context_line":"      no_log: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4cf87942_76b2a927","line":53,"range":{"start_line":23,"start_character":0,"end_line":53,"end_character":18},"updated":"2021-11-05 13:05:17.000000000","message":"It must be like this: https://opendev.org/openstack/openstack-ansible-tests/src/branch/master/sync/tasks/db_setup.yml\n\nWe should not change db_setup since it\u0027s same across all roles ans automatically synced.","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"}],"tasks/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":38,"context_line":"          - username: \"{{ vault_galera_user }}\""},{"line_number":39,"context_line":"            password: \"{{ vault_galera_password }}\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Refresh local facts"},{"line_number":42,"context_line":"  setup:"},{"line_number":43,"context_line":"    filter: ansible_local"},{"line_number":44,"context_line":"    gather_subset: \"!all\""},{"line_number":45,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":46,"context_line":"  with_items:"},{"line_number":47,"context_line":"    - \"{{ ansible_play_hosts }}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Set the vault existing cluster fact"},{"line_number":50,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"90200802_78859b02","line":47,"range":{"start_line":41,"start_character":0,"end_line":47,"end_character":32},"updated":"2021-11-05 13:05:17.000000000","message":"do we really need this? I believe that facts should be gathered at this point by playbook L16-20 https://review.opendev.org/c/openstack/openstack-ansible/+/800787/5/playbooks/vault-install.yml#16","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":49,"context_line":"- name: Set the vault existing cluster fact"},{"line_number":50,"context_line":"  set_fact:"},{"line_number":51,"context_line":"    vault_initialized: \"{{ ansible_local[\u0027openstack_ansible\u0027][\u0027vault\u0027][\u0027initialized\u0027] | default(false) | bool }}\""},{"line_number":52,"context_line":"  when: ansible_local[\u0027openstack_ansible\u0027][\u0027vault\u0027] is defined"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#- name: DEBUG vault"},{"line_number":55,"context_line":"#  debug:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0cda6e97_67980ce4","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":62},"updated":"2021-11-05 13:05:17.000000000","message":"doesn\u0027t default cover this?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    vault_initialized: \"{{ ansible_local[\u0027openstack_ansible\u0027][\u0027vault\u0027][\u0027initialized\u0027] | default(false) | bool }}\""},{"line_number":52,"context_line":"  when: ansible_local[\u0027openstack_ansible\u0027][\u0027vault\u0027] is defined"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#- name: DEBUG vault"},{"line_number":55,"context_line":"#  debug:"},{"line_number":56,"context_line":"#    var: ansible_local[\u0027openstack_ansible\u0027][\u0027vault\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- name: Set the vault existing cluster fact with undefined ansible_local"},{"line_number":59,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"129ba87c_a5301d27","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":53},"updated":"2021-11-05 13:05:17.000000000","message":"let\u0027s drop commented out garbage","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":63,"context_line":"- import_tasks: vault_pre_install.yml"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- import_tasks: vault_install.yml"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- include_tasks: vault_post_install.yml"},{"line_number":68,"context_line":"  when:"},{"line_number":69,"context_line":"    - not vault_initialized"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ec2f5352_eb0e1501","line":66,"updated":"2021-11-05 13:05:17.000000000","message":"why flush_handlers were dropped out of here?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    - not vault_initialized"},{"line_number":70,"context_line":"    - _vault_is_first_play_host"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- debug: msg\u003d\"Trigger Restart Vault\""},{"line_number":73,"context_line":"  notify: Restart Vault"},{"line_number":74,"context_line":"  changed_when: True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: Record vault host"},{"line_number":77,"context_line":"  ini_file:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"6a85e35e_cdb466a0","line":74,"range":{"start_line":72,"start_character":0,"end_line":74,"end_character":20},"updated":"2021-11-05 13:05:17.000000000","message":"why we need to restart here?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":73,"context_line":"  notify: Restart Vault"},{"line_number":74,"context_line":"  changed_when: True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: Record vault host"},{"line_number":77,"context_line":"  ini_file:"},{"line_number":78,"context_line":"    dest: \"/etc/ansible/facts.d/openstack_ansible.fact\""},{"line_number":79,"context_line":"    section: vault"},{"line_number":80,"context_line":"    option: vault_host"},{"line_number":81,"context_line":"    value: \"{{ internal_lb_vip_address }}\""},{"line_number":82,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":83,"context_line":"  with_items: "},{"line_number":84,"context_line":"    - \"{{ ansible_play_hosts }}\""},{"line_number":85,"context_line":"    - \"{{ groups[\u0027keystone_all\u0027] }}\""},{"line_number":86,"context_line":"    - \"{{ groups[\u0027cinder_all\u0027] }}\""},{"line_number":87,"context_line":"    - \"{{ groups[\u0027glance_all\u0027] }}\""},{"line_number":88,"context_line":"    - \"{{ groups[\u0027nova_all\u0027] }}\""},{"line_number":89,"context_line":"    - \"{{ groups[\u0027neutron_all\u0027] }}\""},{"line_number":90,"context_line":"    - \"{{ groups[\u0027placement_all\u0027] }}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"- name: Record vault proto"},{"line_number":93,"context_line":"  ini_file:"},{"line_number":94,"context_line":"    dest: \"/etc/ansible/facts.d/openstack_ansible.fact\""},{"line_number":95,"context_line":"    section: vault"},{"line_number":96,"context_line":"    option: vault_proto"},{"line_number":97,"context_line":"    value: \"{{ vault_listen_proto_haproxy }}\""},{"line_number":98,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":99,"context_line":"  with_items: "},{"line_number":100,"context_line":"    - \"{{ ansible_play_hosts }}\""},{"line_number":101,"context_line":"    - \"{{ groups[\u0027keystone_all\u0027] }}\""},{"line_number":102,"context_line":"    - \"{{ groups[\u0027cinder_all\u0027] }}\""},{"line_number":103,"context_line":"    - \"{{ groups[\u0027glance_all\u0027] }}\""},{"line_number":104,"context_line":"    - \"{{ groups[\u0027nova_all\u0027] }}\""},{"line_number":105,"context_line":"    - \"{{ groups[\u0027neutron_all\u0027] }}\""},{"line_number":106,"context_line":"    - \"{{ groups[\u0027placement_all\u0027] }}\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"- name: Record vault port"},{"line_number":109,"context_line":"  ini_file:"},{"line_number":110,"context_line":"    dest: \"/etc/ansible/facts.d/openstack_ansible.fact\""},{"line_number":111,"context_line":"    section: vault"},{"line_number":112,"context_line":"    option: vault_port"},{"line_number":113,"context_line":"    value: \"{{ vault_listen_port }}\""},{"line_number":114,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":115,"context_line":"  with_items: "},{"line_number":116,"context_line":"    - \"{{ ansible_play_hosts }}\""},{"line_number":117,"context_line":"    - \"{{ groups[\u0027keystone_all\u0027] }}\""},{"line_number":118,"context_line":"    - \"{{ groups[\u0027cinder_all\u0027] }}\""},{"line_number":119,"context_line":"    - \"{{ groups[\u0027glance_all\u0027] }}\""},{"line_number":120,"context_line":"    - \"{{ groups[\u0027nova_all\u0027] }}\""},{"line_number":121,"context_line":"    - \"{{ groups[\u0027neutron_all\u0027] }}\""},{"line_number":122,"context_line":"    - \"{{ groups[\u0027placement_all\u0027] }}\""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"adb511e3_6d0e00fb","line":122,"range":{"start_line":76,"start_character":0,"end_line":122,"end_character":37},"updated":"2021-11-05 13:05:17.000000000","message":"I\u0027m not sure this is needed and should be set this way anyway.","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"}],"tasks/vault_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Install Vault with DEB"},{"line_number":17,"context_line":"  when: (ansible_facts[\u0027os_family\u0027] | lower \u003d\u003d \u0027debian\u0027) and (vault_install_from_repo \u003d\u003d True)"},{"line_number":18,"context_line":"  block:"},{"line_number":19,"context_line":"    - name: Add GPG keys"},{"line_number":20,"context_line":"      apt_key:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"50370c21_2a53783a","line":17,"range":{"start_line":17,"start_character":62,"end_line":17,"end_character":85},"updated":"2021-11-05 13:05:17.000000000","message":"I don\u0027t see this variable being defined anywhere","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":81,"context_line":"- name: Install vault from zip"},{"line_number":82,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":83,"context_line":"  unarchive:"},{"line_number":84,"context_line":"    src: \"{{ vault_zip_filename }}\""},{"line_number":85,"context_line":"    dest: \"/usr/bin/\""},{"line_number":86,"context_line":"    mode: 0755"},{"line_number":87,"context_line":"    owner: root"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"57cf6cf6_d79f8c51","line":84,"range":{"start_line":84,"start_character":13,"end_line":84,"end_character":31},"updated":"2021-11-05 13:05:17.000000000","message":"this variable is not defined/described anywhere.","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    name: vault"},{"line_number":102,"context_line":"    enabled: yes"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Create vault.env "},{"line_number":105,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":106,"context_line":"  template:"},{"line_number":107,"context_line":"    src: \"vault.env.j2\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"984a5abe_93c30ce4","line":104,"range":{"start_line":104,"start_character":24,"end_line":104,"end_character":25},"updated":"2021-11-05 13:05:17.000000000","message":"trailing whitespace","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a02d731fba71767d8ab9393327326e5b86d5565f","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  notify:"},{"line_number":79,"context_line":"    - Restart Vault"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- name: Install vault from zip"},{"line_number":82,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":83,"context_line":"  unarchive:"},{"line_number":84,"context_line":"    src: \"{{ vault_zip_filename }}\""},{"line_number":85,"context_line":"    dest: \"/usr/bin/\""},{"line_number":86,"context_line":"    mode: 0755"},{"line_number":87,"context_line":"    owner: root"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"- name: Create vault.service"},{"line_number":90,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":91,"context_line":"  template:"},{"line_number":92,"context_line":"    src: \"vault.service.j2\""},{"line_number":93,"context_line":"    dest: \"/lib/systemd/system/vault.service\""},{"line_number":94,"context_line":"    mode: 0644"},{"line_number":95,"context_line":"    owner: \"{{ vault_system_user_name }}\""},{"line_number":96,"context_line":"    group: \"{{ vault_system_group_name }}\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Reload daemons"},{"line_number":99,"context_line":"  systemd:"},{"line_number":100,"context_line":"    daemon_reload: yes"},{"line_number":101,"context_line":"    name: vault"},{"line_number":102,"context_line":"    enabled: yes"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Create vault.env "},{"line_number":105,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":106,"context_line":"  template:"},{"line_number":107,"context_line":"    src: \"vault.env.j2\""},{"line_number":108,"context_line":"    dest: \"/etc/vault.d/vault.env\""},{"line_number":109,"context_line":"    mode: 0644"},{"line_number":110,"context_line":"    owner: \"{{ vault_system_user_name }}\""},{"line_number":111,"context_line":"    group: \"{{ vault_system_group_name }}\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"- name: Create vault data directory"},{"line_number":114,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":115,"context_line":"  file:"},{"line_number":116,"context_line":"    path: \"/opt/vault/data\""},{"line_number":117,"context_line":"    mode: 0755"},{"line_number":118,"context_line":"    state: directory"},{"line_number":119,"context_line":"    owner: \"{{ vault_system_user_name }}\""},{"line_number":120,"context_line":"    group: \"{{ vault_system_group_name }}\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"- name: Create vault tls directory"},{"line_number":123,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":124,"context_line":"  file:"},{"line_number":125,"context_line":"    path: \"/opt/vault/tls\""},{"line_number":126,"context_line":"    mode: 0700"},{"line_number":127,"context_line":"    state: directory"},{"line_number":128,"context_line":"    owner: \"{{ vault_system_user_name }}\""},{"line_number":129,"context_line":"    group: \"{{ vault_system_group_name }}\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: Deploy vault config"},{"line_number":132,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bdb3d417_efee5982","line":129,"range":{"start_line":81,"start_character":0,"end_line":129,"end_character":42},"updated":"2021-11-05 13:08:25.000000000","message":"Can you please evaluate usecase for installing from zip archive?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  notify:"},{"line_number":79,"context_line":"    - Restart Vault"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- name: Install vault from zip"},{"line_number":82,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":83,"context_line":"  unarchive:"},{"line_number":84,"context_line":"    src: \"{{ vault_zip_filename }}\""},{"line_number":85,"context_line":"    dest: \"/usr/bin/\""},{"line_number":86,"context_line":"    mode: 0755"},{"line_number":87,"context_line":"    owner: root"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"- name: Create vault.service"},{"line_number":90,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":91,"context_line":"  template:"},{"line_number":92,"context_line":"    src: \"vault.service.j2\""},{"line_number":93,"context_line":"    dest: \"/lib/systemd/system/vault.service\""},{"line_number":94,"context_line":"    mode: 0644"},{"line_number":95,"context_line":"    owner: \"{{ vault_system_user_name }}\""},{"line_number":96,"context_line":"    group: \"{{ vault_system_group_name }}\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Reload daemons"},{"line_number":99,"context_line":"  systemd:"},{"line_number":100,"context_line":"    daemon_reload: yes"},{"line_number":101,"context_line":"    name: vault"},{"line_number":102,"context_line":"    enabled: yes"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Create vault.env "},{"line_number":105,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":106,"context_line":"  template:"},{"line_number":107,"context_line":"    src: \"vault.env.j2\""},{"line_number":108,"context_line":"    dest: \"/etc/vault.d/vault.env\""},{"line_number":109,"context_line":"    mode: 0644"},{"line_number":110,"context_line":"    owner: \"{{ vault_system_user_name }}\""},{"line_number":111,"context_line":"    group: \"{{ vault_system_group_name }}\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"- name: Create vault data directory"},{"line_number":114,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":115,"context_line":"  file:"},{"line_number":116,"context_line":"    path: \"/opt/vault/data\""},{"line_number":117,"context_line":"    mode: 0755"},{"line_number":118,"context_line":"    state: directory"},{"line_number":119,"context_line":"    owner: \"{{ vault_system_user_name }}\""},{"line_number":120,"context_line":"    group: \"{{ vault_system_group_name }}\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"- name: Create vault tls directory"},{"line_number":123,"context_line":"  when: vault_install_from_repo \u003d\u003d False"},{"line_number":124,"context_line":"  file:"},{"line_number":125,"context_line":"    path: \"/opt/vault/tls\""},{"line_number":126,"context_line":"    mode: 0700"},{"line_number":127,"context_line":"    state: directory"},{"line_number":128,"context_line":"    owner: \"{{ vault_system_user_name }}\""},{"line_number":129,"context_line":"    group: \"{{ vault_system_group_name }}\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: Deploy vault config"},{"line_number":132,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bd9e6a81_0f2be95a","line":129,"range":{"start_line":81,"start_character":0,"end_line":129,"end_character":42},"updated":"2021-11-05 13:05:17.000000000","message":"can we place that under block?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    - Restart Vault"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"- name: Copy CA file"},{"line_number":158,"context_line":"  copy: "},{"line_number":159,"context_line":"    src: \"{{ vault_mysql_tls_ca_file }}\""},{"line_number":160,"context_line":"    dest: /opt/vault/tls/ca.crt"},{"line_number":161,"context_line":"  when: vault_mysql_tls_ca_file is defined and vault_mysql_tls_ca_file|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4887fe1e_f4abdcc6","line":158,"range":{"start_line":158,"start_character":7,"end_line":158,"end_character":8},"updated":"2021-11-05 13:05:17.000000000","message":"trailing twhitespace","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"- name: Copy CA file"},{"line_number":158,"context_line":"  copy: "},{"line_number":159,"context_line":"    src: \"{{ vault_mysql_tls_ca_file }}\""},{"line_number":160,"context_line":"    dest: /opt/vault/tls/ca.crt"},{"line_number":161,"context_line":"  when: vault_mysql_tls_ca_file is defined and vault_mysql_tls_ca_file|length \u003e 0"},{"line_number":162,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"b66ceda4_00d64836","line":159,"range":{"start_line":159,"start_character":13,"end_line":159,"end_character":36},"updated":"2021-11-05 13:05:17.000000000","message":"I don\u0027t see this variable being mentioned in defaults.","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":161,"context_line":"  when: vault_mysql_tls_ca_file is defined and vault_mysql_tls_ca_file|length \u003e 0"},{"line_number":162,"context_line":"  notify:"},{"line_number":163,"context_line":"    - Restart Vault"},{"line_number":164,"context_line":" "}],"source_content_type":"text/x-yaml","patch_set":18,"id":"043604cf_901d3f54","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":1},"updated":"2021-11-05 13:05:17.000000000","message":"trailing whitespace","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"}],"tasks/vault_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Restart Vault"},{"line_number":17,"context_line":"  systemd:"},{"line_number":18,"context_line":"    name: vault"},{"line_number":19,"context_line":"    state: restarted"},{"line_number":20,"context_line":"    enabled: true"},{"line_number":21,"context_line":"    daemon_reload: yes"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Init vault"},{"line_number":24,"context_line":"  command: \"vault operator init -format\u003dyaml -tls-skip-verify -address\u003d{{ vault_listen_proto }}://{{ vault_listen_host }}:{{ vault_listen_port }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"275a4a7f_ca25322c","line":21,"range":{"start_line":16,"start_character":0,"end_line":21,"end_character":22},"updated":"2021-11-05 13:05:17.000000000","message":"We shouldn\u0027t do it here.","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  register: vault_keys"},{"line_number":26,"context_line":"  changed_when: false"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"#- name: DEBUG keys"},{"line_number":29,"context_line":"#  debug:"},{"line_number":30,"context_line":"#    var: vault_keys"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Record vault has been initialized"},{"line_number":33,"context_line":"  ini_file:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"88317537_cb2aa8c3","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":20},"updated":"2021-11-05 13:05:17.000000000","message":"let\u0027s drop commented garbage","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":49,"context_line":"  with_items:"},{"line_number":50,"context_line":"    - \"{{ ansible_play_hosts }}\""},{"line_number":51,"context_line":"    - \"{{ groups[\u0027keystone_all\u0027] }}\""},{"line_number":52,"context_line":"    - \"{{ groups[\u0027cinder_all\u0027] }}\""},{"line_number":53,"context_line":"    - \"{{ groups[\u0027glance_all\u0027] }}\""},{"line_number":54,"context_line":"    - \"{{ groups[\u0027nova_all\u0027] }}\""},{"line_number":55,"context_line":"    - \"{{ groups[\u0027neutron_all\u0027] }}\""},{"line_number":56,"context_line":"    - \"{{ groups[\u0027placement_all\u0027] }}\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- name: Record vault root token"},{"line_number":59,"context_line":"  ini_file:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"f8461b45_57bff1dc","line":56,"range":{"start_line":51,"start_character":0,"end_line":56,"end_character":37},"updated":"2021-11-05 13:05:17.000000000","message":"why we store vault unseal keys on all these hosts? that is not right/secure","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":65,"context_line":"  with_items: "},{"line_number":66,"context_line":"    - \"{{ ansible_play_hosts }}\""},{"line_number":67,"context_line":"    - \"{{ groups[\u0027keystone_all\u0027] }}\""},{"line_number":68,"context_line":"    - \"{{ groups[\u0027cinder_all\u0027] }}\""},{"line_number":69,"context_line":"    - \"{{ groups[\u0027glance_all\u0027] }}\""},{"line_number":70,"context_line":"    - \"{{ groups[\u0027nova_all\u0027] }}\""},{"line_number":71,"context_line":"    - \"{{ groups[\u0027neutron_all\u0027] }}\""},{"line_number":72,"context_line":"    - \"{{ groups[\u0027placement_all\u0027] }}\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- name: Refresh local facts"},{"line_number":75,"context_line":"  setup:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"08c5995e_205740f4","line":72,"range":{"start_line":67,"start_character":0,"end_line":72,"end_character":37},"updated":"2021-11-05 13:05:17.000000000","message":"why we store vault root token on all hosts? that is not right/secure","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    filter: ansible_local"},{"line_number":77,"context_line":"    gather_subset: \"!all\""},{"line_number":78,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":79,"context_line":"  with_items: "},{"line_number":80,"context_line":"    - \"{{ ansible_play_hosts }}\""},{"line_number":81,"context_line":"    - \"{{ groups[\u0027keystone_all\u0027] }}\""},{"line_number":82,"context_line":"    - \"{{ groups[\u0027cinder_all\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"56c41e9d_f880357b","line":79,"range":{"start_line":79,"start_character":13,"end_line":79,"end_character":14},"updated":"2021-11-05 13:05:17.000000000","message":"trailing whitespace","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":79,"context_line":"  with_items: "},{"line_number":80,"context_line":"    - \"{{ ansible_play_hosts }}\""},{"line_number":81,"context_line":"    - \"{{ groups[\u0027keystone_all\u0027] }}\""},{"line_number":82,"context_line":"    - \"{{ groups[\u0027cinder_all\u0027] }}\""},{"line_number":83,"context_line":"    - \"{{ groups[\u0027glance_all\u0027] }}\""},{"line_number":84,"context_line":"    - \"{{ groups[\u0027nova_all\u0027] }}\""},{"line_number":85,"context_line":"    - \"{{ groups[\u0027neutron_all\u0027] }}\""},{"line_number":86,"context_line":"    - \"{{ groups[\u0027placement_all\u0027] }}\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- name: Set the vault existing cluster fact"},{"line_number":89,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"a9064585_2518e867","line":86,"range":{"start_line":81,"start_character":0,"end_line":86,"end_character":37},"updated":"2021-11-05 13:05:17.000000000","message":"why we refresh facts on all these hosts?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    vault_root_token: \"{{ ansible_local[\u0027openstack_ansible\u0027][\u0027vault\u0027][\u0027root_token\u0027] | default([]) }}\""},{"line_number":91,"context_line":"  when: ansible_local[\u0027openstack_ansible\u0027][\u0027vault\u0027] is defined"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- meta: flush_handlers"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- name: Create Vault kv storage engine"},{"line_number":96,"context_line":"  shell: \"VAULT_TOKEN\u003d{{ vault_root_token }} vault secrets enable -tls-skip-verify -address\u003d{{ vault_listen_proto }}://{{ vault_listen_host }}:{{ vault_listen_port }} -version\u003d1 kv\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"a953faa4_3ab095c2","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":22},"updated":"2021-11-05 13:05:17.000000000","message":"why flushing here?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c8f5c0ed619ef2f4afcad501275f69d903c21546","unresolved":true,"context_lines":[{"line_number":93,"context_line":"- meta: flush_handlers"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- name: Create Vault kv storage engine"},{"line_number":96,"context_line":"  shell: \"VAULT_TOKEN\u003d{{ vault_root_token }} vault secrets enable -tls-skip-verify -address\u003d{{ vault_listen_proto }}://{{ vault_listen_host }}:{{ vault_listen_port }} -version\u003d1 kv\""},{"line_number":97,"context_line":"  when: vault_root_token | length \u003e 0"},{"line_number":98,"context_line":"              "},{"line_number":99,"context_line":"- name: Print keys"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"a654b058_61165caa","line":96,"range":{"start_line":96,"start_character":167,"end_line":96,"end_character":177},"updated":"2021-11-05 13:06:54.000000000","message":"why not version2?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4e9df6d0d928bf0174b97b3a8a1a8e0d30d19350","unresolved":true,"context_lines":[{"line_number":93,"context_line":"- meta: flush_handlers"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- name: Create Vault kv storage engine"},{"line_number":96,"context_line":"  shell: \"VAULT_TOKEN\u003d{{ vault_root_token }} vault secrets enable -tls-skip-verify -address\u003d{{ vault_listen_proto }}://{{ vault_listen_host }}:{{ vault_listen_port }} -version\u003d1 kv\""},{"line_number":97,"context_line":"  when: vault_root_token | length \u003e 0"},{"line_number":98,"context_line":"              "},{"line_number":99,"context_line":"- name: Print keys"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"371c6bee_436fc874","line":96,"range":{"start_line":96,"start_character":167,"end_line":96,"end_character":177},"in_reply_to":"a654b058_61165caa","updated":"2021-11-05 13:07:28.000000000","message":"and doesn\u0027t kv2 enabled by default?","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"}],"templates/vault.hcl.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e64da869c7b398fbf1dd5b5c6dd98accb994f3c6","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  {% endif %}"},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"api_addr \u003d \"{{ vault_listen_proto }}://{{ internal_lb_vip_address }}:{{ vault_listen_port }}\""},{"line_number":25,"context_line":"cluster_addr \u003d \"{{ vault_listen_proto }}://{{ vault_listen_host }}:{{ vault_cluster_port }}\""},{"line_number":26,"context_line":"ui \u003d {{ vault_enable_ui | bool | lower }}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"df8295e1_567553f2","line":24,"range":{"start_line":24,"start_character":42,"end_line":24,"end_character":65},"updated":"2021-11-05 13:05:17.000000000","message":"it should be vault_listen_host? I can\u0027t recall now but there were issues with clustering when wrong (or different?) is set for api/cluster addr.\nSo worth double checking this part.","commit_id":"e4d36f36428c0a02f28321b70cc9bb99814666ff"}]}