)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"ab629e0ad32c835d89cffae54f3fc8dc90abcb6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40c4b39d_9da5a8f0","updated":"2026-03-10 17:48:29.000000000","message":"These seem to be unresolved comments here?","commit_id":"f9c96e6eeacfd869ac91d3767f9c1ed55b405d7f"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"ea2d0329067181c7e3a237f84a97509f1067ad2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d0fae17b_0f5f3f9d","updated":"2025-10-09 13:54:06.000000000","message":"recheck","commit_id":"f9c96e6eeacfd869ac91d3767f9c1ed55b405d7f"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"1d7d2c3a09ebfc4a57183ef3f3a08066aa9a0c0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57f26253_84df5737","updated":"2025-10-09 19:27:07.000000000","message":"recheck - parent change passed CI jobs","commit_id":"f9c96e6eeacfd869ac91d3767f9c1ed55b405d7f"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"31c91648c742f8feb3076e0a24a8a224246d1d50","unresolved":true,"context_lines":[{"line_number":93,"context_line":"  - name: \"zookeeper_{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":94,"context_line":"    cn: \"{{ hostvars[inventory_hostname][zookeeper_cluster_address_hostvars_key] }}\""},{"line_number":95,"context_line":"    san:"},{"line_number":96,"context_line":"      dns:"},{"line_number":97,"context_line":"        - \"{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":98,"context_line":"      ip:"},{"line_number":99,"context_line":"        - \"{{ ansible_host }}\""},{"line_number":100,"context_line":"    condition: \"{{ zookeeper_ssl_client_enable or zookeeper_ssl_quorum_enable }}\""},{"line_number":101,"context_line":"    key_format: pkcs8"},{"line_number":102,"context_line":"    # standalone backend only"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7fbc3589_3929c17c","line":99,"range":{"start_line":96,"start_character":0,"end_line":99,"end_character":30},"updated":"2025-11-05 11:33:43.000000000","message":"should we use `openstack_pki_san` as a default?","commit_id":"f9c96e6eeacfd869ac91d3767f9c1ed55b405d7f"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"be647cb16bf656735901d1c39de04b0f12c8f625","unresolved":false,"context_lines":[{"line_number":93,"context_line":"  - name: \"zookeeper_{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":94,"context_line":"    cn: \"{{ hostvars[inventory_hostname][zookeeper_cluster_address_hostvars_key] }}\""},{"line_number":95,"context_line":"    san:"},{"line_number":96,"context_line":"      dns:"},{"line_number":97,"context_line":"        - \"{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":98,"context_line":"      ip:"},{"line_number":99,"context_line":"        - \"{{ ansible_host }}\""},{"line_number":100,"context_line":"    condition: \"{{ zookeeper_ssl_client_enable or zookeeper_ssl_quorum_enable }}\""},{"line_number":101,"context_line":"    key_format: pkcs8"},{"line_number":102,"context_line":"    # standalone backend only"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fc306e96_6e9f9421","line":99,"range":{"start_line":96,"start_character":0,"end_line":99,"end_character":30},"in_reply_to":"365aa551_316ce68e","updated":"2026-03-17 16:03:09.000000000","message":"Done","commit_id":"f9c96e6eeacfd869ac91d3767f9c1ed55b405d7f"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"a0a85002d8282ed2ebd735165da93a8ef9a0da1e","unresolved":true,"context_lines":[{"line_number":93,"context_line":"  - name: \"zookeeper_{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":94,"context_line":"    cn: \"{{ hostvars[inventory_hostname][zookeeper_cluster_address_hostvars_key] }}\""},{"line_number":95,"context_line":"    san:"},{"line_number":96,"context_line":"      dns:"},{"line_number":97,"context_line":"        - \"{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":98,"context_line":"      ip:"},{"line_number":99,"context_line":"        - \"{{ ansible_host }}\""},{"line_number":100,"context_line":"    condition: \"{{ zookeeper_ssl_client_enable or zookeeper_ssl_quorum_enable }}\""},{"line_number":101,"context_line":"    key_format: pkcs8"},{"line_number":102,"context_line":"    # standalone backend only"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d9808bb1_53860cf7","line":99,"range":{"start_line":96,"start_character":0,"end_line":99,"end_character":30},"in_reply_to":"7fbc3589_3929c17c","updated":"2025-11-10 13:13:14.000000000","message":"the values from here differs a bit from `openstack_pki_san`.\nPlease note that I didn\u0027t introduce them in this patch, I just used what we already had in zookeper role.\n\nPotentially we can try to test if zookeper role works fine with `openstack_pki_san`, but it looks like something for a separate patch, isn\u0027t it?","commit_id":"f9c96e6eeacfd869ac91d3767f9c1ed55b405d7f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"dcf644480788f416dd0d2cd9fbb539b3879cf44f","unresolved":true,"context_lines":[{"line_number":93,"context_line":"  - name: \"zookeeper_{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":94,"context_line":"    cn: \"{{ hostvars[inventory_hostname][zookeeper_cluster_address_hostvars_key] }}\""},{"line_number":95,"context_line":"    san:"},{"line_number":96,"context_line":"      dns:"},{"line_number":97,"context_line":"        - \"{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":98,"context_line":"      ip:"},{"line_number":99,"context_line":"        - \"{{ ansible_host }}\""},{"line_number":100,"context_line":"    condition: \"{{ zookeeper_ssl_client_enable or zookeeper_ssl_quorum_enable }}\""},{"line_number":101,"context_line":"    key_format: pkcs8"},{"line_number":102,"context_line":"    # standalone backend only"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"365aa551_316ce68e","line":99,"range":{"start_line":96,"start_character":0,"end_line":99,"end_character":30},"in_reply_to":"d9808bb1_53860cf7","updated":"2025-12-16 16:10:13.000000000","message":"well, not really, if default `openstack_pki_san` would be including `ansible_facts[\u0027fqdn\u0027]` on top of things.\n\nBut now, when there\u0027s no default value for `openstack_pki_san` we should be using it anyway. I\u0027m fine to have that as a follow-up patch, but please push it before we land this one 😊","commit_id":"f9c96e6eeacfd869ac91d3767f9c1ed55b405d7f"}]}