)]}'
{"aodh/alarm/evaluator/threshold.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d5589ea23764ba8ee312cf25e710adb0e21bdd69","unresolved":false,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":41,"context_line":"class ThresholdEvaluator(evaluator.Evaluator):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # the sliding evaluation window is extended to allow"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_14aed280","line":40,"updated":"2015-07-09 10:06:01.000000000","message":"This seems useless as you\u0027re not using abc decorators anywhere :)","commit_id":"a746b78895ed261c40ebb58bdeb5a3b4e3ff17e0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"8344dc22fddd13e8c9d936398caead9f1ad84e83","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        LOG.debug(_(\u0027pruned statistics to %d\u0027) % len(statistics))"},{"line_number":85,"context_line":"        return result_statistics"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _statistics(self, alarm, query, start, end):"},{"line_number":88,"context_line":"        \"\"\"Retrieve statistics over the current window.\"\"\""},{"line_number":89,"context_line":"        after \u003d dict(field\u003d\u0027timestamp\u0027, op\u003d\u0027ge\u0027, value\u003dstart)"},{"line_number":90,"context_line":"        before \u003d dict(field\u003d\u0027timestamp\u0027, op\u003d\u0027le\u0027, value\u003dend)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_dcae102f","line":87,"updated":"2015-07-10 12:41:41.000000000","message":"Small suggestion, query here have no sense for gnocchi alarm.\nperhaps we can remove this argument and use directly alarm.rule[\u0027query\u0027] in the threshold _statistics() implementations.","commit_id":"ad940809838964aaa4f2afefe7b750d874de250f"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"2de3e6b03e400c1a9ba965aa762e1ebaf5e5df48","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        LOG.debug(_(\u0027pruned statistics to %d\u0027) % len(statistics))"},{"line_number":85,"context_line":"        return result_statistics"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _statistics(self, alarm, query, start, end):"},{"line_number":88,"context_line":"        \"\"\"Retrieve statistics over the current window.\"\"\""},{"line_number":89,"context_line":"        after \u003d dict(field\u003d\u0027timestamp\u0027, op\u003d\u0027ge\u0027, value\u003dstart)"},{"line_number":90,"context_line":"        before \u003d dict(field\u003d\u0027timestamp\u0027, op\u003d\u0027le\u0027, value\u003dend)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_b25d7317","line":87,"in_reply_to":"ba3cc151_dcae102f","updated":"2015-07-10 13:03:33.000000000","message":"Done, good suggestion","commit_id":"ad940809838964aaa4f2afefe7b750d874de250f"}],"aodh/api/controllers/v2/alarm_rules/gnocchi.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"89a480af336d544cb73f622cdaa180340c317426","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    evaluation_periods \u003d wsme.wsattr(wtypes.IntegerType(minimum\u003d1), default\u003d1)"},{"line_number":48,"context_line":"    \"The number of historical periods to evaluate the threshold\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    period \u003d wsme.wsattr(wtypes.IntegerType(minimum\u003d1), default\u003d60)"},{"line_number":51,"context_line":"    \"The time range in seconds over which query\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f4d80ef1","line":50,"updated":"2015-07-09 10:07:49.000000000","message":"we cannot change this anymore that will break the API, heat already uses it.\n\nAlso \"granularity\" comes from the gnocchi vocable, that why we didn\u0027t reuse period.","commit_id":"a746b78895ed261c40ebb58bdeb5a3b4e3ff17e0"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"6c5a205473e2ace44988a58fd00bbd765d52f84c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    evaluation_periods \u003d wsme.wsattr(wtypes.IntegerType(minimum\u003d1), default\u003d1)"},{"line_number":48,"context_line":"    \"The number of historical periods to evaluate the threshold\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    period \u003d wsme.wsattr(wtypes.IntegerType(minimum\u003d1), default\u003d60)"},{"line_number":51,"context_line":"    \"The time range in seconds over which query\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_8fe3afa3","line":50,"in_reply_to":"ba3cc151_f4d80ef1","updated":"2015-07-09 10:22:01.000000000","message":"That\u0027s sad:( Ok, will think about it","commit_id":"a746b78895ed261c40ebb58bdeb5a3b4e3ff17e0"}]}