)]}'
{"aodh/alarm/notifier/trust.py":[{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"ae8452b969eba94b3df7fc7bbe54efb1664db9dc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               reason, reason_data):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        cfg.CONF.import_opt(\u0027http_timeout\u0027, \u0027aodh.service\u0027)"},{"line_number":39,"context_line":"        cfg.CONF.import_group(\u0027service_credentials\u0027, \u0027aodh.service\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        trust_id \u003d action.username"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_27827901","line":39,"updated":"2015-07-13 02:23:56.000000000","message":"Why did you move those import lines into a static method? Doesn\u0027t it affect to the performance?","commit_id":"319723e529d492bc77d412998bfeb03cf50c7cdf"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"91ea1deb18001e6545da4f0297d9ac99db7e5df1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               reason, reason_data):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        cfg.CONF.import_opt(\u0027http_timeout\u0027, \u0027aodh.service\u0027)"},{"line_number":39,"context_line":"        cfg.CONF.import_group(\u0027service_credentials\u0027, \u0027aodh.service\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        trust_id \u003d action.username"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_dced9326","line":39,"in_reply_to":"9a41bdd9_27827901","updated":"2015-07-17 12:15:46.000000000","message":"Because of import loops.\n\nNot sure about the perf, but that should go away soon too anyway.","commit_id":"319723e529d492bc77d412998bfeb03cf50c7cdf"}],"aodh/service.py":[{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"ae8452b969eba94b3df7fc7bbe54efb1664db9dc","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from aodh import alarm as aodh_alarm"},{"line_number":32,"context_line":"from aodh.alarm import rpc as rpc_alarm"},{"line_number":33,"context_line":"from aodh import coordination as coordination"},{"line_number":34,"context_line":"from aodh.i18n import _"},{"line_number":35,"context_line":"from aodh import messaging"},{"line_number":36,"context_line":"from aodh import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_c7aaad70","line":33,"updated":"2015-07-13 02:23:56.000000000","message":"I think we can remove this renaming (\u0027as coordination\u0027).","commit_id":"319723e529d492bc77d412998bfeb03cf50c7cdf"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"91ea1deb18001e6545da4f0297d9ac99db7e5df1","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from aodh import alarm as aodh_alarm"},{"line_number":32,"context_line":"from aodh.alarm import rpc as rpc_alarm"},{"line_number":33,"context_line":"from aodh import coordination as coordination"},{"line_number":34,"context_line":"from aodh.i18n import _"},{"line_number":35,"context_line":"from aodh import messaging"},{"line_number":36,"context_line":"from aodh import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_7cf24708","line":33,"in_reply_to":"9a41bdd9_c7aaad70","updated":"2015-07-17 12:15:46.000000000","message":"Good catch.","commit_id":"319723e529d492bc77d412998bfeb03cf50c7cdf"}]}
