)]}'
{"aodh/api/controllers/v2/alarm_rules/event.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3f55883dc048426fbc2c3026fafe0bd78d368831","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2015 NEC Corporation."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Authors: Ryota Mibu \u003cr-mibu@cq.jp.nec.com\u003e"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_97f91c83","line":4,"updated":"2015-07-13 12:22:22.000000000","message":"remove name, we dropped this from our files","commit_id":"8ced379e210aa2ee8930064746c1662e40758572"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"3eba3d41115996893793d95156fb6f4866ceeb6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2015 NEC Corporation."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Authors: Ryota Mibu \u003cr-mibu@cq.jp.nec.com\u003e"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_e293e44d","line":4,"in_reply_to":"9a41bdd9_97f91c83","updated":"2015-07-15 07:20:13.000000000","message":"Done","commit_id":"8ced379e210aa2ee8930064746c1662e40758572"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3f55883dc048426fbc2c3026fafe0bd78d368831","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property"},{"line_number":49,"context_line":"    def default_description(self):"},{"line_number":50,"context_line":"        return (_(\u0027Alarm when %s event occurred.\u0027) % self.event_type)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def as_dict(self):"},{"line_number":53,"context_line":"        rule \u003d self.as_dict_from_keys([\u0027event_type\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_d7b004e0","line":50,"updated":"2015-07-13 12:22:22.000000000","message":"_(\u0027Alarm when %s event occurred.\u0027), self.event_type","commit_id":"8ced379e210aa2ee8930064746c1662e40758572"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"3eba3d41115996893793d95156fb6f4866ceeb6a","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property"},{"line_number":49,"context_line":"    def default_description(self):"},{"line_number":50,"context_line":"        return (_(\u0027Alarm when %s event occurred.\u0027) % self.event_type)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def as_dict(self):"},{"line_number":53,"context_line":"        rule \u003d self.as_dict_from_keys([\u0027event_type\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_02784829","line":50,"in_reply_to":"9a41bdd9_d7b004e0","updated":"2015-07-15 07:20:13.000000000","message":"Will remove external \u0027()\u0027, but it seems we have to use \u0027%\u0027.","commit_id":"8ced379e210aa2ee8930064746c1662e40758572"}],"aodh/tests/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3f55883dc048426fbc2c3026fafe0bd78d368831","unresolved":false,"context_lines":[{"line_number":2833,"context_line":""},{"line_number":2834,"context_line":"            self.alarm_conn.update_alarm(alarm)"},{"line_number":2835,"context_line":""},{"line_number":2836,"context_line":"    def _verify_alarm(self, json, alarm, expected_name\u003dNone):"},{"line_number":2837,"context_line":"        if expected_name and alarm.name !\u003d expected_name:"},{"line_number":2838,"context_line":"            self.fail(\"Alarm not found\")"},{"line_number":2839,"context_line":"        self._add_default_threshold_rule(json)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_77f8184a","line":2836,"updated":"2015-07-13 12:22:22.000000000","message":"this doesn\u0027t seem to be used anywhere.","commit_id":"8ced379e210aa2ee8930064746c1662e40758572"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"3eba3d41115996893793d95156fb6f4866ceeb6a","unresolved":false,"context_lines":[{"line_number":2833,"context_line":""},{"line_number":2834,"context_line":"            self.alarm_conn.update_alarm(alarm)"},{"line_number":2835,"context_line":""},{"line_number":2836,"context_line":"    def _verify_alarm(self, json, alarm, expected_name\u003dNone):"},{"line_number":2837,"context_line":"        if expected_name and alarm.name !\u003d expected_name:"},{"line_number":2838,"context_line":"            self.fail(\"Alarm not found\")"},{"line_number":2839,"context_line":"        self._add_default_threshold_rule(json)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_427e501a","line":2836,"in_reply_to":"9a41bdd9_77f8184a","updated":"2015-07-15 07:20:13.000000000","message":"yes, I\u0027ll remove this.","commit_id":"8ced379e210aa2ee8930064746c1662e40758572"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"30dbda22fb00a4947207b4dcb8ea8cd9dda78ca3","unresolved":false,"context_lines":[{"line_number":2829,"context_line":"                         rule\u003ddict(event_type\u003d\u0027event.test\u0027,"},{"line_number":2830,"context_line":"                                   query\u003d[]),"},{"line_number":2831,"context_line":"                         ),"},{"line_number":2832,"context_line":"                ]:"},{"line_number":2833,"context_line":""},{"line_number":2834,"context_line":"            self.alarm_conn.update_alarm(alarm)"},{"line_number":2835,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_c6e4faad","line":2832,"updated":"2015-07-24 12:22:14.000000000","message":"Is there a particular reason there is a loop here. Making room for future expansion?","commit_id":"d947c47eba16df9ca99ecadf636ec394c07395c7"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"5dd959f7cf41849b3fc96322eefab5ab74fa5988","unresolved":false,"context_lines":[{"line_number":2829,"context_line":"                         rule\u003ddict(event_type\u003d\u0027event.test\u0027,"},{"line_number":2830,"context_line":"                                   query\u003d[]),"},{"line_number":2831,"context_line":"                         ),"},{"line_number":2832,"context_line":"                ]:"},{"line_number":2833,"context_line":""},{"line_number":2834,"context_line":"            self.alarm_conn.update_alarm(alarm)"},{"line_number":2835,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_8f48652f","line":2832,"in_reply_to":"3a50d1a3_c6e4faad","updated":"2015-08-03 14:38:10.000000000","message":"No, we don\u0027t need a loop here.\n\nAnd also the alarm created here only used in test_list_alarms(), so I will move this to the function from setUp().","commit_id":"d947c47eba16df9ca99ecadf636ec394c07395c7"}]}