)]}'
{"aodh/evaluator/event.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"416b1cb13a1c149862a12cb2c4a1ab122fdff565","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        alarms \u003d {a.alarm_id: a for a in"},{"line_number":116,"context_line":"                  self._storage_conn.get_alarms(enabled\u003dTrue,"},{"line_number":117,"context_line":"                                                alarm_type\u003d\u0027event\u0027,"},{"line_number":118,"context_line":"                                                project\u003dproject)}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if self.conf.event_alarm_cache_ttl:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_751ad1c7","line":117,"updated":"2015-09-05 02:26:18.000000000","message":"maybe it\u0027s better to add a \"change-since\" parameter to _storage_conn.get_alarms(). this cache mechanism will remove all the alarms owned by this project and reload all. but it is possible that most of alarms didn\u0027t changed, we can use a \"change-since\" with last evaluation time to filter them out.\n\nthis can be done in another patch.","commit_id":"2977acfc7c0ae7f6439a2a5c77e18519611675c6"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"3c3b38215e4d66cf01773c334a13782b65596238","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        alarms \u003d {a.alarm_id: a for a in"},{"line_number":116,"context_line":"                  self._storage_conn.get_alarms(enabled\u003dTrue,"},{"line_number":117,"context_line":"                                                alarm_type\u003d\u0027event\u0027,"},{"line_number":118,"context_line":"                                                project\u003dproject)}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if self.conf.event_alarm_cache_ttl:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4836f951","line":117,"in_reply_to":"da20952f_751ad1c7","updated":"2015-09-07 01:54:58.000000000","message":"liusheng, agree. That should be nice. I have to check how to implement \"change-since\" at storage api and whether we can capture deletion of alarms. Anyway, I will leave note it in this patch.","commit_id":"2977acfc7c0ae7f6439a2a5c77e18519611675c6"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"37ca4895ec0ebcec87f64d5c77aa80b5cdcd1e9c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import fnmatch"},{"line_number":18,"context_line":"import operator"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_812dbea9","line":19,"updated":"2015-09-07 12:45:56.000000000","message":"Not a big deal but this is in the wrong place, down one section.","commit_id":"78d6675296e9ef649b5afcb94f6ff3860c95f18b"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"3ef96b5c4d936512135e7671642049aa3b7b03ae","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import fnmatch"},{"line_number":18,"context_line":"import operator"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_4284845c","line":19,"in_reply_to":"da20952f_812dbea9","updated":"2015-09-07 13:31:31.000000000","message":"Done","commit_id":"78d6675296e9ef649b5afcb94f6ff3860c95f18b"}]}