)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"bfc2ca899b6be430c8791d0bc2296452807651cc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The parser and helper functions for alarms (type\u003d\u0027event\u0027) are moved to"},{"line_number":11,"context_line":"this new class."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"All trait values in event_ule/query will be sanitized."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If5600113b0552ccc1d3c4cd7d32d4a4ce6057128"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_c3257eae","line":13,"updated":"2015-09-10 08:30:45.000000000","message":"event_rule?","commit_id":"1a31691428e4f4a19b3dff369c5109843710c521"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"a9eb2837eaefaa7b75e3defcdb0d206be6af2b16","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The parser and helper functions for alarms (type\u003d\u0027event\u0027) are moved to"},{"line_number":11,"context_line":"this new class."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"All trait values in event_ule/query will be sanitized."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If5600113b0552ccc1d3c4cd7d32d4a4ce6057128"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_c6d26c34","line":13,"in_reply_to":"da20952f_c3257eae","updated":"2015-09-10 09:01:05.000000000","message":"Done","commit_id":"1a31691428e4f4a19b3dff369c5109843710c521"}],"aodh/evaluator/event.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d5b5887b1836cff3cb9ef917cc64fde2208a3a58","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            value \u003d _sanitize_trait_value(q.get(\u0027value\u0027), type_num)"},{"line_number":140,"context_line":"            op \u003d COMPARATORS[q.get(\u0027op\u0027, \u0027eq\u0027)]"},{"line_number":141,"context_line":"            self.query.append({\u0027field\u0027: field, \u0027value\u0027: value,"},{"line_number":142,"context_line":"                               \u0027op\u0027: op, \u0027org\u0027: q})"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def fired_and_no_repeat(self):"},{"line_number":145,"context_line":"        return (not self.obj.repeat_actions and"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_2c3a7e99","line":142,"updated":"2015-09-08 14:19:38.000000000","message":"what does org stand for?","commit_id":"6c9d198c4253c3e94e04a8e56d45450f9f4b4060"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"500ab88fddca0566d4442a0dc14d32a2f4dd2416","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            value \u003d _sanitize_trait_value(q.get(\u0027value\u0027), type_num)"},{"line_number":140,"context_line":"            op \u003d COMPARATORS[q.get(\u0027op\u0027, \u0027eq\u0027)]"},{"line_number":141,"context_line":"            self.query.append({\u0027field\u0027: field, \u0027value\u0027: value,"},{"line_number":142,"context_line":"                               \u0027op\u0027: op, \u0027org\u0027: q})"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def fired_and_no_repeat(self):"},{"line_number":145,"context_line":"        return (not self.obj.repeat_actions and"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b8244760","line":142,"in_reply_to":"da20952f_27161859","updated":"2015-09-09 21:45:59.000000000","message":"it\u0027s an odd name to be honest. maybe criteria? or  query? \u0027org\u0027 usually is short for organisation.","commit_id":"6c9d198c4253c3e94e04a8e56d45450f9f4b4060"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"ccbc465002b457eee534578d3d0a379a7fd9e2f4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            value \u003d _sanitize_trait_value(q.get(\u0027value\u0027), type_num)"},{"line_number":140,"context_line":"            op \u003d COMPARATORS[q.get(\u0027op\u0027, \u0027eq\u0027)]"},{"line_number":141,"context_line":"            self.query.append({\u0027field\u0027: field, \u0027value\u0027: value,"},{"line_number":142,"context_line":"                               \u0027op\u0027: op, \u0027org\u0027: q})"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def fired_and_no_repeat(self):"},{"line_number":145,"context_line":"        return (not self.obj.repeat_actions and"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_27161859","line":142,"in_reply_to":"da20952f_2c3a7e99","updated":"2015-09-08 15:02:41.000000000","message":"\"original\" - this is just used for creating debug message instead of searching original query in event_rule of this alarm","commit_id":"6c9d198c4253c3e94e04a8e56d45450f9f4b4060"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"40d5b32ac70a92734cf719260c4b05778d48c7b4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            value \u003d _sanitize_trait_value(q.get(\u0027value\u0027), type_num)"},{"line_number":140,"context_line":"            op \u003d COMPARATORS[q.get(\u0027op\u0027, \u0027eq\u0027)]"},{"line_number":141,"context_line":"            self.query.append({\u0027field\u0027: field, \u0027value\u0027: value,"},{"line_number":142,"context_line":"                               \u0027op\u0027: op, \u0027org\u0027: q})"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def fired_and_no_repeat(self):"},{"line_number":145,"context_line":"        return (not self.obj.repeat_actions and"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_4943dbaf","line":142,"in_reply_to":"da20952f_b8244760","updated":"2015-09-09 23:57:00.000000000","message":"Ah, ok.\n\nI rethink this parameter can be dropped. For debugging purpose, showing converted query makes sense rather than showing original format stored in the DB, since developer can find that original query by searching the DB with its alarm id and field name.\n\nSo, I\u0027ll drop \u0027org\u0027 param from here in the next patch set.","commit_id":"6c9d198c4253c3e94e04a8e56d45450f9f4b4060"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"bfc2ca899b6be430c8791d0bc2296452807651cc","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if not alarm.event_type_to_watch(event.obj[\u0027event_type\u0027]):"},{"line_number":228,"context_line":"            LOG.debug(\u0027Aborting evaluation of the alarm (id\u003d%s) due to \u0027"},{"line_number":229,"context_line":"                      \u0027uninterested event_type.\u0027, alarm.id)"},{"line_number":230,"context_line":"            return"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        def _compare(condition):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_002feca1","line":229,"updated":"2015-09-10 08:30:45.000000000","message":"nit: \"due to uninterested event_type\" is an awkward construction\n\nBut since it was already there, no big deal.","commit_id":"1a31691428e4f4a19b3dff369c5109843710c521"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"a9eb2837eaefaa7b75e3defcdb0d206be6af2b16","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if not alarm.event_type_to_watch(event.obj[\u0027event_type\u0027]):"},{"line_number":228,"context_line":"            LOG.debug(\u0027Aborting evaluation of the alarm (id\u003d%s) due to \u0027"},{"line_number":229,"context_line":"                      \u0027uninterested event_type.\u0027, alarm.id)"},{"line_number":230,"context_line":"            return"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        def _compare(condition):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_661b601d","line":229,"in_reply_to":"da20952f_002feca1","updated":"2015-09-10 09:01:05.000000000","message":"ok, i will replace it by \"since event_type is not matched\".","commit_id":"1a31691428e4f4a19b3dff369c5109843710c521"}]}
