)]}'
{"aodh/notifier/__init__.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bd0ff4db3dfcb52a6e1c394541d0b8f1fb9a8182","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                        previous, current, reason, reason_data)"},{"line_number":146,"context_line":"    except Exception:"},{"line_number":147,"context_line":"        LOG.exception(_(\"Unable to notify alarm %s\"), alarm_id)"},{"line_number":148,"context_line":"        return"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def process_alarm(notifiers, data):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_13ddf541","line":148,"updated":"2015-11-24 04:14:23.000000000","message":"I think this last return can be removed","commit_id":"d11a696cae0e2b4f7884ed1321dcbf97cb9a7108"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c2718354eaf0fa43c51a54f87567537cc4458186","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                        previous, current, reason, reason_data)"},{"line_number":146,"context_line":"    except Exception:"},{"line_number":147,"context_line":"        LOG.exception(_(\"Unable to notify alarm %s\"), alarm_id)"},{"line_number":148,"context_line":"        return"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def process_alarm(notifiers, data):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_5800ecaa","line":148,"in_reply_to":"ba8a016a_13ddf541","updated":"2015-11-24 13:14:35.000000000","message":"can i clean this up later as it\u0027s not part of my patch?","commit_id":"d11a696cae0e2b4f7884ed1321dcbf97cb9a7108"}],"aodh/tests/unit/test_notifier.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bd0ff4db3dfcb52a6e1c394541d0b8f1fb9a8182","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # configuration."},{"line_number":56,"context_line":"        self.CONF.set_override(\u0027ipc_protocol\u0027, \u0027rpc\u0027)"},{"line_number":57,"context_line":"        self.service \u003d notifier.AlarmNotifierService(self.CONF)"},{"line_number":58,"context_line":"        with mock.patch.object(self.service.rpc_server, \u0027start\u0027):"},{"line_number":59,"context_line":"            self.service.start()"},{"line_number":60,"context_line":"            self.service.stop()"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_33859906","line":58,"updated":"2015-11-24 04:14:23.000000000","message":"I think this might fail if oslo.messaging\u003d\u003d3.0.0, see bug https://bugs.launchpad.net/aodh/+bug/1519182","commit_id":"d11a696cae0e2b4f7884ed1321dcbf97cb9a7108"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bd0ff4db3dfcb52a6e1c394541d0b8f1fb9a8182","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # returns. Mock it out so we can establish the service"},{"line_number":65,"context_line":"        # configuration."},{"line_number":66,"context_line":"        self.service \u003d notifier.AlarmNotifierService(self.CONF)"},{"line_number":67,"context_line":"        with mock.patch.object(self.service.listener, \u0027start\u0027):"},{"line_number":68,"context_line":"            self.service.start()"},{"line_number":69,"context_line":"            self.service.stop()"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_339cb95c","line":67,"updated":"2015-11-24 04:14:23.000000000","message":"ditto","commit_id":"d11a696cae0e2b4f7884ed1321dcbf97cb9a7108"}]}
