)]}'
{"aodh/api/controllers/v2/alarms.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9356a3e5fcbefe29df70455a1b14432d797295cb","unresolved":false,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        # Ensure alarm exists"},{"line_number":644,"context_line":"        self._alarm(\u0027get_alarm\u0027)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        target \u003d rbac.target_from_segregation_rule("},{"line_number":647,"context_line":"            pecan.request.headers, pecan.request.enforcer)"},{"line_number":648,"context_line":"        rbac.enforce(\u0027alarm_history\u0027, pecan.request.headers,"},{"line_number":649,"context_line":"                     pecan.request.enforcer, target)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        q \u003d q or []"},{"line_number":652,"context_line":"        # allow history to be returned for deleted alarms, but scope changes"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_c873307f","line":649,"range":{"start_line":645,"start_character":0,"end_line":649,"end_character":52},"updated":"2016-03-17 09:24:05.000000000","message":"What about replacing that with:\nself._alarm(\"alarm_history\")\n\nthat should do it.","commit_id":"3ae7abcffdff7d61512a2ebe3d2996235146e17d"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f46fdaafd4922ffeca323a39a3c361b9d5aeef81","unresolved":false,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        # Ensure alarm exists"},{"line_number":644,"context_line":"        self._alarm(\u0027get_alarm\u0027)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        target \u003d rbac.target_from_segregation_rule("},{"line_number":647,"context_line":"            pecan.request.headers, pecan.request.enforcer)"},{"line_number":648,"context_line":"        rbac.enforce(\u0027alarm_history\u0027, pecan.request.headers,"},{"line_number":649,"context_line":"                     pecan.request.enforcer, target)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        q \u003d q or []"},{"line_number":652,"context_line":"        # allow history to be returned for deleted alarms, but scope changes"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_88276863","line":649,"range":{"start_line":645,"start_character":0,"end_line":649,"end_character":52},"in_reply_to":"1af94dfe_c873307f","updated":"2016-03-17 09:25:31.000000000","message":"thanks","commit_id":"3ae7abcffdff7d61512a2ebe3d2996235146e17d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"669aa0948599eb5ff35d974dbc9c4f4be6467d23","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        # Ensure alarm exists"},{"line_number":644,"context_line":"        self._alarm(\u0027alarm_history\u0027)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        target \u003d rbac.target_from_segregation_rule("},{"line_number":647,"context_line":"            pecan.request.headers, pecan.request.enforcer)"},{"line_number":648,"context_line":"        rbac.enforce(\u0027alarm_history\u0027, pecan.request.headers,"},{"line_number":649,"context_line":"                     pecan.request.enforcer, target)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        q \u003d q or []"},{"line_number":652,"context_line":"        # allow history to be returned for deleted alarms, but scope changes"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_da72c910","line":649,"range":{"start_line":646,"start_character":8,"end_line":649,"end_character":52},"updated":"2016-03-17 12:59:20.000000000","message":"You should not need that then.","commit_id":"c36934f6aaa9d1edd15c6a7be5959fd85c0619a8"}],"aodh/tests/functional/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"d3b0aea67f734fb9415b61c2249023fc08383e9e","unresolved":false,"context_lines":[{"line_number":1980,"context_line":"        self.delete(\u0027/alarms/%s\u0027 % \u0027a\u0027,"},{"line_number":1981,"context_line":"                    headers\u003dself.auth_headers,"},{"line_number":1982,"context_line":"                    status\u003d204)"},{"line_number":1983,"context_line":"        self._get_alarm_history(\u0027a\u0027, expect_errors\u003dTrue, status\u003d404)"},{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"    def test_get_alarm_history_ordered_by_recentness(self):"},{"line_number":1986,"context_line":"        for i in moves.xrange(10):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_1615ce9a","line":1983,"range":{"start_line":1983,"start_character":8,"end_line":1983,"end_character":68},"updated":"2016-03-19 02:31:40.000000000","message":"I think this is not enough to test alarm history is deleted, it just test alarm history cannot be retrieved","commit_id":"29422693b90bc6137215bb686ec26233a0f719a7"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f993721d31a9786ef6f194a8e53e7ad0c0469db6","unresolved":false,"context_lines":[{"line_number":1980,"context_line":"        self.delete(\u0027/alarms/%s\u0027 % \u0027a\u0027,"},{"line_number":1981,"context_line":"                    headers\u003dself.auth_headers,"},{"line_number":1982,"context_line":"                    status\u003d204)"},{"line_number":1983,"context_line":"        self._get_alarm_history(\u0027a\u0027, expect_errors\u003dTrue, status\u003d404)"},{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"    def test_get_alarm_history_ordered_by_recentness(self):"},{"line_number":1986,"context_line":"        for i in moves.xrange(10):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_a12f5da0","line":1983,"range":{"start_line":1983,"start_character":8,"end_line":1983,"end_character":68},"in_reply_to":"1af94dfe_1615ce9a","updated":"2016-03-21 01:21:16.000000000","message":"If we cannot retrive the previous existed alarm history, after we delete the coresponding alarm, we can say it has been deleted. Otherwise how should we check it?","commit_id":"29422693b90bc6137215bb686ec26233a0f719a7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"d3b0aea67f734fb9415b61c2249023fc08383e9e","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"                         history[0][\u0027detail\u0027])"},{"line_number":2067,"context_line":""},{"line_number":2068,"context_line":"    def test_get_nonexistent_alarm_history(self):"},{"line_number":2069,"context_line":"        # the existence of alarm history is independent of the"},{"line_number":2070,"context_line":"        # continued existence of the alarm itself"},{"line_number":2071,"context_line":"        self._get_alarm_history(\u0027foobar\u0027, expect_errors\u003dTrue, status\u003d404)"},{"line_number":2072,"context_line":""},{"line_number":2073,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_96427eac","line":2070,"range":{"start_line":2069,"start_character":8,"end_line":2070,"end_character":49},"updated":"2016-03-19 02:31:40.000000000","message":"rm this","commit_id":"29422693b90bc6137215bb686ec26233a0f719a7"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f993721d31a9786ef6f194a8e53e7ad0c0469db6","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"                         history[0][\u0027detail\u0027])"},{"line_number":2067,"context_line":""},{"line_number":2068,"context_line":"    def test_get_nonexistent_alarm_history(self):"},{"line_number":2069,"context_line":"        # the existence of alarm history is independent of the"},{"line_number":2070,"context_line":"        # continued existence of the alarm itself"},{"line_number":2071,"context_line":"        self._get_alarm_history(\u0027foobar\u0027, expect_errors\u003dTrue, status\u003d404)"},{"line_number":2072,"context_line":""},{"line_number":2073,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_4122c1ba","line":2070,"range":{"start_line":2069,"start_character":8,"end_line":2070,"end_character":49},"in_reply_to":"1af94dfe_96427eac","updated":"2016-03-21 01:21:16.000000000","message":"Done","commit_id":"29422693b90bc6137215bb686ec26233a0f719a7"}]}