)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"338a1ea66149da3257e1672f3c23d9ad534b7c7b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change add batch messages listener for aodh-notifier service, that"},{"line_number":10,"context_line":"allow users configure aodh-notifier to receive messages in batch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact: Add new config options in \"notifier\" group: batch_size and"},{"line_number":13,"context_line":"batch_timeout"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5d1eb60be656088a83a3428d0387338b081d1b88"},{"line_number":16,"context_line":"Signed-off-by: liusheng \u003cliusheng@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a122d0e_0dcf652a","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":13},"updated":"2016-04-30 07:14:30.000000000","message":"After further thought, I think we can remove it and add some release notes instead, what do you think?\n\nfor i.e.: https://review.openstack.org/#/c/310450/3/releasenotes/notes/enable-aodh-service-multi-processes-67ed9a0b7fac69aa.yaml\n\nand here is the guide: http://docs.openstack.org/developer/reno/usage.html","commit_id":"820ce0caa77e4755be57ab0a05b544053a8201b4"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"817abd773d473751abd2045b1f9d64e5749f42cd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change add batch messages listener for aodh-notifier service, that"},{"line_number":10,"context_line":"allow users configure aodh-notifier to receive messages in batch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact: Add new config options in \"notifier\" group: batch_size and"},{"line_number":13,"context_line":"batch_timeout"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5d1eb60be656088a83a3428d0387338b081d1b88"},{"line_number":16,"context_line":"Signed-off-by: liusheng \u003cliusheng@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a122d0e_ca388ad7","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":13},"in_reply_to":"1a122d0e_0dcf652a","updated":"2016-05-03 02:02:18.000000000","message":"fair enough, will add reno","commit_id":"820ce0caa77e4755be57ab0a05b544053a8201b4"}],"aodh/notifier/__init__.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"deee92ade07464128f1199198865f82fba003484","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        target \u003d oslo_messaging.Target(topic\u003dconf.notifier_topic)"},{"line_number":81,"context_line":"        self.listener \u003d messaging.get_batch_notification_listener("},{"line_number":82,"context_line":"            transport, [target], [AlarmEndpoint(self.notifiers)], True,"},{"line_number":83,"context_line":"            conf.notifier.batch_size, conf.notifier.batch_timeout)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c7a05ca8","line":82,"range":{"start_line":82,"start_character":66,"end_line":82,"end_character":71},"updated":"2016-04-23 05:26:00.000000000","message":"I\u0027m some kind of against such idea, image that we have 10 alarm should be notified to http, then we batch it, and some fails, we requeue, then notify the succeed again?\n\nand honestly, we have catch everything in process_alarm, there is barely nothing to raise","commit_id":"f7dadce93715343f3d4f0b6764118691d3a80459"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e675eca1df3a79fd9f80885aeca17b8506afc8d5","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        target \u003d oslo_messaging.Target(topic\u003dconf.notifier_topic)"},{"line_number":81,"context_line":"        self.listener \u003d messaging.get_batch_notification_listener("},{"line_number":82,"context_line":"            transport, [target], [AlarmEndpoint(self.notifiers)], True,"},{"line_number":83,"context_line":"            conf.notifier.batch_size, conf.notifier.batch_timeout)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_2784b0af","line":82,"range":{"start_line":82,"start_character":66,"end_line":82,"end_character":71},"in_reply_to":"1a122d0e_c7a05ca8","updated":"2016-04-23 06:23:10.000000000","message":"Hmmm, make sense, will do it.","commit_id":"f7dadce93715343f3d4f0b6764118691d3a80459"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"338a1ea66149da3257e1672f3c23d9ad534b7c7b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    \u0027dispatching them\u0027),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":38,"context_line":"               default\u003dNone,"},{"line_number":39,"context_line":"               help\u003d\u0027Number of seconds to wait before dispatching samples\u0027"},{"line_number":40,"context_line":"                    \u0027when batch_size is not reached (None means indefinitely)\u0027"},{"line_number":41,"context_line":"               ),"},{"line_number":42,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_8de375a4","line":39,"range":{"start_line":39,"start_character":66,"end_line":39,"end_character":74},"updated":"2016-04-30 07:14:30.000000000","message":"need a trailing space, as I told you\n\nAnd perhaps add end dot (.) for the two help strings, Andreas Jaeger will be happy :P","commit_id":"820ce0caa77e4755be57ab0a05b544053a8201b4"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"817abd773d473751abd2045b1f9d64e5749f42cd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    \u0027dispatching them\u0027),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":38,"context_line":"               default\u003dNone,"},{"line_number":39,"context_line":"               help\u003d\u0027Number of seconds to wait before dispatching samples\u0027"},{"line_number":40,"context_line":"                    \u0027when batch_size is not reached (None means indefinitely)\u0027"},{"line_number":41,"context_line":"               ),"},{"line_number":42,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_6a5a162c","line":39,"range":{"start_line":39,"start_character":66,"end_line":39,"end_character":74},"in_reply_to":"1a122d0e_8de375a4","updated":"2016-05-03 02:02:18.000000000","message":"Hmm, seems I made a stupid rebase :)","commit_id":"820ce0caa77e4755be57ab0a05b544053a8201b4"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"338a1ea66149da3257e1672f3c23d9ad534b7c7b","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        target \u003d oslo_messaging.Target(topic\u003dself.conf.notifier_topic)"},{"line_number":85,"context_line":"        self.listener \u003d messaging.get_batch_notification_listener("},{"line_number":86,"context_line":"            transport, [target], [AlarmEndpoint(self.notifiers)], False,"},{"line_number":87,"context_line":"            self.conf.notifier.batch_size, self.conf.notifier.batch_timeout)"},{"line_number":88,"context_line":"        self.listener.start()"},{"line_number":89,"context_line":"        # Add a dummy thread to have wait() working"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_cdebad7a","line":86,"range":{"start_line":86,"start_character":66,"end_line":86,"end_character":72},"updated":"2016-04-30 07:14:30.000000000","message":"clever, then I need to rebase your change, haha :)","commit_id":"820ce0caa77e4755be57ab0a05b544053a8201b4"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b2ab1e05e01a7b28f53d2abcf3e5b96a7957b791","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        target \u003d oslo_messaging.Target(topic\u003dself.conf.notifier_topic)"},{"line_number":85,"context_line":"        self.listener \u003d messaging.get_batch_notification_listener("},{"line_number":86,"context_line":"            transport, [target], [AlarmEndpoint(self.notifiers)], False,"},{"line_number":87,"context_line":"            self.conf.notifier.batch_size, self.conf.notifier.batch_timeout)"},{"line_number":88,"context_line":"        self.listener.start()"},{"line_number":89,"context_line":"        # Add a dummy thread to have wait() working"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_8d041519","line":86,"range":{"start_line":86,"start_character":66,"end_line":86,"end_character":72},"in_reply_to":"1a122d0e_cdebad7a","updated":"2016-04-30 07:48:07.000000000","message":"oops, it is notifier....","commit_id":"820ce0caa77e4755be57ab0a05b544053a8201b4"}],"aodh/tests/unit/test_notifier.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"deee92ade07464128f1199198865f82fba003484","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.assertEqual(mock.call(\u0027Received %s messages in batch.\u0027, 2),"},{"line_number":152,"context_line":"                         logger.call_args_list[0])"},{"line_number":153,"context_line":"        self.svc.stop()"},{"line_number":154,"context_line":"        # restart the self.service since it will be stop in cleanUp method"},{"line_number":155,"context_line":"        self.service.start()"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @staticmethod"},{"line_number":158,"context_line":"    def _notification(action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c7b97cee","line":155,"range":{"start_line":154,"start_character":8,"end_line":155,"end_character":28},"updated":"2016-04-23 05:26:00.000000000","message":"can\u0027t we stop again, is there any error raised? I don\u0027t think so, remove it","commit_id":"f7dadce93715343f3d4f0b6764118691d3a80459"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"a3d5c0fec7a762113f5b44932776e87b939643e1","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.assertEqual(mock.call(\u0027Received %s messages in batch.\u0027, 2),"},{"line_number":152,"context_line":"                         logger.call_args_list[0])"},{"line_number":153,"context_line":"        self.svc.stop()"},{"line_number":154,"context_line":"        # restart the self.service since it will be stop in cleanUp method"},{"line_number":155,"context_line":"        self.service.start()"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @staticmethod"},{"line_number":158,"context_line":"    def _notification(action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c7bb3c74","line":155,"range":{"start_line":154,"start_character":8,"end_line":155,"end_character":28},"in_reply_to":"1a122d0e_c7b97cee","updated":"2016-04-23 06:23:28.000000000","message":"Done","commit_id":"f7dadce93715343f3d4f0b6764118691d3a80459"}]}