)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bb94ba4245f0c1e0f59bbe72c9694c9ad63cf9d3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add batch listener support for event evaluator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DocImpact: Add new config options in \"event\" group: batch_size and"},{"line_number":10,"context_line":"batch_timeout"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifd287b4903bec92db10be759aa239ea354da8a06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_e7740f9d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"updated":"2016-04-28 01:43:35.000000000","message":"this tag is no longer required for config change, last time I submit a config reference patch to openstack-manuals and it is still there","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"c4fd62f82a130a602f4b826e3ca82f3992fd294b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add batch listener support for event evaluator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DocImpact: Add new config options in \"event\" group: batch_size and"},{"line_number":10,"context_line":"batch_timeout"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifd287b4903bec92db10be759aa239ea354da8a06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_eb3cd9c9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"in_reply_to":"1a122d0e_a74b37b0","updated":"2016-04-28 03:18:35.000000000","message":"or you can leave it there, just note that this is no longer a -1 issue\n\nI\u0027m not quite sure doc team\u0027s opinion, they says config reference will be updated periodically, it seems true because my last patch only contains very little diff content, but I;m not quite sure\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2016-April/093255.html","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9976e1ac83ac3e86ebeea2420e33e23fdbe3a299","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add batch listener support for event evaluator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DocImpact: Add new config options in \"event\" group: batch_size and"},{"line_number":10,"context_line":"batch_timeout"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifd287b4903bec92db10be759aa239ea354da8a06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_a74b37b0","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"in_reply_to":"1a122d0e_e7740f9d","updated":"2016-04-28 02:54:41.000000000","message":"so we don\u0027t need this anymore ? any conclusion about the that ?","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"345802286ae8e6296cf7f51481ca80831b6e3620","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add batch listener support for event evaluator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DocImpact: Add new config options in \"event\" group: batch_size and"},{"line_number":10,"context_line":"batch_timeout"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifd287b4903bec92db10be759aa239ea354da8a06"},{"line_number":13,"context_line":"Signed-off-by: liusheng \u003cliusheng@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a122d0e_280e8f32","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":13},"updated":"2016-04-30 07:53:35.000000000","message":"we can remove it and just add a release note in our repo, let doc team update config reference regularly","commit_id":"979d3cc9b948a8fce6d90bc7338331cd650e52cd"}],"aodh/event.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bb94ba4245f0c1e0f59bbe72c9694c9ad63cf9d3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d\u0027The topic that aodh uses for event alarm evaluation.\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027batch_size\u0027,"},{"line_number":33,"context_line":"               default\u003d1,"},{"line_number":34,"context_line":"               help\u003d\u0027Number of notification messages to wait before \u0027"},{"line_number":35,"context_line":"               \u0027dispatching them\u0027),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_07702ba3","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":52},"updated":"2016-04-28 01:43:35.000000000","message":"I\u0027m not sure \u0027notification message\u0027 is legal in language, but I can understand it","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9976e1ac83ac3e86ebeea2420e33e23fdbe3a299","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d\u0027The topic that aodh uses for event alarm evaluation.\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027batch_size\u0027,"},{"line_number":33,"context_line":"               default\u003d1,"},{"line_number":34,"context_line":"               help\u003d\u0027Number of notification messages to wait before \u0027"},{"line_number":35,"context_line":"               \u0027dispatching them\u0027),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_07eaeb73","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":52},"in_reply_to":"1a122d0e_07702ba3","updated":"2016-04-28 02:54:41.000000000","message":"Hmm, seems there are many \"notification message\" usages :) any suggestion ?","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"c4fd62f82a130a602f4b826e3ca82f3992fd294b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d\u0027The topic that aodh uses for event alarm evaluation.\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027batch_size\u0027,"},{"line_number":33,"context_line":"               default\u003d1,"},{"line_number":34,"context_line":"               help\u003d\u0027Number of notification messages to wait before \u0027"},{"line_number":35,"context_line":"               \u0027dispatching them\u0027),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_4b798d92","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":52},"in_reply_to":"1a122d0e_07eaeb73","updated":"2016-04-28 03:18:35.000000000","message":"leave it there :P\n\nor just improve the current place text to: notifications ? Honestly, I don\u0027t know there difference, haha, I think they are duplicate......","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"985e34072f79c5e9f78ed7fd85fe864b86beb15d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d\u0027The topic that aodh uses for event alarm evaluation.\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027batch_size\u0027,"},{"line_number":33,"context_line":"               default\u003d1,"},{"line_number":34,"context_line":"               help\u003d\u0027Number of notification messages to wait before \u0027"},{"line_number":35,"context_line":"               \u0027dispatching them\u0027),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_8b5ba585","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":52},"in_reply_to":"1a122d0e_4b798d92","updated":"2016-04-28 03:47:02.000000000","message":"I guess this can specifically refer to notification type messages than RPC.","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"02db2c6b528d28395f68a69b492ccb828bfe924b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d\u0027The topic that aodh uses for event alarm evaluation.\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027batch_size\u0027,"},{"line_number":33,"context_line":"               default\u003d1,"},{"line_number":34,"context_line":"               help\u003d\u0027Number of notification messages to wait before \u0027"},{"line_number":35,"context_line":"               \u0027dispatching them\u0027),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_4bcced34","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":52},"in_reply_to":"1a122d0e_8b5ba585","updated":"2016-04-28 03:49:58.000000000","message":"make sense","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bb94ba4245f0c1e0f59bbe72c9694c9ad63cf9d3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027dispatching them\u0027),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"},{"line_number":38,"context_line":"               help\u003d\u0027Number of seconds to wait before dispatching samples\u0027"},{"line_number":39,"context_line":"               \u0027when batch_size is not reached (None means indefinitely)\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_c7791395","line":38,"range":{"start_line":38,"start_character":73,"end_line":38,"end_character":74},"updated":"2016-04-28 01:43:35.000000000","message":"s/messages/\n\nah, a space","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9976e1ac83ac3e86ebeea2420e33e23fdbe3a299","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027dispatching them\u0027),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"},{"line_number":38,"context_line":"               help\u003d\u0027Number of seconds to wait before dispatching samples\u0027"},{"line_number":39,"context_line":"               \u0027when batch_size is not reached (None means indefinitely)\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_6703df42","line":38,"range":{"start_line":38,"start_character":73,"end_line":38,"end_character":74},"in_reply_to":"1a122d0e_c7791395","updated":"2016-04-28 02:54:41.000000000","message":"Done","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bb94ba4245f0c1e0f59bbe72c9694c9ad63cf9d3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.listener \u003d messaging.get_batch_notification_listener("},{"line_number":65,"context_line":"            messaging.get_transport(self.conf),"},{"line_number":66,"context_line":"            [oslo_messaging.Target(topic\u003dself.conf.event.event_alarm_topic)],"},{"line_number":67,"context_line":"            [EventAlarmEndpoint(self.evaluator)], True,"},{"line_number":68,"context_line":"            self.conf.event.batch_size,"},{"line_number":69,"context_line":"            self.conf.event.batch_timeout)"},{"line_number":70,"context_line":"        self.listener.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_e79b6fc7","line":67,"range":{"start_line":67,"start_character":50,"end_line":67,"end_character":55},"updated":"2016-04-28 01:43:35.000000000","message":"without my patch: https://review.openstack.org/#/c/309761/2/aodh/evaluator/event.py  , this setting actually has no effect, please, review that one and rebase on it, thanks\n\nafter we enable the requeue for batch, we need more discuss about the requeue behavior, this will impact the event already evaluated\n\n@sileht any hint?\n\nI have a solution, drafting for it, @liusheng, you can continue for this work, thanks for your patience","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"c4fd62f82a130a602f4b826e3ca82f3992fd294b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.listener \u003d messaging.get_batch_notification_listener("},{"line_number":65,"context_line":"            messaging.get_transport(self.conf),"},{"line_number":66,"context_line":"            [oslo_messaging.Target(topic\u003dself.conf.event.event_alarm_topic)],"},{"line_number":67,"context_line":"            [EventAlarmEndpoint(self.evaluator)], True,"},{"line_number":68,"context_line":"            self.conf.event.batch_size,"},{"line_number":69,"context_line":"            self.conf.event.batch_timeout)"},{"line_number":70,"context_line":"        self.listener.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_6b39e9a3","line":67,"range":{"start_line":67,"start_character":50,"end_line":67,"end_character":55},"in_reply_to":"1a122d0e_a7a7b74e","updated":"2016-04-28 03:18:35.000000000","message":"my patch needs update as well...","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9976e1ac83ac3e86ebeea2420e33e23fdbe3a299","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.listener \u003d messaging.get_batch_notification_listener("},{"line_number":65,"context_line":"            messaging.get_transport(self.conf),"},{"line_number":66,"context_line":"            [oslo_messaging.Target(topic\u003dself.conf.event.event_alarm_topic)],"},{"line_number":67,"context_line":"            [EventAlarmEndpoint(self.evaluator)], True,"},{"line_number":68,"context_line":"            self.conf.event.batch_size,"},{"line_number":69,"context_line":"            self.conf.event.batch_timeout)"},{"line_number":70,"context_line":"        self.listener.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_a7a7b74e","line":67,"range":{"start_line":67,"start_character":50,"end_line":67,"end_character":55},"in_reply_to":"1a122d0e_e79b6fc7","updated":"2016-04-28 02:54:41.000000000","message":"yeah, I know that and your changes is necessary, this parameter means \"allow_reqeue\", so I think enable this is the precondition for your change, and this change also changed the input parameters of sample() method, so may it is better to rebase your change on this ?\n\nI will review your change, thanks :)","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"345802286ae8e6296cf7f51481ca80831b6e3620","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d\u0027The topic that aodh uses for event alarm evaluation.\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027batch_size\u0027,"},{"line_number":33,"context_line":"               default\u003d1,"},{"line_number":34,"context_line":"               help\u003d\u0027Number of notification messages to wait before \u0027"},{"line_number":35,"context_line":"               \u0027dispatching them\u0027),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027batch_timeout\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"},{"line_number":38,"context_line":"               help\u003d\u0027Number of seconds to wait before dispatching samples \u0027"},{"line_number":39,"context_line":"               \u0027when batch_size is not reached (None means indefinitely)\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_c8fc3b0f","line":39,"range":{"start_line":34,"start_character":20,"end_line":39,"end_character":73},"updated":"2016-04-30 07:53:35.000000000","message":"and trailing dot (.) for those two help string if you can","commit_id":"979d3cc9b948a8fce6d90bc7338331cd650e52cd"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"345802286ae8e6296cf7f51481ca80831b6e3620","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.listener \u003d messaging.get_batch_notification_listener("},{"line_number":65,"context_line":"            messaging.get_transport(self.conf),"},{"line_number":66,"context_line":"            [oslo_messaging.Target(topic\u003dself.conf.event.event_alarm_topic)],"},{"line_number":67,"context_line":"            [EventAlarmEndpoint(self.evaluator)], True,"},{"line_number":68,"context_line":"            self.conf.event.batch_size,"},{"line_number":69,"context_line":"            self.conf.event.batch_timeout)"},{"line_number":70,"context_line":"        self.listener.start()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_08075319","line":67,"range":{"start_line":67,"start_character":50,"end_line":67,"end_character":54},"updated":"2016-04-30 07:53:35.000000000","message":"make it false, just as what we do now, I will fix it in next patches\n\neven if my patch is blocked, such change affect two aspects of consuming notifications, which is not good for one patch","commit_id":"979d3cc9b948a8fce6d90bc7338331cd650e52cd"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"21950f161dd628f0d1f575704412185f6ec1c089","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.listener \u003d messaging.get_batch_notification_listener("},{"line_number":65,"context_line":"            messaging.get_transport(self.conf),"},{"line_number":66,"context_line":"            [oslo_messaging.Target(topic\u003dself.conf.event.event_alarm_topic)],"},{"line_number":67,"context_line":"            [EventAlarmEndpoint(self.evaluator)], True,"},{"line_number":68,"context_line":"            self.conf.event.batch_size,"},{"line_number":69,"context_line":"            self.conf.event.batch_timeout)"},{"line_number":70,"context_line":"        self.listener.start()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_4510edab","line":67,"range":{"start_line":67,"start_character":49,"end_line":67,"end_character":55},"updated":"2016-05-03 03:26:32.000000000","message":"OK, seems you do like it\n\nanyway, I think it is no effect, because we catch all exceptions","commit_id":"9379aec2ba50a31ab93b663b003c25bece0c1acb"}],"aodh/opts.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"06eb73440faf96d536198ad75c33ecd9384eb16f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        (\u0027service_credentials\u0027, aodh.keystone_client.OPTS),"},{"line_number":69,"context_line":"        (\u0027service_types\u0027, aodh.notifier.zaqar.SERVICE_OPTS),"},{"line_number":70,"context_line":"        (\u0027notifier\u0027, aodh.notifier.OPTS),"},{"line_number":71,"context_line":"        (\u0027event\u0027, aodh.event.OPTS)"},{"line_number":72,"context_line":"    ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_959fc964","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":34},"updated":"2016-05-03 11:57:50.000000000","message":"how about move it to listener section? Since L66 exists, there is a listener section for event alarm and an event section for event alarm consumer, it seems a bit inconvenient, what\u0027s your opinion?","commit_id":"9379aec2ba50a31ab93b663b003c25bece0c1acb"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"069d22e2a3bfcff496b7f0784f85f9640c37af85","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        (\u0027service_credentials\u0027, aodh.keystone_client.OPTS),"},{"line_number":69,"context_line":"        (\u0027service_types\u0027, aodh.notifier.zaqar.SERVICE_OPTS),"},{"line_number":70,"context_line":"        (\u0027notifier\u0027, aodh.notifier.OPTS),"},{"line_number":71,"context_line":"        (\u0027event\u0027, aodh.event.OPTS)"},{"line_number":72,"context_line":"    ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_9c05177b","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":34},"in_reply_to":"1a122d0e_959fc964","updated":"2016-05-04 01:22:53.000000000","message":"yeah, it should be that group, thanks for pointing!","commit_id":"9379aec2ba50a31ab93b663b003c25bece0c1acb"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e2f5c8ad251435a0f62f9978bb35433e3d3d2929","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        (\u0027service_credentials\u0027, aodh.keystone_client.OPTS),"},{"line_number":69,"context_line":"        (\u0027service_types\u0027, aodh.notifier.zaqar.SERVICE_OPTS),"},{"line_number":70,"context_line":"        (\u0027notifier\u0027, aodh.notifier.OPTS),"},{"line_number":71,"context_line":"        (\u0027event\u0027, aodh.event.OPTS)"},{"line_number":72,"context_line":"    ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_dc0dcf90","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":34},"in_reply_to":"1a122d0e_9c05177b","updated":"2016-05-04 01:26:06.000000000","message":"Hmm, but I am a bit prefer \"event\" than \"listener\", the listener easy make us remind message listener.. :) but OK.","commit_id":"9379aec2ba50a31ab93b663b003c25bece0c1acb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"864d4d91fd0518e25b1f119a9cba8fac53d7143b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        (\u0027service_credentials\u0027, aodh.keystone_client.OPTS),"},{"line_number":69,"context_line":"        (\u0027service_types\u0027, aodh.notifier.zaqar.SERVICE_OPTS),"},{"line_number":70,"context_line":"        (\u0027notifier\u0027, aodh.notifier.OPTS),"},{"line_number":71,"context_line":"        (\u0027event\u0027, aodh.event.OPTS)"},{"line_number":72,"context_line":"    ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_e7a6380e","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":34},"in_reply_to":"1a122d0e_dc0dcf90","updated":"2016-05-04 01:54:18.000000000","message":"I just want to keep it concentrate, if people want to control listener behavior, then most of them should be found in listener(or another name) section, not searching through entire config file :)","commit_id":"9379aec2ba50a31ab93b663b003c25bece0c1acb"}],"aodh/tests/unit/test_event.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bb94ba4245f0c1e0f59bbe72c9694c9ad63cf9d3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        time.sleep(1)"},{"line_number":77,"context_line":"        self.assertEqual(1, len(received_events))"},{"line_number":78,"context_line":"        self.assertEqual(2, len(received_events[0]))"},{"line_number":79,"context_line":"        self.svc.stop()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_67975f90","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":22},"updated":"2016-04-28 01:43:35.000000000","message":"self.addCleanup(self.svc.stop) and move it before self.svc.start()","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"c4fd62f82a130a602f4b826e3ca82f3992fd294b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        time.sleep(1)"},{"line_number":77,"context_line":"        self.assertEqual(1, len(received_events))"},{"line_number":78,"context_line":"        self.assertEqual(2, len(received_events[0]))"},{"line_number":79,"context_line":"        self.svc.stop()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_eb4df93e","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":22},"in_reply_to":"1a122d0e_6778ffc4","updated":"2016-04-28 03:18:35.000000000","message":"not necessary so far, until it bites you :P","commit_id":"2a84242263334c7cec54ae9273abde3304add709"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9976e1ac83ac3e86ebeea2420e33e23fdbe3a299","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        time.sleep(1)"},{"line_number":77,"context_line":"        self.assertEqual(1, len(received_events))"},{"line_number":78,"context_line":"        self.assertEqual(2, len(received_events[0]))"},{"line_number":79,"context_line":"        self.svc.stop()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_6778ffc4","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":22},"in_reply_to":"1a122d0e_67975f90","updated":"2016-04-28 02:54:41.000000000","message":"does this will cause cleanup action with self.svc.stop when end every tests ? it is not very necessary, because this self.svc is specific for this test with \"self.CONF.set_override(\"batch_size\", 2, \u0027event\u0027)\"","commit_id":"2a84242263334c7cec54ae9273abde3304add709"}]}