)]}'
{"aodh/evaluator/event.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"ed4785b35caa57288c6b9af14f15d60c2a90ac93","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                    LOG.exception(_LE(\u0027Failed to evaluate alarm (id\u003d%(a)s) \u0027"},{"line_number":179,"context_line":"                                      \u0027triggered by event \u003d %(e)s.\u0027),"},{"line_number":180,"context_line":"                                  {\u0027a\u0027: id, \u0027e\u0027: e})"},{"line_number":181,"context_line":"                    raise"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.debug(\u0027Finished event alarm evaluation.\u0027)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_8b58c532","line":181,"range":{"start_line":181,"start_character":20,"end_line":181,"end_character":25},"updated":"2016-04-28 03:08:50.000000000","message":"a bit concern, the event evaluator don\u0027t raise any exception explicitly. and, I am not sure any exception raised need to requeue the message.","commit_id":"a4fdca7b92fee3710711681c092cd779177be8b3"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b22dbe2e695b95ca4a7048e55549ee533c384050","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                    LOG.exception(_LE(\u0027Failed to evaluate alarm (id\u003d%(a)s) \u0027"},{"line_number":179,"context_line":"                                      \u0027triggered by event \u003d %(e)s.\u0027),"},{"line_number":180,"context_line":"                                  {\u0027a\u0027: id, \u0027e\u0027: e})"},{"line_number":181,"context_line":"                    raise"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.debug(\u0027Finished event alarm evaluation.\u0027)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_4b8d0d30","line":181,"range":{"start_line":181,"start_character":20,"end_line":181,"end_character":25},"in_reply_to":"1a122d0e_0beb15dd","updated":"2016-04-28 03:35:33.000000000","message":"so convenient, no news is good news, so we are silent...\n\nI think I can handle it in this patch","commit_id":"a4fdca7b92fee3710711681c092cd779177be8b3"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"904eb29d3341fec51543af52b6b181240f8cf2a3","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                    LOG.exception(_LE(\u0027Failed to evaluate alarm (id\u003d%(a)s) \u0027"},{"line_number":179,"context_line":"                                      \u0027triggered by event \u003d %(e)s.\u0027),"},{"line_number":180,"context_line":"                                  {\u0027a\u0027: id, \u0027e\u0027: e})"},{"line_number":181,"context_line":"                    raise"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.debug(\u0027Finished event alarm evaluation.\u0027)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_abc821a9","line":181,"range":{"start_line":181,"start_character":20,"end_line":181,"end_character":25},"in_reply_to":"1a122d0e_8b58c532","updated":"2016-04-28 03:16:03.000000000","message":"An exception raised means this alarm evaluation is not fully completer, such it could fail in anywhere including database, notifier, I think if fail at last step of sending notifier, it is arguable if requeue or not, otherwise, I think requeue is the right direction\n\nCheers!","commit_id":"a4fdca7b92fee3710711681c092cd779177be8b3"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"8ead00bb934d0fbddd74d87a596a3ef711eab10f","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                    LOG.exception(_LE(\u0027Failed to evaluate alarm (id\u003d%(a)s) \u0027"},{"line_number":179,"context_line":"                                      \u0027triggered by event \u003d %(e)s.\u0027),"},{"line_number":180,"context_line":"                                  {\u0027a\u0027: id, \u0027e\u0027: e})"},{"line_number":181,"context_line":"                    raise"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.debug(\u0027Finished event alarm evaluation.\u0027)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_0beb15dd","line":181,"range":{"start_line":181,"start_character":20,"end_line":181,"end_character":25},"in_reply_to":"1a122d0e_abc821a9","updated":"2016-04-28 03:30:02.000000000","message":"as you said, exceptions may in database, notifier. but I found these two devils have been killed, see:\nhttps://github.com/openstack/aodh/blob/master/aodh/evaluator/__init__.py#L129-L132\n\nhaha :P","commit_id":"a4fdca7b92fee3710711681c092cd779177be8b3"}]}