)]}'
{"aodh/api/controllers/v2/query.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e6de0cfd4975064491e62117a5b2234a53a88f8a","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                                           query.orderby,"},{"line_number":390,"context_line":"                                           query.limit)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        if query.orderby:"},{"line_number":393,"context_line":"            for query_item in query.orderby:"},{"line_number":394,"context_line":"                # Check if dict has key \u0027severity\u0027"},{"line_number":395,"context_line":"                if \u0027severity\u0027 in query_item:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_00cf6f56","line":392,"updated":"2016-06-14 10:10:43.000000000","message":"This must be done by backend, not in API layer.","commit_id":"da74024aaacd91aadd82b08365b3e3122c83979c"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"bf7b65b70c3bbff0bb4a3d2ff815690293db27bf","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                                           query.orderby,"},{"line_number":390,"context_line":"                                           query.limit)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        if query.orderby:"},{"line_number":393,"context_line":"            for query_item in query.orderby:"},{"line_number":394,"context_line":"                # Check if dict has key \u0027severity\u0027"},{"line_number":395,"context_line":"                if \u0027severity\u0027 in query_item:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_76c1dde3","line":392,"in_reply_to":"7aa08908_00cf6f56","updated":"2016-06-14 10:47:41.000000000","message":"@sileht Thanks for pointing that out. I understand that this change is inappropriate here. I will submit a new patch which makes changes at the storage level rather than API layer.","commit_id":"da74024aaacd91aadd82b08365b3e3122c83979c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"87e9ad28db8c59d1be06e2dbdb79cf68cac88b8b","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                if \u0027severity\u0027 in query_item:"},{"line_number":396,"context_line":"                    for alarm in get_alarm_list:"},{"line_number":397,"context_line":"                        # Change severity strings to numbers"},{"line_number":398,"context_line":"                        if alarm.severity \u003d\u003d \u0027critical\u0027:"},{"line_number":399,"context_line":"                            alarm.severity \u003d 2"},{"line_number":400,"context_line":"                            alarm_list.append(alarm)"},{"line_number":401,"context_line":"                        elif alarm.severity \u003d\u003d \u0027moderate\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ed59e55c","line":398,"updated":"2016-06-10 19:19:45.000000000","message":"these should use hardcoded values.","commit_id":"da74024aaacd91aadd82b08365b3e3122c83979c"}],"aodh/tests/functional/api/v2/test_complex_query_scenarios.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"59ed74e2a53626e323809a24b9052270a11681a0","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        alarms \u003d list(data.json)"},{"line_number":205,"context_line":"        severities \u003d [a[\u0027severity\u0027] for a in alarms]"},{"line_number":206,"context_line":"        sorted_severities \u003d sorted("},{"line_number":207,"context_line":"            severities, key\u003d[\u0027low\u0027, \u0027moderate\u0027, \u0027critical\u0027].index)"},{"line_number":208,"context_line":"        self.assertEqual(sorted_severities, severities)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        orderby \u003d \u0027[{\"severity\": \"DESC\"}]\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_0251b30e","line":207,"range":{"start_line":207,"start_character":28,"end_line":207,"end_character":65},"updated":"2016-06-21 08:31:33.000000000","message":"This is also used in DESC test, so I think it is better to define a variable to assign this to reduce future changes. The list may be changed, e.g. new severity is added.","commit_id":"6b40de8e819e375b50de49c467310ae606b6cf83"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"18470ffe97074000686451a35cab58580cb5477a","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        alarms \u003d list(data.json)"},{"line_number":205,"context_line":"        severities \u003d [a[\u0027severity\u0027] for a in alarms]"},{"line_number":206,"context_line":"        sorted_severities \u003d sorted("},{"line_number":207,"context_line":"            severities, key\u003d[\u0027low\u0027, \u0027moderate\u0027, \u0027critical\u0027].index)"},{"line_number":208,"context_line":"        self.assertEqual(sorted_severities, severities)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        orderby \u003d \u0027[{\"severity\": \"DESC\"}]\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_b330f3e9","line":207,"range":{"start_line":207,"start_character":28,"end_line":207,"end_character":65},"in_reply_to":"5a9d85d2_0251b30e","updated":"2016-06-21 09:11:58.000000000","message":"Done","commit_id":"6b40de8e819e375b50de49c467310ae606b6cf83"}]}