)]}'
{"aodh/storage/impl_sqlalchemy.py":[{"author":{"_account_id":18802,"name":"liyuanzhen","email":"li.yuanzhen@zte.com.cn","username":"liyuanzhen"},"change_message_id":"433ec6d221705183824e09a3ad786304f711ddc3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            current_version \u003d ctxt.get_current_revision()"},{"line_number":97,"context_line":"            if current_version is None:"},{"line_number":98,"context_line":"                try:"},{"line_number":99,"context_line":"                    models.Base.metadata.create_all(engine, checkfirst\u003dFalse)"},{"line_number":100,"context_line":"                except exception.DBError:"},{"line_number":101,"context_line":"                    # Assume tables exist from Ceilometer, take control"},{"line_number":102,"context_line":"                    # FIXME(jd) Remove in Ocata"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9b9010ef","line":99,"range":{"start_line":99,"start_character":60,"end_line":99,"end_character":76},"updated":"2016-06-30 06:39:47.000000000","message":"why set \"checkfirst\"\u003dFlase? Could you help me to solve this puzzle? I think use the default value \"checkfirst\u003dTrue\" maybe more suitable. what do you think?","commit_id":"7b82364b514db28e0c86e8e1d96fddb6eeacb0d5"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7808ab383ce6ba9e10fcdda65f44107e7bc23cca","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            current_version \u003d ctxt.get_current_revision()"},{"line_number":97,"context_line":"            if current_version is None:"},{"line_number":98,"context_line":"                try:"},{"line_number":99,"context_line":"                    models.Base.metadata.create_all(engine, checkfirst\u003dFalse)"},{"line_number":100,"context_line":"                except exception.DBError:"},{"line_number":101,"context_line":"                    # Assume tables exist from Ceilometer, take control"},{"line_number":102,"context_line":"                    # FIXME(jd) Remove in Ocata"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f8b6733c","line":99,"range":{"start_line":99,"start_character":60,"end_line":99,"end_character":76},"in_reply_to":"3aaa91ec_9b9010ef","updated":"2016-06-30 08:50:54.000000000","message":"Without checkfirst\u003dFalse, if a table already exists, it will be ignored by SQLAlchemy. So there\u0027s no way we\u0027ll know if the table is up to date.\n\nBy setting it to False, create_all() will raise a DBError if an alarm table already exist, and will be able to try to upgrade it.","commit_id":"7b82364b514db28e0c86e8e1d96fddb6eeacb0d5"},{"author":{"_account_id":18802,"name":"liyuanzhen","email":"li.yuanzhen@zte.com.cn","username":"liyuanzhen"},"change_message_id":"b7b9cba674b278036d8533c03a216353351fd4d4","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            current_version \u003d ctxt.get_current_revision()"},{"line_number":97,"context_line":"            if current_version is None:"},{"line_number":98,"context_line":"                try:"},{"line_number":99,"context_line":"                    models.Base.metadata.create_all(engine, checkfirst\u003dFalse)"},{"line_number":100,"context_line":"                except exception.DBError:"},{"line_number":101,"context_line":"                    # Assume tables exist from Ceilometer, take control"},{"line_number":102,"context_line":"                    # FIXME(jd) Remove in Ocata"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b85fcb3f","line":99,"range":{"start_line":99,"start_character":60,"end_line":99,"end_character":76},"in_reply_to":"3aaa91ec_f8b6733c","updated":"2016-06-30 09:03:16.000000000","message":"Got it, thank you","commit_id":"7b82364b514db28e0c86e8e1d96fddb6eeacb0d5"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"82a5dfbf3c7d2c63c2d6491f48a88b1b1156edb2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    command.stamp(cfg, \"12fe8fac9fe4\")"},{"line_number":104,"context_line":"                    command.upgrade(cfg, \"head\")"},{"line_number":105,"context_line":"                else:"},{"line_number":106,"context_line":"                    command.stamp(cfg, \"head\")"},{"line_number":107,"context_line":"            else:"},{"line_number":108,"context_line":"                command.upgrade(cfg, \"head\")"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_902676b8","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":46},"updated":"2016-07-11 08:49:22.000000000","message":"Does just set the revision in the database to the head, without performing any migrations(upgrade)?","commit_id":"7b82364b514db28e0c86e8e1d96fddb6eeacb0d5"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"81dd804aa86fc942d5ba17a9afc83f160e64d4f1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    command.stamp(cfg, \"12fe8fac9fe4\")"},{"line_number":104,"context_line":"                    command.upgrade(cfg, \"head\")"},{"line_number":105,"context_line":"                else:"},{"line_number":106,"context_line":"                    command.stamp(cfg, \"head\")"},{"line_number":107,"context_line":"            else:"},{"line_number":108,"context_line":"                command.upgrade(cfg, \"head\")"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_414dcb3c","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":46},"in_reply_to":"1aa78d24_902676b8","updated":"2016-07-13 16:30:11.000000000","message":"Is the answer in the question? Why do you set -1? :(","commit_id":"7b82364b514db28e0c86e8e1d96fddb6eeacb0d5"}]}