)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"c2125d750e041ccc54c51d043f005ed8e79b1420","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dongwenjuan \u003cdong.wenjuan@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-18 08:51:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add alarm delete notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-off-by: dongwenjuan \u003cdong.wenjuan@zte.com.cn\u003e"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_1f5f4b0f","line":7,"updated":"2016-10-18 08:45:43.000000000","message":"Better to add the use case of this new notification in commit message.","commit_id":"8aa88b50da057f473d3d4256fa1a8908536348a4"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"24a919253c0a1020f9988e586f04007a7b82de79","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Aodh user may would like to get Aodh alarm state immdiately via notification"},{"line_number":10,"context_line":"from the message bus. Currently, the alarm.creation and alarm.state_transition"},{"line_number":11,"context_line":"notifications are exits except the alarm.deletion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: dongwenjuan \u003cdong.wenjuan@zte.com.cn\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa6399be_13f654d7","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":23},"updated":"2016-10-18 15:21:14.000000000","message":"^ both exist","commit_id":"3dc2b575f7aaac96c67067aa15cb30e829411b3e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"24a919253c0a1020f9988e586f04007a7b82de79","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Aodh user may would like to get Aodh alarm state immdiately via notification"},{"line_number":10,"context_line":"from the message bus. Currently, the alarm.creation and alarm.state_transition"},{"line_number":11,"context_line":"notifications are exits except the alarm.deletion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: dongwenjuan \u003cdong.wenjuan@zte.com.cn\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa6399be_f3f800c7","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":30},"updated":"2016-10-18 15:21:14.000000000","message":"^ but xxx does not","commit_id":"3dc2b575f7aaac96c67067aa15cb30e829411b3e"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"4a94402e2f1545f101af3323c255eed1f02bdea0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add alarm.deletion notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Aodh user may would like to get Aodh alarm state immdiately via notification"},{"line_number":10,"context_line":"from the message bus. Currently, the alarm.creation and alarm.state_transition"},{"line_number":11,"context_line":"notifications both exist but the alarm.deletion does not."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa6399be_d4a2cd4a","line":9,"updated":"2016-10-19 16:32:35.000000000","message":"minor wording corrections:\n\n\"user may would like ...\" \u003d\u003e  \"user may like ...\"","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"135f8adfab6d9dc2029911a3fcddfea451e511dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add alarm.deletion notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Aodh user may would like to get Aodh alarm state immdiately via notification"},{"line_number":10,"context_line":"from the message bus. Currently, the alarm.creation and alarm.state_transition"},{"line_number":11,"context_line":"notifications both exist but the alarm.deletion does not."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa6399be_cc84f6b2","line":9,"in_reply_to":"fa6399be_d4a2cd4a","updated":"2016-10-20 01:07:53.000000000","message":"Done","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"4a94402e2f1545f101af3323c255eed1f02bdea0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add alarm.deletion notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Aodh user may would like to get Aodh alarm state immdiately via notification"},{"line_number":10,"context_line":"from the message bus. Currently, the alarm.creation and alarm.state_transition"},{"line_number":11,"context_line":"notifications both exist but the alarm.deletion does not."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: dongwenjuan \u003cdong.wenjuan@zte.com.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa6399be_94669527","line":10,"updated":"2016-10-19 16:32:35.000000000","message":"minor wording:  \"the\" not needed here (delete):\n\"Currently, the alarm.creation ...\" \u003d\u003e \"Currently, alarm.creation ...\"","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"135f8adfab6d9dc2029911a3fcddfea451e511dc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add alarm.deletion notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Aodh user may would like to get Aodh alarm state immdiately via notification"},{"line_number":10,"context_line":"from the message bus. Currently, the alarm.creation and alarm.state_transition"},{"line_number":11,"context_line":"notifications both exist but the alarm.deletion does not."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: dongwenjuan \u003cdong.wenjuan@zte.com.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa6399be_ec937af8","line":10,"in_reply_to":"fa6399be_94669527","updated":"2016-10-20 01:07:53.000000000","message":"Done","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"4a94402e2f1545f101af3323c255eed1f02bdea0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Aodh user may would like to get Aodh alarm state immdiately via notification"},{"line_number":10,"context_line":"from the message bus. Currently, the alarm.creation and alarm.state_transition"},{"line_number":11,"context_line":"notifications both exist but the alarm.deletion does not."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: dongwenjuan \u003cdong.wenjuan@zte.com.cn\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa6399be_3459495b","line":11,"updated":"2016-10-19 16:32:35.000000000","message":"minor working:  \"the\" not needed here; add \",\" (delete):\n\"...exist but the alarm.deletion ...\" \u003d\u003e \"...exist, but alarm.deletion ...\"","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"135f8adfab6d9dc2029911a3fcddfea451e511dc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Aodh user may would like to get Aodh alarm state immdiately via notification"},{"line_number":10,"context_line":"from the message bus. Currently, the alarm.creation and alarm.state_transition"},{"line_number":11,"context_line":"notifications both exist but the alarm.deletion does not."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: dongwenjuan \u003cdong.wenjuan@zte.com.cn\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa6399be_0c8fcecc","line":11,"in_reply_to":"fa6399be_3459495b","updated":"2016-10-20 01:07:53.000000000","message":"Done","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"}],"aodh/api/controllers/v2/alarms.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"41e99c8d59ad37fdc3011fb22c1843149f6d07c0","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        payload[\u0027detail\u0027] \u003d scrubbed_data"},{"line_number":561,"context_line":"        _send_notification(type, payload)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def _record_delete(self, alarm):"},{"line_number":564,"context_line":"        if not alarm:"},{"line_number":565,"context_line":"            return"},{"line_number":566,"context_line":"        type \u003d models.AlarmChange.DELETION"},{"line_number":567,"context_line":"        detail \u003d {\u0027state\u0027: alarm.state}"},{"line_number":568,"context_line":"        user_id \u003d pecan.request.headers.get(\u0027X-User-Id\u0027)"},{"line_number":569,"context_line":"        project_id \u003d pecan.request.headers.get(\u0027X-Project-Id\u0027)"},{"line_number":570,"context_line":"        payload \u003d dict(event_id\u003dstr(uuid.uuid4()),"},{"line_number":571,"context_line":"                       alarm_id\u003dself._id,"},{"line_number":572,"context_line":"                       type\u003dtype,"},{"line_number":573,"context_line":"                       detail\u003ddetail,"},{"line_number":574,"context_line":"                       user_id\u003duser_id,"},{"line_number":575,"context_line":"                       project_id\u003dproject_id,"},{"line_number":576,"context_line":"                       on_behalf_of\u003dproject_id,"},{"line_number":577,"context_line":"                       timestamp\u003dtimeutils.utcnow(),"},{"line_number":578,"context_line":"                       severity\u003dalarm.severity)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        pecan.request.storage.delete_alarm(alarm.alarm_id)"},{"line_number":581,"context_line":"        _send_notification(type, payload)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    @wsme_pecan.wsexpose(Alarm)"},{"line_number":584,"context_line":"    def get(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_35e1409b","line":581,"range":{"start_line":563,"start_character":0,"end_line":581,"end_character":41},"updated":"2016-10-19 19:07:31.000000000","message":"tbh, i\u0027d prefer to separate the notification from the action. i don\u0027t want it to fail because my notification failed.\n\nit\u0027d be best to make notification aspect more generic so we don\u0027t need one per change type","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"1109ae7694a04fadaef3b44fc4e010738b3f417e","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        payload[\u0027detail\u0027] \u003d scrubbed_data"},{"line_number":561,"context_line":"        _send_notification(type, payload)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def _record_delete(self, alarm):"},{"line_number":564,"context_line":"        if not alarm:"},{"line_number":565,"context_line":"            return"},{"line_number":566,"context_line":"        type \u003d models.AlarmChange.DELETION"},{"line_number":567,"context_line":"        detail \u003d {\u0027state\u0027: alarm.state}"},{"line_number":568,"context_line":"        user_id \u003d pecan.request.headers.get(\u0027X-User-Id\u0027)"},{"line_number":569,"context_line":"        project_id \u003d pecan.request.headers.get(\u0027X-Project-Id\u0027)"},{"line_number":570,"context_line":"        payload \u003d dict(event_id\u003dstr(uuid.uuid4()),"},{"line_number":571,"context_line":"                       alarm_id\u003dself._id,"},{"line_number":572,"context_line":"                       type\u003dtype,"},{"line_number":573,"context_line":"                       detail\u003ddetail,"},{"line_number":574,"context_line":"                       user_id\u003duser_id,"},{"line_number":575,"context_line":"                       project_id\u003dproject_id,"},{"line_number":576,"context_line":"                       on_behalf_of\u003dproject_id,"},{"line_number":577,"context_line":"                       timestamp\u003dtimeutils.utcnow(),"},{"line_number":578,"context_line":"                       severity\u003dalarm.severity)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        pecan.request.storage.delete_alarm(alarm.alarm_id)"},{"line_number":581,"context_line":"        _send_notification(type, payload)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    @wsme_pecan.wsexpose(Alarm)"},{"line_number":584,"context_line":"    def get(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_8cf67ef7","line":581,"range":{"start_line":563,"start_character":0,"end_line":581,"end_character":41},"in_reply_to":"fa6399be_35e1409b","updated":"2016-10-20 00:19:04.000000000","message":"This is reasonable but better to fix in a separate patch.\n\nThis implementation is consistent with existing functions such as _record_change() in L532-L561","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"135f8adfab6d9dc2029911a3fcddfea451e511dc","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        payload[\u0027detail\u0027] \u003d scrubbed_data"},{"line_number":561,"context_line":"        _send_notification(type, payload)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def _record_delete(self, alarm):"},{"line_number":564,"context_line":"        if not alarm:"},{"line_number":565,"context_line":"            return"},{"line_number":566,"context_line":"        type \u003d models.AlarmChange.DELETION"},{"line_number":567,"context_line":"        detail \u003d {\u0027state\u0027: alarm.state}"},{"line_number":568,"context_line":"        user_id \u003d pecan.request.headers.get(\u0027X-User-Id\u0027)"},{"line_number":569,"context_line":"        project_id \u003d pecan.request.headers.get(\u0027X-Project-Id\u0027)"},{"line_number":570,"context_line":"        payload \u003d dict(event_id\u003dstr(uuid.uuid4()),"},{"line_number":571,"context_line":"                       alarm_id\u003dself._id,"},{"line_number":572,"context_line":"                       type\u003dtype,"},{"line_number":573,"context_line":"                       detail\u003ddetail,"},{"line_number":574,"context_line":"                       user_id\u003duser_id,"},{"line_number":575,"context_line":"                       project_id\u003dproject_id,"},{"line_number":576,"context_line":"                       on_behalf_of\u003dproject_id,"},{"line_number":577,"context_line":"                       timestamp\u003dtimeutils.utcnow(),"},{"line_number":578,"context_line":"                       severity\u003dalarm.severity)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        pecan.request.storage.delete_alarm(alarm.alarm_id)"},{"line_number":581,"context_line":"        _send_notification(type, payload)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    @wsme_pecan.wsexpose(Alarm)"},{"line_number":584,"context_line":"    def get(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_6c9f6a03","line":581,"range":{"start_line":563,"start_character":0,"end_line":581,"end_character":41},"in_reply_to":"fa6399be_8cf67ef7","updated":"2016-10-20 01:07:53.000000000","message":"+1","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"}],"aodh/storage/models.py":[{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"c2125d750e041ccc54c51d043f005ed8e79b1420","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    CREATION \u003d \u0027creation\u0027"},{"line_number":116,"context_line":"    RULE_CHANGE \u003d \u0027rule change\u0027"},{"line_number":117,"context_line":"    STATE_TRANSITION \u003d \u0027state transition\u0027"},{"line_number":118,"context_line":"    DELETE \u003d \u0027deleted\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    SUPPORT_SORT_KEYS \u003d ("},{"line_number":121,"context_line":"        \u0027event_id\u0027, \u0027alarm_id\u0027, \u0027on_behalf_of\u0027, \u0027project_id\u0027, \u0027user_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_dc088130","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":10},"updated":"2016-10-18 08:45:43.000000000","message":"Other constants are all noun. Consider using \n\nDELETION \u003d \u0027deletion\u0027","commit_id":"8aa88b50da057f473d3d4256fa1a8908536348a4"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"e05a5464578641fe11165ccd5757096fae23ee9b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    CREATION \u003d \u0027creation\u0027"},{"line_number":116,"context_line":"    RULE_CHANGE \u003d \u0027rule change\u0027"},{"line_number":117,"context_line":"    STATE_TRANSITION \u003d \u0027state transition\u0027"},{"line_number":118,"context_line":"    DELETE \u003d \u0027deleted\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    SUPPORT_SORT_KEYS \u003d ("},{"line_number":121,"context_line":"        \u0027event_id\u0027, \u0027alarm_id\u0027, \u0027on_behalf_of\u0027, \u0027project_id\u0027, \u0027user_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_3f116fb0","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":10},"in_reply_to":"fa6399be_dc088130","updated":"2016-10-18 09:07:28.000000000","message":"Done","commit_id":"8aa88b50da057f473d3d4256fa1a8908536348a4"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"6213a99e1051a36ae8a10a4cb44a6c676b8929f5","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    CREATION \u003d \u0027creation\u0027"},{"line_number":116,"context_line":"    RULE_CHANGE \u003d \u0027rule change\u0027"},{"line_number":117,"context_line":"    STATE_TRANSITION \u003d \u0027state transition\u0027"},{"line_number":118,"context_line":"    DELETE \u003d \u0027deletion\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    SUPPORT_SORT_KEYS \u003d ("},{"line_number":121,"context_line":"        \u0027event_id\u0027, \u0027alarm_id\u0027, \u0027on_behalf_of\u0027, \u0027project_id\u0027, \u0027user_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_6aba43c2","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":10},"updated":"2016-10-18 09:14:03.000000000","message":"Please change also the constant name.","commit_id":"9df664197d5fd384846d388f4924c4a4dc7b009f"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"3c882fdf7748a7eb10db6ea472012ea426550ae8","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    CREATION \u003d \u0027creation\u0027"},{"line_number":116,"context_line":"    RULE_CHANGE \u003d \u0027rule change\u0027"},{"line_number":117,"context_line":"    STATE_TRANSITION \u003d \u0027state transition\u0027"},{"line_number":118,"context_line":"    DELETE \u003d \u0027deletion\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    SUPPORT_SORT_KEYS \u003d ("},{"line_number":121,"context_line":"        \u0027event_id\u0027, \u0027alarm_id\u0027, \u0027on_behalf_of\u0027, \u0027project_id\u0027, \u0027user_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_aaec5b90","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":10},"in_reply_to":"fa6399be_6aba43c2","updated":"2016-10-18 09:19:45.000000000","message":"Done","commit_id":"9df664197d5fd384846d388f4924c4a4dc7b009f"}],"aodh/tests/functional/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"c2125d750e041ccc54c51d043f005ed8e79b1420","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                      params\u003ddata,"},{"line_number":187,"context_line":"                      headers\u003dauth_headers or self.auth_headers)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _delete_alarm(self, alarm_id, auth_headers\u003dNone):"},{"line_number":190,"context_line":"        self.delete(\u0027/alarms/%s\u0027 % alarm_id,"},{"line_number":191,"context_line":"                    headers\u003dauth_headers or self.auth_headers,"},{"line_number":192,"context_line":"                    status\u003d204)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_5f51c30d","line":189,"range":{"start_line":189,"start_character":28,"end_line":189,"end_character":36},"updated":"2016-10-18 08:45:43.000000000","message":"- Suggest to rename to `id` to keep consistency with L182\n- Changing the function signature didn\u0027t break anything? I couldn\u0027t find the original test case covering it.","commit_id":"8aa88b50da057f473d3d4256fa1a8908536348a4"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"e05a5464578641fe11165ccd5757096fae23ee9b","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                      params\u003ddata,"},{"line_number":187,"context_line":"                      headers\u003dauth_headers or self.auth_headers)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _delete_alarm(self, alarm_id, auth_headers\u003dNone):"},{"line_number":190,"context_line":"        self.delete(\u0027/alarms/%s\u0027 % alarm_id,"},{"line_number":191,"context_line":"                    headers\u003dauth_headers or self.auth_headers,"},{"line_number":192,"context_line":"                    status\u003d204)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_df3b1337","line":189,"range":{"start_line":189,"start_character":28,"end_line":189,"end_character":36},"in_reply_to":"fa6399be_5f51c30d","updated":"2016-10-18 09:07:28.000000000","message":"OK, i\u0027ll fix it.\nIt is a test function and no others call it.","commit_id":"8aa88b50da057f473d3d4256fa1a8908536348a4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"41e99c8d59ad37fdc3011fb22c1843149f6d07c0","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"            get_notifier.assert_called_once_with(mock.ANY,"},{"line_number":1763,"context_line":"                                                 publisher_id\u003d\u0027aodh.api\u0027)"},{"line_number":1764,"context_line":"        calls \u003d notifier.info.call_args_list"},{"line_number":1765,"context_line":"        self.assertEqual(1, len(calls))"},{"line_number":1766,"context_line":"        args, _ \u003d calls[0]"},{"line_number":1767,"context_line":"        context, event_type, payload \u003d args"},{"line_number":1768,"context_line":"        self.assertEqual(\u0027alarm.deletion\u0027, event_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_1578bcf1","line":1765,"range":{"start_line":1765,"start_character":0,"end_line":1765,"end_character":39},"updated":"2016-10-19 19:07:31.000000000","message":"already verified by assert_called_once_with","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"135f8adfab6d9dc2029911a3fcddfea451e511dc","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"            get_notifier.assert_called_once_with(mock.ANY,"},{"line_number":1763,"context_line":"                                                 publisher_id\u003d\u0027aodh.api\u0027)"},{"line_number":1764,"context_line":"        calls \u003d notifier.info.call_args_list"},{"line_number":1765,"context_line":"        self.assertEqual(1, len(calls))"},{"line_number":1766,"context_line":"        args, _ \u003d calls[0]"},{"line_number":1767,"context_line":"        context, event_type, payload \u003d args"},{"line_number":1768,"context_line":"        self.assertEqual(\u0027alarm.deletion\u0027, event_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_ac6d0234","line":1765,"range":{"start_line":1765,"start_character":0,"end_line":1765,"end_character":39},"in_reply_to":"fa6399be_1578bcf1","updated":"2016-10-20 01:07:53.000000000","message":"Ok, delete it.","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"41e99c8d59ad37fdc3011fb22c1843149f6d07c0","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        context, event_type, payload \u003d args"},{"line_number":1768,"context_line":"        self.assertEqual(\u0027alarm.deletion\u0027, event_type)"},{"line_number":1769,"context_line":"        self.assertEqual(\u0027insufficient data\u0027, payload[\u0027detail\u0027][\u0027state\u0027])"},{"line_number":1770,"context_line":"        self.assertTrue(set([\u0027alarm_id\u0027, \u0027detail\u0027, \u0027event_id\u0027, \u0027on_behalf_of\u0027,"},{"line_number":1771,"context_line":"                             \u0027project_id\u0027, \u0027timestamp\u0027, \u0027type\u0027, \u0027severity\u0027,"},{"line_number":1772,"context_line":"                             \u0027user_id\u0027]).issubset(payload.keys()))"},{"line_number":1773,"context_line":""},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"class TestAlarmsLegacy(LegacyPolicyFileMixin, TestAlarms):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_7563b841","line":1772,"range":{"start_line":1770,"start_character":0,"end_line":1772,"end_character":66},"updated":"2016-10-19 19:07:31.000000000","message":"what is this suppose to prove?","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"eb8f7cd44efeadce0dbc0835045c722d4b5e6ef2","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        context, event_type, payload \u003d args"},{"line_number":1768,"context_line":"        self.assertEqual(\u0027alarm.deletion\u0027, event_type)"},{"line_number":1769,"context_line":"        self.assertEqual(\u0027insufficient data\u0027, payload[\u0027detail\u0027][\u0027state\u0027])"},{"line_number":1770,"context_line":"        self.assertTrue(set([\u0027alarm_id\u0027, \u0027detail\u0027, \u0027event_id\u0027, \u0027on_behalf_of\u0027,"},{"line_number":1771,"context_line":"                             \u0027project_id\u0027, \u0027timestamp\u0027, \u0027type\u0027, \u0027severity\u0027,"},{"line_number":1772,"context_line":"                             \u0027user_id\u0027]).issubset(payload.keys()))"},{"line_number":1773,"context_line":""},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"class TestAlarmsLegacy(LegacyPolicyFileMixin, TestAlarms):"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6895a0_ee08432b","line":1772,"range":{"start_line":1770,"start_character":0,"end_line":1772,"end_character":66},"in_reply_to":"fa6399be_6cd12acd","updated":"2016-10-20 21:42:50.000000000","message":"you just copy/paste and have no idea what it\u0027s suppose to do?","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"135f8adfab6d9dc2029911a3fcddfea451e511dc","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        context, event_type, payload \u003d args"},{"line_number":1768,"context_line":"        self.assertEqual(\u0027alarm.deletion\u0027, event_type)"},{"line_number":1769,"context_line":"        self.assertEqual(\u0027insufficient data\u0027, payload[\u0027detail\u0027][\u0027state\u0027])"},{"line_number":1770,"context_line":"        self.assertTrue(set([\u0027alarm_id\u0027, \u0027detail\u0027, \u0027event_id\u0027, \u0027on_behalf_of\u0027,"},{"line_number":1771,"context_line":"                             \u0027project_id\u0027, \u0027timestamp\u0027, \u0027type\u0027, \u0027severity\u0027,"},{"line_number":1772,"context_line":"                             \u0027user_id\u0027]).issubset(payload.keys()))"},{"line_number":1773,"context_line":""},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"class TestAlarmsLegacy(LegacyPolicyFileMixin, TestAlarms):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_6cd12acd","line":1772,"range":{"start_line":1770,"start_character":0,"end_line":1772,"end_character":66},"in_reply_to":"fa6399be_7563b841","updated":"2016-10-20 01:07:53.000000000","message":"It is consistent with the above test cases, see L1733 and L1754","commit_id":"dd5712e85922f37df86834ebb12e98b0033fea9d"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"f00881b2de2c797cae650cc904c0662b47bb4c07","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"            get_notifier.assert_called_once_with(mock.ANY,"},{"line_number":1763,"context_line":"                                                 publisher_id\u003d\u0027aodh.api\u0027)"},{"line_number":1764,"context_line":"        calls \u003d notifier.info.call_args_list"},{"line_number":1765,"context_line":"        self.assertEqual(1, len(calls))"},{"line_number":1766,"context_line":"        args, _ \u003d calls[0]"},{"line_number":1767,"context_line":"        context, event_type, payload \u003d args"},{"line_number":1768,"context_line":"        self.assertEqual(\u0027alarm.deletion\u0027, event_type)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_add979f5","line":1765,"updated":"2016-10-20 06:41:16.000000000","message":"This line should be reverted. Not the reason of check failure.","commit_id":"75cfb60fa2c004d4738af522f72ab1990ef8a436"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"1f2dd04aedca16107fa276bbfde43e81ea88ae2c","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"            get_notifier.assert_called_once_with(mock.ANY,"},{"line_number":1763,"context_line":"                                                 publisher_id\u003d\u0027aodh.api\u0027)"},{"line_number":1764,"context_line":"        calls \u003d notifier.info.call_args_list"},{"line_number":1765,"context_line":"        self.assertEqual(1, len(calls))"},{"line_number":1766,"context_line":"        args, _ \u003d calls[0]"},{"line_number":1767,"context_line":"        context, event_type, payload \u003d args"},{"line_number":1768,"context_line":"        self.assertEqual(\u0027alarm.deletion\u0027, event_type)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_9303f641","line":1765,"in_reply_to":"fa6399be_add979f5","updated":"2016-10-20 07:56:11.000000000","message":"Yes, it is not the reason of check failure, but this is verified for the length of calls, not the same as assert_called_once_with.","commit_id":"75cfb60fa2c004d4738af522f72ab1990ef8a436"}]}