)]}'
{"aodh/api/controllers/v2/alarm_rules/generic.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4e8b4106935e948c7af549e9a55a23d130b96114","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"Alarm metadata. Default is {}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, metadata\u003d{}):"},{"line_number":32,"context_line":"        metadata \u003d ast.literal_eval(metadata)"},{"line_number":33,"context_line":"        super(AlarmGenericRule, self).__init__(metadata\u003dmetadata)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_c42b0932","line":32,"updated":"2017-01-10 21:11:17.000000000","message":"is this just a normal dict as string? maybe just use json.loads. literal_eval is a much slower conversion.","commit_id":"0ede36615c3df1a4b1d7f00cccdeb2e06699948c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4e8b4106935e948c7af549e9a55a23d130b96114","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @property"},{"line_number":40,"context_line":"    def default_description(self):"},{"line_number":41,"context_line":"        return _(\u0027Generic alarm metadata is: %s\u0027) % self.metadata"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def as_dict(self):"},{"line_number":44,"context_line":"        rule \u003d dict()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_c4a069a8","line":41,"range":{"start_line":41,"start_character":52,"end_line":41,"end_character":65},"updated":"2017-01-10 21:11:17.000000000","message":"this isn\u0027t set anywhere.","commit_id":"0ede36615c3df1a4b1d7f00cccdeb2e06699948c"}],"aodh/evaluator/__init__.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8049291db9641e691d598a8ec00c9d40b78d1515","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return self.storage_conn"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @property"},{"line_number":82,"context_line":"    def _alarm_change_notifier(self):"},{"line_number":83,"context_line":"        if not self.alarm_change_notifier:"},{"line_number":84,"context_line":"            transport \u003d messaging.get_transport(self.conf)"},{"line_number":85,"context_line":"            self.alarm_change_notifier \u003d messaging.get_notifier("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_51728e7d","line":82,"updated":"2017-01-10 13:44:49.000000000","message":"that should probably be the other way around: the @property should not start with _ and the stored attribute should start with _\n\nAlso, I don\u0027t think this change is related to this patch, so while this change might be interesting as an optimization (I imagine), maybe it\u0027d be better to have a it in a different patch just before this one?","commit_id":"c485c748a5388e88f8e5294a2fdcc809c8ba0a1e"}],"aodh/tests/functional/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8049291db9641e691d598a8ec00c9d40b78d1515","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def setUp(self):"},{"line_number":145,"context_line":"        super(TestAlarmsBase, self).setUp()"},{"line_number":146,"context_line":"        self.auth_headers \u003d {\u0027X-User-Id\u0027: str(uuid.uuid4()),"},{"line_number":147,"context_line":"                             \u0027X-Project-Id\u0027: str(uuid.uuid4())}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_f12e2241","line":146,"updated":"2017-01-10 13:44:49.000000000","message":"looks like you had a problem rebasing :)","commit_id":"c485c748a5388e88f8e5294a2fdcc809c8ba0a1e"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8049291db9641e691d598a8ec00c9d40b78d1515","unresolved":false,"context_lines":[{"line_number":3095,"context_line":"                         set(r[\u0027generic_rule\u0027][\u0027metadata\u0027]"},{"line_number":3096,"context_line":"                             for r in data if \u0027generic_rule\u0027 in r))"},{"line_number":3097,"context_line":""},{"line_number":3098,"context_line":"    @unittest.skip(\"testing skipping\")"},{"line_number":3099,"context_line":"    def test_post_event_alarm_defaults(self):"},{"line_number":3100,"context_line":"        to_check \u003d {"},{"line_number":3101,"context_line":"            \u0027enabled\u0027: True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_51e7ee11","line":3098,"updated":"2017-01-10 13:44:49.000000000","message":"that\u0027s not a good idea :)","commit_id":"c485c748a5388e88f8e5294a2fdcc809c8ba0a1e"}]}