)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6b0cc4abe93d41e3c3d7c2f0d6f6b1ffa610f1d6","unresolved":false,"context_lines":[{"line_number":247,"context_line":"function install_aodh {"},{"line_number":248,"context_line":"    _aodh_prepare_coordination"},{"line_number":249,"context_line":"    install_aodhclient"},{"line_number":250,"context_line":"    setup_develop \"$AODH_DIR\" test,$AODH_BACKEND"},{"line_number":251,"context_line":"    sudo install -d -o $STACK_USER -m 755 $AODH_CONF_DIR"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    if [ \"$AODH_DEPLOY\" \u003d\u003d \"mod_wsgi\" ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba5201f7_37c6739a","line":250,"updated":"2017-01-05 16:59:32.000000000","message":"We don\u0027t want to apply any constraints from global-req.","commit_id":"d2649c0396f958e7af548da852fe2fe6075296cd"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"e44bfdfc57113d9982f28db5e517540b0fc492f4","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    install_aodhclient"},{"line_number":250,"context_line":"    if python3_enabled; then"},{"line_number":251,"context_line":"        PIP\u003d$(which pip 2\u003e/dev/null || which pip-python 2\u003e/dev/null)"},{"line_number":252,"context_line":"        sudo -H python${PYTHON3_VERSION} $PIP install -e \"$AODH_DIR\"[test,$AODH_BACKEND]"},{"line_number":253,"context_line":"    else"},{"line_number":254,"context_line":"        sudo -H pip install -e \"$AODH_DIR\"[test,$AODH_BACKEND]"},{"line_number":255,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba5201f7_4eae0182","line":252,"range":{"start_line":252,"start_character":16,"end_line":252,"end_character":53},"updated":"2017-01-05 18:44:29.000000000","message":"this looks a little confused to me:   The preferred practice for calling pip is as a module, so (for example):\n\n    python3.6 -m pip install -e ...\n\n\nI don\u0027t understand why \"which pip\" is in this...","commit_id":"ae1b17203f2683a2590c2295196c6014116784f8"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"e44bfdfc57113d9982f28db5e517540b0fc492f4","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        PIP\u003d$(which pip 2\u003e/dev/null || which pip-python 2\u003e/dev/null)"},{"line_number":252,"context_line":"        sudo -H python${PYTHON3_VERSION} $PIP install -e \"$AODH_DIR\"[test,$AODH_BACKEND]"},{"line_number":253,"context_line":"    else"},{"line_number":254,"context_line":"        sudo -H pip install -e \"$AODH_DIR\"[test,$AODH_BACKEND]"},{"line_number":255,"context_line":"    fi"},{"line_number":256,"context_line":"    sudo install -d -o $STACK_USER -m 755 $AODH_CONF_DIR"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba5201f7_eeedf5b7","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":62},"updated":"2017-01-05 18:44:29.000000000","message":"similarly, this should have the preferred python format of calling pip as a module, e.g.:\n\n    python2 -m pip install -e ...","commit_id":"ae1b17203f2683a2590c2295196c6014116784f8"}]}
