)]}'
{"aodh/evaluator/gnocchi.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"079f016e744c891f35aac86724dde0a099d3905f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                resource_id\u003drule[\u0027resource_id\u0027],"},{"line_number":65,"context_line":"                aggregation\u003drule[\u0027aggregation_method\u0027])"},{"line_number":66,"context_line":"        except Exception as e:"},{"line_number":67,"context_line":"            if not isinstance(e, exceptions.ClientException) or e.code \u003d\u003d 404:"},{"line_number":68,"context_line":"                LOG.warning(_LW(\u0027alarm stats retrieval failed: %s\u0027),"},{"line_number":69,"context_line":"                            e)"},{"line_number":70,"context_line":"            return []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_33867ddb","line":67,"updated":"2017-03-10 15:45:54.000000000","message":"what are these extra exception filtering for? it doesn\u0027t seem like you\u0027re raising anything new in your chagne?","commit_id":"f69d550db71cdb115eacc72352baf7aed8fd9a82"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"4d3f334a2690cd43f3102a6ea5b0ca5b174f249d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                resource_id\u003drule[\u0027resource_id\u0027],"},{"line_number":65,"context_line":"                aggregation\u003drule[\u0027aggregation_method\u0027])"},{"line_number":66,"context_line":"        except Exception as e:"},{"line_number":67,"context_line":"            if not isinstance(e, exceptions.ClientException) or e.code \u003d\u003d 404:"},{"line_number":68,"context_line":"                LOG.warning(_LW(\u0027alarm stats retrieval failed: %s\u0027),"},{"line_number":69,"context_line":"                            e)"},{"line_number":70,"context_line":"            return []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_7f88b771","line":67,"in_reply_to":"9a30ddce_33867ddb","updated":"2017-03-10 15:59:22.000000000","message":"get_measures returns 404 when resource_id or metric does not exists, I don\u0027t think we should log a warning for this, because that mean that the resource or the metric does not yet exists.\n\nI uploaded a clearer version of this.","commit_id":"f69d550db71cdb115eacc72352baf7aed8fd9a82"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b92f68be52f8568e8aa6a7a83c870a83fa084b9c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_log import log"},{"line_number":18,"context_line":"from oslo_serialization import jsonutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from gnocchiclient import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from aodh.evaluator import threshold"},{"line_number":23,"context_line":"from aodh.i18n import _LW"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_bf0eaf89","line":20,"updated":"2017-03-10 16:02:29.000000000","message":"should be grouped with above.","commit_id":"59514f9ef6677fe963103d4808f8ca0f1b737287"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f67a14c4bad914bfdc2de725ae6859427abd74fd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_log import log"},{"line_number":18,"context_line":"from oslo_serialization import jsonutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from gnocchiclient import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from aodh.evaluator import threshold"},{"line_number":23,"context_line":"from aodh.i18n import _LW"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_c2146c4e","line":20,"in_reply_to":"9a30ddce_bf0eaf89","updated":"2017-03-10 16:26:45.000000000","message":"Done","commit_id":"59514f9ef6677fe963103d4808f8ca0f1b737287"}]}