)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"5a180840daf6362c05edb4cb3f8c715ff797088f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix gnocchi alarm query update issue and tox.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) Aodh gnocchi alarm query should not be updated when the project condition"},{"line_number":10,"context_line":"has already be appended."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Bug: #1721452"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_540308b9","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":14},"updated":"2017-10-13 07:48:55.000000000","message":"been","commit_id":"215186cedc68f5aa7fc1847687c0b8931e0c37d9"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"c0869ddc2d08b2eb5210c251fddfce7bfee82111","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix gnocchi alarm query update issue and tox.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) Aodh gnocchi alarm query should not be updated when the project condition"},{"line_number":10,"context_line":"has already be appended."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Bug: #1721452"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_1238e4ec","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":14},"in_reply_to":"5f4e5783_540308b9","updated":"2017-10-17 23:38:59.000000000","message":"Done","commit_id":"215186cedc68f5aa7fc1847687c0b8931e0c37d9"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"5a180840daf6362c05edb4cb3f8c715ff797088f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1) Aodh gnocchi alarm query should not be updated when the project condition"},{"line_number":10,"context_line":"has already be appended."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Bug: #1721452"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"2) Add whitelist_externals in tox.ini"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_74460424","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":3},"updated":"2017-10-13 07:48:55.000000000","message":"Closes-Bug","commit_id":"215186cedc68f5aa7fc1847687c0b8931e0c37d9"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"c0869ddc2d08b2eb5210c251fddfce7bfee82111","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1) Aodh gnocchi alarm query should not be updated when the project condition"},{"line_number":10,"context_line":"has already be appended."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Bug: #1721452"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"2) Add whitelist_externals in tox.ini"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_f238a8ee","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":3},"in_reply_to":"5f4e5783_74460424","updated":"2017-10-17 23:38:59.000000000","message":"Done, thanks!","commit_id":"215186cedc68f5aa7fc1847687c0b8931e0c37d9"}],"aodh/api/controllers/v2/alarm_rules/gnocchi.py":[{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"5a180840daf6362c05edb4cb3f8c715ff797088f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                        {\"\u003d\": {\"project_id\": auth_project}}]}"},{"line_number":178,"context_line":"                ]}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            if (not query or not query.get(\"and\") or"},{"line_number":181,"context_line":"               perms_filter not in list(query.get(\"and\"))):"},{"line_number":182,"context_line":"                query \u003d {\"and\": [perms_filter, query]}"},{"line_number":183,"context_line":"            rule.query \u003d jsonutils.dumps(query)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_28ecacf1","line":181,"range":{"start_line":180,"start_character":0,"end_line":181,"end_character":59},"updated":"2017-10-13 07:48:55.000000000","message":"I think you can use \u0027and\u0027 logic like this:\n\n    if query and query.get(\"and\") and perms_filter in \n             list(query.get(\"and\")):","commit_id":"215186cedc68f5aa7fc1847687c0b8931e0c37d9"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"c0869ddc2d08b2eb5210c251fddfce7bfee82111","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                        {\"\u003d\": {\"project_id\": auth_project}}]}"},{"line_number":178,"context_line":"                ]}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            if (not query or not query.get(\"and\") or"},{"line_number":181,"context_line":"               perms_filter not in list(query.get(\"and\"))):"},{"line_number":182,"context_line":"                query \u003d {\"and\": [perms_filter, query]}"},{"line_number":183,"context_line":"            rule.query \u003d jsonutils.dumps(query)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_3233e016","line":181,"range":{"start_line":180,"start_character":0,"end_line":181,"end_character":59},"in_reply_to":"5f4e5783_28ecacf1","updated":"2017-10-17 23:38:59.000000000","message":"Comparing to use \"and\" logic and put \"not\" in front of them, I do think this way here is clearer.","commit_id":"215186cedc68f5aa7fc1847687c0b8931e0c37d9"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"85d6930e0b343b0309ac1ebf6b651d5930ddadcc","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                        {\"\u003d\": {\"project_id\": auth_project}}]}"},{"line_number":178,"context_line":"                ]}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            if (not query or not query.get(\"and\") or"},{"line_number":181,"context_line":"               perms_filter not in list(query.get(\"and\"))):"},{"line_number":182,"context_line":"                query \u003d {\"and\": [perms_filter, query]}"},{"line_number":183,"context_line":"            rule.query \u003d jsonutils.dumps(query)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_360142b0","line":181,"range":{"start_line":180,"start_character":0,"end_line":181,"end_character":59},"in_reply_to":"5f4e5783_3233e016","updated":"2017-10-18 02:49:55.000000000","message":"sure, it just simplifies the format.\nBoth are ok :)","commit_id":"215186cedc68f5aa7fc1847687c0b8931e0c37d9"}],"tox.ini":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ba3f4fd47e327ed76c9538ff454882f1dec4efd7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"   {toxinidir}/run-tests.sh {posargs}"},{"line_number":21,"context_line":"   {toxinidir}/run-functional-tests.sh \"{posargs}\""},{"line_number":22,"context_line":"   aodh-config-generator"},{"line_number":23,"context_line":"whitelist_externals \u003d bash"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[testenv:cover]"},{"line_number":26,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5f4e5783_ab7096dd","line":23,"updated":"2017-10-13 08:26:58.000000000","message":"that needs a different patch","commit_id":"215186cedc68f5aa7fc1847687c0b8931e0c37d9"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"c0869ddc2d08b2eb5210c251fddfce7bfee82111","unresolved":false,"context_lines":[{"line_number":20,"context_line":"   {toxinidir}/run-tests.sh {posargs}"},{"line_number":21,"context_line":"   {toxinidir}/run-functional-tests.sh \"{posargs}\""},{"line_number":22,"context_line":"   aodh-config-generator"},{"line_number":23,"context_line":"whitelist_externals \u003d bash"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[testenv:cover]"},{"line_number":26,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5f4e5783_b226b0cd","line":23,"in_reply_to":"5f4e5783_ab7096dd","updated":"2017-10-17 23:38:59.000000000","message":"Thanks. I will submit a separate patch","commit_id":"215186cedc68f5aa7fc1847687c0b8931e0c37d9"}]}
