)]}'
{".gitignore":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"29e203a2a04dca6a850c464fb4d82c16d14f3e6d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"*.egg*"},{"line_number":2,"context_line":".idea"},{"line_number":3,"context_line":".vscode"},{"line_number":4,"context_line":"*.mo"},{"line_number":5,"context_line":"*.pyc"},{"line_number":6,"context_line":"*~"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f4b6375_5425d807","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":7},"updated":"2017-10-26 17:01:28.000000000","message":"These seem  unrelated?","commit_id":"5ffa9e3d15af1eb4ba2418aba6e0ccd898c34779"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cb858f45881da0119364d9db23e0ebe99b5224ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"*.egg*"},{"line_number":2,"context_line":".idea"},{"line_number":3,"context_line":".vscode"},{"line_number":4,"context_line":"*.mo"},{"line_number":5,"context_line":"*.pyc"},{"line_number":6,"context_line":"*~"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f4b6375_1a1549e5","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":7},"in_reply_to":"3f4b6375_5425d807","updated":"2017-10-26 18:09:27.000000000","message":"yeah, seems ide related. let\u0027s remove.","commit_id":"5ffa9e3d15af1eb4ba2418aba6e0ccd898c34779"}],"/COMMIT_MSG":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"e228a61191eac75137d4a24cd24fe9cf3f913761","unresolved":false,"context_lines":[{"line_number":21,"context_line":"update rules, they should define them in policy file like the way"},{"line_number":22,"context_line":"we done with config option with oslo.config."},{"line_number":23,"context_line":"- And also similar with oslo.config, we will support generating sample"},{"line_number":24,"context_line":"policy file (YAML fomart) for now."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Summary, with any rules that we defined in codebase, we no need to keep"},{"line_number":27,"context_line":"them in policy file anymore if we don\u0027t want to customize them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f4b6375_40b06f43","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":24},"updated":"2017-11-07 10:30:42.000000000","message":"format","commit_id":"1f1f46d194ee329fec24e612deb12a4716e346e0"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"33c6d2734aa93ceddbfb5108cc8b41e42008723f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"update rules, they should define them in policy file like the way"},{"line_number":22,"context_line":"we done with config option with oslo.config."},{"line_number":23,"context_line":"- And also similar with oslo.config, we will support generating sample"},{"line_number":24,"context_line":"policy file (YAML fomart) for now."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Summary, with any rules that we defined in codebase, we no need to keep"},{"line_number":27,"context_line":"them in policy file anymore if we don\u0027t want to customize them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f4b6375_80af877b","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":24},"in_reply_to":"3f4b6375_40b06f43","updated":"2017-11-07 10:43:27.000000000","message":"OK.","commit_id":"1f1f46d194ee329fec24e612deb12a4716e346e0"}],"aodh/api/policy.json":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3523e2bc62e2fc83cfc590ca13cd046012b0a95d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"context_is_admin\": \"role:admin\","},{"line_number":3,"context_line":"    \"segregation\": \"rule:context_is_admin\","},{"line_number":4,"context_line":"    \"admin_or_owner\": \"rule:context_is_admin or project_id:%(project_id)s\","},{"line_number":5,"context_line":"    \"default\": \"rule:admin_or_owner\","},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    \"telemetry:get_alarm\": \"rule:admin_or_owner\","},{"line_number":8,"context_line":"    \"telemetry:get_alarms\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":7,"id":"3f4b6375_5d573802","side":"PARENT","line":5,"updated":"2017-11-07 09:29:58.000000000","message":"you remove rules that are being used\n\nthe commit message does not even explain why or how this is gonna work now","commit_id":"37ddc6569ee0085720bbb308fafc3e7e9a0930b2"}],"aodh/cmd/aodh-policy-generator.conf":[{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"f0985dd78f3aec10fa10b1cf4c6ba883a148056e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"namespace \u003d aodh"}],"source_content_type":"text/plain","patch_set":9,"id":"3f4b6375_3bab64d6","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":16},"updated":"2017-11-07 11:09:43.000000000","message":"I still keep this file and and entrypoint to make an aodh-policy-generator in a follow up patchset later.","commit_id":"c150d00dee41c780888e00e6bdc225226b503cb5"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7e555d0a350efc2973f14fab8177470898f29ae5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"namespace \u003d aodh"}],"source_content_type":"text/plain","patch_set":9,"id":"3f4b6375_7b28bc31","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":16},"in_reply_to":"3f4b6375_3bab64d6","updated":"2017-11-07 11:23:24.000000000","message":"sure","commit_id":"c150d00dee41c780888e00e6bdc225226b503cb5"}],"tools/aodh-policy-generator.conf":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"e228a61191eac75137d4a24cd24fe9cf3f913761","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"output_file \u003d aodh/api/policy.yaml.sample"},{"line_number":3,"context_line":"namespace \u003d aodh"}],"source_content_type":"text/plain","patch_set":8,"id":"3f4b6375_80f0a7fe","line":2,"updated":"2017-11-07 10:30:42.000000000","message":"this seems like a bad thing to output sample in the middle of the code base","commit_id":"1f1f46d194ee329fec24e612deb12a4716e346e0"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"33c6d2734aa93ceddbfb5108cc8b41e42008723f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"output_file \u003d aodh/api/policy.yaml.sample"},{"line_number":3,"context_line":"namespace \u003d aodh"}],"source_content_type":"text/plain","patch_set":8,"id":"3f4b6375_c0b9ffcb","line":2,"in_reply_to":"3f4b6375_80f0a7fe","updated":"2017-11-07 10:43:27.000000000","message":"OK.","commit_id":"1f1f46d194ee329fec24e612deb12a4716e346e0"}],"tox.ini":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"e228a61191eac75137d4a24cd24fe9cf3f913761","unresolved":false,"context_lines":[{"line_number":23,"context_line":"whitelist_externals \u003d bash"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[testenv:genpolicy]"},{"line_number":26,"context_line":"commands \u003d oslopolicy-sample-generator --config-file tools/aodh-policy-generator.conf"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[testenv:cover]"},{"line_number":29,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":8,"id":"3f4b6375_2094538a","line":26,"updated":"2017-11-07 10:30:42.000000000","message":"i don\u0027t think we really need that","commit_id":"1f1f46d194ee329fec24e612deb12a4716e346e0"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"bd9e141c823c979bdf069bb104f47791546fce6d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"whitelist_externals \u003d bash"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[testenv:genpolicy]"},{"line_number":26,"context_line":"commands \u003d oslopolicy-sample-generator --config-file tools/aodh-policy-generator.conf"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[testenv:cover]"},{"line_number":29,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":8,"id":"3f4b6375_600ecb8c","line":26,"in_reply_to":"3f4b6375_00aa776f","updated":"2017-11-07 10:50:10.000000000","message":"doing an aodh-policy-generator would be a great idea I think, but it can be done later.\n\nI just don\u0027t think this tox target is useful at all. you should remove it.","commit_id":"1f1f46d194ee329fec24e612deb12a4716e346e0"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"33c6d2734aa93ceddbfb5108cc8b41e42008723f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"whitelist_externals \u003d bash"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[testenv:genpolicy]"},{"line_number":26,"context_line":"commands \u003d oslopolicy-sample-generator --config-file tools/aodh-policy-generator.conf"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[testenv:cover]"},{"line_number":29,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":8,"id":"3f4b6375_00aa776f","line":26,"in_reply_to":"3f4b6375_2094538a","updated":"2017-11-07 10:43:27.000000000","message":"Sorry, I didn\u0027t get your point? You mean we need to define something like this [1] or pre-generate and just keep an sample file in source code?\n\n[1] https://github.com/openstack/aodh/blob/master/setup.cfg#L111","commit_id":"1f1f46d194ee329fec24e612deb12a4716e346e0"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"e8e3891309f48340b215ce75749a8ae3b1c0130a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"whitelist_externals \u003d bash"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[testenv:genpolicy]"},{"line_number":26,"context_line":"commands \u003d oslopolicy-sample-generator --config-file tools/aodh-policy-generator.conf"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[testenv:cover]"},{"line_number":29,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":8,"id":"3f4b6375_9b06d81b","line":26,"in_reply_to":"3f4b6375_600ecb8c","updated":"2017-11-07 11:00:40.000000000","message":"Ok, gotchat, thanks!","commit_id":"1f1f46d194ee329fec24e612deb12a4716e346e0"}]}