)]}'
{"aodh/keystone_client.py":[{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"078e629326a214b406184214eb42387ce1c42bb4","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    endpoint \u003d sess.get_endpoint("},{"line_number":102,"context_line":"        service_type\u003d\u0027orchestration\u0027,"},{"line_number":103,"context_line":"        interface\u003d\"internal\","},{"line_number":104,"context_line":"        region_name\u003dconf.service_credentials.region_name"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_f1166149","line":103,"range":{"start_line":103,"start_character":19,"end_line":103,"end_character":27},"updated":"2019-05-15 01:26:14.000000000","message":"can we also get this from conf.service_credentials like region_name","commit_id":"d93e4e4b291f4f1a8dbe86b7f8bf5a7b0563ba83"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"e9415c2ef6b3058fc924582968d635bc51258d17","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    endpoint \u003d sess.get_endpoint("},{"line_number":102,"context_line":"        service_type\u003d\u0027orchestration\u0027,"},{"line_number":103,"context_line":"        interface\u003d\"internal\","},{"line_number":104,"context_line":"        region_name\u003dconf.service_credentials.region_name"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_075c12eb","line":103,"range":{"start_line":103,"start_character":19,"end_line":103,"end_character":27},"in_reply_to":"dfbec78f_918b651d","updated":"2019-05-15 08:05:18.000000000","message":"I still think we should add a config for this, if you feel service_credentials is not property. but if your guys think this is OK. I am OK too...\nhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L203\nhttps://github.com/openstack/heat/blob/master/heat/engine/clients/os/nova.py#L90","commit_id":"d93e4e4b291f4f1a8dbe86b7f8bf5a7b0563ba83"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"0aa5fbb1ac283d972674957dba50f8eb5c15fb84","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    endpoint \u003d sess.get_endpoint("},{"line_number":102,"context_line":"        service_type\u003d\u0027orchestration\u0027,"},{"line_number":103,"context_line":"        interface\u003d\"internal\","},{"line_number":104,"context_line":"        region_name\u003dconf.service_credentials.region_name"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_918b651d","line":103,"range":{"start_line":103,"start_character":19,"end_line":103,"end_character":27},"in_reply_to":"dfbec78f_f1166149","updated":"2019-05-15 01:50:38.000000000","message":"The `interface` option in `service_credentials`  is mainly for Identity service according to the option description. `internal` type is designed for services talking to each other internally inside the cloud.","commit_id":"d93e4e4b291f4f1a8dbe86b7f8bf5a7b0563ba83"}],"aodh/notifier/heat.py":[{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"078e629326a214b406184214eb42387ce1c42bb4","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    )"},{"line_number":111,"context_line":"            except Exception as e:"},{"line_number":112,"context_line":"                LOG.exception(\"Failed to communicate with Heat service, \""},{"line_number":113,"context_line":"                              \"error: %s\", str(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_116bf5b6","line":113,"range":{"start_line":113,"start_character":43,"end_line":113,"end_character":46},"updated":"2019-05-15 01:26:14.000000000","message":"also, here pls use six.text_type(e)","commit_id":"d93e4e4b291f4f1a8dbe86b7f8bf5a7b0563ba83"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"0aa5fbb1ac283d972674957dba50f8eb5c15fb84","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    )"},{"line_number":111,"context_line":"            except Exception as e:"},{"line_number":112,"context_line":"                LOG.exception(\"Failed to communicate with Heat service, \""},{"line_number":113,"context_line":"                              \"error: %s\", str(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_f1718145","line":113,"range":{"start_line":113,"start_character":43,"end_line":113,"end_character":46},"in_reply_to":"dfbec78f_116bf5b6","updated":"2019-05-15 01:50:38.000000000","message":"Done","commit_id":"d93e4e4b291f4f1a8dbe86b7f8bf5a7b0563ba83"}],"requirements.txt":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"2681e3400c83fe69fcd7d4056f8890ba69c1cd12","unresolved":false,"context_lines":[{"line_number":37,"context_line":"debtcollector\u003e\u003d1.2.0  # Apache-2.0"},{"line_number":38,"context_line":"python-octaviaclient\u003e\u003d1.8.0"},{"line_number":39,"context_line":"python-dateutil  # BSD"},{"line_number":40,"context_line":"python-heatclient\u003e\u003d1.17.0"}],"source_content_type":"text/plain","patch_set":4,"id":"dfbec78f_47be8ab4","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":25},"updated":"2019-05-15 08:24:55.000000000","message":"Since this is the latest released version of python-heatclient at this point, I would suggest adding some notes (in the release notes?) or employ a lower-constraints check.","commit_id":"08d0dd4731016d09a64cd34d4d717e3c39c91f7c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"06c7cec8dc5d2bcec89938abff7019563f896d35","unresolved":false,"context_lines":[{"line_number":37,"context_line":"debtcollector\u003e\u003d1.2.0  # Apache-2.0"},{"line_number":38,"context_line":"python-octaviaclient\u003e\u003d1.8.0"},{"line_number":39,"context_line":"python-dateutil  # BSD"},{"line_number":40,"context_line":"python-heatclient\u003e\u003d1.17.0"}],"source_content_type":"text/plain","patch_set":4,"id":"dfbec78f_b53e90be","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":25},"in_reply_to":"dfbec78f_47be8ab4","updated":"2019-05-15 09:26:06.000000000","message":"Because it\u0027s the first time to introduce the lib here and we are on aodh master branch, so it\u0027s reasonable to choose the latest release version (I assume it\u0027s always the good practice to install openstack services in separate virtual env or inside container). I don\u0027t mind mentioning that in release note but it\u0027s a little bit weird.","commit_id":"08d0dd4731016d09a64cd34d4d717e3c39c91f7c"}]}