)]}'
{"aodh/cmd/storage.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9b0f5f9e33ef5d91f10835a9a2ad0cc635c1cd79","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    deleted \u003d conn.clear_expired_alarm_history_data("},{"line_number":47,"context_line":"                        conf.database.alarm_history_time_to_live,"},{"line_number":48,"context_line":"                        max_count)"},{"line_number":49,"context_line":"        except TypeError:"},{"line_number":50,"context_line":"            LOG.warning(\"Storage driver does not support \""},{"line_number":51,"context_line":"                        \"\u0027alarm_delete_batch_size\u0027 config option.\")"},{"line_number":52,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1dd21cfe","line":49,"range":{"start_line":49,"start_character":15,"end_line":49,"end_character":24},"updated":"2020-10-05 00:56:31.000000000","message":"Where does this TypeError come from?","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8e2d8ebb3f2f9948b0112ded14bf498a4a288ef","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    deleted \u003d conn.clear_expired_alarm_history_data("},{"line_number":47,"context_line":"                        conf.database.alarm_history_time_to_live,"},{"line_number":48,"context_line":"                        max_count)"},{"line_number":49,"context_line":"        except TypeError:"},{"line_number":50,"context_line":"            LOG.warning(\"Storage driver does not support \""},{"line_number":51,"context_line":"                        \"\u0027alarm_delete_batch_size\u0027 config option.\")"},{"line_number":52,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5d613438","line":49,"range":{"start_line":49,"start_character":15,"end_line":49,"end_character":24},"in_reply_to":"9f560f44_1dd21cfe","updated":"2020-10-05 01:48:18.000000000","message":"This implementation is based on the one in Panko, and I guess it assumes that somebody can use 3rd party storage backend implementation which is not yet implement max_count.\n\nI don\u0027t think this TypeError can happen within current aodh codes so we can remove it, if it sounds better.","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9b0f5f9e33ef5d91f10835a9a2ad0cc635c1cd79","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        max_count)"},{"line_number":49,"context_line":"        except TypeError:"},{"line_number":50,"context_line":"            LOG.warning(\"Storage driver does not support \""},{"line_number":51,"context_line":"                        \"\u0027alarm_delete_batch_size\u0027 config option.\")"},{"line_number":52,"context_line":"    else:"},{"line_number":53,"context_line":"        LOG.info(\"Nothing to clean, database alarm history time to live \""},{"line_number":54,"context_line":"                 \"is disabled\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5d05b478","line":51,"range":{"start_line":51,"start_character":26,"end_line":51,"end_character":49},"updated":"2020-10-05 00:56:31.000000000","message":"alarm_history_delete_batch_size","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8e2d8ebb3f2f9948b0112ded14bf498a4a288ef","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        max_count)"},{"line_number":49,"context_line":"        except TypeError:"},{"line_number":50,"context_line":"            LOG.warning(\"Storage driver does not support \""},{"line_number":51,"context_line":"                        \"\u0027alarm_delete_batch_size\u0027 config option.\")"},{"line_number":52,"context_line":"    else:"},{"line_number":53,"context_line":"        LOG.info(\"Nothing to clean, database alarm history time to live \""},{"line_number":54,"context_line":"                 \"is disabled\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fd680823","line":51,"range":{"start_line":51,"start_character":26,"end_line":51,"end_character":49},"in_reply_to":"9f560f44_5d05b478","updated":"2020-10-05 01:48:18.000000000","message":"Done. Updated the parameter name to alarm_histories_delete_batch_size to follow the existing one in panko.","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"}],"aodh/storage/__init__.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9b0f5f9e33ef5d91f10835a9a2ad0cc635c1cd79","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               default\u003d0,"},{"line_number":39,"context_line":"               min\u003d0,"},{"line_number":40,"context_line":"               help\u003d(\"Number of alarm histories to be deleted in one \""},{"line_number":41,"context_line":"                     \"iteration from the database for (0 means all).\")),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bde330d8","line":41,"range":{"start_line":41,"start_character":32,"end_line":41,"end_character":53},"updated":"2020-10-05 00:56:31.000000000","message":"from the database","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8e2d8ebb3f2f9948b0112ded14bf498a4a288ef","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               default\u003d0,"},{"line_number":39,"context_line":"               min\u003d0,"},{"line_number":40,"context_line":"               help\u003d(\"Number of alarm histories to be deleted in one \""},{"line_number":41,"context_line":"                     \"iteration from the database for (0 means all).\")),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bd58508a","line":41,"range":{"start_line":41,"start_character":32,"end_line":41,"end_character":53},"in_reply_to":"9f560f44_bde330d8","updated":"2020-10-05 01:48:18.000000000","message":"done","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"}],"releasenotes/notes/support-batch-delete-events-32496f15b1169887.yaml":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9b0f5f9e33ef5d91f10835a9a2ad0cc635c1cd79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``events_delete_bacth_size`` option has been added to limit a number"},{"line_number":5,"context_line":"    of alarm histories deleted from the database in one single interation. This"},{"line_number":6,"context_line":"    parameter is useful when there\u0027re a lot of alarm history in the database."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_7db4f8d4","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":36},"updated":"2020-10-05 00:56:31.000000000","message":"alarm_history_delete_batch_size","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8e2d8ebb3f2f9948b0112ded14bf498a4a288ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``events_delete_bacth_size`` option has been added to limit a number"},{"line_number":5,"context_line":"    of alarm histories deleted from the database in one single interation. This"},{"line_number":6,"context_line":"    parameter is useful when there\u0027re a lot of alarm history in the database."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_9d5bcc84","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":36},"in_reply_to":"9f560f44_7db4f8d4","updated":"2020-10-05 01:48:18.000000000","message":"Done. and renamed alarm_history to alarm_histories.","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9b0f5f9e33ef5d91f10835a9a2ad0cc635c1cd79","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``events_delete_bacth_size`` option has been added to limit a number"},{"line_number":5,"context_line":"    of alarm histories deleted from the database in one single interation. This"},{"line_number":6,"context_line":"    parameter is useful when there\u0027re a lot of alarm history in the database."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_ddc26435","line":5,"updated":"2020-10-05 00:56:31.000000000","message":"Please also mention aodh-expirer service explicitly","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8e2d8ebb3f2f9948b0112ded14bf498a4a288ef","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``events_delete_bacth_size`` option has been added to limit a number"},{"line_number":5,"context_line":"    of alarm histories deleted from the database in one single interation. This"},{"line_number":6,"context_line":"    parameter is useful when there\u0027re a lot of alarm history in the database."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_dd4c24cb","line":5,"in_reply_to":"9f560f44_ddc26435","updated":"2020-10-05 01:48:18.000000000","message":"Done","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9b0f5f9e33ef5d91f10835a9a2ad0cc635c1cd79","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``events_delete_bacth_size`` option has been added to limit a number"},{"line_number":5,"context_line":"    of alarm histories deleted from the database in one single interation. This"},{"line_number":6,"context_line":"    parameter is useful when there\u0027re a lot of alarm history in the database."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_3dc28035","line":6,"range":{"start_line":6,"start_character":53,"end_line":6,"end_character":60},"updated":"2020-10-05 00:56:31.000000000","message":"histories","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8e2d8ebb3f2f9948b0112ded14bf498a4a288ef","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``events_delete_bacth_size`` option has been added to limit a number"},{"line_number":5,"context_line":"    of alarm histories deleted from the database in one single interation. This"},{"line_number":6,"context_line":"    parameter is useful when there\u0027re a lot of alarm history in the database."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_fd512865","line":6,"range":{"start_line":6,"start_character":53,"end_line":6,"end_character":60},"in_reply_to":"9f560f44_3dc28035","updated":"2020-10-05 01:48:18.000000000","message":"Done","commit_id":"0d2e6c5b47d837531d41c39c6d0b82c4ab0916c4"}]}