)]}'
{"id":"openstack%2Faodh~786880","triplet_id":"openstack%2Faodh~master~I60fb1dc75ed511c82602ddc6c70d9db370374daa","project":"openstack/aodh","branch":"master","topic":"bug/38895","hashtags":[],"change_id":"I60fb1dc75ed511c82602ddc6c70d9db370374daa","subject":"Allows calculation of cpu metric values as percentages.","status":"ABANDONED","created":"2021-04-19 14:06:04.000000000","updated":"2022-02-21 10:04:08.000000000","total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"c771bb5a51b5aa499eacc17124611ccd59512d44","_number":786880,"virtual_id_number":786880,"owner":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-04-28 13:57:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2021-04-29 15:07:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2021-04-28 15:16:05.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"}],"CC":[{"_account_id":11242,"name":"Erol Ozcan","email":"erol.ozcan@gmail.com","username":"erol.ozcan"},{"_account_id":33389,"name":"Caner Türkaslan","display_name":"Caner Türkaslan","email":"canerturkaslan1998@gmail.com","username":"canerturkaslan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-19 14:10:54.000000000","updated_by":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2021-04-19 15:06:24.000000000","updated_by":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-19 18:20:01.000000000","updated_by":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"reviewer":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"state":"REVIEWER"},{"updated":"2021-04-20 14:09:06.000000000","updated_by":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"reviewer":{"_account_id":33389,"name":"Caner Türkaslan","display_name":"Caner Türkaslan","email":"canerturkaslan1998@gmail.com","username":"canerturkaslan"},"state":"CC"},{"updated":"2021-04-22 13:37:30.000000000","updated_by":{"_account_id":11242,"name":"Erol Ozcan","email":"erol.ozcan@gmail.com","username":"erol.ozcan"},"reviewer":{"_account_id":11242,"name":"Erol Ozcan","email":"erol.ozcan@gmail.com","username":"erol.ozcan"},"state":"CC"},{"updated":"2021-04-28 15:16:05.000000000","updated_by":{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"},"reviewer":{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"},"state":"REVIEWER"}],"messages":[{"id":"95ac30b0d3e4bf76ffa6ec3bdae46572e03abc28","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"date":"2021-04-19 14:06:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0eaf3bd43d53d59b1aa8d3a2f160f1ccbbf7e899","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-19 15:08:15.000000000","message":"Patch Set 1: Verified-1\n\n(30 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8a930d23be51418e80881257bd434a4f : FAILURE in 5m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bab73383b9dd428994d224f74b2a20e8 : FAILURE in 5m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ceb6e375056947b7b6ae856f2af4f4b8 : FAILURE in 5m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/27a61e31c60a45da8207aa5883ad5779 : FAILURE in 6m 42s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b881866445054e069b80d528e15a168e : SUCCESS in 11m 17s\n- aodh-tempest-plugin-mysql https://zuul.opendev.org/t/openstack/build/38dccee4df8647668ce5dbe1438ca7ce : SUCCESS in 42m 26s\n- aodh-tempest-plugin-postgresql https://zuul.opendev.org/t/openstack/build/cf408099831e4f16953d1fbc4216e4f2 : SUCCESS in 37m 35s\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/5b5cba88b2c34026bb7aad9ba650e37f : FAILURE in 1h 00m 39s\n- telemetry-dsvm-integration-ipv6-only https://zuul.opendev.org/t/openstack/build/4bf817a833e44ed2b12c114fcb2da194 : FAILURE in 49m 58s","accounts_in_message":[],"_revision_number":1},{"id":"277543cc4c68d8afa4e8aec2f56e50817fc3f60c","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-04-19 18:20:01.000000000","message":"Patch Set 1: Code-Review-1\n\nThank you for your patch!\n\nThere are a few tests failing here, which are mostly cosmetic.\nYou also re-introduced the use of six, which can be avoided. Since we moved completely to use python3, there is no need for six anymore.","accounts_in_message":[],"_revision_number":1},{"id":"fd1f6fbdfd24c2c28a9371149f07b669905e1e1c","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-04-20 08:04:53.000000000","message":"Patch Set 1:\n\nthe way you\u0027d work on this change here is to check it out, do the necessary changes and do a git commit --amend \u0026\u0026 git review\n\nThat way all the changes stick together.","accounts_in_message":[],"_revision_number":1},{"id":"60acc01ae40674f368a908e0e3e228f7a43b204a","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-04-20 08:07:59.000000000","message":"Patch Set 1:\n\nYou probably saw https://www.openstack.org/blog/submit-your-first-openstack-patch-in-three-steps/ ?","accounts_in_message":[],"_revision_number":1},{"id":"29dd40535c471a1df20b170b93a586664165202e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"date":"2021-04-20 08:38:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0ad0f0084f30428296c20d668484e4b0f53bef6b","author":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"date":"2021-04-20 08:46:54.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 1:\n\u003e \n\u003e You probably saw https://www.openstack.org/blog/submit-your-first-openstack-patch-in-three-steps/ ?\n\nSorry for duplicates .My first commit to openstack comminity so I am a newbee . I formatted the code with pep8 and removed six library grom threshold.py . I hope it is ok for you. \n\nThis codes helps to trasform cpu data to a human readable form . So a heat stack developer may easily inject percents rather then huge numbers.","accounts_in_message":[],"_revision_number":2},{"id":"568767d09b17a67ff20ecc18b61ab4a66c63aa4f","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-04-20 09:01:13.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e You probably saw https://www.openstack.org/blog/submit-your-first-openstack-patch-in-three-steps/ ?\n\u003e \n\u003e Sorry for duplicates .My first commit to openstack comminity so I am a newbee . I formatted the code with pep8 and removed six library grom threshold.py . I hope it is ok for you. \n\u003e \n\u003e This codes helps to trasform cpu data to a human readable form . So a heat stack developer may easily inject percents rather then huge numbers.\n\n\nThank you, this is really much appreciated. I\u0027ll have a look at this later on.\n\nTo make such a change perfect, you\u0027d clean up the commented out debug log and you\u0027d also add a test.","accounts_in_message":[],"_revision_number":2},{"id":"121adebacb7b35073aa17227a0cb9985c505bb1e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-20 09:45:14.000000000","message":"Patch Set 2: Verified-1\n\n(2 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/aa3a02634d4f4cc3ada4b03502ae7b4a : FAILURE in 4m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/904762c2354e4191ab5ca36dabed8183 : FAILURE in 5m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7e19fbbc004148ccbcf85f9a0cd09959 : FAILURE in 9m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7b0b44b6cc7141388cad1c5875b483d4 : FAILURE in 6m 14s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ced11bdd4a144b6ea262c94adb3eaa26 : SUCCESS in 8m 13s\n- aodh-tempest-plugin-mysql https://zuul.opendev.org/t/openstack/build/38a566ec6672490b83db6ef37405f402 : SUCCESS in 44m 52s\n- aodh-tempest-plugin-postgresql https://zuul.opendev.org/t/openstack/build/2f524cc1954e40f5828abcb60d31130a : SUCCESS in 43m 19s\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/9e63eec08c8346569971694bf31489ba : FAILURE in 59m 47s\n- telemetry-dsvm-integration-ipv6-only https://zuul.opendev.org/t/openstack/build/41719e1a5ef34d21b70e034b8dbf6c6f : FAILURE in 56m 58s","accounts_in_message":[],"_revision_number":2},{"id":"dacb41c139ace0c38a6b83b26fcb434b624ea1b4","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-04-20 12:40:14.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nThank you, this is a good progress.","accounts_in_message":[],"_revision_number":2},{"id":"3db39cfa7120a0e3b241c9df7e54869c587262ea","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"date":"2021-04-20 13:50:16.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"fa4aef287e9bcf14165a51b30e3c30a47f57595c","author":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"date":"2021-04-20 14:09:06.000000000","message":"Patch Set 3:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e (2 comments)\n\u003e \n\u003e Thank you, this is a good progress.","accounts_in_message":[],"_revision_number":3},{"id":"a6e466b38dc1ea5d5e774a345eb836a54edf4494","author":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"date":"2021-04-20 14:10:13.000000000","message":"Patch Set 3:\n\n\u003e Patch Set 3:\n\u003e \n\u003e \u003e Patch Set 2: Code-Review-1\n\u003e \u003e \n\u003e \u003e (2 comments)\n\u003e \u003e \n\u003e \u003e Thank you, this is a good progress.\n\nI have updated code according to your comments and released Patchset-3","accounts_in_message":[],"_revision_number":3},{"id":"d23866519f3b1c50a5fc844edf55aa6b919765be","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-20 14:59:20.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b094108e9efc419c8796b286f6cf363a : SUCCESS in 5m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/92ff8a999ce14e8d9c94afd320397ed3 : FAILURE in 5m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d57a1acdcbe94f289c3f5f4966d008c1 : FAILURE in 5m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2319b455c451430ca150a3209165ff19 : FAILURE in 6m 11s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/12c065c2527d4912965f6110561c197c : SUCCESS in 8m 39s\n- aodh-tempest-plugin-mysql https://zuul.opendev.org/t/openstack/build/45755689a30245aab727f578c1eb017f : FAILURE in 14m 23s\n- aodh-tempest-plugin-postgresql https://zuul.opendev.org/t/openstack/build/e550ec3e79334a0bb9a62956fd031b61 : SUCCESS in 49m 54s\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/c64aa1871d0b4bc994488a6fec54798b : FAILURE in 1h 00m 27s\n- telemetry-dsvm-integration-ipv6-only https://zuul.opendev.org/t/openstack/build/5c54ff0335aa4b01b7fe166901e80f59 : FAILURE in 1h 02m 44s","accounts_in_message":[],"_revision_number":3},{"id":"8267d53ba322e2e58eabf2a77b6c73417c275b4d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"date":"2021-04-22 11:13:17.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f215c94a48d7f74b71b979f6b61cc95b4701f23e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"date":"2021-04-22 11:15:28.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"1767e79fe2440f9092ad22b1dad7ad52d0baeffa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-22 12:17:18.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2330d7e9d2ab4b8e99051df0e1b79ad3 : SUCCESS in 5m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/75eed252fd9f4866a02b22ed9117e2a6 : SUCCESS in 10m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0a26d89cb6ee4c55b7b1374a4dd892ce : SUCCESS in 10m 49s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f1729968f6bc4131ab546f1962e3e2e6 : SUCCESS in 9m 51s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5a1ad893d8e3498c90e5fea6ec657e86 : SUCCESS in 7m 46s\n- aodh-tempest-plugin-mysql https://zuul.opendev.org/t/openstack/build/ec194d690c7244f4abd90780a0943c20 : SUCCESS in 44m 31s\n- aodh-tempest-plugin-postgresql https://zuul.opendev.org/t/openstack/build/5697ede6c21a45cc92f2ff101784b9f5 : SUCCESS in 45m 14s\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/6e4c0ff914204e7c9f1aceaec6cb6d17 : FAILURE in 58m 49s\n- telemetry-dsvm-integration-ipv6-only https://zuul.opendev.org/t/openstack/build/7c2dc835f8e54527a8b81b375635248a : FAILURE in 57m 31s","accounts_in_message":[],"_revision_number":5},{"id":"356131f499a85993c1f90b79e51112bf12014650","author":{"_account_id":11242,"name":"Erol Ozcan","email":"erol.ozcan@gmail.com","username":"erol.ozcan"},"date":"2021-04-22 13:37:30.000000000","message":"Patch Set 5:\n\nThe failure with id 6e4c0ff914204e7c9f1aceaec6cb6d17 could be related with the following Neutron bug.\n\nhttps://bugs.launchpad.net/neutron/+bug/1902998","accounts_in_message":[],"_revision_number":5},{"id":"10e2761870b82b18cd67e0718e6a3c4bd55197d2","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-04-22 15:17:33.000000000","message":"Patch Set 5: Code-Review+1\n\nThank you for fixing all the minor issues.\n\nI am quite certain, the patch does not cause the gate failing, it did before and it really hard to debug. From the linked issue, this should already be fixed. I have seen the gate job failing since end of February, but couldn\u0027t figure out yet why this happens. I\u0027m willing to skip these checks.\n\nHowever, especially this change should affect the integration test. It would be absolutely awesome, if you could add a test to the change so that this is not getting broken by a different change without a notice.\nThat is the reason for me to +1 this patch here.","accounts_in_message":[],"_revision_number":5},{"id":"5b191ed0329de45f6a155c3a3a150552ebeea571","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-04-28 13:02:32.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"1927e9c246ca15a942612ce7dfd5eff81249b8d4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-28 13:57:37.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9d4043f76a594adb8f6ea7e0a0dd954b : SUCCESS in 4m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/482212ee584f4e68986bf80ec428ed98 : SUCCESS in 7m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e5c6bc4aa6c04e49bae2020c292324ac : SUCCESS in 9m 07s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/caee25eec30b4a679eff686346be305d : SUCCESS in 19m 23s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa45c97e2fd644cdb7fba6dbab8eece8 : SUCCESS in 6m 52s\n- aodh-tempest-plugin-mysql https://zuul.opendev.org/t/openstack/build/3ba4e6a2564647088e3044fe0d1c521a : SUCCESS in 29m 24s\n- aodh-tempest-plugin-postgresql https://zuul.opendev.org/t/openstack/build/4a40b5234d3146bca055efb6be9356d4 : SUCCESS in 33m 44s\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/8a0903b2ec4645aa84a391fdbe27fbed : FAILURE in 47m 12s (non-voting)\n- telemetry-dsvm-integration-ipv6-only https://zuul.opendev.org/t/openstack/build/7861a39f6de94077a55a9be9fa406be0 : FAILURE in 52m 38s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"4ce1b76efe167feae77b475cfdc13773ee1d8b12","author":{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"},"date":"2021-04-28 15:16:05.000000000","message":"Patch Set 5: Code-Review-1\n\nHi Matthias,\n\nThank you for looking into this, I was struggling myself trying to understand how all this ecosytem works (Gnocchi - Ceilometer - Aodh) when I saw your work. It helped me a lot to understand the current situation 😊\n\nSo I tested your patch but it didn\u0027t work out of the box (Bullseye + Victoria)...\n\n1. in [GnocchiAggregationResourcesThresholdEvaluator] _statistics - aodh/evaluator/gnocchi.py\nThe cpu_operation doesn\u0027t work for us, it is the way around : (aggregate rate:mean (metric cpu mean))\n\n2. Sometimes I do have negative values returned which trigger alarms\n\n3. evaluate_rule fails in /aodh/evaluator/threshold.py in case of evaluation_periods \u003e 1 defined in my alarm. I had hack it to test and it passes this way:\n\nif alarm_rule[\u0027metric\u0027] \u003d\u003d \u0027cpu\u0027:\n          sufficient \u003d len(statistics) \u003e\u003d 1\n        else:\n          sufficient \u003d len(statistics) \u003e\u003d alarm_rule[\u0027evaluation_periods\u0027]\n\nI don\u0027t know if it is possible but, wouldn\u0027t it be simpler and more understandbale for end users to document how to compute the cpu_util metric instead and expose this metric to users so they can use it in their alarms ? kind of like... before... 😄","accounts_in_message":[],"_revision_number":5},{"id":"17e87b67000ee39b94b6d6d22c8686939f5fc321","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-04-29 15:07:45.000000000","message":"Patch Set 5: Code-Review-2\n\nThank you for your work here!\n\nTbh, I am not sure if I like the extra role/handling for this single metric here, especially it does not help with any other metrics collected the same way. One could think of bringing up another network interface if there are faults or if the utilization goes over ... %\n\nCeilometer deprecated and removed transformers e.g to calculate cpu_util a couple of releases ago. The idea was to let gnocchi calculate this. \n\nI see two steps here: Get gnocchi do the necessary operation calculated documented and second get aodh work with theses aggregations. If there is an issue here in aodh re. that, it needs to be fixed.","accounts_in_message":[],"_revision_number":5},{"id":"c771bb5a51b5aa499eacc17124611ccd59512d44","tag":"autogenerated:gerrit:abandon","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2022-02-21 10:04:08.000000000","message":"Abandoned\n\nabandoned in favor of https://review.opendev.org/c/openstack/aodh/+/829870","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"0e4823285f06fde5e7a93dccee3d936050fb752c","revisions":{"e8d0aeddaaf723379f4f54f6e4085b5b74caa7d3":{"kind":"REWORK","_number":1,"created":"2021-04-19 14:06:04.000000000","uploader":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"ref":"refs/changes/80/786880/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/aodh","ref":"refs/changes/80/786880/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/aodh refs/changes/80/786880/1"}}},"commit":{"parents":[{"commit":"dcb97668bfa768eed4e6f5c6604e9e3336a58862","subject":"Merge \"Use python 3.8 for tox\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/dcb97668bfa768eed4e6f5c6604e9e3336a58862"}]}],"author":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-19 14:02:57.000000000","tz":0},"committer":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-19 14:02:57.000000000","tz":0},"subject":"Allows calculation of cpu metric values as percentages.","message":"Allows calculation of cpu metric values as percentages.\n\nFixes bug :  38895\n\nStory: https://storyboard.openstack.org/#!/story/2007350\nChange-Id: I60fb1dc75ed511c82602ddc6c70d9db370374daa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/e8d0aeddaaf723379f4f54f6e4085b5b74caa7d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/e8d0aeddaaf723379f4f54f6e4085b5b74caa7d3"}]},"branch":"refs/heads/master"},"b3aa76dd76fbbce5613cc212d010f92c528eb678":{"kind":"REWORK","_number":2,"created":"2021-04-20 08:38:39.000000000","uploader":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"ref":"refs/changes/80/786880/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/aodh","ref":"refs/changes/80/786880/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/aodh refs/changes/80/786880/2"}}},"commit":{"parents":[{"commit":"dcb97668bfa768eed4e6f5c6604e9e3336a58862","subject":"Merge \"Use python 3.8 for tox\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/dcb97668bfa768eed4e6f5c6604e9e3336a58862"}]}],"author":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-19 14:02:57.000000000","tz":0},"committer":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-20 08:38:35.000000000","tz":0},"subject":"Allows calculation of cpu metric values as percentages.","message":"Allows calculation of cpu metric values as percentages.\n\nFixes bug :  38895\nFixed PEP8 Formating\n\nStory: https://storyboard.openstack.org/#!/story/2007350\nChange-Id: I60fb1dc75ed511c82602ddc6c70d9db370374daa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/b3aa76dd76fbbce5613cc212d010f92c528eb678"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/b3aa76dd76fbbce5613cc212d010f92c528eb678"}]},"branch":"refs/heads/master"},"347021e688135c7f69b6b25b39b5eac64d778903":{"kind":"REWORK","_number":3,"created":"2021-04-20 13:50:16.000000000","uploader":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"ref":"refs/changes/80/786880/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/aodh","ref":"refs/changes/80/786880/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/aodh refs/changes/80/786880/3"}}},"commit":{"parents":[{"commit":"dcb97668bfa768eed4e6f5c6604e9e3336a58862","subject":"Merge \"Use python 3.8 for tox\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/dcb97668bfa768eed4e6f5c6604e9e3336a58862"}]}],"author":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-19 14:02:57.000000000","tz":0},"committer":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-20 13:50:13.000000000","tz":0},"subject":"Allows calculation of cpu metric values as percentages.","message":"Allows calculation of cpu metric values as percentages.\n\nFixes bug :  38895\nFixed PEP8 Formating\nLines longer than 80 characters are arranged\nDebug Lines Removed\n\nStory: https://storyboard.openstack.org/#!/story/2007350\nChange-Id: I60fb1dc75ed511c82602ddc6c70d9db370374daa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/347021e688135c7f69b6b25b39b5eac64d778903"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/347021e688135c7f69b6b25b39b5eac64d778903"}]},"branch":"refs/heads/master"},"32b1b7205c936458d7a58cbf7dd87c4a54c9bf47":{"kind":"REWORK","_number":4,"created":"2021-04-22 11:13:17.000000000","uploader":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"ref":"refs/changes/80/786880/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/aodh","ref":"refs/changes/80/786880/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/aodh refs/changes/80/786880/4"}}},"commit":{"parents":[{"commit":"dcb97668bfa768eed4e6f5c6604e9e3336a58862","subject":"Merge \"Use python 3.8 for tox\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/dcb97668bfa768eed4e6f5c6604e9e3336a58862"}]}],"author":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-19 14:02:57.000000000","tz":0},"committer":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-22 11:13:04.000000000","tz":0},"subject":"Allows calculation of cpu metric values as percentages.","message":"Allows calculation of cpu metric values as percentages.\n\nFixes bug :  38895\nFixed PEP8 Formating\nLines longer than 80 characters are arranged\nDebug Lines Removed\nopenstack-tox-py36 bugfixx\n\nStory: https://storyboard.openstack.org/#!/story/2007350\nChange-Id: I60fb1dc75ed511c82602ddc6c70d9db370374daa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/32b1b7205c936458d7a58cbf7dd87c4a54c9bf47"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/32b1b7205c936458d7a58cbf7dd87c4a54c9bf47"}]},"branch":"refs/heads/master"},"0e4823285f06fde5e7a93dccee3d936050fb752c":{"kind":"REWORK","_number":5,"created":"2021-04-22 11:15:28.000000000","uploader":{"_account_id":33383,"name":"Nebi Unlenen","display_name":"Nebi Volkan ÜNLENEN","email":"unlenen@gmail.com","username":"unlenen"},"ref":"refs/changes/80/786880/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/aodh","ref":"refs/changes/80/786880/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/aodh refs/changes/80/786880/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/aodh refs/changes/80/786880/5"}}},"commit":{"parents":[{"commit":"dcb97668bfa768eed4e6f5c6604e9e3336a58862","subject":"Merge \"Use python 3.8 for tox\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/dcb97668bfa768eed4e6f5c6604e9e3336a58862"}]}],"author":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-19 14:02:57.000000000","tz":0},"committer":{"name":"Nebi Unlenen","email":"unlenen@gmail.com","date":"2021-04-22 11:15:06.000000000","tz":0},"subject":"Allows calculation of cpu metric values as percentages.","message":"Allows calculation of cpu metric values as percentages.\n\nFixes bug :  38895\nFixed PEP8 Formating\nLines longer than 80 characters are arranged\nDebug Lines Removed\nopenstack-tox-py36 bugfixx\n\nStory: https://storyboard.openstack.org/#!/story/2007350\nChange-Id: I60fb1dc75ed511c82602ddc6c70d9db370374daa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/0e4823285f06fde5e7a93dccee3d936050fb752c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/aodh/commit/0e4823285f06fde5e7a93dccee3d936050fb752c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
