)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3ce9d13ad2ae37a0658986351c1090b469b81714","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f758695f_a67fe8f0","updated":"2023-09-04 12:56:10.000000000","message":"recheck","commit_id":"2ec72710d4e45d9b4e76a542faa43405e04524d0"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"34111003658f568d4fc3fd8b5e3909788791fc0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b412d7a2_dc7be6e5","updated":"2023-09-11 08:51:24.000000000","message":"Thank you, a few nits, this needs a bit more work","commit_id":"c42c1f175f30a9072bdc7fe420f64cc62c32bdf6"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"44bd8401d1ef2208d0419cc2df5d356079ac88cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c6810f60_f5ea746f","updated":"2023-09-18 06:48:03.000000000","message":"recheck","commit_id":"c42c1f175f30a9072bdc7fe420f64cc62c32bdf6"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"169ec1ebd131e612d32c05a989dd2f79ae0165e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"02738031_b950441e","updated":"2023-09-27 07:57:19.000000000","message":"This depends on the requirements patch to get the observabilityclient in. In theory, we should not see dependency failures?","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"1e0cefc302945c914f941d3b85197d3554d55009","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"344a8949_ccca4232","updated":"2023-09-27 06:36:30.000000000","message":"True errors in the logs\n\nCaptured stdout:\n~~~~~~~~~~~~~~~~\n    2023-09-26 12:55:58.490 6688 ERROR stevedore.extension [-] Could not load \u0027prometheus\u0027: Can\u0027t find prometheus host and port configuration.: observabilityclient.utils.metric_utils.ConfigurationError: Can\u0027t find prometheus host and port configuration.\n2023-09-26 12:55:58.492 6688 WARNING stevedore.named [-] Could not load prometheus\n2023-09-26 12:55:58.493 6688 INFO aodh.evaluator [-] alarm 701eb3b0-404a-437b-b60f-59adfa9bad69 transitioning to alarm because Composite rule alarm with composition form: (rule1 or rule2 or rule3) transition to alarm, due to rules: rule1 outside their threshold.","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"47f6b56cb76f69203cf9b5ae30d632f44c91372a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"25784165_a557dbce","updated":"2023-09-29 13:10:23.000000000","message":"recheck","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9e5cc2081f4552b5e9d1c1a445fe56fc3acbfd2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"68cdfdef_b6371ce4","updated":"2023-09-25 08:56:08.000000000","message":"recheck","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"2c76f886e107f1ef76ae8a538b0fd86d9c8516f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"42d209db_d15710da","updated":"2023-09-26 12:51:15.000000000","message":"recheck - The missing aodh-dbsync should be fixed now","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"2d90fea9e0f730d6d1520b1175420461ebbf3769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a8ab901e_8bacfec2","in_reply_to":"02738031_b950441e","updated":"2023-09-27 08:01:52.000000000","message":"It looks like the observabilityclient is already in. It tries to look for the location of prometheus when the client is created, but it can\u0027t find any configuration for that, so it logs an error.","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"380d3d796300be47d96ed38994b6e8e57cff3b1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"aac6916a_2133a031","in_reply_to":"344a8949_ccca4232","updated":"2023-09-27 07:37:59.000000000","message":"I don\u0027t think, this is what caused the job to fail, especially because we can see the same errors being logged in all the other tox-p3x jobs. I\u0027d expect the job to succeed with a recheck. But this is still an interesting find.","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"7aba261671ffb8f1b625bc09f8bda04403ba7be1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e5aaaf12_c46d3a90","in_reply_to":"aac6916a_2133a031","updated":"2023-09-29 16:32:48.000000000","message":"No it indeed is not the reason. Gabbi tests for API functional testing is what is failing. But still, loading the prometheus_client is patched with mock in the added unit test (line 219). So the code looking for prometheus.yaml should not be even executed.","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"ae13faba8f3b688307ee56f8113f4fe23fe1e19d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5104d571_72603803","updated":"2023-10-11 09:32:52.000000000","message":"LGTM","commit_id":"a3586df9c5f793c0b23ad66dbc921445ab7cc2da"},{"author":{"_account_id":34918,"name":"wangkuntian","email":"wangkuntian1994@163.com","username":"wangkuntian"},"change_message_id":"5450d3f369cefd304c31dad9bdcde5843526e885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c7c584eb_0f79f82e","updated":"2023-10-09 02:23:39.000000000","message":"LGTM","commit_id":"a3586df9c5f793c0b23ad66dbc921445ab7cc2da"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"19bc91fb9a675c841331c3190fc5d28519864bd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d6633e62_aa426f75","updated":"2023-10-02 08:44:34.000000000","message":"The CI failed due to heat trying to pull images from less secure mirror in a fips job, which is unrelated to this change. The Heat change, which is attempting to fix this probably deserves some eyes: https://review.opendev.org/c/openstack/heat/+/896753\n\nAfter that we might get the CI to succeed.","commit_id":"a3586df9c5f793c0b23ad66dbc921445ab7cc2da"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"e138968a0ab6171adc3771aad48fe22d465cd05d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f41ebf75_2116d486","updated":"2023-10-02 15:26:05.000000000","message":"recheck","commit_id":"a3586df9c5f793c0b23ad66dbc921445ab7cc2da"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"634bb09cbc797045d74a3ab3efe1e9aba051f4c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"42bf4a9d_3e2a1160","updated":"2023-10-02 18:30:03.000000000","message":"thanks!","commit_id":"a3586df9c5f793c0b23ad66dbc921445ab7cc2da"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"2e2c97304ca42face0ff1fbda64085cae12a54d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e73eb023_3df469c4","updated":"2023-10-23 08:19:31.000000000","message":"recheck","commit_id":"884cd6d7b2bb2545d16a902b5190719b0e55460d"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"17767be09cf43069247ee6ca2ac28ed5fb7176bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d2deb7ec_d1a79ea2","updated":"2023-11-07 04:32:59.000000000","message":"The Depends-On: Iaba2f7d8d7f45e1ca50a4a542a98caf076eb2d28 patch is abandoned. It not needed can we please remove it from commit msg.","commit_id":"79f20f23cdb7ce565d8b4cbb60eb0ea8ec7c46fc"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"7e4b58f07430984e712ccb5faca22b52c9cfa1d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bfdc833e_3d1026c8","updated":"2023-11-06 06:40:37.000000000","message":"recheck","commit_id":"79f20f23cdb7ce565d8b4cbb60eb0ea8ec7c46fc"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"8c3431d27c66b8b4df6649932f77035d4b1de5de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c2e65330_7694c3af","updated":"2023-11-03 16:17:18.000000000","message":"recheck","commit_id":"79f20f23cdb7ce565d8b4cbb60eb0ea8ec7c46fc"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"f7537f38f5c4e94c625ded34d627bf8437a934a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f0004102_1c7919ae","updated":"2023-10-31 19:59:51.000000000","message":"recheck","commit_id":"79f20f23cdb7ce565d8b4cbb60eb0ea8ec7c46fc"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"bc9753ad0be8034fe29c48ed83fba01228596e18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e9702a0c_9603c9e6","updated":"2023-11-07 10:31:40.000000000","message":"recheck heat accessing fedora image dumped again.","commit_id":"79f20f23cdb7ce565d8b4cbb60eb0ea8ec7c46fc"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"44cc20f976414b136da3d5a87dcdbee9c18737a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"71654beb_66e5a190","updated":"2023-11-07 13:39:08.000000000","message":"recheck","commit_id":"f932265290a4e923eac6111eb28578489c7dce33"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"1a909c7b717443eccf38604d366ab83616e9fffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5aeea78d_7827d68e","updated":"2023-11-07 08:32:56.000000000","message":"recheck FIPS job failed again","commit_id":"f932265290a4e923eac6111eb28578489c7dce33"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9d1a52b232de381222e6433c1b4ff4bfd21eaa47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"98c63425_17247980","updated":"2023-11-07 06:23:28.000000000","message":"removed the dependency to the abandoned change that prevented this to be merged.","commit_id":"f932265290a4e923eac6111eb28578489c7dce33"}],"aodh/evaluator/composite.py":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"380d3d796300be47d96ed38994b6e8e57cff3b1e","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                               \u0027gnocchi_resources_threshold\u0027,"},{"line_number":121,"context_line":"                               \u0027gnocchi_aggregation_by_metrics_threshold\u0027,"},{"line_number":122,"context_line":"                               \u0027gnocchi_aggregation_by_resources_threshold\u0027)"},{"line_number":123,"context_line":"            self._threshold_evaluators \u003d stevedore.NamedExtensionManager("},{"line_number":124,"context_line":"                \u0027aodh.evaluator\u0027, threshold_types, invoke_on_load\u003dTrue,"},{"line_number":125,"context_line":"                invoke_args\u003d(self.conf,))"},{"line_number":126,"context_line":"        return self._threshold_evaluators"}],"source_content_type":"text/x-python","patch_set":8,"id":"876b110f_047a01ba","line":123,"updated":"2023-09-27 07:37:59.000000000","message":"What I think is happening during the errors seen by Matthias is, that over here we are instantiating the PrometheusEvaluator class and it doesn\u0027t matter if the PrometheusEvaluator actually gets used or not (I might be wrong here, it which case ignore this comment). So the composite unit tests would instantiate the class with each test case. That\u0027s why we see an error logged with each composite test case.\n\nInside the constructor of PrometheusEvaluator we are creating an observabilityclient client, which tries to look for the location of prometheus when created.\n\nI\u0027m unsure what the best solution for this is. From what I can think of right now, we could either put the prometheus threshold type behind some kind of condition here, we could implement the PrometheusEvaluator to postpone the creation of the observabilityclient client (maybe until it\u0027s first use), or we could modify the observabilityclient to look for the host and port configuration later.","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"7aba261671ffb8f1b625bc09f8bda04403ba7be1","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                               \u0027gnocchi_resources_threshold\u0027,"},{"line_number":121,"context_line":"                               \u0027gnocchi_aggregation_by_metrics_threshold\u0027,"},{"line_number":122,"context_line":"                               \u0027gnocchi_aggregation_by_resources_threshold\u0027)"},{"line_number":123,"context_line":"            self._threshold_evaluators \u003d stevedore.NamedExtensionManager("},{"line_number":124,"context_line":"                \u0027aodh.evaluator\u0027, threshold_types, invoke_on_load\u003dTrue,"},{"line_number":125,"context_line":"                invoke_args\u003d(self.conf,))"},{"line_number":126,"context_line":"        return self._threshold_evaluators"}],"source_content_type":"text/x-python","patch_set":8,"id":"871717c1_5dc101b4","line":123,"in_reply_to":"876b110f_047a01ba","updated":"2023-09-29 16:32:48.000000000","message":"You are actually right that this is the cause of complains in stdout of unit tests. Ideal would be to mock the piece of code which uses observabilityclient to noop logic similar way as is in the PrometheusEvaluator code, but that\u0027s not possible (or not easily possible ... IMO) thanks to this dynamic load of extensions. Luckily you\u0027ve enabled easy override of Prometheus setting in observabilityclient, so will add it in next patchset, so that complains disappear.","commit_id":"e3b9f004fc25192cdb509baf177b136a095e368e"}],"aodh/tests/unit/test_evaluator.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"34111003658f568d4fc3fd8b5e3909788791fc0b","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import time"},{"line_number":19,"context_line":"from unittest import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from observabilityclient import prometheus_client"},{"line_number":22,"context_line":"from oslo_config import fixture as fixture_config"},{"line_number":23,"context_line":"from stevedore import extension"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"8df046ab_2597aa10","line":21,"updated":"2023-09-11 08:51:24.000000000","message":"another try/except needed here.","commit_id":"c42c1f175f30a9072bdc7fe420f64cc62c32bdf6"}],"test-requirements.txt":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"34111003658f568d4fc3fd8b5e3909788791fc0b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"gabbi\u003e\u003d1.30.0 # Apache-2.0"},{"line_number":8,"context_line":"# Provides subunit-trace"},{"line_number":9,"context_line":"WebTest\u003e\u003d3.0.0"},{"line_number":10,"context_line":"python-observabilityclient\u003e\u003d0.0.4"}],"source_content_type":"text/plain","patch_set":7,"id":"ad7daea9_95bce025","line":10,"updated":"2023-09-11 08:51:24.000000000","message":"this causes the requirements check to fail","commit_id":"c42c1f175f30a9072bdc7fe420f64cc62c32bdf6"}]}