)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d4f8c896d09ae85913f76da26de423c5de6648d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c2f3495_dade4d5e","updated":"2024-12-05 11:05:12.000000000","message":"Nice catch!\n\nIn-line comment on the docstring of the settings.","commit_id":"5b4f3c8bc8d65830064a402f189c192190480bea"}],"devstack/settings":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d4f8c896d09ae85913f76da26de423c5de6648d9","unresolved":true,"context_lines":[{"line_number":21,"context_line":"AODH_SERVICE_HOST\u003d${AODH_SERVICE_HOST:-$SERVICE_HOST}"},{"line_number":22,"context_line":"AODH_SERVICE_PORT\u003d${AODH_SERVICE_PORT:-8042}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# AODH_DEPLOY defines how Aodh is deployed, allowed values:"},{"line_number":25,"context_line":"# - mod_wsgi : Run Aodh under Apache HTTPd mod_wsgi"},{"line_number":26,"context_line":"# - uwsgi : Run Aodh under uwsgi"},{"line_number":27,"context_line":"AODH_DEPLOY\u003d${AODH_DEPLOY:-uwsgi}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"AODH_NOTIFICATION_TOPICS\u003d${AODH_NOTIFICATION_TOPICS:-notifications}"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"09de1669_77cee23c","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":33},"updated":"2024-12-05 11:05:12.000000000","message":"This does not correctly represent the proposed change. Either we should keep the checks that the value is \u0027mod_wsgi\u0027 or \u0027uwsgi\u0027, if not fail gracefully (rather than stack trace as it is now), or indicate here that the value can be anything, but only \u0027mod_wsgi\u0027 does have effect and everything else defaults deploying on uwsgi.\n\nI can fully appreciate that the old version seemed to have been equally incorrect.","commit_id":"5b4f3c8bc8d65830064a402f189c192190480bea"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9a20d7c587039d0b5777dc45736f6ce3d3b58578","unresolved":true,"context_lines":[{"line_number":21,"context_line":"AODH_SERVICE_HOST\u003d${AODH_SERVICE_HOST:-$SERVICE_HOST}"},{"line_number":22,"context_line":"AODH_SERVICE_PORT\u003d${AODH_SERVICE_PORT:-8042}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# AODH_DEPLOY defines how Aodh is deployed, allowed values:"},{"line_number":25,"context_line":"# - mod_wsgi : Run Aodh under Apache HTTPd mod_wsgi"},{"line_number":26,"context_line":"# - uwsgi : Run Aodh under uwsgi"},{"line_number":27,"context_line":"AODH_DEPLOY\u003d${AODH_DEPLOY:-uwsgi}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"AODH_NOTIFICATION_TOPICS\u003d${AODH_NOTIFICATION_TOPICS:-notifications}"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ddb73c16_4c7f03f1","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":33},"in_reply_to":"09de1669_77cee23c","updated":"2024-12-06 05:10:27.000000000","message":"I can fix it but I\u0027m removing this option in the next change which removes mod_wsgi support (following the removal in devstack), so I\u0027m wondering if we can skip updating this now because we anyway remove it soon.\n\nhttps://review.opendev.org/c/openstack/aodh/+/936099","commit_id":"5b4f3c8bc8d65830064a402f189c192190480bea"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"af1d08e256f2d4d99dce58188a0e100f81396825","unresolved":false,"context_lines":[{"line_number":21,"context_line":"AODH_SERVICE_HOST\u003d${AODH_SERVICE_HOST:-$SERVICE_HOST}"},{"line_number":22,"context_line":"AODH_SERVICE_PORT\u003d${AODH_SERVICE_PORT:-8042}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# AODH_DEPLOY defines how Aodh is deployed, allowed values:"},{"line_number":25,"context_line":"# - mod_wsgi : Run Aodh under Apache HTTPd mod_wsgi"},{"line_number":26,"context_line":"# - uwsgi : Run Aodh under uwsgi"},{"line_number":27,"context_line":"AODH_DEPLOY\u003d${AODH_DEPLOY:-uwsgi}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"AODH_NOTIFICATION_TOPICS\u003d${AODH_NOTIFICATION_TOPICS:-notifications}"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"79cf2be2_b25f4906","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":33},"in_reply_to":"ddb73c16_4c7f03f1","updated":"2025-03-24 08:29:54.000000000","message":"It is a strange choice to remove the \"simple\" api in one change and the mod_wsgi in the next one, but nevertheless, the objetive is fulfilled, which is leaving uwsgi as the only api option.\n\nWe should start merging first the chain of changes in order.","commit_id":"5b4f3c8bc8d65830064a402f189c192190480bea"}]}