)]}'
{"tools/check_app_catalog_yaml.py":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"39df8f47eda7da41a4fc0f35652d249ec5012d23","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        url \u003d a.get(\u0027attributes\u0027, {}).get(\u0027url\u0027)"},{"line_number":104,"context_line":"        if url:"},{"line_number":105,"context_line":"            r \u003d requests.head(url, allow_redirects\u003dTrue)"},{"line_number":106,"context_line":"            if r.status_code !\u003d 200:"},{"line_number":107,"context_line":"                a[\u0027attributes\u0027][\u0027active\u0027] \u003d False"},{"line_number":108,"context_line":"        assets.append(a)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_01c9bcab","line":106,"range":{"start_line":106,"start_character":12,"end_line":106,"end_character":28},"updated":"2015-12-21 21:54:31.000000000","message":"r.ok is a bit cleaner to read and also should accept some of the other 2xx responses.","commit_id":"d48ff9040209df15f15dcdc954b15d70b96d0a25"},{"author":{"_account_id":9788,"name":"Christopher Aedo","email":"doc@aedo.net","username":"doc"},"change_message_id":"89c2f7259a283d1a555d305ade1af91dc559a7f6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        url \u003d a.get(\u0027attributes\u0027, {}).get(\u0027url\u0027)"},{"line_number":104,"context_line":"        if url:"},{"line_number":105,"context_line":"            r \u003d requests.head(url, allow_redirects\u003dTrue)"},{"line_number":106,"context_line":"            if r.status_code !\u003d 200:"},{"line_number":107,"context_line":"                a[\u0027attributes\u0027][\u0027active\u0027] \u003d False"},{"line_number":108,"context_line":"        assets.append(a)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_61668052","line":106,"range":{"start_line":106,"start_character":12,"end_line":106,"end_character":28},"in_reply_to":"3a7e1126_01c9bcab","updated":"2015-12-21 22:06:40.000000000","message":"Done","commit_id":"d48ff9040209df15f15dcdc954b15d70b96d0a25"},{"author":{"_account_id":9788,"name":"Christopher Aedo","email":"doc@aedo.net","username":"doc"},"change_message_id":"7664de825284022eca17fc48cb2c83f8eb3e72db","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        url \u003d a.get(\u0027attributes\u0027, {}).get(\u0027url\u0027)"},{"line_number":104,"context_line":"        if url:"},{"line_number":105,"context_line":"            r \u003d requests.head(url, allow_redirects\u003dTrue)"},{"line_number":106,"context_line":"            if r.status_code !\u003d 200:"},{"line_number":107,"context_line":"                a[\u0027attributes\u0027][\u0027active\u0027] \u003d False"},{"line_number":108,"context_line":"        assets.append(a)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_0c822153","line":106,"range":{"start_line":106,"start_character":12,"end_line":106,"end_character":28},"in_reply_to":"3a7e1126_61668052","updated":"2015-12-22 23:17:33.000000000","message":"Actually I am switching this back to checking for a 200 response - I think the alternate \"ok\" codes are not the same as guaranteeing the link got a 200. Also, this makes the code more obvious, showing exactly what we are looking for.","commit_id":"d48ff9040209df15f15dcdc954b15d70b96d0a25"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"80e063a6664035ae848961549d32759595859f21","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        url \u003d a.get(\u0027attributes\u0027, {}).get(\u0027url\u0027)"},{"line_number":104,"context_line":"        if url:"},{"line_number":105,"context_line":"            r \u003d requests.head(url, allow_redirects\u003dTrue)"},{"line_number":106,"context_line":"            if r.status_code !\u003d requests.codes.ok:"},{"line_number":107,"context_line":"                a[\u0027attributes\u0027][\u0027active\u0027] \u003d False"},{"line_number":108,"context_line":"        assets.append(a)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_6769b0f8","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":50},"updated":"2015-12-21 23:25:10.000000000","message":"I actually meant this https://github.com/kennethreitz/requests/blob/a1c9b8439c7d36125867200aadfb44184f865fa6/requests/models.py#L620-L626\nproperty.\n\nso it would be like \n\n  if r.ok:\n    ...\n\nI\u0027ve been using it for years, wonder why it\u0027s not documented... \u003d/","commit_id":"32e5ebd8c3479db0353030ace15b3e9f1f41e075"},{"author":{"_account_id":9788,"name":"Christopher Aedo","email":"doc@aedo.net","username":"doc"},"change_message_id":"d5765713a689774d1e1289b35e3bb2166c7b8e3c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        url \u003d a.get(\u0027attributes\u0027, {}).get(\u0027url\u0027)"},{"line_number":104,"context_line":"        if url:"},{"line_number":105,"context_line":"            r \u003d requests.head(url, allow_redirects\u003dTrue)"},{"line_number":106,"context_line":"            if r.status_code !\u003d requests.codes.ok:"},{"line_number":107,"context_line":"                a[\u0027attributes\u0027][\u0027active\u0027] \u003d False"},{"line_number":108,"context_line":"        assets.append(a)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_b2a7d4a5","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":50},"in_reply_to":"3a7e1126_6769b0f8","updated":"2015-12-21 23:48:33.000000000","message":"Ah ok I see what you are saying. In this case I would argue just saying \"r.ok\" is LESS readable. At least here it\u0027s clear we are checking for a status code response. If it just says \"r.ok\" you would have to understand that OK refers to the response-code rather than something else that could be OK.","commit_id":"32e5ebd8c3479db0353030ace15b3e9f1f41e075"}]}