)]}'
{"tools/asset_history.sh":[{"author":{"_account_id":8829,"name":"Ryan Moe","email":"rmoe@mirantis.com","username":"rmoe"},"change_message_id":"1e41beced49d5b67331971d6bb745ff9c31428d9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    name\u003d`head -n $end \"$asset_file\" | tail -n $size | python -c \u0027import yaml,sys; print yaml.load(sys.stdin)[0][\"name\"]\u0027`"},{"line_number":6,"context_line":"    date\u003d`git blame -w -L $line \"$asset_file\" | sed \u0027s/^[^(]*(\\([^)]*\\)).*/\\1/\u0027 | python -c \u0027import sys,dateutil.parser; print max([dateutil.parser.parse(\"%s %s%s\"%(j[0], j[1], j[2])) for j in [i.split()[-4:] for i in sys.stdin.readlines()]])\u0027`"},{"line_number":7,"context_line":"    (echo $name; echo $date) | python -c \u0027import sys,json; print json.dumps([i.strip() for i in sys.stdin.readlines()]),\u0027"},{"line_number":8,"context_line":"done | python -c \u0027import sys,json,yaml; print yaml.safe_dump({\"assets\":dict([[j[0], {\"last_modified\":j[1]}] for j in [json.loads(i) for i in sys.stdin.readlines()]])}),\u0027"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba63e191_b75be0f5","line":8,"updated":"2016-01-19 23:44:40.000000000","message":"This is incredibly difficult to follow. If it absolutely has to be a shell script (as opposed to doing it all in Python) then maybe split this up somehow and replace the python -c invocations with heredocs. e.g.\n\n\npython - \u003c\u003c EOF\nimport sys\nimport yaml\nprint yaml.load(sys.stdin)[0][\"name\"]\nEOF","commit_id":"e8911b45e10bf6eaf72a4f4f2e25a85ada3a17da"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"3882df79b6088bf7c127e12f23d46f515f3da76e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    name\u003d`head -n $end \"$asset_file\" | tail -n $size | python -c \u0027import yaml,sys; print yaml.load(sys.stdin)[0][\"name\"]\u0027`"},{"line_number":6,"context_line":"    date\u003d`git blame -w -L $line \"$asset_file\" | sed \u0027s/^[^(]*(\\([^)]*\\)).*/\\1/\u0027 | python -c \u0027import sys,dateutil.parser; print max([dateutil.parser.parse(\"%s %s%s\"%(j[0], j[1], j[2])) for j in [i.split()[-4:] for i in sys.stdin.readlines()]])\u0027`"},{"line_number":7,"context_line":"    (echo $name; echo $date) | python -c \u0027import sys,json; print json.dumps([i.strip() for i in sys.stdin.readlines()]),\u0027"},{"line_number":8,"context_line":"done | python -c \u0027import sys,json,yaml; print yaml.safe_dump({\"assets\":dict([[j[0], {\"last_modified\":j[1]}] for j in [json.loads(i) for i in sys.stdin.readlines()]])}),\u0027"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a68dd71_c2da9a78","line":8,"in_reply_to":"ba63e191_b75be0f5","updated":"2016-01-20 16:55:58.000000000","message":"Yeah, I was just scripting up something I had kind of working in bits.\n\nIf we wanted to keep this long term, I\u0027d be 100% with you on writing it nice and clean all in python.\n\nSince we plan on only doing the git repo stuff only until glare is ready, its a little less important.\n\nI\u0027ll see if I can dig up some time to rewrite it though.","commit_id":"e8911b45e10bf6eaf72a4f4f2e25a85ada3a17da"}],"tools/update_assets.sh":[{"author":{"_account_id":9788,"name":"Christopher Aedo","email":"doc@aedo.net","username":"doc"},"change_message_id":"179c5779b7850c0fcab7e6670b4cfc7e5830bb36","unresolved":false,"context_lines":[{"line_number":7,"context_line":"then"},{"line_number":8,"context_line":"\t$ROOTDIR/tools/asset_history.sh static/assets.yaml \u003e static/assets_merge.yaml"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":"if [ ! -f api/v1/assets ] || [ static/assets.yaml -nt api/v1/assets ] || [ static/assets_merge.yaml -nt  pi/v1/assets ];"},{"line_number":11,"context_line":"then"},{"line_number":12,"context_line":"\tpython $ROOTDIR/tools/yaml2json.py static/assets_merge.yaml \u003c static/assets.yaml \u003e /tmp/assets.$$"},{"line_number":13,"context_line":"\tzopfli --i150 -c /tmp/assets.$$ \u003e /tmp/assets.$$.gz || gzip -c /tmp/assets.$$ \u003e /tmp/assets.$$.gz"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da6ed579_bedfc838","line":10,"range":{"start_line":10,"start_character":105,"end_line":10,"end_character":107},"updated":"2016-01-15 00:38:08.000000000","message":"pi/v1/assets -\u003e api/v1/assets","commit_id":"1777a5771d826130b2fdf01265739f510f07650b"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"24098b7c061e86f7d0aa16c769aa2beb4758a5b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"then"},{"line_number":8,"context_line":"\t$ROOTDIR/tools/asset_history.sh static/assets.yaml \u003e static/assets_merge.yaml"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":"if [ ! -f api/v1/assets ] || [ static/assets.yaml -nt api/v1/assets ] || [ static/assets_merge.yaml -nt  pi/v1/assets ];"},{"line_number":11,"context_line":"then"},{"line_number":12,"context_line":"\tpython $ROOTDIR/tools/yaml2json.py static/assets_merge.yaml \u003c static/assets.yaml \u003e /tmp/assets.$$"},{"line_number":13,"context_line":"\tzopfli --i150 -c /tmp/assets.$$ \u003e /tmp/assets.$$.gz || gzip -c /tmp/assets.$$ \u003e /tmp/assets.$$.gz"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da6ed579_74238756","line":10,"range":{"start_line":10,"start_character":105,"end_line":10,"end_character":107},"in_reply_to":"da6ed579_bedfc838","updated":"2016-01-15 17:09:57.000000000","message":"Done","commit_id":"1777a5771d826130b2fdf01265739f510f07650b"}],"tools/yaml2json.py":[{"author":{"_account_id":9788,"name":"Christopher Aedo","email":"doc@aedo.net","username":"doc"},"change_message_id":"4717891ed623cceb03289598d3a18e5484d9143e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if \u0027environment\u0027 in s:"},{"line_number":44,"context_line":"            s[\u0027environment\u0027] \u003d yaml.dump(s[\u0027environment\u0027])"},{"line_number":45,"context_line":"    if a[\u0027name\u0027] in merge:"},{"line_number":46,"context_line":"      dict_merge(a, merge[a[\u0027name\u0027]])"},{"line_number":47,"context_line":"y \u003d [a for a in y[\u0027assets\u0027] if a.get(\u0027active\u0027, True)]"},{"line_number":48,"context_line":"y \u003d {\u0027assets\u0027: y}"},{"line_number":49,"context_line":"json.dump(y, sys.stdout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_3ed678f1","line":46,"updated":"2016-01-15 00:45:10.000000000","message":"There is no mechanism to prevent duplicate names right now in assets.yaml. Considering it would be very possible to have different asset types with the same name, I don\u0027t think this would work without a second constraint.","commit_id":"1777a5771d826130b2fdf01265739f510f07650b"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"24098b7c061e86f7d0aa16c769aa2beb4758a5b8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if \u0027environment\u0027 in s:"},{"line_number":44,"context_line":"            s[\u0027environment\u0027] \u003d yaml.dump(s[\u0027environment\u0027])"},{"line_number":45,"context_line":"    if a[\u0027name\u0027] in merge:"},{"line_number":46,"context_line":"      dict_merge(a, merge[a[\u0027name\u0027]])"},{"line_number":47,"context_line":"y \u003d [a for a in y[\u0027assets\u0027] if a.get(\u0027active\u0027, True)]"},{"line_number":48,"context_line":"y \u003d {\u0027assets\u0027: y}"},{"line_number":49,"context_line":"json.dump(y, sys.stdout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_34c3cf39","line":46,"in_reply_to":"da6ed579_3ed678f1","updated":"2016-01-15 17:09:57.000000000","message":"openstack_catalog/tests/test_openstack_catalog.py lines 47-52 check for, and prevent duplicate names. Other parts of our UI depends on there never being duplicates as well.","commit_id":"1777a5771d826130b2fdf01265739f510f07650b"},{"author":{"_account_id":8829,"name":"Ryan Moe","email":"rmoe@mirantis.com","username":"rmoe"},"change_message_id":"1e41beced49d5b67331971d6bb745ff9c31428d9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"args \u003d parser.parse_args()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"for f in args.files:"},{"line_number":28,"context_line":"    merge \u003d yaml.load(open(f))[\u0027assets\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def dict_merge(a, b):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_9cb60389","line":28,"updated":"2016-01-19 23:44:40.000000000","message":"merge is being reassigned in the loop so it will only ever have the last value of files.","commit_id":"e8911b45e10bf6eaf72a4f4f2e25a85ada3a17da"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"3882df79b6088bf7c127e12f23d46f515f3da76e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"args \u003d parser.parse_args()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"for f in args.files:"},{"line_number":28,"context_line":"    merge \u003d yaml.load(open(f))[\u0027assets\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def dict_merge(a, b):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_420a2ad4","line":28,"in_reply_to":"ba63e191_9cb60389","updated":"2016-01-20 16:55:58.000000000","message":"yes, this is true. at the moment, it is only ever used with one file. but could easily be extended to support multiple.","commit_id":"e8911b45e10bf6eaf72a4f4f2e25a85ada3a17da"},{"author":{"_account_id":8829,"name":"Ryan Moe","email":"rmoe@mirantis.com","username":"rmoe"},"change_message_id":"1e41beced49d5b67331971d6bb745ff9c31428d9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    for k, v in b.items():"},{"line_number":33,"context_line":"        if isinstance(v, dict):"},{"line_number":34,"context_line":"            n \u003d a.setdefault(k, {})"},{"line_number":35,"context_line":"            merge(v, n)"},{"line_number":36,"context_line":"        else:"},{"line_number":37,"context_line":"            a[k] \u003d v"},{"line_number":38,"context_line":"    return a"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_3ca6f753","line":35,"updated":"2016-01-19 23:44:40.000000000","message":"This won\u0027t work as merge is a list, not a function.","commit_id":"e8911b45e10bf6eaf72a4f4f2e25a85ada3a17da"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"3882df79b6088bf7c127e12f23d46f515f3da76e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    for k, v in b.items():"},{"line_number":33,"context_line":"        if isinstance(v, dict):"},{"line_number":34,"context_line":"            n \u003d a.setdefault(k, {})"},{"line_number":35,"context_line":"            merge(v, n)"},{"line_number":36,"context_line":"        else:"},{"line_number":37,"context_line":"            a[k] \u003d v"},{"line_number":38,"context_line":"    return a"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_621ace19","line":35,"in_reply_to":"ba63e191_3ca6f753","updated":"2016-01-20 16:55:58.000000000","message":"doh. copy paste error... should be dict_merge. For the last updated case, we never hit it. I\u0027ll fix.","commit_id":"e8911b45e10bf6eaf72a4f4f2e25a85ada3a17da"},{"author":{"_account_id":8829,"name":"Ryan Moe","email":"rmoe@mirantis.com","username":"rmoe"},"change_message_id":"1e41beced49d5b67331971d6bb745ff9c31428d9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if \u0027environment\u0027 in s:"},{"line_number":45,"context_line":"            s[\u0027environment\u0027] \u003d yaml.dump(s[\u0027environment\u0027])"},{"line_number":46,"context_line":"    if a[\u0027name\u0027] in merge:"},{"line_number":47,"context_line":"        dict_merge(a, merge[a[\u0027name\u0027]])"},{"line_number":48,"context_line":"y \u003d [a for a in y[\u0027assets\u0027] if a.get(\u0027active\u0027, True)]"},{"line_number":49,"context_line":"y \u003d {\u0027assets\u0027: y}"},{"line_number":50,"context_line":"json.dump(y, sys.stdout)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_576944bd","line":47,"updated":"2016-01-19 23:44:40.000000000","message":"If these \u0027merge\u0027 files passed in have the same format as assets.yaml won\u0027t a[\u0027name\u0027] be a string? If so then line 32 will result in an exception.","commit_id":"e8911b45e10bf6eaf72a4f4f2e25a85ada3a17da"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"3882df79b6088bf7c127e12f23d46f515f3da76e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if \u0027environment\u0027 in s:"},{"line_number":45,"context_line":"            s[\u0027environment\u0027] \u003d yaml.dump(s[\u0027environment\u0027])"},{"line_number":46,"context_line":"    if a[\u0027name\u0027] in merge:"},{"line_number":47,"context_line":"        dict_merge(a, merge[a[\u0027name\u0027]])"},{"line_number":48,"context_line":"y \u003d [a for a in y[\u0027assets\u0027] if a.get(\u0027active\u0027, True)]"},{"line_number":49,"context_line":"y \u003d {\u0027assets\u0027: y}"},{"line_number":50,"context_line":"json.dump(y, sys.stdout)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_42bb0ac5","line":47,"in_reply_to":"ba63e191_576944bd","updated":"2016-01-20 16:55:58.000000000","message":"no. the merge files are a hash keyed by name. The list with a name is a legacy feature of the assets.yaml file format, but name uniqueness is enforced by the tests so its guaranteed to be unique. So it was much easier/cleaner to just use a hash for merged in data rather then having to walk lists in multiple files and try and join them up by the name property.","commit_id":"e8911b45e10bf6eaf72a4f4f2e25a85ada3a17da"}]}
