)]}'
{"contrib/glare/openstack_app_catalog/artifacts.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e9b386bdcef8d514cd3a82279d8db81bd4ddef22","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    VERSION \u003d \u00270.1\u0027"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    fields \u003d {"},{"line_number":72,"context_line":"        \u0027depends\u0027: attribute(glare_fields.List,"},{"line_number":73,"context_line":"                             element_type\u003dglare_fields.Dependency,"},{"line_number":74,"context_line":"                             validators\u003d[],"},{"line_number":75,"context_line":"                             required_on_activate\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_fe15fbe4","line":72,"updated":"2016-07-25 19:15:19.000000000","message":"It seems that you are not using oslo.versionedobjects\u0027 ListOfObjectsField for things but are instead using a custom glare_fields.List field type, passing in a glare_fields.Dependency as the element type. Is there any reason you aren\u0027t just using the standard:\n\n \u0027depends\u0027: fields.ListOfObjectsField(\u0027Dependency\u0027),\n\nand make Dependency an object instead of a field?","commit_id":"8d19b59f6aade76a21d587b6a9510fa76dcb3d98"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e9b386bdcef8d514cd3a82279d8db81bd4ddef22","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                             validators\u003d[],"},{"line_number":87,"context_line":"                             required_on_activate\u003dFalse,"},{"line_number":88,"context_line":"                             element_type\u003dfields.String),"},{"line_number":89,"context_line":"        \u0027icon\u0027: attribute(glare_fields.Dict,"},{"line_number":90,"context_line":"                          validators\u003d[icon_validator],"},{"line_number":91,"context_line":"                          required_on_activate\u003dFalse,"},{"line_number":92,"context_line":"                          element_type\u003dfields.String),"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_fe5dfb15","line":89,"updated":"2016-07-25 19:15:19.000000000","message":"An icon is a Dict?","commit_id":"8d19b59f6aade76a21d587b6a9510fa76dcb3d98"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e9b386bdcef8d514cd3a82279d8db81bd4ddef22","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \u0027license_url\u0027: attribute(fields.StringField,"},{"line_number":97,"context_line":"                                 validators\u003d[],"},{"line_number":98,"context_line":"                                 required_on_activate\u003dFalse),"},{"line_number":99,"context_line":"        \u0027metadata\u0027: attribute(glare_fields.Dict,"},{"line_number":100,"context_line":"                              validators\u003d[],"},{"line_number":101,"context_line":"                              required_on_activate\u003dFalse,"},{"line_number":102,"context_line":"                              element_type\u003dfields.String),"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_5ed08753","line":99,"updated":"2016-07-25 19:15:19.000000000","message":"Having a free-form key/value dict of metadata on the base asset essentially defeats the purpose of using oslo.versionedobjects for your object representation. This field will never be able to store any information that is coupled with a version of the object\u0027s schema because it\u0027s totally free-form.","commit_id":"8d19b59f6aade76a21d587b6a9510fa76dcb3d98"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e9b386bdcef8d514cd3a82279d8db81bd4ddef22","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    fields \u003d {"},{"line_number":172,"context_line":"        \u0027environment\u0027: attribute(glare_fields.Dict,"},{"line_number":173,"context_line":"                                 required_on_activate\u003dFalse,"},{"line_number":174,"context_line":"                                 default\u003d{},"},{"line_number":175,"context_line":"                                 element_type\u003dfields.String),"},{"line_number":176,"context_line":"        \u0027template\u0027: attribute(glare_fields.BlobField,"},{"line_number":177,"context_line":"                              required_on_activate\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_dee75710","line":174,"updated":"2016-07-25 19:15:19.000000000","message":"Same comment about totally free-form dicts of things defeating the purpose of versioning the object in the first place :)","commit_id":"8d19b59f6aade76a21d587b6a9510fa76dcb3d98"}],"contrib/glare/setup.cfg":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"7fe2784ab2a08167226a3c3b323390bea9f502fa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"setup-hooks \u003d"},{"line_number":21,"context_line":"    pbr.hooks.setup_hook"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[entry_points]"},{"line_number":24,"context_line":"glance.artifacts.types \u003d"},{"line_number":25,"context_line":"    GlanceImageAsset \u003d assets.common:ASSETS"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"1aa78d24_27902eec","line":23,"updated":"2016-07-05 12:25:53.000000000","message":"It installs package into old Glare v0.1. To use it new v1 this section has to be omitted.","commit_id":"bf9a3cc26b32f4ef4a01ed9d2ebfb86d3f786702"}]}
