)]}'
{"diskimage-builder/elements/nginx-plus/element-deps":[{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"bfe52f055908bf455cd4bacff0472f60f69bd195","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apt-transport-https"},{"line_number":2,"context_line":"cloud-init-datasources"},{"line_number":3,"context_line":"source-repositories"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a2ca52d_6c794893","line":1,"updated":"2015-10-13 16:32:14.000000000","message":"apt-transport-https is a package, not an element. you\u0027re depending on an element that doesn\u0027t exist","commit_id":"3a0aa78b4a71811e1c60de3e5f466bf0ec2cea4b"}],"diskimage-builder/elements/nginx-plus/pre-install.d/01-nginx-plus":[{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"b6d2986e0408c09514c89a09d629b8b894ddfa38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# this is an install script for nginx plus"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# make nginx ssl dir"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a2fa921_79032674","line":1,"updated":"2015-10-06 17:38:49.000000000","message":"this should be \u0027#!/bin/bash -e\u0027 so that it fails the DIB build on any failure.","commit_id":"005a45cdbd1ae51e88998181278dbec759d76c7f"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"c4a4e5e09b6ba7f3e1eec4f05ad8b4d943a41520","unresolved":false,"context_lines":[{"line_number":8,"context_line":"wget https://cs.nginx.com/static/files/CA.crt -P /etc/ssl/nginx/"},{"line_number":9,"context_line":"wget http://nginx.org/keys/nginx_signing.key -P /etc/ssl/nginx/"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"apt-key add /etc/nginx/ssl/nginx_signing.key"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"printf \"deb https://plus-pkgs.nginx.com/debian `lsb_release -cs` nginx-plus\\n\" \u003e/etc/apt/sources.list.d/nginx-plus.list"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a2fa921_2419fe88","line":11,"updated":"2015-10-06 19:18:44.000000000","message":"you\u0027re wget\u0027ing to /etc/ssl/nginx but apt-key add\u0027ing from /etc/nginx/ssl","commit_id":"005a45cdbd1ae51e88998181278dbec759d76c7f"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"ce4b7fe60523b3a38015234c74e3a36f632aaf49","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# make nginx ssl dir"},{"line_number":5,"context_line":"mkdir /etc/ssl/nginx"},{"line_number":6,"context_line":"cp $(dirname $0)/../bin/* /etc/ssl/nginx/"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"wget https://cs.nginx.com/static/files/CA.crt -P /etc/ssl/nginx/"},{"line_number":9,"context_line":"wget http://nginx.org/keys/nginx_signing.key -P /etc/ssl/nginx/"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a2fa921_e03867a2","line":6,"updated":"2015-10-08 17:56:52.000000000","message":"We should be explicit about what is required and where to find it.  I think there should be new DIB_* env vars introduces here that hold the paths to the required certs and keys, allowing the build to fail if they are not specified correctly or not found.  You might also want to split this element into a pre-install.d and install.d--the pre-install.d would be responsible for installing certs and apt stuff, and install.d responsible for installing the actual package via package-installs-nginx-plus.","commit_id":"74d90c9aebfc8a04a54b8cff54671753865e658f"}]}