)]}'
{"astara/cli/router.py":[{"author":{"_account_id":986,"name":"Rosario Di Somma","email":"rosario.disomma@gmail.com","username":"mr-rods"},"change_message_id":"ac8870acee4bf71acd0e390dbb059cc6fbb98cb2","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            mgmt_ip_addr \u003d port[\u0027ports\u0027][0][\u0027fixed_ips\u0027].pop()[\u0027ip_address\u0027]"},{"line_number":169,"context_line":"        except (KeyError, IndexError):"},{"line_number":170,"context_line":"            raise ValueError(\u0027No router mgmt port with id %r found\u0027 %"},{"line_number":171,"context_line":"                             router_id)"},{"line_number":172,"context_line":"        try:"},{"line_number":173,"context_line":"            cmd \u003d [\"ssh\", \"astara@%s\" % mgmt_ip_addr] + parsed_args.remainder"},{"line_number":174,"context_line":"            subprocess.check_call(cmd)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_0a2d97fd","line":171,"range":{"start_line":170,"start_character":12,"end_line":171,"end_character":39},"updated":"2016-01-05 15:31:08.000000000","message":"One nit, the  error message makes it sound like the ID given is the port ID and that a mgmt port with that ID hasn\u0027t been found. We may want to make it a little more clear that a mgmt port hasn\u0027t been found for a router with the given ID","commit_id":"2a72bf5836eea4326518262a3fd11604583198b4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"355555dc6a59885bc1318cf7508ad064360ae41c","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            mgmt_ip_addr \u003d port[\u0027ports\u0027][0][\u0027fixed_ips\u0027].pop()[\u0027ip_address\u0027]"},{"line_number":169,"context_line":"        except (KeyError, IndexError):"},{"line_number":170,"context_line":"            raise ValueError(\u0027No router mgmt port with id %r found\u0027 %"},{"line_number":171,"context_line":"                             router_id)"},{"line_number":172,"context_line":"        try:"},{"line_number":173,"context_line":"            cmd \u003d [\"ssh\", \"astara@%s\" % mgmt_ip_addr] + parsed_args.remainder"},{"line_number":174,"context_line":"            subprocess.check_call(cmd)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_7d5dfc45","line":171,"range":{"start_line":170,"start_character":12,"end_line":171,"end_character":39},"in_reply_to":"fa69d971_0a2d97fd","updated":"2016-01-05 16:52:29.000000000","message":"What about \u0027No router management address found for router with id %s\u0027 ?","commit_id":"2a72bf5836eea4326518262a3fd11604583198b4"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"90927fd901e7dc62c05eb9a8bbb7b94106344fae","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            auth_strategy\u003dself.app.rug_ini.auth_strategy,"},{"line_number":163,"context_line":"            region_name\u003dself.app.rug_ini.auth_region,"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":"        router_id \u003d parsed_args.router_id.lower()"},{"line_number":166,"context_line":"        port \u003d n_c.list_ports(name\u003d\"ASTARA:MGT:%s\" % router_id)"},{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            mgmt_ip_addr \u003d port[\u0027ports\u0027][0][\u0027fixed_ips\u0027].pop()[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_c44d283f","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":17},"updated":"2016-01-05 19:42:17.000000000","message":"While you are poking around here, the Client instatation here is wrong. We should be using keystone sessions, can you update this to match how it gets created in the same file at line 73?  I couldn\u0027t get this to work with my config without updating it here.","commit_id":"367738cdfc37a7c19b7dda4d02292ef46f5b11d7"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"90927fd901e7dc62c05eb9a8bbb7b94106344fae","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        except (KeyError, IndexError):"},{"line_number":170,"context_line":"            raise ValueError(("},{"line_number":171,"context_line":"\t\t\t     \"No router management address found for router\""},{"line_number":172,"context_line":"\t\t\t     \" with id %s\") % router_id)"},{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            cmd \u003d [\"ssh\", \"astara@%s\" % mgmt_ip_addr] + parsed_args.remainder"},{"line_number":175,"context_line":"            subprocess.check_call(cmd)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_a4c35456","line":172,"range":{"start_line":172,"start_character":15,"end_line":172,"end_character":17},"updated":"2016-01-05 19:42:17.000000000","message":"This will cause a pep8 error. I\u0027d pull line 171 and 172 back so they\u0027re indented one tab from the \u0027raise\u0027 on line 170","commit_id":"367738cdfc37a7c19b7dda4d02292ef46f5b11d7"}]}