)]}'
{"astara/api/config/router.py":[{"author":{"_account_id":19278,"name":"Eric Lopez","email":"elopez@tricksters.net","username":"eric_lopez"},"change_message_id":"54e9a0ed22cee6fdcc272b32c9db6c608cd9e275","unresolved":false,"context_lines":[{"line_number":29,"context_line":"DEFAULT_AS \u003d 64512"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTIONS \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027provider_rules_path\u0027, default\u003d\u0027/etc/provider_rules.json\u0027),"},{"line_number":33,"context_line":"    cfg.IntOpt(\u0027asn\u0027, default\u003dDEFAULT_AS),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027neighbor_asn\u0027, default\u003dDEFAULT_AS),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_dd8d197d","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":74},"updated":"2016-01-11 22:19:11.000000000","message":"Shouldn\u0027t the default provider_rules_path be /etc/astara/provider_rules.json","commit_id":"6f5b5779db8cf038d9c118b49d660a1cc9d3245b"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"130f6704953f8536e805c5d66cabd0eb4af7311b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"DEFAULT_AS \u003d 64512"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTIONS \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027provider_rules_path\u0027, default\u003d\u0027/etc/provider_rules.json\u0027),"},{"line_number":33,"context_line":"    cfg.IntOpt(\u0027asn\u0027, default\u003dDEFAULT_AS),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027neighbor_asn\u0027, default\u003dDEFAULT_AS),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_d576ad3d","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":74},"in_reply_to":"fa69d971_dd8d197d","updated":"2016-01-12 19:48:02.000000000","message":"Agree /w eric here. Not sure theres a $CONF_DIR equiv. constant we could use, but happy to just hard-code the default.","commit_id":"6f5b5779db8cf038d9c118b49d660a1cc9d3245b"},{"author":{"_account_id":19951,"name":"xiayu","email":"1013230155@qq.com","username":"Xiayu"},"change_message_id":"440eadfb153862f269b378adb01bc3a4b3a47f93","unresolved":false,"context_lines":[{"line_number":29,"context_line":"DEFAULT_AS \u003d 64512"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTIONS \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027provider_rules_path\u0027, default\u003d\u0027/etc/provider_rules.json\u0027),"},{"line_number":33,"context_line":"    cfg.IntOpt(\u0027asn\u0027, default\u003dDEFAULT_AS),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027neighbor_asn\u0027, default\u003dDEFAULT_AS),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_de5fe173","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":74},"in_reply_to":"fa69d971_dd8d197d","updated":"2016-01-13 12:20:37.000000000","message":"Thank you for your remind！","commit_id":"6f5b5779db8cf038d9c118b49d660a1cc9d3245b"},{"author":{"_account_id":19278,"name":"Eric Lopez","email":"elopez@tricksters.net","username":"eric_lopez"},"change_message_id":"7d238df2a3b5f9a0eefb1df9755ca39e0241bd8e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"DEFAULT_AS \u003d 64512"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTIONS \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027provider_rules_path\u0027, default\u003d\u0027/etc/astara/provider_rules.json\u0027),"},{"line_number":33,"context_line":"    cfg.IntOpt(\u0027asn\u0027, default\u003dDEFAULT_AS),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027neighbor_asn\u0027, default\u003dDEFAULT_AS),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_f6b92916","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":81},"updated":"2016-01-14 02:20:09.000000000","message":"PEP8 error: line too long (81 \u003e 79 characters)","commit_id":"295c7f56f8386f98558548bb98f83e1c63d4575e"}],"astara/main.py":[{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"bfcfe88b6d8c5c805fa6f7c5a44a46cbd73ff387","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":47,"context_line":"               default\u003dsocket.getfqdn(),"},{"line_number":48,"context_line":"               help\u003d\"The hostname Astara is running on\"),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027plug_external_port\u0027, default\u003dFalse),"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":"CONF.register_opts(MAIN_OPTS)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_d558ed58","side":"PARENT","line":49,"range":{"start_line":49,"start_character":46,"end_line":49,"end_character":51},"updated":"2016-01-12 19:57:23.000000000","message":"We\u0027ve discussed this a bit and decided to make the default here False, and to eventually remove it.  Lets just keep it False for now.","commit_id":"b409224bf318a1c22b19fc4467f7d3b0fee65fd9"}],"devstack/plugin.sh":[{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"b5d9eb0a33e635db3a040a02248fc5a9a91822a4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    sudo mkdir -p $ASTARA_CACHE_DIR"},{"line_number":65,"context_line":"    sudo chown $STACK_USER $ASTARA_CACHE_DIR"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    (cd $ASTARA_DIR ;exec tools/generate_config_file_samples.sh)"},{"line_number":68,"context_line":"    cp $ASTARA_DIR/etc/orchestrator.ini.sample $ASTARA_CONF"},{"line_number":69,"context_line":"    cp $ASTARA_DIR/etc/provider_rules.json $ASTARA_PROVIDER_RULE_CONF"},{"line_number":70,"context_line":"    iniset $ASTARA_CONF DEFAULT verbose True"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da6ed579_957915ff","line":67,"range":{"start_line":67,"start_character":9,"end_line":67,"end_character":19},"updated":"2016-01-12 19:52:41.000000000","message":"Curious why we need to generate the config on the fly here, instead of using the version thats checked into git?  I think using the one thats checked into git is a good way to test changes to the sample, and doesn\u0027t modify the checked out git repo.","commit_id":"6f5b5779db8cf038d9c118b49d660a1cc9d3245b"},{"author":{"_account_id":19951,"name":"xiayu","email":"1013230155@qq.com","username":"Xiayu"},"change_message_id":"440eadfb153862f269b378adb01bc3a4b3a47f93","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    sudo mkdir -p $ASTARA_CACHE_DIR"},{"line_number":65,"context_line":"    sudo chown $STACK_USER $ASTARA_CACHE_DIR"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    (cd $ASTARA_DIR ;exec tools/generate_config_file_samples.sh)"},{"line_number":68,"context_line":"    cp $ASTARA_DIR/etc/orchestrator.ini.sample $ASTARA_CONF"},{"line_number":69,"context_line":"    cp $ASTARA_DIR/etc/provider_rules.json $ASTARA_PROVIDER_RULE_CONF"},{"line_number":70,"context_line":"    iniset $ASTARA_CONF DEFAULT verbose True"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da6ed579_2d1b1a1d","line":67,"range":{"start_line":67,"start_character":9,"end_line":67,"end_character":19},"in_reply_to":"da6ed579_957915ff","updated":"2016-01-13 12:20:37.000000000","message":"You are right, there is no need to generate the config file indeed.\nBecause we still need to run tox -e genconfig manually after we modify or add a config.","commit_id":"6f5b5779db8cf038d9c118b49d660a1cc9d3245b"}],"etc/orchestrator.ini.sample":[{"author":{"_account_id":19278,"name":"Eric Lopez","email":"elopez@tricksters.net","username":"eric_lopez"},"change_message_id":"54e9a0ed22cee6fdcc272b32c9db6c608cd9e275","unresolved":false,"context_lines":[{"line_number":110,"context_line":"#hash_partition_exponent \u003d 5"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# (string value)"},{"line_number":113,"context_line":"#provider_rules_path \u003d /etc/provider_rules.json"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# (integer value)"},{"line_number":116,"context_line":"#asn \u003d 64512"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa69d971_486b7b1e","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":47},"updated":"2016-01-11 22:19:11.000000000","message":"should be /etc/astara/provider_rules.json","commit_id":"6f5b5779db8cf038d9c118b49d660a1cc9d3245b"}]}