)]}'
{"automaton/machines.py":[{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"c04af5a55843778bd28ba9e4dd3b943998777d15","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        current \u003d self._current"},{"line_number":151,"context_line":"        if current is None:"},{"line_number":152,"context_line":"            return False"},{"line_number":153,"context_line":"        if self._states[current.name][\u0027terminal\u0027]:"},{"line_number":154,"context_line":"            return False"},{"line_number":155,"context_line":"        if event not in self._transitions[current.name]:"},{"line_number":156,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_48ee16ee","line":153,"updated":"2015-06-24 14:54:57.000000000","message":"a terminal state wouldn\u0027t/shouldn\u0027t have any valid transitions, is it worth doing this explicit check or is it simpler to have just the transition check?","commit_id":"1049d639eed862e89dc427c30a9029cbc914e5ab"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"6df2946b1ae970a391620cda58793bd538d9aae4","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        current \u003d self._current"},{"line_number":151,"context_line":"        if current is None:"},{"line_number":152,"context_line":"            return False"},{"line_number":153,"context_line":"        if self._states[current.name][\u0027terminal\u0027]:"},{"line_number":154,"context_line":"            return False"},{"line_number":155,"context_line":"        if event not in self._transitions[current.name]:"},{"line_number":156,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_df9177f2","line":153,"in_reply_to":"fa32b979_48ee16ee","updated":"2015-06-24 17:27:31.000000000","message":"hmmm, good point, probably is worth doing an explict check on add","commit_id":"1049d639eed862e89dc427c30a9029cbc914e5ab"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"46da14cc3fa7b70c664ed5bc18e62eaff1d67da9","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        current \u003d self._current"},{"line_number":151,"context_line":"        if current is None:"},{"line_number":152,"context_line":"            return False"},{"line_number":153,"context_line":"        if self._states[current.name][\u0027terminal\u0027]:"},{"line_number":154,"context_line":"            return False"},{"line_number":155,"context_line":"        if event not in self._transitions[current.name]:"},{"line_number":156,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_6c8d1930","line":153,"in_reply_to":"fa32b979_df9177f2","updated":"2015-06-24 22:54:48.000000000","message":"added explicit check @ https://review.openstack.org/#/c/195323/ will make this review depend on that, so we can remove this check","commit_id":"1049d639eed862e89dc427c30a9029cbc914e5ab"}]}