)]}'
{"automaton/machines.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"245e15511e25842986c2091ebae00b5f2fe299e3","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if self._states[start][\u0027terminal\u0027]:"},{"line_number":194,"context_line":"            raise excp.InvalidState(\"Can not add a transition from terminal\""},{"line_number":195,"context_line":"                                    \" state \u0027%s\u0027 to state \u0027%s\u0027 on event \u0027%s\u0027\""},{"line_number":196,"context_line":"                                    % (start, end, event))"},{"line_number":197,"context_line":"        self._transitions[start][event] \u003d _Jump(end,"},{"line_number":198,"context_line":"                                                self._states[end][\u0027on_enter\u0027],"},{"line_number":199,"context_line":"                                                self._states[start][\u0027on_exit\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_913ac633","line":196,"updated":"2015-06-25 20:48:18.000000000","message":"I wonder if we should just say \u0027Can not add a transition from terminal state \u0027%s\u0027 because it is a terminal state.\u0027\n\nie, regardless of the event or end state.\n\nOr \u0027Transitions are not allowed from state \u0027%s\u0027 because it is a terminal state.\u0027 ?\n\nBut maybe we want to mention what they were trying to do too. So we could make this longer. \u0027Transitions are not allowed from terminal states, so can not add a transition from ... \u003crest of your msg\u003e\u0027.","commit_id":"b3abdf2d83f8f588fb9588e3ab69af45795e89d5"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"db59fde58e8db70f2c2f8c65ecb05d7f2587253c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if self._states[start][\u0027terminal\u0027]:"},{"line_number":194,"context_line":"            raise excp.InvalidState(\"Can not add a transition from terminal\""},{"line_number":195,"context_line":"                                    \" state \u0027%s\u0027 to state \u0027%s\u0027 on event \u0027%s\u0027\""},{"line_number":196,"context_line":"                                    % (start, end, event))"},{"line_number":197,"context_line":"        self._transitions[start][event] \u003d _Jump(end,"},{"line_number":198,"context_line":"                                                self._states[end][\u0027on_enter\u0027],"},{"line_number":199,"context_line":"                                                self._states[start][\u0027on_exit\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_66e9631a","line":196,"in_reply_to":"ba3cc151_302394bf","updated":"2015-06-29 19:58:51.000000000","message":"Done","commit_id":"b3abdf2d83f8f588fb9588e3ab69af45795e89d5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e639c9a1a43c425f9699f56c59fd91a88665d391","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if self._states[start][\u0027terminal\u0027]:"},{"line_number":194,"context_line":"            raise excp.InvalidState(\"Can not add a transition from terminal\""},{"line_number":195,"context_line":"                                    \" state \u0027%s\u0027 to state \u0027%s\u0027 on event \u0027%s\u0027\""},{"line_number":196,"context_line":"                                    % (start, end, event))"},{"line_number":197,"context_line":"        self._transitions[start][event] \u003d _Jump(end,"},{"line_number":198,"context_line":"                                                self._states[end][\u0027on_enter\u0027],"},{"line_number":199,"context_line":"                                                self._states[start][\u0027on_exit\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_302394bf","line":196,"in_reply_to":"fa32b979_5a017203","updated":"2015-06-29 18:16:38.000000000","message":"I don\u0027t think the other messages need to be updated. Unless they don\u0027t know what \u0027undefined state\u0027 means.\n\nI was just concerned here that with this message, they won\u0027t know what the problem is -- if it is due to the start state, end state, or event. The point here is that the start state is a terminal state.\n\nHmm. So what about \"Can not add a transition on event \u0027%s\u0027 that starts in the terminal state \u0027%s\u0027\". This seems more in line with the formats above :)","commit_id":"b3abdf2d83f8f588fb9588e3ab69af45795e89d5"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d1e4499cc375f1666b8540d43d4e40fb2f5027b1","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if self._states[start][\u0027terminal\u0027]:"},{"line_number":194,"context_line":"            raise excp.InvalidState(\"Can not add a transition from terminal\""},{"line_number":195,"context_line":"                                    \" state \u0027%s\u0027 to state \u0027%s\u0027 on event \u0027%s\u0027\""},{"line_number":196,"context_line":"                                    % (start, end, event))"},{"line_number":197,"context_line":"        self._transitions[start][event] \u003d _Jump(end,"},{"line_number":198,"context_line":"                                                self._states[end][\u0027on_enter\u0027],"},{"line_number":199,"context_line":"                                                self._states[start][\u0027on_exit\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_5a017203","line":196,"in_reply_to":"fa32b979_913ac633","updated":"2015-06-27 18:13:58.000000000","message":"We could, I was just trying to stick with the format that is already used, instead of changing all of them, maybe if u want u can change them in a follow-up commit?","commit_id":"b3abdf2d83f8f588fb9588e3ab69af45795e89d5"}]}