)]}'
{"automaton/machines.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a9a76223c518a1fbf401d12dd460eb19e344234c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    #: The result of processing an event (cause and effect...)"},{"line_number":68,"context_line":"    Effect \u003d collections.namedtuple(\u0027Effect\u0027, \u0027reaction,terminal\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def _effect_builder(cls, new_state, event):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_450a878b","line":68,"updated":"2015-07-08 22:03:35.000000000","message":"Would be nice to doc what a \u0027reaction\u0027 and a \u0027terminal\u0027 are.","commit_id":"6f5e2360b244bcc0e7ff9abecab6e89f5f84c59b"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ad50245f513a7889a9461cf18de1a342da1be7c0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    #: The result of processing an event (cause and effect...)"},{"line_number":68,"context_line":"    Effect \u003d collections.namedtuple(\u0027Effect\u0027, \u0027reaction,terminal\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def _effect_builder(cls, new_state, event):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_f6beafd2","line":68,"in_reply_to":"ba3cc151_450a878b","updated":"2015-07-09 21:20:21.000000000","message":"Ya, for that I need to remove usage of namedtuple, since afaik it doesn\u0027t support specifying \u0027custom\u0027 docstrings for each of the items.","commit_id":"6f5e2360b244bcc0e7ff9abecab6e89f5f84c59b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"68b92fd890ce012fe27018fed648d37087cda321","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    #: The result of processing an event (cause and effect...)"},{"line_number":68,"context_line":"    Effect \u003d collections.namedtuple(\u0027Effect\u0027, \u0027reaction,terminal\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def _effect_builder(cls, new_state, event):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_b1ab5187","line":68,"in_reply_to":"ba3cc151_f6beafd2","updated":"2015-07-09 21:40:47.000000000","message":"oh, nothing fancey. i meant you could just add a \u0027# reaction is ..., terminal is ...\u0027 above this :)","commit_id":"6f5e2360b244bcc0e7ff9abecab6e89f5f84c59b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a9a76223c518a1fbf401d12dd460eb19e344234c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                  contains items which can be examined to react to the"},{"line_number":223,"context_line":"                  new stable state that was arrived at (either by calling"},{"line_number":224,"context_line":"                  into the returned reaction callback or by doing something"},{"line_number":225,"context_line":"                  else)"},{"line_number":226,"context_line":"        :rtype: namedtuple"},{"line_number":227,"context_line":"        \"\"\""},{"line_number":228,"context_line":"        self._pre_process_event(event)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_a5f91382","line":225,"updated":"2015-07-08 22:03:35.000000000","message":"being picky -- this is a really long sentence. might want to break it up.\n\nAlso, \u0027either by calling into the returned reaction callback\u0027 -- you mean via the Effect.reaction item in the returned tuple, right?","commit_id":"6f5e2360b244bcc0e7ff9abecab6e89f5f84c59b"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"aa6400c2cb0bea07ce690415ff2eaa8ab5a79784","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                  contains items which can be examined to react to the"},{"line_number":223,"context_line":"                  new stable state that was arrived at (either by calling"},{"line_number":224,"context_line":"                  into the returned reaction callback or by doing something"},{"line_number":225,"context_line":"                  else)"},{"line_number":226,"context_line":"        :rtype: namedtuple"},{"line_number":227,"context_line":"        \"\"\""},{"line_number":228,"context_line":"        self._pre_process_event(event)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_bcb1f302","line":225,"in_reply_to":"ba3cc151_a5f91382","updated":"2015-07-09 18:00:26.000000000","message":"Right.","commit_id":"6f5e2360b244bcc0e7ff9abecab6e89f5f84c59b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a9a76223c518a1fbf401d12dd460eb19e344234c","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        :rtype: namedtuple"},{"line_number":385,"context_line":"        \"\"\""},{"line_number":386,"context_line":"        # This method exists just to change the docstring (perhaps there"},{"line_number":387,"context_line":"        # is a better way to do this?)"},{"line_number":388,"context_line":"        return super(HierarchicalFiniteMachine, self).process_event(event)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def add_state(self, state,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_e5087b82","line":387,"updated":"2015-07-08 22:03:35.000000000","message":"Yeah, doesn\u0027t seem right to be putting this here just for the docstring.\n\nWhat about something like :returns: namedtuple \u0027Effect\u0027. \n\nUmm... guess I need to understand a bit more. Are classes supposed to override Effect \u0026 have an _effect_builder(), or can they use an inherited Effect?","commit_id":"6f5e2360b244bcc0e7ff9abecab6e89f5f84c59b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"699006bab51420675b57d0c38db7f51d05b8eb64","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        :rtype: namedtuple"},{"line_number":385,"context_line":"        \"\"\""},{"line_number":386,"context_line":"        # This method exists just to change the docstring (perhaps there"},{"line_number":387,"context_line":"        # is a better way to do this?)"},{"line_number":388,"context_line":"        return super(HierarchicalFiniteMachine, self).process_event(event)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def add_state(self, state,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_9cff4f33","line":387,"in_reply_to":"ba3cc151_3cc64368","updated":"2015-07-09 18:16:44.000000000","message":"ok, how about getting rid of this one, and for the FiniteMachine.process_event() above, something like\n\n:returns: named tuple Effect -- this is either :py:class:`~.FiniteMachine.Effect` or from a subclass of FiniteMachine. See the appropriate named tuple for a description of the actual items in the tuple. For example, FiniteMachine.Effect\u0027s first item is \u0027reaction\u0027: one could invoke this reaction\u0027s callback to react to the new stable state.\n\nWell, I don\u0027t really know what I\u0027m talking about, but hopefully you get the point...","commit_id":"6f5e2360b244bcc0e7ff9abecab6e89f5f84c59b"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"29e611242cb0071733655ae3e2f9083ecfd87dcf","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        :rtype: namedtuple"},{"line_number":385,"context_line":"        \"\"\""},{"line_number":386,"context_line":"        # This method exists just to change the docstring (perhaps there"},{"line_number":387,"context_line":"        # is a better way to do this?)"},{"line_number":388,"context_line":"        return super(HierarchicalFiniteMachine, self).process_event(event)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def add_state(self, state,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_b6dd8742","line":387,"in_reply_to":"ba3cc151_9cff4f33","updated":"2015-07-09 21:15:08.000000000","message":"Sure, sounds fine with me :)","commit_id":"6f5e2360b244bcc0e7ff9abecab6e89f5f84c59b"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"aa6400c2cb0bea07ce690415ff2eaa8ab5a79784","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        :rtype: namedtuple"},{"line_number":385,"context_line":"        \"\"\""},{"line_number":386,"context_line":"        # This method exists just to change the docstring (perhaps there"},{"line_number":387,"context_line":"        # is a better way to do this?)"},{"line_number":388,"context_line":"        return super(HierarchicalFiniteMachine, self).process_event(event)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def add_state(self, state,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_3cc64368","line":387,"in_reply_to":"ba3cc151_e5087b82","updated":"2015-07-09 18:00:26.000000000","message":"They can do either.","commit_id":"6f5e2360b244bcc0e7ff9abecab6e89f5f84c59b"}]}
