)]}'
{"plugins/insecure_ssl_tls.py":[{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"8e671339f99a442625e83ed358b26f419f03b975","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def get_bad_proto_versions(config):"},{"line_number":22,"context_line":"    ipdb.set_trace()"},{"line_number":23,"context_line":"    bad_ssl_versions \u003d [\u0027PROTOCOL_SSLv2\u0027,"},{"line_number":24,"context_line":"                        \u0027PROTOCOL_SSLv23\u0027,"},{"line_number":25,"context_line":"                        \u0027SSLv2_METHOD\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_70c81275","line":22,"updated":"2014-09-22 14:56:22.000000000","message":"Residual debug command?","commit_id":"8671e26189e844c896cb4822c3181962a31c18ca"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"520204fc73976c46d7fb9679031e6e36a66644ab","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def get_bad_proto_versions(config):"},{"line_number":22,"context_line":"    ipdb.set_trace()"},{"line_number":23,"context_line":"    bad_ssl_versions \u003d [\u0027PROTOCOL_SSLv2\u0027,"},{"line_number":24,"context_line":"                        \u0027PROTOCOL_SSLv23\u0027,"},{"line_number":25,"context_line":"                        \u0027SSLv2_METHOD\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_7093b2fa","line":22,"in_reply_to":"da9df570_70c81275","updated":"2014-09-22 15:07:48.000000000","message":"bah, missed that one, good catch.","commit_id":"8671e26189e844c896cb4822c3181962a31c18ca"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"8e671339f99a442625e83ed358b26f419f03b975","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def get_bad_proto_versions(config):"},{"line_number":22,"context_line":"    ipdb.set_trace()"},{"line_number":23,"context_line":"    bad_ssl_versions \u003d [\u0027PROTOCOL_SSLv2\u0027,"},{"line_number":24,"context_line":"                        \u0027PROTOCOL_SSLv23\u0027,"},{"line_number":25,"context_line":"                        \u0027SSLv2_METHOD\u0027,"},{"line_number":26,"context_line":"                        \u0027SSLv23_METHOD\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_909c966b","line":23,"updated":"2014-09-22 14:56:22.000000000","message":"Other option could be to move these out to config / bandit.yaml, but the strict flag approach is a nice middle road - some central configuration, but also keeping the test-specific detail here.  Works for me.","commit_id":"8671e26189e844c896cb4822c3181962a31c18ca"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"bb4d6f9fffa5e6754b2360eb92cc6e2c3a993886","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def get_bad_proto_versions(config):"},{"line_number":22,"context_line":"    ipdb.set_trace()"},{"line_number":23,"context_line":"    bad_ssl_versions \u003d [\u0027PROTOCOL_SSLv2\u0027,"},{"line_number":24,"context_line":"                        \u0027PROTOCOL_SSLv23\u0027,"},{"line_number":25,"context_line":"                        \u0027SSLv2_METHOD\u0027,"},{"line_number":26,"context_line":"                        \u0027SSLv23_METHOD\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_93ee60eb","line":23,"in_reply_to":"da9df570_104a6680","updated":"2014-09-22 15:27:40.000000000","message":"I could see people wanting to define different SSL versions as bad for different run environments.  I\u0027m in favor of moving it to config.","commit_id":"8671e26189e844c896cb4822c3181962a31c18ca"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"520204fc73976c46d7fb9679031e6e36a66644ab","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def get_bad_proto_versions(config):"},{"line_number":22,"context_line":"    ipdb.set_trace()"},{"line_number":23,"context_line":"    bad_ssl_versions \u003d [\u0027PROTOCOL_SSLv2\u0027,"},{"line_number":24,"context_line":"                        \u0027PROTOCOL_SSLv23\u0027,"},{"line_number":25,"context_line":"                        \u0027SSLv2_METHOD\u0027,"},{"line_number":26,"context_line":"                        \u0027SSLv23_METHOD\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_104a6680","line":23,"in_reply_to":"da9df570_909c966b","updated":"2014-09-22 15:07:48.000000000","message":"cool, I did think about putting the details into the config, but as you say it is test specific... I guess I\u0027ll leave it like this unless anyone else wants to voice an opinion on this.","commit_id":"8671e26189e844c896cb4822c3181962a31c18ca"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"8e671339f99a442625e83ed358b26f419f03b975","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                             \u0027PROTOCOL_TLSv1\u0027,"},{"line_number":30,"context_line":"                             \u0027SSLv3_METHOD\u0027,"},{"line_number":31,"context_line":"                             \u0027TLSv1_METHOD\u0027]"},{"line_number":32,"context_line":"    #if really_strict:"},{"line_number":33,"context_line":"    #    the default is SSLv23, we should moan about that ...."},{"line_number":34,"context_line":"    #    However, it\u0027s ok with NO_SSLv2 option added. Also it\u0027s"},{"line_number":35,"context_line":"    #    ok if its a client and the server isn\u0027t silly."}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_109fc653","line":32,"updated":"2014-09-22 14:56:22.000000000","message":"Comment looks like it\u0027s dated and can be removed?  I don\u0027t see really_strict being referred to elsewhere.","commit_id":"8671e26189e844c896cb4822c3181962a31c18ca"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"520204fc73976c46d7fb9679031e6e36a66644ab","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                             \u0027PROTOCOL_TLSv1\u0027,"},{"line_number":30,"context_line":"                             \u0027SSLv3_METHOD\u0027,"},{"line_number":31,"context_line":"                             \u0027TLSv1_METHOD\u0027]"},{"line_number":32,"context_line":"    #if really_strict:"},{"line_number":33,"context_line":"    #    the default is SSLv23, we should moan about that ...."},{"line_number":34,"context_line":"    #    However, it\u0027s ok with NO_SSLv2 option added. Also it\u0027s"},{"line_number":35,"context_line":"    #    ok if its a client and the server isn\u0027t silly."}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_30b04a8b","line":32,"in_reply_to":"da9df570_109fc653","updated":"2014-09-22 15:07:48.000000000","message":"this was designed to get a discussion going during review. Is it worth checking for the default, given the points below?","commit_id":"8671e26189e844c896cb4822c3181962a31c18ca"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"b7389d2e91f0486ab398e1af3935682bfd7e0725","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                             \u0027PROTOCOL_TLSv1\u0027,"},{"line_number":30,"context_line":"                             \u0027SSLv3_METHOD\u0027,"},{"line_number":31,"context_line":"                             \u0027TLSv1_METHOD\u0027]"},{"line_number":32,"context_line":"    #if really_strict:"},{"line_number":33,"context_line":"    #    the default is SSLv23, we should moan about that ...."},{"line_number":34,"context_line":"    #    However, it\u0027s ok with NO_SSLv2 option added. Also it\u0027s"},{"line_number":35,"context_line":"    #    ok if its a client and the server isn\u0027t silly."}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_d617f6a1","line":32,"in_reply_to":"da9df570_30b04a8b","updated":"2014-09-22 16:08:28.000000000","message":"Checking for that NO_SSLv2 option will be awkward with bandit in its current state.  I\u0027d be inclined to just report the default usage for investigation at a lower priority (WARN or INFO).","commit_id":"8671e26189e844c896cb4822c3181962a31c18ca"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"98d9655f6fdc634807909fa32a60bebca66d06c8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                             \u0027PROTOCOL_TLSv1\u0027,"},{"line_number":30,"context_line":"                             \u0027SSLv3_METHOD\u0027,"},{"line_number":31,"context_line":"                             \u0027TLSv1_METHOD\u0027]"},{"line_number":32,"context_line":"    #if really_strict:"},{"line_number":33,"context_line":"    #    the default is SSLv23, we should moan about that ...."},{"line_number":34,"context_line":"    #    However, it\u0027s ok with NO_SSLv2 option added. Also it\u0027s"},{"line_number":35,"context_line":"    #    ok if its a client and the server isn\u0027t silly."}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_c1a1eeaa","line":32,"in_reply_to":"da9df570_d617f6a1","updated":"2014-09-22 16:34:17.000000000","message":"yes, thats a good fit","commit_id":"8671e26189e844c896cb4822c3181962a31c18ca"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"02bec06724d51a00afd8c0e079ab7457e8f269fe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    if (context.call_function_name_qual \u003d\u003d \u0027ssl.wrap_socket\u0027):"},{"line_number":29,"context_line":"        if context.check_call_arg_value(\u0027ssl_version\u0027) in bad_ssl_versions:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"            return(bandit.ERROR, \u0027ssl.wrap_socket call with insecure ssl/tls\u0027"},{"line_number":32,"context_line":"                   \u0027 protocol version identified, security issue.  %s\u0027 %"},{"line_number":33,"context_line":"                   context.call_args_string)"},{"line_number":34,"context_line":"    elif (context.call_function_name_qual \u003d\u003d \u0027SSL.Context\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_b2d5feba","line":31,"updated":"2014-09-23 13:42:17.000000000","message":"capital ssl/tls","commit_id":"d429306971bade8d158f1c0a03900be3e1df5b0e"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"02bec06724d51a00afd8c0e079ab7457e8f269fe","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    elif (context.call_function_name_qual \u003d\u003d \u0027SSL.Context\u0027):"},{"line_number":35,"context_line":"        if context.check_call_arg_value(\u0027method\u0027) in bad_ssl_versions:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"            return(bandit.ERROR, \u0027SSL.Context call with insecure ssl/tls\u0027"},{"line_number":38,"context_line":"                   \u0027 protocol version identified, security issue.  %s\u0027 %"},{"line_number":39,"context_line":"                   context.call_args_string)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_52ef7287","line":37,"updated":"2014-09-23 13:42:17.000000000","message":"capital ssl/tls","commit_id":"d429306971bade8d158f1c0a03900be3e1df5b0e"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"02bec06724d51a00afd8c0e079ab7457e8f269fe","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                   \u0027 protocol version identified, security issue.  %s\u0027 %"},{"line_number":39,"context_line":"                   context.call_args_string)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    elif context.call_function_name_qual !\u003d \u0027ssl.wrap_socket\u0027 and \\"},{"line_number":42,"context_line":"       context.call_function_name_qual !\u003d \u0027SSL.Context\u0027:"},{"line_number":43,"context_line":"        if context.check_call_arg_value(\u0027method\u0027) in bad_ssl_versions or \\"},{"line_number":44,"context_line":"           context.check_call_arg_value(\u0027ssl_version\u0027) in bad_ssl_versions:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_7299d61e","line":41,"updated":"2014-09-23 13:42:17.000000000","message":"pep hates \u0027\\\u0027 for new line, it prefers wrapping the function in \u0027( )\u0027","commit_id":"d429306971bade8d158f1c0a03900be3e1df5b0e"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"02bec06724d51a00afd8c0e079ab7457e8f269fe","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    elif context.call_function_name_qual !\u003d \u0027ssl.wrap_socket\u0027 and \\"},{"line_number":42,"context_line":"       context.call_function_name_qual !\u003d \u0027SSL.Context\u0027:"},{"line_number":43,"context_line":"        if context.check_call_arg_value(\u0027method\u0027) in bad_ssl_versions or \\"},{"line_number":44,"context_line":"           context.check_call_arg_value(\u0027ssl_version\u0027) in bad_ssl_versions:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            return(bandit.WARN, \u0027Function call with insecure ssl/tls \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_d289a2cb","line":43,"updated":"2014-09-23 13:42:17.000000000","message":"same thing about pep \u0027\\\u0027","commit_id":"d429306971bade8d158f1c0a03900be3e1df5b0e"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"02bec06724d51a00afd8c0e079ab7457e8f269fe","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if context.check_call_arg_value(\u0027method\u0027) in bad_ssl_versions or \\"},{"line_number":44,"context_line":"           context.check_call_arg_value(\u0027ssl_version\u0027) in bad_ssl_versions:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            return(bandit.WARN, \u0027Function call with insecure ssl/tls \u0027"},{"line_number":47,"context_line":"                   \u0027protocol identified, possible security issue.  %s\u0027 %"},{"line_number":48,"context_line":"                   context.call_args_string)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_f2fdc63c","line":46,"updated":"2014-09-23 13:42:17.000000000","message":"capital ssl/tls","commit_id":"d429306971bade8d158f1c0a03900be3e1df5b0e"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"3fd7b257c46562b2474b60f83e9c1a7ecfbf3629","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        if context.check_call_arg_value(\u0027ssl_version\u0027) is None:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            return(bandit.INFO, \u0027ssl.wrap_socket call with no ssl/tls\u0027"},{"line_number":57,"context_line":"                   \u0027 protocol version specified, the defualt SSLv23 could be\u0027"},{"line_number":58,"context_line":"                   \u0027 insecure, possible security issue.  %s\u0027 %"},{"line_number":59,"context_line":"                   context.call_args_string)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_e372567b","line":57,"updated":"2014-09-23 14:46:04.000000000","message":"typo \u0027defualt\u0027","commit_id":"d429306971bade8d158f1c0a03900be3e1df5b0e"}]}
