)]}'
{"bandit/core/node_visitor.py":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"b5631180b844e26270c9060f1f14c8c7b9c42d85","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    module + \".\" + nodename.name"},{"line_number":145,"context_line":"                )"},{"line_number":146,"context_line":"            else:"},{"line_number":147,"context_line":"                # Even if import is not aliased we need entry that maps"},{"line_number":148,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027 b should"},{"line_number":149,"context_line":"                # be aliased to the qualified name a.b"},{"line_number":150,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + nodename.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_44113bab","line":147,"updated":"2015-01-29 16:06:48.000000000","message":"*an entry that maps","commit_id":"808ce2e5e291244fc105f37189bd2f0d8a40574b"},{"author":{"_account_id":14692,"name":"Lucas Fisher","email":"lucas.fisher@gmail.com","username":"lucas.fisher"},"change_message_id":"17143db316c3c8c8cc694f0afe61c606c9d1e401","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    module + \".\" + nodename.name"},{"line_number":145,"context_line":"                )"},{"line_number":146,"context_line":"            else:"},{"line_number":147,"context_line":"                # Even if import is not aliased we need entry that maps"},{"line_number":148,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027 b should"},{"line_number":149,"context_line":"                # be aliased to the qualified name a.b"},{"line_number":150,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + nodename.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_5a4cb642","line":147,"in_reply_to":"fa81d914_44113bab","updated":"2015-01-29 16:39:23.000000000","message":"Done","commit_id":"808ce2e5e291244fc105f37189bd2f0d8a40574b"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"b5631180b844e26270c9060f1f14c8c7b9c42d85","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                # Even if import is not aliased we need entry that maps"},{"line_number":148,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027 b should"},{"line_number":149,"context_line":"                # be aliased to the qualified name a.b"},{"line_number":150,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + nodename.name"},{"line_number":151,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":152,"context_line":"            self.context[\u0027module\u0027] \u003d module"},{"line_number":153,"context_line":"            self.context[\u0027name\u0027] \u003d nodename.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_240e078e","line":150,"updated":"2015-01-29 16:06:48.000000000","message":"in this case, if we have\n\nfrom a import b \nfrom c import b\n\nthe a.b import will be discarded, won\u0027t it?","commit_id":"808ce2e5e291244fc105f37189bd2f0d8a40574b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"465c73edca20c66676b27948aa3cf7cc234bdf74","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                # Even if import is not aliased we need entry that maps"},{"line_number":148,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027 b should"},{"line_number":149,"context_line":"                # be aliased to the qualified name a.b"},{"line_number":150,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + nodename.name"},{"line_number":151,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":152,"context_line":"            self.context[\u0027module\u0027] \u003d module"},{"line_number":153,"context_line":"            self.context[\u0027name\u0027] \u003d nodename.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_e405cf7a","line":150,"updated":"2015-01-29 16:06:42.000000000","message":"please wrap lines at 79 chars","commit_id":"808ce2e5e291244fc105f37189bd2f0d8a40574b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"496006d60d070bebf832ebf366c182611a2b4bf2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                # Even if import is not aliased we need entry that maps"},{"line_number":148,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027 b should"},{"line_number":149,"context_line":"                # be aliased to the qualified name a.b"},{"line_number":150,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + nodename.name"},{"line_number":151,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":152,"context_line":"            self.context[\u0027module\u0027] \u003d module"},{"line_number":153,"context_line":"            self.context[\u0027name\u0027] \u003d nodename.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_a482f791","line":150,"in_reply_to":"fa81d914_240e078e","updated":"2015-01-29 16:10:16.000000000","message":"it looks to me like that will happen, and it is mentioned in the commit message from Lucas. I don\u0027t think its enough of a problem to stop this merging, since this is much better than not having the names recorded at all, but I would like to see a TODO comment about it at least.","commit_id":"808ce2e5e291244fc105f37189bd2f0d8a40574b"},{"author":{"_account_id":14692,"name":"Lucas Fisher","email":"lucas.fisher@gmail.com","username":"lucas.fisher"},"change_message_id":"17143db316c3c8c8cc694f0afe61c606c9d1e401","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                # Even if import is not aliased we need entry that maps"},{"line_number":148,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027 b should"},{"line_number":149,"context_line":"                # be aliased to the qualified name a.b"},{"line_number":150,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + nodename.name"},{"line_number":151,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":152,"context_line":"            self.context[\u0027module\u0027] \u003d module"},{"line_number":153,"context_line":"            self.context[\u0027name\u0027] \u003d nodename.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_9a91ce9b","line":150,"in_reply_to":"fa81d914_a482f791","updated":"2015-01-29 16:39:23.000000000","message":"I think this would have happened before with aliases.  If you defined something with the same name as the alias it would be masked by the alias from bandit\u0027s perspective. I\u0027ll add a TODO.","commit_id":"808ce2e5e291244fc105f37189bd2f0d8a40574b"},{"author":{"_account_id":14692,"name":"Lucas Fisher","email":"lucas.fisher@gmail.com","username":"lucas.fisher"},"change_message_id":"17143db316c3c8c8cc694f0afe61c606c9d1e401","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                # Even if import is not aliased we need entry that maps"},{"line_number":148,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027 b should"},{"line_number":149,"context_line":"                # be aliased to the qualified name a.b"},{"line_number":150,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + nodename.name"},{"line_number":151,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":152,"context_line":"            self.context[\u0027module\u0027] \u003d module"},{"line_number":153,"context_line":"            self.context[\u0027name\u0027] \u003d nodename.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_9a562ed1","line":150,"in_reply_to":"fa81d914_e405cf7a","updated":"2015-01-29 16:39:23.000000000","message":"Done","commit_id":"808ce2e5e291244fc105f37189bd2f0d8a40574b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"e71852506749ff7bc2f79b376d0b316183972d31","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            return self.visit_Import(node)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        for nodename in node.names:"},{"line_number":142,"context_line":"            # TODO Names in import_aliases could be overridden by local"},{"line_number":143,"context_line":"            #      definitions. If this occurs bandit will see the name"},{"line_number":144,"context_line":"            #      in import_aliases instead of the local definition."},{"line_number":145,"context_line":"            #      We need better tracking of names."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_9a30ee02","line":142,"updated":"2015-01-29 16:49:13.000000000","message":"sorry to be nit picking on this, please use the format TODO(name): .... \nPEP8 checks will catch this and fail.","commit_id":"9382c2134b0c3afb74a30ee845ae8326418f6479"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"e71852506749ff7bc2f79b376d0b316183972d31","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                # Even if import is not aliased we need an entry that maps"},{"line_number":152,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027"},{"line_number":153,"context_line":"                # b should be aliased to the qualified name a.b"},{"line_number":154,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + \\"},{"line_number":155,"context_line":"                                                                 nodename.name"},{"line_number":156,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":157,"context_line":"            self.context[\u0027module\u0027] \u003d module"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_fc0ac71f","line":154,"updated":"2015-01-29 16:49:13.000000000","message":"please don\u0027t use \u0027\\\u0027 to wrap lines, its bad practice. Please use \u0027(\u0027 and \u0027)\u0027 as show at line 147","commit_id":"9382c2134b0c3afb74a30ee845ae8326418f6479"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"b52fd5cdd24f041f950115510cdc98e97a99795a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                # Even if import is not aliased we need an entry that maps"},{"line_number":152,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027"},{"line_number":153,"context_line":"                # b should be aliased to the qualified name a.b"},{"line_number":154,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + \\"},{"line_number":155,"context_line":"                                                                 nodename.name"},{"line_number":156,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":157,"context_line":"            self.context[\u0027module\u0027] \u003d module"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_3c3b7fd2","line":154,"updated":"2015-01-29 16:47:45.000000000","message":"sorry - nit.  Please don\u0027t wrap lines with \u0027\\\u0027, pip doesn\u0027t like it.  Use parens instead","commit_id":"9382c2134b0c3afb74a30ee845ae8326418f6479"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"be120413d45c3b399dd74e5c6f193aa835682589","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027"},{"line_number":153,"context_line":"                # b should be aliased to the qualified name a.b"},{"line_number":154,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d module + \u0027.\u0027 + \\"},{"line_number":155,"context_line":"                                                                 nodename.name"},{"line_number":156,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":157,"context_line":"            self.context[\u0027module\u0027] \u003d module"},{"line_number":158,"context_line":"            self.context[\u0027name\u0027] \u003d nodename.name"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_1c5ddbe9","line":155,"updated":"2015-01-29 16:50:39.000000000","message":"PEP doesn\u0027t like it even :)","commit_id":"9382c2134b0c3afb74a30ee845ae8326418f6479"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"95c6d2567a5019d744d9cdf0ad76f80dc62545d3","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                # Even if import is not aliased we need an entry that maps"},{"line_number":152,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027"},{"line_number":153,"context_line":"                # b should be aliased to the qualified name a.b"},{"line_number":154,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d (module + \u0027.\u0027 + "},{"line_number":155,"context_line":"                                                                 nodename.name)"},{"line_number":156,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":157,"context_line":"            self.context[\u0027module\u0027] \u003d module"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_5ce3d304","line":154,"updated":"2015-01-29 16:52:25.000000000","message":"whitespace :/","commit_id":"3b32fcae84fca55e4351bfd678b180b5ca726ccc"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"673dba49abedec0081aa1a4fcc519180fe6a6e04","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                # Even if import is not aliased we need an entry that maps"},{"line_number":152,"context_line":"                # name to module.name.  For example, with \u0027from a import b\u0027"},{"line_number":153,"context_line":"                # b should be aliased to the qualified name a.b"},{"line_number":154,"context_line":"                self.context[\u0027import_aliases\u0027][nodename.name] \u003d (module + \u0027.\u0027 + "},{"line_number":155,"context_line":"                                                                 nodename.name)"},{"line_number":156,"context_line":"            self.context[\u0027imports\u0027].add(module + \".\" + nodename.name)"},{"line_number":157,"context_line":"            self.context[\u0027module\u0027] \u003d module"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_bc904f44","line":154,"in_reply_to":"fa81d914_5ce3d304","updated":"2015-01-29 16:54:15.000000000","message":"yeah, please remove the trailing whitespace. Sorry to be so pedantic but the stylistic checks enforce PEP8 compliance (also its a good thing :) )","commit_id":"3b32fcae84fca55e4351bfd678b180b5ca726ccc"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6954d8331221d21bf2882cafa399b5ab45ba66a1","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            return self.visit_Import(node)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        for nodename in node.names:"},{"line_number":142,"context_line":"            # TODO Names in import_aliases could be overridden by local"},{"line_number":143,"context_line":"            #      definitions. If this occurs bandit will see the name"},{"line_number":144,"context_line":"            #      in import_aliases instead of the local definition."},{"line_number":145,"context_line":"            #      We need better tracking of names."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_0211f004","line":142,"updated":"2015-01-29 17:33:42.000000000","message":"you need to use TODO(name): ....","commit_id":"1a82dc7ba306fbce329998c53de1aef3705630ac"}]}
