)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactored AST processing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"AST now Parses by statement."},{"line_number":10,"context_line":"Added StatementBuffer class to manage statement processing."},{"line_number":11,"context_line":"Fixed a bug with multi-line numbering, moved to statement object."},{"line_number":12,"context_line":"Updated sql injection test to implement statement context knowledge POC."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba7be1f8_8d6b371d","line":9,"updated":"2015-03-03 04:29:01.000000000","message":"Can you bullet this list using \"-\" character?","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"a6f2998c40f9247ff2755aa90279e96981bb4116","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- Added node_visitor unit tests"},{"line_number":14,"context_line":"- Completed test_node_visitor StatementBuffer coverage"},{"line_number":15,"context_line":"- Added docstrings"},{"line_number":16,"context_line":"- fixed a bug processing try/except constructs"},{"line_number":17,"context_line":"- fixed reporting to only display the affected line number"},{"line_number":18,"context_line":"- updated reporting to use dicts rather than tuples"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a80dd14_13e522a8","line":16,"updated":"2015-03-04 15:43:19.000000000","message":"Super nit, match case","commit_id":"4467fd8fbbc567ea3c8db0a2e13d7e7016ca95a2"}],"bandit/core/context.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        if \u0027statement\u0027 in self._context:"},{"line_number":158,"context_line":"            return self._context[\u0027statement\u0027]"},{"line_number":159,"context_line":"        else:"},{"line_number":160,"context_line":"            return None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @property"},{"line_number":163,"context_line":"    def function_def_defaults_qual(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_0d67474e","line":160,"updated":"2015-03-03 04:29:01.000000000","message":"None is actually the default return of functions, so this statement is redundant.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5cf0dd68be3fe7cf9ea09765cfab9dc27aff599c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        if \u0027statement\u0027 in self._context:"},{"line_number":158,"context_line":"            return self._context[\u0027statement\u0027]"},{"line_number":159,"context_line":"        else:"},{"line_number":160,"context_line":"            return None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @property"},{"line_number":163,"context_line":"    def function_def_defaults_qual(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_14d5871b","line":160,"in_reply_to":"ba7be1f8_0d67474e","updated":"2015-03-03 09:14:34.000000000","message":"True, this is syntactically redundant, however I personally think that it is better to explicitly state you are returning None. That way it\u0027s distinguishable from simply forgetting to return a value.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8d1eb7e163f6e47a6298a071161260dc913324e8","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        if \u0027statement\u0027 in self._context:"},{"line_number":158,"context_line":"            return self._context[\u0027statement\u0027]"},{"line_number":159,"context_line":"        else:"},{"line_number":160,"context_line":"            return None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @property"},{"line_number":163,"context_line":"    def function_def_defaults_qual(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_29705f71","line":160,"in_reply_to":"ba7be1f8_14d5871b","updated":"2015-03-03 16:28:32.000000000","message":"I mention it because I haven\u0027t seen most openstack projects explicitly return the None.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"419749fd8f35cf7a4c705dc8675786a5e6a446f3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        if \u0027statement\u0027 in self._context:"},{"line_number":158,"context_line":"            return self._context[\u0027statement\u0027]"},{"line_number":159,"context_line":"        else:"},{"line_number":160,"context_line":"            return None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @property"},{"line_number":163,"context_line":"    def function_def_defaults_qual(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_89deab0f","line":160,"in_reply_to":"ba7be1f8_29705f71","updated":"2015-03-03 16:33:49.000000000","message":"I\u0027d favor explicitly stating the return value here also","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"4590886c10428df75f0951fc9ce46afc39b973f1","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        :param argument_name: A string - name of the argument to look for"},{"line_number":247,"context_line":"        :return: Integer - the line number of the found argument"},{"line_number":248,"context_line":"        \u0027\u0027\u0027"},{"line_number":249,"context_line":"        for key in self.node.keywords:"},{"line_number":250,"context_line":"            if key.arg is argument_name:"},{"line_number":251,"context_line":"                self._context[\u0027lineno\u0027] \u003d key.value.lineno"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_d7d8c855","line":249,"updated":"2015-03-04 20:32:57.000000000","message":"probably need to add a check here to make sure the node has keywords?","commit_id":"282285f83fb42d5ccea9e575a5a64dc7fcb5e97a"}],"bandit/core/node_visitor.py":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"24109b0b80fad20970a2b2fa55af3da8fa59fe60","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class StatementBuffer():"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self):"},{"line_number":27,"context_line":"        self._buffer \u003d []"},{"line_number":28,"context_line":"        self.file_len \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_efe9391b","line":25,"updated":"2015-03-02 09:28:33.000000000","message":"please add docstring describing use of statement buffer. I know other stuff in here is missing docstrings but its worth doing.","commit_id":"ee4741e75f0f805f043c74837393dd75cf07fd31"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"24109b0b80fad20970a2b2fa55af3da8fa59fe60","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def load_buffer(self, fdata):"},{"line_number":31,"context_line":"        # Read the file as lines, so we can store the length of the file"},{"line_number":32,"context_line":"        # so we don\u0027t lose multi-line statements at the bottom of the target"},{"line_number":33,"context_line":"        # file"},{"line_number":34,"context_line":"        lines \u003d fdata.readlines()"},{"line_number":35,"context_line":"        self.file_len \u003d len(lines)"},{"line_number":36,"context_line":"        f_ast \u003d ast.parse(\"\".join(lines))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4ff7a5f5","line":33,"updated":"2015-03-02 09:28:33.000000000","message":"please transform this comment into a docstring","commit_id":"ee4741e75f0f805f043c74837393dd75cf07fd31"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"24109b0b80fad20970a2b2fa55af3da8fa59fe60","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        f_ast \u003d ast.parse(\"\".join(lines))"},{"line_number":37,"context_line":"        self._buffer \u003d f_ast.body"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_next(self):"},{"line_number":40,"context_line":"        if(len(self._buffer) \u003e 0):"},{"line_number":41,"context_line":"            # Update the context, and shift the next statement off the array"},{"line_number":42,"context_line":"            statement \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6fdd4970","line":39,"updated":"2015-03-02 09:28:33.000000000","message":"please add docstring","commit_id":"ee4741e75f0f805f043c74837393dd75cf07fd31"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"24109b0b80fad20970a2b2fa55af3da8fa59fe60","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self._buffer \u003d f_ast.body"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_next(self):"},{"line_number":40,"context_line":"        if(len(self._buffer) \u003e 0):"},{"line_number":41,"context_line":"            # Update the context, and shift the next statement off the array"},{"line_number":42,"context_line":"            statement \u003d {}"},{"line_number":43,"context_line":"            statement[\u0027node\u0027] \u003d self._buffer[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6f262918","line":40,"updated":"2015-03-02 09:28:33.000000000","message":"no need for the \u0027()\u0027 here, just \u0027if len(self._buffer):\u0027 is fine","commit_id":"ee4741e75f0f805f043c74837393dd75cf07fd31"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"24109b0b80fad20970a2b2fa55af3da8fa59fe60","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            statement \u003d {}"},{"line_number":43,"context_line":"            statement[\u0027node\u0027] \u003d self._buffer[0]"},{"line_number":44,"context_line":"            statement[\u0027lineno\u0027] \u003d self.linenumber_range(statement[\u0027node\u0027])"},{"line_number":45,"context_line":"            if(len(self._buffer) \u003e 1):"},{"line_number":46,"context_line":"                self._buffer \u003d self._buffer[1:]"},{"line_number":47,"context_line":"            else:"},{"line_number":48,"context_line":"                self._buffer \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_af2021f8","line":45,"updated":"2015-03-02 09:28:33.000000000","message":"no need for this conditional, just \u0027self._buffer \u003d self._buffer[1:]\u0027 will do the right thing","commit_id":"ee4741e75f0f805f043c74837393dd75cf07fd31"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"24109b0b80fad20970a2b2fa55af3da8fa59fe60","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            return statement"},{"line_number":50,"context_line":"        return None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def linenumber_range(self, node):"},{"line_number":53,"context_line":"        lines \u003d set()"},{"line_number":54,"context_line":"        for n in ast.walk(node):"},{"line_number":55,"context_line":"            if hasattr(n, \u0027lineno\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_8fd8bd80","line":52,"updated":"2015-03-02 09:28:33.000000000","message":"please add docstring","commit_id":"ee4741e75f0f805f043c74837393dd75cf07fd31"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"24109b0b80fad20970a2b2fa55af3da8fa59fe60","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        self.logger.debug(\"%s\\texiting : %s\" % (self.depth, hex(id(node))))"},{"line_number":263,"context_line":"        return self.score"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def process(self, fdata):"},{"line_number":266,"context_line":"        self.stmt_buffer.load_buffer(fdata)"},{"line_number":267,"context_line":"        self.statement \u003d self.stmt_buffer.get_next()"},{"line_number":268,"context_line":"        while self.statement is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4fcec5b5","line":265,"updated":"2015-03-02 09:28:33.000000000","message":"please add docstring","commit_id":"ee4741e75f0f805f043c74837393dd75cf07fd31"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"57990441a7efd9bd5e967eae3f891ca8584f92f7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027\u0027\u0027Buffer for code statements"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Creates a buffer to store a code file as individual statements"},{"line_number":28,"context_line":"    for AST processing"},{"line_number":29,"context_line":"    :param: -"},{"line_number":30,"context_line":"    :return: -"},{"line_number":31,"context_line":"    \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_e0c30655","line":28,"updated":"2015-03-02 10:32:25.000000000","message":"no need for param and return on a class docstring, the concepts don\u0027t exist for classes.","commit_id":"19595b80c7714dec968b76d5acb4f763c5c336b0"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"cfb52ec23ae1e22cbbf4b3d718ee5130f88d1c86","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            statement \u003d {}"},{"line_number":56,"context_line":"            statement[\u0027node\u0027] \u003d self._buffer[0]"},{"line_number":57,"context_line":"            statement[\u0027lineno\u0027] \u003d self.linenumber_range(statement[\u0027node\u0027])"},{"line_number":58,"context_line":"            self._buffer \u003d self._buffer[1:]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            return statement"},{"line_number":61,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_ace2e42c","line":58,"updated":"2015-03-02 13:15:57.000000000","message":"I think you\u0027re looking for self._buffer.pop() :)","commit_id":"d26c594bd8c7e170ce76eb283c9400e500b301d4"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"cfb52ec23ae1e22cbbf4b3d718ee5130f88d1c86","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            self.logger.debug(\u0027s_node: %s\u0027 % ast.dump(self.statement[\u0027node\u0027]))"},{"line_number":296,"context_line":"            self.logger.debug(\u0027s_lineno: %s\u0027 % self.statement[\u0027lineno\u0027])"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"            self.visit(self.statement[\u0027node\u0027])"},{"line_number":299,"context_line":"            self.statement \u003d self.stmt_buffer.get_next()"},{"line_number":300,"context_line":"        return self.score"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_cca1d8aa","line":298,"updated":"2015-03-02 13:15:57.000000000","message":"Hmmmm, I could be wrong here, but my understanding is that we don\u0027t have to call visit directly, by extending the ast.NodeVisitor class we get this for free.","commit_id":"d26c594bd8c7e170ce76eb283c9400e500b301d4"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"06e70a2080f311f7994d052cc621072f0fec2783","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                stmt.body.extend(tmp_buf)"},{"line_number":63,"context_line":"                tmp_buf \u003d stmt.body"},{"line_number":64,"context_line":"                stmt.body \u003d []"},{"line_number":65,"context_line":"            if (isinstance(stmt, ast.For)"},{"line_number":66,"context_line":"                    or isinstance(stmt, ast.While)"},{"line_number":67,"context_line":"                    or isinstance(stmt, ast.If)"},{"line_number":68,"context_line":"                    or isinstance(stmt, ast.TryExcept)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_3420e7af","line":65,"updated":"2015-03-02 18:48:38.000000000","message":"this would be more efficient as \u0027elif\u0027","commit_id":"45293dd68a2fbf3869ab4ead4d1122c296a14416"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"06e70a2080f311f7994d052cc621072f0fec2783","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                stmt.body.extend(tmp_buf)"},{"line_number":71,"context_line":"                tmp_buf \u003d stmt.body"},{"line_number":72,"context_line":"                stmt.body \u003d []"},{"line_number":73,"context_line":"            if (isinstance(stmt, ast.TryFinally)):"},{"line_number":74,"context_line":"                stmt.body.extend(stmt.finalbody)"},{"line_number":75,"context_line":"                stmt.body.extend(tmp_buf)"},{"line_number":76,"context_line":"                tmp_buf \u003d stmt.body"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_d4122b61","line":73,"updated":"2015-03-02 18:48:38.000000000","message":"this would be more efficient  as \u0027elif\u0027","commit_id":"45293dd68a2fbf3869ab4ead4d1122c296a14416"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"1e7f02adda8c08cf3cd5740e5b36769fb8bdab0d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # isolation"},{"line_number":49,"context_line":"        tmp_buf \u003d f_ast.body"},{"line_number":50,"context_line":"        while len(tmp_buf):"},{"line_number":51,"context_line":"            # For each statement, if it is one of the special statement"},{"line_number":52,"context_line":"            # types which contain a body, we first update the tmp_buf"},{"line_number":53,"context_line":"            # adding the internal body statements to the beginning of"},{"line_number":54,"context_line":"            # the temporary buffer, then clear the body of the special"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_5252c467","line":51,"updated":"2015-03-02 22:15:22.000000000","message":"I \u003c3 this comment","commit_id":"c00bbefcfd3dadbda0d9f8660c095e8bffc8078b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \u0027\u0027\u0027"},{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":"        self._buffer \u003d []"},{"line_number":32,"context_line":"        self.file_len \u003d 0"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def load_buffer(self, fdata):"},{"line_number":35,"context_line":"        \u0027\u0027\u0027Buffer initialization"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_ad555b1f","line":32,"updated":"2015-03-03 04:29:01.000000000","message":"I think this statement isn\u0027t needed since file_len is only used in load_buffer and its set to len(lines) there.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5cf0dd68be3fe7cf9ea09765cfab9dc27aff599c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \u0027\u0027\u0027"},{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":"        self._buffer \u003d []"},{"line_number":32,"context_line":"        self.file_len \u003d 0"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def load_buffer(self, fdata):"},{"line_number":35,"context_line":"        \u0027\u0027\u0027Buffer initialization"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_34bd2bb8","line":32,"in_reply_to":"ba7be1f8_ad555b1f","updated":"2015-03-03 09:14:34.000000000","message":"+1","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                stmt.orelse \u003d []"},{"line_number":73,"context_line":"            elif (isinstance(stmt, ast.TryExcept)):"},{"line_number":74,"context_line":"                for handler in stmt.handlers:"},{"line_number":75,"context_line":"                    stmt.body.extend(handler.body)"},{"line_number":76,"context_line":"                stmt.body.extend(stmt.orelse)"},{"line_number":77,"context_line":"                stmt.body.extend(tmp_buf)"},{"line_number":78,"context_line":"                tmp_buf \u003d stmt.body"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_4debff77","line":75,"updated":"2015-03-03 04:29:01.000000000","message":"Looks like a nice place to use map() or list comprehension.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            statement[\u0027lineno\u0027] \u003d self.linenumber_range(statement[\u0027node\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            return statement"},{"line_number":109,"context_line":"        return None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def linenumber_range(self, node):"},{"line_number":112,"context_line":"        \u0027\u0027\u0027Get set of line numbers for statement"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_6d55234f","line":109,"updated":"2015-03-03 04:29:01.000000000","message":"This is the default value of a function, so you don\u0027t have to explicitly return None.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        :return lines: A set of line numbers"},{"line_number":118,"context_line":"        \u0027\u0027\u0027"},{"line_number":119,"context_line":"        lines \u003d set()"},{"line_number":120,"context_line":"        for n in ast.walk(node):"},{"line_number":121,"context_line":"            if hasattr(n, \u0027lineno\u0027):"},{"line_number":122,"context_line":"                lines.add(n.lineno)"},{"line_number":123,"context_line":"        return sorted(lines)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_6db1a38e","line":120,"updated":"2015-03-03 04:29:01.000000000","message":"Looks like a good place to utilize filter(function, iterable)","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                        \u0027imports\u0027: None, \u0027import_aliases\u0027: None, \u0027call\u0027: None,"},{"line_number":141,"context_line":"                        \u0027function\u0027: None}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    stmt_buffer \u003d None"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __init__(self, fname, logger, config, metaast, results, testset,"},{"line_number":146,"context_line":"                 debug):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_0d6ae7ed","line":143,"updated":"2015-03-03 04:29:01.000000000","message":"Don\u0027t think this is needed. In your __init__ you set to StatementBuffer anyway.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5cf0dd68be3fe7cf9ea09765cfab9dc27aff599c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                        \u0027imports\u0027: None, \u0027import_aliases\u0027: None, \u0027call\u0027: None,"},{"line_number":141,"context_line":"                        \u0027function\u0027: None}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    stmt_buffer \u003d None"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __init__(self, fname, logger, config, metaast, results, testset,"},{"line_number":146,"context_line":"                 debug):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_74aec399","line":143,"in_reply_to":"ba7be1f8_0d6ae7ed","updated":"2015-03-03 09:14:34.000000000","message":"Yeah, this line is redundent","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self.stmt_buffer.load_buffer(fdata)"},{"line_number":340,"context_line":"        self.statement \u003d self.stmt_buffer.get_next()"},{"line_number":341,"context_line":"        while self.statement is not None:"},{"line_number":342,"context_line":"            self.logger.debug(\u0027New statement loaded\u0027)"},{"line_number":343,"context_line":"            self.logger.debug(\u0027s_node: %s\u0027 % ast.dump(self.statement[\u0027node\u0027]))"},{"line_number":344,"context_line":"            self.logger.debug(\u0027s_lineno: %s\u0027 % self.statement[\u0027lineno\u0027])"},{"line_number":345,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_0d510736","line":342,"updated":"2015-03-03 04:29:01.000000000","message":"Its probably not necessary to pass in the logger as parm to class.  The logger can be loaded by name as part of this module.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5cf0dd68be3fe7cf9ea09765cfab9dc27aff599c","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self.stmt_buffer.load_buffer(fdata)"},{"line_number":340,"context_line":"        self.statement \u003d self.stmt_buffer.get_next()"},{"line_number":341,"context_line":"        while self.statement is not None:"},{"line_number":342,"context_line":"            self.logger.debug(\u0027New statement loaded\u0027)"},{"line_number":343,"context_line":"            self.logger.debug(\u0027s_node: %s\u0027 % ast.dump(self.statement[\u0027node\u0027]))"},{"line_number":344,"context_line":"            self.logger.debug(\u0027s_lineno: %s\u0027 % self.statement[\u0027lineno\u0027])"},{"line_number":345,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_c79c236d","line":342,"in_reply_to":"ba7be1f8_0d510736","updated":"2015-03-03 09:14:34.000000000","message":"Yeah, it would be cleaner not to pass in the logger, though considering thats how it works right now I\u0027m happy to let this stand. We should look at cleaning it up in a future patch though.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"}],"bandit/core/result_store.py":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"a6f2998c40f9247ff2755aa90279e96981bb4116","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        linerange \u003d context[\u0027statement\u0027][\u0027linerange\u0027]"},{"line_number":71,"context_line":"        (issue_type, issue_text) \u003d issue"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # XXX(fletcher): tuple usage is fragile because ordering changes on"},{"line_number":74,"context_line":"        # agg_type; ordering is important for reporting"},{"line_number":75,"context_line":"        if self.agg_type \u003d\u003d \u0027vuln\u0027:"},{"line_number":76,"context_line":"            if test in self.resstore:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_8809e12e","line":73,"updated":"2015-03-04 15:43:19.000000000","message":"since you\u0027ve fixed the tuple usage you can remove this comment","commit_id":"4467fd8fbbc567ea3c8db0a2e13d7e7016ca95a2"}],"bandit/plugins/injection_shell.py":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"4590886c10428df75f0951fc9ce46afc39b973f1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    if context.call_function_name_qual !\u003d \u0027subprocess.Popen\u0027:"},{"line_number":41,"context_line":"        if context.check_call_arg_value(\u0027shell\u0027) \u003d\u003d \u0027True\u0027:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            context.set_lineno_for_call_arg(\u0027shell\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"            return(bandit.WARN, \u0027Function call with shell\u003dTrue \u0027"},{"line_number":46,"context_line":"                   \u0027parameter identified, possible security issue.  %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_97c5705d","line":43,"updated":"2015-03-04 20:32:57.000000000","message":"I don\u0027t think this is the right place.  We really don\u0027t want tests to have to worry about (or rely on them to) set things in context.  They should only worry about consuming context if they want.","commit_id":"282285f83fb42d5ccea9e575a5a64dc7fcb5e97a"}],"bandit/plugins/injection_sql.py":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"24109b0b80fad20970a2b2fa55af3da8fa59fe60","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    elif isinstance(statement, ast.Expr):"},{"line_number":49,"context_line":"        test_str \u003d \"\""},{"line_number":50,"context_line":"        if isinstance(statement.value, ast.Call):"},{"line_number":51,"context_line":"            test_str \u003d \"\""},{"line_number":52,"context_line":"            for arg in statement.value.args:"},{"line_number":53,"context_line":"                test_str +\u003d helper_ast_build_string(arg).lower() + \" \""},{"line_number":54,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_efba19e0","line":51,"updated":"2015-03-02 09:28:33.000000000","message":"unneeded second \"test_str \u003d \"\"\"?","commit_id":"ee4741e75f0f805f043c74837393dd75cf07fd31"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"cfb52ec23ae1e22cbbf4b3d718ee5130f88d1c86","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def helper_ast_build_string(data):"},{"line_number":22,"context_line":"    if isinstance(data, ast.Str):"},{"line_number":23,"context_line":"        return data.s"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    if isinstance(data, ast.BinOp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_4cd168fa","line":22,"updated":"2015-03-02 13:15:57.000000000","message":"If this is a helper method, please prepend with \u0027_\u0027.","commit_id":"d26c594bd8c7e170ce76eb283c9400e500b301d4"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"cfb52ec23ae1e22cbbf4b3d718ee5130f88d1c86","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def helper_ast_binop_stringify(data):"},{"line_number":36,"context_line":"    left \u003d data.left"},{"line_number":37,"context_line":"    right \u003d data.right"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    return helper_ast_build_string(left) + helper_ast_build_string(right)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_ccdd5816","line":36,"updated":"2015-03-02 13:15:57.000000000","message":"If this is a helper method, please prepend with \u0027_\u0027.  \n\nAlso, I\u0027d like to see a comment here explaining when we need to use this function.","commit_id":"d26c594bd8c7e170ce76eb283c9400e500b301d4"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"8a0cd4815a7fbc80545888da26fb8411b616c2e8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from bandit.core.test_properties import *"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def _ast_build_string(data):"},{"line_number":22,"context_line":"    # used to return a string representation of AST data"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    if isinstance(data, ast.Str):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_e99715ea","line":21,"updated":"2015-03-03 22:43:03.000000000","message":"This helper function seems generically useful; should it be moved out into core/utils.py, rather than defined within the test file?","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"37d2c5cfee82ff082d3b28fed5b6ea9f66006164","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from bandit.core.test_properties import *"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def _ast_build_string(data):"},{"line_number":22,"context_line":"    # used to return a string representation of AST data"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    if isinstance(data, ast.Str):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_3abcc06c","line":21,"in_reply_to":"ba7be1f8_e99715ea","updated":"2015-03-04 12:47:55.000000000","message":"Yeah, Jamie is right.  If this is something other tests should/can use, we should move it to utils.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"8a0cd4815a7fbc80545888da26fb8411b616c2e8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    return \"XXX\"  # placeholder for unaccounted for values"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _ast_binop_stringify(data):"},{"line_number":40,"context_line":"    # used to recursively build a string from a binary operation"},{"line_number":41,"context_line":"    left \u003d data.left"},{"line_number":42,"context_line":"    right \u003d data.right"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_299e8d07","line":39,"updated":"2015-03-03 22:43:03.000000000","message":"This helper function seems generically useful; should it be moved out into core/utils.py, rather than defined within the test file?","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"37d2c5cfee82ff082d3b28fed5b6ea9f66006164","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    return \"XXX\"  # placeholder for unaccounted for values"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _ast_binop_stringify(data):"},{"line_number":40,"context_line":"    # used to recursively build a string from a binary operation"},{"line_number":41,"context_line":"    left \u003d data.left"},{"line_number":42,"context_line":"    right \u003d data.right"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_7ab6388c","line":39,"in_reply_to":"ba7be1f8_299e8d07","updated":"2015-03-04 12:47:55.000000000","message":"+1","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        test_str \u003d context.string_val.lower()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if ("},{"line_number":62,"context_line":"        (test_str.startswith(\u0027select \u0027) and \u0027 from \u0027 in test_str) or"},{"line_number":63,"context_line":"        test_str.startswith(\u0027insert into\u0027) or"},{"line_number":64,"context_line":"        (test_str.startswith(\u0027update \u0027) and \u0027 set \u0027 in test_str) or"},{"line_number":65,"context_line":"        test_str.startswith(\u0027delete from \u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_90118a54","line":62,"updated":"2015-03-03 04:29:01.000000000","message":"You can move this line up","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        test_str.startswith(\u0027insert into\u0027) or"},{"line_number":64,"context_line":"        (test_str.startswith(\u0027update \u0027) and \u0027 set \u0027 in test_str) or"},{"line_number":65,"context_line":"        test_str.startswith(\u0027delete from \u0027)"},{"line_number":66,"context_line":"    ):"},{"line_number":67,"context_line":"        # if sqlalchemy is not imported and it looks like they are using SQL"},{"line_number":68,"context_line":"        # statements, mark it as a WARNING"},{"line_number":69,"context_line":"        if not context.is_module_imported_like(\"sqlalchemy\"):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_301e1e60","line":66,"updated":"2015-03-03 04:29:01.000000000","message":"You can move this up one line at end of last conditional.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8d1eb7e163f6e47a6298a071161260dc913324e8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        test_str.startswith(\u0027insert into\u0027) or"},{"line_number":64,"context_line":"        (test_str.startswith(\u0027update \u0027) and \u0027 set \u0027 in test_str) or"},{"line_number":65,"context_line":"        test_str.startswith(\u0027delete from \u0027)"},{"line_number":66,"context_line":"    ):"},{"line_number":67,"context_line":"        # if sqlalchemy is not imported and it looks like they are using SQL"},{"line_number":68,"context_line":"        # statements, mark it as a WARNING"},{"line_number":69,"context_line":"        if not context.is_module_imported_like(\"sqlalchemy\"):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_c9c7c396","line":66,"in_reply_to":"ba7be1f8_27541ffe","updated":"2015-03-03 16:28:32.000000000","message":"No this was just for style.  Within openstack projects usually the conditional block would be like\n\nif ((test_str.......\n     .....\n    ......\n    .....\n    test_str.startswith....)):","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5cf0dd68be3fe7cf9ea09765cfab9dc27aff599c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        test_str.startswith(\u0027insert into\u0027) or"},{"line_number":64,"context_line":"        (test_str.startswith(\u0027update \u0027) and \u0027 set \u0027 in test_str) or"},{"line_number":65,"context_line":"        test_str.startswith(\u0027delete from \u0027)"},{"line_number":66,"context_line":"    ):"},{"line_number":67,"context_line":"        # if sqlalchemy is not imported and it looks like they are using SQL"},{"line_number":68,"context_line":"        # statements, mark it as a WARNING"},{"line_number":69,"context_line":"        if not context.is_module_imported_like(\"sqlalchemy\"):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_27541ffe","line":66,"in_reply_to":"ba7be1f8_301e1e60","updated":"2015-03-03 09:14:34.000000000","message":"Your trying to group the \u0027starts with\u0027 tests higher up than the \u0027starts with and contains\u0027 tests? That wont be any more efficient, since only one \u0027starts with\u0027 predicate can be satisfied, regardless of any \u0027and contains\u0027 logic attached to it ... or am I missing something?","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"}],"tests/test_node_visitor.py":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"24109b0b80fad20970a2b2fa55af3da8fa59fe60","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # Check buffer contains 10 statements"},{"line_number":37,"context_line":"        self.assertEqual(len(self.buf._buffer), 10)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_get_next(self):"},{"line_number":40,"context_line":"        # Check get_next returns an AST statement"},{"line_number":41,"context_line":"        stmt \u003d self.buf.get_next()"},{"line_number":42,"context_line":"        self.assertTrue(isinstance(stmt[\u0027node\u0027], ast.AST))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_8fcc3d63","line":39,"updated":"2015-03-02 09:28:33.000000000","message":"please add a test for get_next when the buffer is empty","commit_id":"ee4741e75f0f805f043c74837393dd75cf07fd31"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"57990441a7efd9bd5e967eae3f891ca8584f92f7","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(StatementBufferTests, self).setUp()"},{"line_number":28,"context_line":"        self.f \u003d open(\"./examples/jinja2_templating.py\")"},{"line_number":29,"context_line":"        self.buf \u003d node_visitor.StatementBuffer()"},{"line_number":30,"context_line":"        self.buf.load_buffer(self.f)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_40ff7267","line":28,"updated":"2015-03-02 10:32:25.000000000","message":"I would prefer a more informative name than just \u0027f\u0027, maybe data_file, or just file","commit_id":"19595b80c7714dec968b76d5acb4f763c5c336b0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"dc5e5be07f3efbde82ffd083e8262d916dc53cb9","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_get_next_empty(self):"},{"line_number":59,"context_line":"        # Check get_next on an empty buffer returns None"},{"line_number":60,"context_line":"        # self.f has already been read, so is empty file handle"},{"line_number":61,"context_line":"        self.buf.load_buffer(self.test_file)"},{"line_number":62,"context_line":"        stmt \u003d self.buf.get_next()"},{"line_number":63,"context_line":"        self.assertEqual(stmt, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_e0a5c647","line":60,"updated":"2015-03-02 10:38:46.000000000","message":"self.f should be self.test_file","commit_id":"223070a1f18472759f5aa2d6882c6f38c988b385"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"cfb52ec23ae1e22cbbf4b3d718ee5130f88d1c86","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def tearDown(self):"},{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_load_buffer(self):"},{"line_number":36,"context_line":"        # Check buffer contains 10 statements"},{"line_number":37,"context_line":"        self.assertEqual(len(self.buf._buffer), 10)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_0c369052","line":35,"updated":"2015-03-02 13:15:57.000000000","message":"Awesome for starting to build unit tests :)","commit_id":"d26c594bd8c7e170ce76eb283c9400e500b301d4"},{"author":{"_account_id":15173,"name":"Rob Fletcher","email":"rfletch.vol@gmail.com","username":"fletcher"},"change_message_id":"c358054e98d612d76a82f73149d5d1438a663343","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            count \u003d count - 1"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # line 9 should be three lines long"},{"line_number":73,"context_line":"        self.assertEqual(len(stmt[\u0027lineno\u0027]), 3)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_4fe78840","line":73,"updated":"2015-03-02 18:41:59.000000000","message":"Can we also add a test that checks specifically what line numbers are returned. In this example, I believe it would be 11,12,13.\n\nTo be honest, I\u0027d probably add a couple of newlines into one of the statements in jinja2_templating, something like:\n\n Environment(loader\u003dtemplateLoader,\n             load\u003dtemplateLoader,\n\n\n             autoescape\u003dFalse)\n\nThen we can check that it returns 11, 12, 15 correctly.\n\nThis is great start on the tests. I\u0027m excited to expand on these now that we have a base to go off of!","commit_id":"45293dd68a2fbf3869ab4ead4d1122c296a14416"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding:utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_f04e466e","line":1,"updated":"2015-03-03 04:29:01.000000000","message":"Think you can remove this.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_load_buffer(self):"},{"line_number":36,"context_line":"        # Check buffer contains 10 statements"},{"line_number":37,"context_line":"        self.assertEqual(len(self.buf._buffer), 10)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_get_next(self):"},{"line_number":40,"context_line":"        # Check get_next returns an AST statement"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_50f632fa","line":37,"updated":"2015-03-03 04:29:01.000000000","message":"asserts should always be (expected, actual)","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5cf0dd68be3fe7cf9ea09765cfab9dc27aff599c","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_load_buffer(self):"},{"line_number":36,"context_line":"        # Check buffer contains 10 statements"},{"line_number":37,"context_line":"        self.assertEqual(len(self.buf._buffer), 10)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_get_next(self):"},{"line_number":40,"context_line":"        # Check get_next returns an AST statement"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_747083dc","line":37,"in_reply_to":"ba7be1f8_50f632fa","updated":"2015-03-03 09:14:34.000000000","message":"+1","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        stmt \u003d self.buf.get_next()"},{"line_number":42,"context_line":"        self.assertTrue(isinstance(stmt[\u0027node\u0027], ast.AST))"},{"line_number":43,"context_line":"        # Check get_next returned the first statement"},{"line_number":44,"context_line":"        self.assertEqual(stmt[\u0027lineno\u0027][0], 1)"},{"line_number":45,"context_line":"        # Check buffer has been reduced by one"},{"line_number":46,"context_line":"        self.assertEqual(len(self.buf._buffer), 9)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_30f1be01","line":44,"updated":"2015-03-03 04:29:01.000000000","message":"asserts should always be (expected, actual)","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # Check get_next returned the first statement"},{"line_number":44,"context_line":"        self.assertEqual(stmt[\u0027lineno\u0027][0], 1)"},{"line_number":45,"context_line":"        # Check buffer has been reduced by one"},{"line_number":46,"context_line":"        self.assertEqual(len(self.buf._buffer), 9)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_get_next_count(self):"},{"line_number":49,"context_line":"        # Check get_next returns exactly 10 statements"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_10f03afd","line":46,"updated":"2015-03-03 04:29:01.000000000","message":"asserts should always be (expected, actual)","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # Check get_next returns exactly 10 statements"},{"line_number":50,"context_line":"        count \u003d 0"},{"line_number":51,"context_line":"        stmt \u003d self.buf.get_next()"},{"line_number":52,"context_line":"        while not stmt \u003d\u003d None:"},{"line_number":53,"context_line":"            count \u003d count + 1"},{"line_number":54,"context_line":"            stmt \u003d self.buf.get_next()"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_10a2fafc","line":52,"updated":"2015-03-03 04:29:01.000000000","message":"PEP8 recommends is over \u003d\u003d for None comparision\n\nwhile stmt is not None:","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5cf0dd68be3fe7cf9ea09765cfab9dc27aff599c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # Check get_next returns exactly 10 statements"},{"line_number":50,"context_line":"        count \u003d 0"},{"line_number":51,"context_line":"        stmt \u003d self.buf.get_next()"},{"line_number":52,"context_line":"        while not stmt \u003d\u003d None:"},{"line_number":53,"context_line":"            count \u003d count + 1"},{"line_number":54,"context_line":"            stmt \u003d self.buf.get_next()"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_9426d7cc","line":52,"in_reply_to":"ba7be1f8_10a2fafc","updated":"2015-03-03 09:14:34.000000000","message":"+1","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # self.test_file has already been read, so is empty file handle"},{"line_number":61,"context_line":"        self.buf.load_buffer(self.test_file)"},{"line_number":62,"context_line":"        stmt \u003d self.buf.get_next()"},{"line_number":63,"context_line":"        self.assertEqual(stmt, None)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_linenumber_range(self):"},{"line_number":66,"context_line":"        # Check linenumber_range returns corrent number of lines"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_f0eac60d","line":63,"updated":"2015-03-03 04:29:01.000000000","message":"asserts should always be (expected, actual)","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # Check linenumber_range returns corrent number of lines"},{"line_number":67,"context_line":"        count \u003d 9"},{"line_number":68,"context_line":"        while count \u003e 0:"},{"line_number":69,"context_line":"            stmt \u003d self.buf.get_next()"},{"line_number":70,"context_line":"            count \u003d count - 1"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # line 9 should be three lines long"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_b0e4ce3c","line":69,"updated":"2015-03-03 04:29:01.000000000","message":"It would be nice if StatementBuffer implemented iterable functions so that you avoid using a counter here.","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5cf0dd68be3fe7cf9ea09765cfab9dc27aff599c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # Check linenumber_range returns corrent number of lines"},{"line_number":67,"context_line":"        count \u003d 9"},{"line_number":68,"context_line":"        while count \u003e 0:"},{"line_number":69,"context_line":"            stmt \u003d self.buf.get_next()"},{"line_number":70,"context_line":"            count \u003d count - 1"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # line 9 should be three lines long"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_5439bff0","line":69,"in_reply_to":"ba7be1f8_b0e4ce3c","updated":"2015-03-03 09:14:34.000000000","message":"Personally I\u0027m not too concerned about iter behaviour here, since this logic is just used in a test function, maybe something to add in a future patch though","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            count \u003d count - 1"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # line 9 should be three lines long"},{"line_number":73,"context_line":"        self.assertEqual(len(stmt[\u0027lineno\u0027]), 3)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # the range should be the correct line numbers"},{"line_number":76,"context_line":"        self.assertEqual(stmt[\u0027lineno\u0027], [11,12,13])"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_b08dae7e","line":73,"updated":"2015-03-03 04:29:01.000000000","message":"asserts should always be (expected, actual)","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"86eb8c395cb7b0e39eda7e96aa25c3bcb69e20e7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.assertEqual(len(stmt[\u0027lineno\u0027]), 3)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # the range should be the correct line numbers"},{"line_number":76,"context_line":"        self.assertEqual(stmt[\u0027lineno\u0027], [11,12,13])"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_d08a2263","line":76,"updated":"2015-03-03 04:29:01.000000000","message":"asserts should always be (expected, actual)","commit_id":"a1a7c227ef86fd8467549adcf3f00a0e286ebc3b"}]}
