)]}'
{"bandit/core/formatters.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    return summation"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def report_csv(manager, filename, sev_level, conf_level, lines, out_format):"},{"line_number":34,"context_line":"    \u0027\u0027\u0027Prints/returns warnings in JSON format"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    :param result_store: results of scan as BanditResultStore object"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_36bb0ce7","line":33,"updated":"2015-09-04 18:56:29.000000000","message":"out_format\u003d\u0027csv\u0027","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \u0027\u0027\u0027Prints/returns warnings in JSON format"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    :param result_store: results of scan as BanditResultStore object"},{"line_number":37,"context_line":"    :param files_list: Which files were inspected"},{"line_number":38,"context_line":"    :param scores: The scores awarded to each file in the scope"},{"line_number":39,"context_line":"    :param excluded_files: Which files were excluded from the scope"},{"line_number":40,"context_line":"    :return: A collection containing the CSV data"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_1637e84d","line":37,"updated":"2015-09-04 18:56:29.000000000","message":"update docstring to match new function signature","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    print(\"CSV output written to file: %s\" % filename)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def report_json(manager, filename, sev_level, conf_level, lines, out_format):"},{"line_number":69,"context_line":"    \u0027\u0027\u0027Prints/returns warnings in JSON format"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    :param result_store: results of scan as BanditResultStore object"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_76ee64ee","line":68,"updated":"2015-09-04 18:56:29.000000000","message":"out_format\u003d\u0027json\u0027","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027\u0027\u0027Prints/returns warnings in JSON format"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    :param result_store: results of scan as BanditResultStore object"},{"line_number":72,"context_line":"    :param files_list: Which files were inspected"},{"line_number":73,"context_line":"    :param scores: The scores awarded to each file in the scope"},{"line_number":74,"context_line":"    :param excluded_files: Which files were excluded from the scope"},{"line_number":75,"context_line":"    :return: JSON string"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b6407ca6","line":72,"updated":"2015-09-04 18:56:29.000000000","message":"update docstring to match new function signature","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        print(result)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"def report_text(manager, filename, sev_level, conf_level, lines, out_format):"},{"line_number":132,"context_line":"    \u0027\u0027\u0027Prints the contents of the result store"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    :param result_store: results of scan as BanditResultStore object"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b6e87ce3","line":131,"updated":"2015-09-04 18:56:29.000000000","message":"out_format\u003d\u0027txt\u0027","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \u0027\u0027\u0027Prints the contents of the result store"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    :param result_store: results of scan as BanditResultStore object"},{"line_number":135,"context_line":"    :param files_list: Which files were inspected"},{"line_number":136,"context_line":"    :param scores: The scores awarded to each file in the scope"},{"line_number":137,"context_line":"    :param excluded_files: List of files excluded from the scope"},{"line_number":138,"context_line":"    :return: TXT string with appropriate TTY coloring for terminals"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_d63df02b","line":135,"updated":"2015-09-04 18:56:29.000000000","message":"update docstring to match new function signature","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        print(result)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"def report_xml(manager, filename, sev_level, conf_level, lines, out_format):"},{"line_number":230,"context_line":"    \u0027\u0027\u0027Prints/returns warnings in XML format (Xunit compatible)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    :param result_store: results of scan as BanditResultStore object"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_56d9e055","line":229,"updated":"2015-09-04 18:56:29.000000000","message":"out_format\u003d\u0027xml\u0027","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    \u0027\u0027\u0027Prints/returns warnings in XML format (Xunit compatible)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    :param result_store: results of scan as BanditResultStore object"},{"line_number":233,"context_line":"    :param files_list: Which files were inspected"},{"line_number":234,"context_line":"    :param scores: The scores awarded to each file in the scope"},{"line_number":235,"context_line":"    :param excluded_files: Which files were excluded from the scope"},{"line_number":236,"context_line":"    :return: A collection containing the XML data"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_764664c1","line":233,"updated":"2015-09-04 18:56:29.000000000","message":"update docstring to match new function signature","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"}],"bandit/core/issue.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"cee64e39bb340084746f6d336e0b5eacc9678f4f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding:utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_93a78aa6","line":3,"updated":"2015-09-04 18:49:03.000000000","message":"2015","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"cee64e39bb340084746f6d336e0b5eacc9678f4f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def get_code(self, max_lines\u003d-1, tabbed\u003dFalse):"},{"line_number":46,"context_line":"        \u0027\u0027\u0027Gets lines of code from a file"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param filename: Filename of file with code in it"},{"line_number":49,"context_line":"        :param line_list: A list of integers corresponding to line numbers"},{"line_number":50,"context_line":"        :return: string of code"},{"line_number":51,"context_line":"        \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_d300a236","line":48,"updated":"2015-09-04 18:49:03.000000000","message":"this was probably wrong before, but \"Filename of file\" sounds funny","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"cee64e39bb340084746f6d336e0b5eacc9678f4f","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if not tabbed:"},{"line_number":58,"context_line":"            out \u003d [lc.getline(self.fname, l) for l in lines]"},{"line_number":59,"context_line":"        out \u003d [\"%s\\t%s\" % (l, lc.getline(self.fname, l)) for l in lines]"},{"line_number":60,"context_line":"        return \u0027\u0027.join(out)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def as_dict(self, with_code\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_d6709074","line":59,"updated":"2015-09-04 18:49:03.000000000","message":"I think you wanted this in an else statement correct?  Otherwise if not tabbed, this is always overwriting out anyway.","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"cee64e39bb340084746f6d336e0b5eacc9678f4f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \u0027issue_confidence\u0027: self.confidence,"},{"line_number":68,"context_line":"            \u0027issue_text\u0027: self.text,"},{"line_number":69,"context_line":"            \u0027line_number\u0027: self.lineno,"},{"line_number":70,"context_line":"            \u0027line_range\u0027: self.linerange"},{"line_number":71,"context_line":"            }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if with_code:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_f3e366d6","line":70,"updated":"2015-09-04 18:49:03.000000000","message":"adding a trailing , here would help avoid line changes to this dict","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad081668ea8bf9d8991335b454d1478e6d1450a1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        are lower then the given threashold values."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        :param confidence: Confidence threashold"},{"line_number":47,"context_line":"        :param confidence: Severity threashold"},{"line_number":48,"context_line":"        \u0027\u0027\u0027"},{"line_number":49,"context_line":"        rank \u003d constants.RANKING"},{"line_number":50,"context_line":"        return (rank.index(self.severity) \u003e\u003d rank.index(severity) and"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_ba62883c","line":47,"updated":"2015-09-06 06:01:42.000000000","message":"s/confidence/severity","commit_id":"9e522d3322295b6236315f4f1eabe47f2c2a58ff"}],"tests/functional/test_functional.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"cee64e39bb340084746f6d336e0b5eacc9678f4f","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        }"},{"line_number":389,"context_line":"        self.check_example(\u0027weak_cryptographic_key_sizes.py\u0027, expect)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def test_multiline_code(self):"},{"line_number":392,"context_line":"        \u0027\u0027\u0027Test issues in multiline statements return code as expected.\u0027\u0027\u0027"},{"line_number":393,"context_line":"        self.run_example(\u0027multiline-str.py\u0027)"},{"line_number":394,"context_line":"        self.assertEqual(0, len(self.b_mgr.skipped))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_537fb2df","line":391,"updated":"2015-09-04 18:49:03.000000000","message":"Can you move this back before test_weak_cryptographic_key","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"74aca7d7f2510b9218c42ccce594b4ece8ad55a8","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        }"},{"line_number":389,"context_line":"        self.check_example(\u0027weak_cryptographic_key_sizes.py\u0027, expect)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def test_multiline_code(self):"},{"line_number":392,"context_line":"        \u0027\u0027\u0027Test issues in multiline statements return code as expected.\u0027\u0027\u0027"},{"line_number":393,"context_line":"        self.run_example(\u0027multiline-str.py\u0027)"},{"line_number":394,"context_line":"        self.assertEqual(0, len(self.b_mgr.skipped))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ba17eda1","line":391,"in_reply_to":"da20952f_537fb2df","updated":"2015-09-05 18:49:23.000000000","message":"I prefer to group the tests that are exercising specific issues together. The multi-line test is generic. I can change the order back if people feel strongly though","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9896fe6117549ce2824aa89c9e7ad2a7a272a1af","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        }"},{"line_number":389,"context_line":"        self.check_example(\u0027weak_cryptographic_key_sizes.py\u0027, expect)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def test_multiline_code(self):"},{"line_number":392,"context_line":"        \u0027\u0027\u0027Test issues in multiline statements return code as expected.\u0027\u0027\u0027"},{"line_number":393,"context_line":"        self.run_example(\u0027multiline-str.py\u0027)"},{"line_number":394,"context_line":"        self.assertEqual(0, len(self.b_mgr.skipped))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_7a58708a","line":391,"in_reply_to":"da20952f_ba17eda1","updated":"2015-09-06 06:01:19.000000000","message":"No problem, this is fine as is.","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"}],"tests/unit/core/test_formatters.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.manager.results.append(self.issue)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_report_csv(self):"},{"line_number":56,"context_line":"        formatters.report_csv(self.manager, self.tmp_fname, 0, 0, -1, \u0027csv\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        with open(self.tmp_fname) as f:"},{"line_number":59,"context_line":"            reader \u003d csv.DictReader(f)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b67ddc1d","line":56,"updated":"2015-09-04 18:56:29.000000000","message":"* remove \u0027csv\u0027 once default value is set in formatters\n* 0 should be self.issue.severity\n* 0 should be self.issue.confidence\n* -1 should be self.issue.lineno","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"74aca7d7f2510b9218c42ccce594b4ece8ad55a8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.manager.results.append(self.issue)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_report_csv(self):"},{"line_number":56,"context_line":"        formatters.report_csv(self.manager, self.tmp_fname, 0, 0, -1, \u0027csv\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        with open(self.tmp_fname) as f:"},{"line_number":59,"context_line":"            reader \u003d csv.DictReader(f)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_3a93dd5c","line":56,"in_reply_to":"da20952f_b67ddc1d","updated":"2015-09-05 18:49:23.000000000","message":"this is not quite correct, -1 indicates the number of lines to return, not the index of the line. In this case -1 means all lines of context\n\nThe 0s are minimum thresholds for results, but I guess changing them in the way you indicate makes this test tighter,","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.manager.scores \u003d [{\u0027SEVERITY\u0027: [0] * len(constants.RANKING),"},{"line_number":74,"context_line":"                                \u0027CONFIDENCE\u0027: [0] * len(constants.RANKING)}]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        formatters.report_json(self.manager, self.tmp_fname, 0, 0, -1, \u0027json\u0027)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        with open(self.tmp_fname) as f:"},{"line_number":79,"context_line":"            data \u003d json.loads(f.read())"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b6963c4a","line":76,"updated":"2015-09-04 18:56:29.000000000","message":"* remove \u0027json\u0027 once default value is set in formatters\n* 0 should be self.issue.severity\n* 0 should be self.issue.confidence\n* -1 should be self.issue.lineno","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                   \u0027CONFIDENCE\u0027: [0] * len(constants.RANKING)}]"},{"line_number":100,"context_line":"        exc_files \u003d [\u0027test_binding.py\u0027]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        formatters.report_text(self.manager, self.tmp_fname, 0, 0, -1, \u0027txt\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        with open(self.tmp_fname) as f:"},{"line_number":105,"context_line":"            data \u003d f.read()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_9699b87b","line":102,"updated":"2015-09-04 18:56:29.000000000","message":"* remove \u0027txt\u0027 once default value is set in formatters\n* 0 should be self.issue.severity\n* 0 should be self.issue.confidence\n* -1 should be self.issue.lineno","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"074091751b4651a1958de48c7361f9bb18175d50","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        return d"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_report_xml(self):"},{"line_number":137,"context_line":"        formatters.report_xml(self.manager, self.tmp_fname, 0, 0, -1, \u0027xml\u0027)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        with open(self.tmp_fname) as f:"},{"line_number":140,"context_line":"            data \u003d self._xml_to_dict(ET.XML(f.read()))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_f67ef419","line":137,"updated":"2015-09-04 18:56:29.000000000","message":"* remove \u0027xml\u0027 once default value is set in formatters\n* 0 should be self.issue.severity\n* 0 should be self.issue.confidence\n* -1 should be self.issue.lineno","commit_id":"a33b9d01e545d2a44ccaf7815081f49f1d6e034e"}]}