)]}'
{"bandit/bandit.py":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"46a69a78258bcaff7456928b43ff3b74de1e5820","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    extension_mgr \u003d _init_extensions()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    baseline_formatters \u003d sorted(filter(lambda x: x.endswith(\u0027_baseline\u0027),"},{"line_number":111,"context_line":"                                        extension_mgr.formatter_names))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    # now do normal startup"},{"line_number":114,"context_line":"    parser \u003d argparse.ArgumentParser("}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_702b72ec","line":111,"updated":"2015-11-09 07:11:02.000000000","message":"How about an trivial decorator on the baseline formatters? (just to detect which ones are tagged) It should be more explicit that way, but maybe I\u0027m missing some ways it\u0027s worse.","commit_id":"64a14c980fb1b7b17dc06a1e135e12675a70ca5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"5e85b0176873153b73c6f8bae8f2c68c0288e735","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    extension_mgr \u003d _init_extensions()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    baseline_formatters \u003d sorted(filter(lambda x: x.endswith(\u0027_baseline\u0027),"},{"line_number":111,"context_line":"                                        extension_mgr.formatter_names))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    # now do normal startup"},{"line_number":114,"context_line":"    parser \u003d argparse.ArgumentParser("}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_c0003fad","line":111,"in_reply_to":"da85f559_702b72ec","updated":"2015-11-09 13:29:50.000000000","message":"We could... either approach seems fine to me.  I guess if we anticipate any other special case formatters we could use a decorator.  If this is the only one probably leave it like this?\n\nI can be convinced either way though.","commit_id":"64a14c980fb1b7b17dc06a1e135e12675a70ca5f"}],"bandit/formatters/text_baseline.py":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"46a69a78258bcaff7456928b43ff3b74de1e5820","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                 \u0027HIGH\u0027: get_setting(\u0027color_HIGH\u0027)"},{"line_number":56,"context_line":"                 }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    # print header"},{"line_number":59,"context_line":"    tmpstr_list.append(\"%sRun started:%s\\n\\t%s\\n\" % ("},{"line_number":60,"context_line":"        color[\u0027HEADER\u0027],"},{"line_number":61,"context_line":"        color[\u0027DEFAULT\u0027],"},{"line_number":62,"context_line":"        datetime.datetime.utcnow()"},{"line_number":63,"context_line":"    ))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if manager.verbose:"},{"line_number":66,"context_line":"        # print which files were inspected"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_535c3825","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":6},"updated":"2015-11-09 07:11:02.000000000","message":"This fragment and a lot of others are reused between text and text_baseline. It looks like both could be cleaned up by reducing them to:\n\n    def report(...):\n        tmpstr_list.extend(text.header(...))\n        if manager.verbose:\n            tmpstr_list.extend(text.files_inspected(...))\n            tmpstr_list.extend(text.files_excluded(...))\n        tmpstr_list.extend(text.basic_metrics(...))\n        ...\n\nApart from the output of issues themselves, there aren\u0027t many changes.","commit_id":"64a14c980fb1b7b17dc06a1e135e12675a70ca5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"5e85b0176873153b73c6f8bae8f2c68c0288e735","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                 \u0027HIGH\u0027: get_setting(\u0027color_HIGH\u0027)"},{"line_number":56,"context_line":"                 }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    # print header"},{"line_number":59,"context_line":"    tmpstr_list.append(\"%sRun started:%s\\n\\t%s\\n\" % ("},{"line_number":60,"context_line":"        color[\u0027HEADER\u0027],"},{"line_number":61,"context_line":"        color[\u0027DEFAULT\u0027],"},{"line_number":62,"context_line":"        datetime.datetime.utcnow()"},{"line_number":63,"context_line":"    ))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if manager.verbose:"},{"line_number":66,"context_line":"        # print which files were inspected"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_41c5308c","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":6},"in_reply_to":"da85f559_535c3825","updated":"2015-11-09 13:29:50.000000000","message":"I agree, we can do some clean up here but I\u0027d rather do that as a separate patch.  The best thing to do would probably be to move things commonly used by formatters to utility functions or even a new formatter_utils.","commit_id":"64a14c980fb1b7b17dc06a1e135e12675a70ca5f"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"46a69a78258bcaff7456928b43ff3b74de1e5820","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            color[\u0027DEFAULT\u0027]"},{"line_number":70,"context_line":"        ))"},{"line_number":71,"context_line":"        for (item, score) in zip(manager.files_list, manager.scores):"},{"line_number":72,"context_line":"            score_dict \u003d {\u0027SEVERITY\u0027: sum(i for i in score[\u0027SEVERITY\u0027]),"},{"line_number":73,"context_line":"                          \u0027CONFIDENCE\u0027: sum(i for i in score[\u0027CONFIDENCE\u0027])}"},{"line_number":74,"context_line":"            tmpstr_list.append(\"\\t%s (score: %s)\\n\" % (item, score_dict))"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_b0fc7a3f","line":72,"range":{"start_line":72,"start_character":42,"end_line":72,"end_character":49},"updated":"2015-11-09 07:11:02.000000000","message":"i for i in is not necessary. It\u0027s the same as just sum(score[...])","commit_id":"64a14c980fb1b7b17dc06a1e135e12675a70ca5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"5e85b0176873153b73c6f8bae8f2c68c0288e735","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            color[\u0027DEFAULT\u0027]"},{"line_number":70,"context_line":"        ))"},{"line_number":71,"context_line":"        for (item, score) in zip(manager.files_list, manager.scores):"},{"line_number":72,"context_line":"            score_dict \u003d {\u0027SEVERITY\u0027: sum(i for i in score[\u0027SEVERITY\u0027]),"},{"line_number":73,"context_line":"                          \u0027CONFIDENCE\u0027: sum(i for i in score[\u0027CONFIDENCE\u0027])}"},{"line_number":74,"context_line":"            tmpstr_list.append(\"\\t%s (score: %s)\\n\" % (item, score_dict))"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_c1e9201c","line":72,"range":{"start_line":72,"start_character":42,"end_line":72,"end_character":49},"in_reply_to":"da85f559_b0fc7a3f","updated":"2015-11-09 13:29:50.000000000","message":"Done","commit_id":"64a14c980fb1b7b17dc06a1e135e12675a70ca5f"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"46a69a78258bcaff7456928b43ff3b74de1e5820","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"da85f559_930aa0d1","line":185,"updated":"2015-11-09 07:11:02.000000000","message":"Nit: There are a few inconsistencies in the file. Nothing critical, but things like\n\n- .append() vs +\u003d\n- list() vs []\n- list(...) vs [...]\n- .format(...) vs %","commit_id":"64a14c980fb1b7b17dc06a1e135e12675a70ca5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"5e85b0176873153b73c6f8bae8f2c68c0288e735","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"da85f559_a1b5fccd","line":185,"in_reply_to":"da85f559_930aa0d1","updated":"2015-11-09 13:29:50.000000000","message":"True.. I guess these were mostly my personal preference vs. the personal preference of whoever I C-C-P\u0027d this from.  Still, I\u0027ve tried to address them in next change.","commit_id":"64a14c980fb1b7b17dc06a1e135e12675a70ca5f"}]}
