)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c3947312f3a5c8840e832c01215df9e38d8e102a","unresolved":false,"context_lines":[{"line_number":22,"context_line":" - B4xx - cryptography"},{"line_number":23,"context_line":" - B5xx - injection"},{"line_number":24,"context_line":" - B6xx - XSS"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ia6f1aac1ba46eeb2ea5a36ad70a86ec819d014ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_ca4d9d73","line":25,"updated":"2015-12-17 17:40:19.000000000","message":"Shouldn\u0027t this reference the blueprint/spec?","commit_id":"bc991a5034d09ae6d40b6f692de2e74b08eff5fe"}],"bandit/plugins/blacklist_calls.py":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"4207c0f0383847bff564fd430188ff591def3a8b","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@test.takes_config"},{"line_number":98,"context_line":"@test.checks(\u0027Call\u0027)"},{"line_number":99,"context_line":"@test.test_id(\u0027B301\u0027)"},{"line_number":100,"context_line":"def blacklist_calls(context, config):"},{"line_number":101,"context_line":"    _ensure_cache(config)"},{"line_number":102,"context_line":"    checks \u003d _cached_blacklist_checks"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_95ed7bf1","line":99,"range":{"start_line":99,"start_character":19,"end_line":99,"end_character":21},"updated":"2015-12-17 16:20:59.000000000","message":"so we\u0027ll eventually split each blacklist call into its own test ID, right?  If so we might want to leave more space between this and imports at 302.\n\nAlso, do you think we\u0027d ever have more than 100 blacklist things?  If so we might want to put blacklist imports and functions in separate ranges.","commit_id":"bc991a5034d09ae6d40b6f692de2e74b08eff5fe"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"68259cf826705121fc360a1b3a1b54adb0291a5c","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@test.takes_config"},{"line_number":98,"context_line":"@test.checks(\u0027Call\u0027)"},{"line_number":99,"context_line":"@test.test_id(\u0027B301\u0027)"},{"line_number":100,"context_line":"def blacklist_calls(context, config):"},{"line_number":101,"context_line":"    _ensure_cache(config)"},{"line_number":102,"context_line":"    checks \u003d _cached_blacklist_checks"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_9609022f","line":99,"range":{"start_line":99,"start_character":19,"end_line":99,"end_character":21},"in_reply_to":"3a7e1126_95ed7bf1","updated":"2015-12-17 16:33:37.000000000","message":"Your right thats the plan, and I should have left more space here. Lets put them in separate ranges to be safe.","commit_id":"bc991a5034d09ae6d40b6f692de2e74b08eff5fe"}],"bandit/plugins/blacklist_imports.py":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"d746be2f5734e0dc7a3c18556c62b850ac71de47","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@test.takes_config"},{"line_number":22,"context_line":"@test.checks(\u0027Import\u0027, \u0027ImportFrom\u0027)"},{"line_number":23,"context_line":"@test.test_id(\u0027B401\u0027)"},{"line_number":24,"context_line":"def blacklist_imports(context, config):"},{"line_number":25,"context_line":"    \"\"\"blacklist_imports"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_c0717c0d","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":21},"updated":"2015-12-21 16:44:52.000000000","message":"I think it\u0027s going to make sense to check \u0027import from\u0027 and \u0027import\u0027 for a specific library together.  When we split out each blacklist check to its own numbers, we can make that change.  For now this works.","commit_id":"51b1781a97a27b0c15309c6fc7d36d54d81bc7c7"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"68306b23dacefc88812424e72d46d7ff8bc711b8","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@test.takes_config"},{"line_number":22,"context_line":"@test.checks(\u0027Import\u0027, \u0027ImportFrom\u0027)"},{"line_number":23,"context_line":"@test.test_id(\u0027B401\u0027)"},{"line_number":24,"context_line":"def blacklist_imports(context, config):"},{"line_number":25,"context_line":"    \"\"\"blacklist_imports"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_3bb8b174","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":21},"in_reply_to":"3a7e1126_c0717c0d","updated":"2015-12-21 16:56:08.000000000","message":"Yes, the blacklist stuff will change when we add the class conversion stuff to give each one its own number. We will most likely merge these specific checks and number by module name as you suggest.","commit_id":"51b1781a97a27b0c15309c6fc7d36d54d81bc7c7"}],"bandit/plugins/general_hardcoded_password.py":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"d746be2f5734e0dc7a3c18556c62b850ac71de47","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"@test.checks(\u0027Call\u0027)"},{"line_number":105,"context_line":"@test.test_id(\u0027B106\u0027)"},{"line_number":106,"context_line":"def hardcoded_password_funcarg(context):"},{"line_number":107,"context_line":"    # looks for \"function(candidate\u003d\u0027some_string\u0027)\""},{"line_number":108,"context_line":"    for kw in context.node.keywords:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_80505433","line":105,"range":{"start_line":105,"start_character":19,"end_line":105,"end_character":21},"updated":"2015-12-21 16:44:52.000000000","message":"do we want to end up with separate numbers for the different parts of one plugin, or have you just done this for now?  IMO the same test ID should apply to all parts of the \u0027hardcoded password\u0027 plugin.","commit_id":"51b1781a97a27b0c15309c6fc7d36d54d81bc7c7"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"68306b23dacefc88812424e72d46d7ff8bc711b8","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"@test.checks(\u0027Call\u0027)"},{"line_number":105,"context_line":"@test.test_id(\u0027B106\u0027)"},{"line_number":106,"context_line":"def hardcoded_password_funcarg(context):"},{"line_number":107,"context_line":"    # looks for \"function(candidate\u003d\u0027some_string\u0027)\""},{"line_number":108,"context_line":"    for kw in context.node.keywords:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_9bfbe546","line":105,"range":{"start_line":105,"start_character":19,"end_line":105,"end_character":21},"in_reply_to":"3a7e1126_80505433","updated":"2015-12-21 16:56:08.000000000","message":"I\u0027m not sure I agree with that, it seems like we would want to switch off these tests separately. For instance, if a particular convention caused a lot of noise from one of these tests, lets say hardcoded_password_funcarg, but the others checks were still valid. \n\nIn either case, these have always been separate plugins, so we are no worse off by doing it this way.\n\nGenerally bandit\u0027s config has always been split on test (e.g. hardcoded_password_funcarg) and not on the general issue, hardcoded passwords in this case. We can talk this over more though if you would like.","commit_id":"51b1781a97a27b0c15309c6fc7d36d54d81bc7c7"}]}