)]}'
{"bandit/bandit.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"18da12cb782a98da401f1309ead06a3867124fd9","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        _init_logger(debug, log_format\u003dlog_format)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    if not args.profile and args.tests:"},{"line_number":235,"context_line":"        profile_name \u003d args.tests.split(\u0027,\u0027)"},{"line_number":236,"context_line":"    else:"},{"line_number":237,"context_line":"        profile_name \u003d args.profile"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_693b269d","line":235,"updated":"2016-01-13 20:50:29.000000000","message":"If the options are mutually exlusive, can we just check one or the other? We shouldn\u0027t need to check both.","commit_id":"bc59e8c6fc1c07660699278e4f3d3d4744f44d28"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"44f1063bb31f4fb0ee9cbfe493fb55252f98a778","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        _init_logger(debug, log_format\u003dlog_format)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    if not args.profile and args.tests:"},{"line_number":235,"context_line":"        profile_name \u003d args.tests.split(\u0027,\u0027)"},{"line_number":236,"context_line":"    else:"},{"line_number":237,"context_line":"        profile_name \u003d args.profile"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_49ef4287","line":235,"in_reply_to":"da6ed579_693b269d","updated":"2016-01-13 21:05:35.000000000","message":"Done","commit_id":"bc59e8c6fc1c07660699278e4f3d3d4744f44d28"}],"bandit/core/extension_loader.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"18da12cb782a98da401f1309ead06a3867124fd9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            )"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_plugin_id(self, plugin_name):"},{"line_number":50,"context_line":"        for p in self.plugins:"},{"line_number":51,"context_line":"            if p.name \u003d\u003d plugin_name:"},{"line_number":52,"context_line":"                return p.plugin._test_id"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_891bfa1a","line":50,"updated":"2016-01-13 20:50:29.000000000","message":"Why don\u0027t we create a different mapping in __init__ that does something like:\n\n    self.plugin_name_to_id \u003d {p.plugin.name: p.id for p in self.plugins}\n\nThen we don\u0027t need to iterate over the plugins list each time","commit_id":"bc59e8c6fc1c07660699278e4f3d3d4744f44d28"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"44f1063bb31f4fb0ee9cbfe493fb55252f98a778","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            )"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_plugin_id(self, plugin_name):"},{"line_number":50,"context_line":"        for p in self.plugins:"},{"line_number":51,"context_line":"            if p.name \u003d\u003d plugin_name:"},{"line_number":52,"context_line":"                return p.plugin._test_id"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_99bcab07","line":50,"in_reply_to":"da6ed579_891bfa1a","updated":"2016-01-13 21:05:35.000000000","message":"Done","commit_id":"bc59e8c6fc1c07660699278e4f3d3d4744f44d28"}],"bandit/core/manager.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"fd78061be2dc89f8bc9a095cfda478b6a947abe7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if isinstance(profile_name, list):"},{"line_number":69,"context_line":"            profile \u003d {\u0027include\u0027: profile_name}"},{"line_number":70,"context_line":"        elif profile_name:"},{"line_number":71,"context_line":"            if profile_name in self.b_conf.config[\u0027profiles\u0027]:"},{"line_number":72,"context_line":"                profile \u003d self.b_conf.config[\u0027profiles\u0027][profile_name]"},{"line_number":73,"context_line":"                logger.debug(\"read in profile \u0027%s\u0027: %s\", profile_name, profile)"},{"line_number":74,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_589cf2bf","line":71,"updated":"2016-01-13 19:39:42.000000000","message":"This logic will be easier to read now if we make this a function (or method), e.g.,\n\n    def _get_profile(self, profile_name):\n        if profile_name not in self.b_conf.config[\u0027profiles\u0027]:\n             raise utils.ProfileNotFound(...)\n        profile \u003d self.b_conf.config[\u0027profiles\u0027][profile_name]\n        logger.debug(...)\n        return profile\n\n\n    # ...\n    elif profile_name:\n        profile \u003d self._get_profile(profile_name)\n    else:\n        profile \u003d None","commit_id":"13f0e03bc9dd8e1b509b77a116d930280b64dece"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c1a23e0f828e950e0bab6a04956323c6ea7b3837","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if isinstance(profile_name, list):"},{"line_number":69,"context_line":"            profile \u003d {\u0027include\u0027: profile_name}"},{"line_number":70,"context_line":"        elif profile_name:"},{"line_number":71,"context_line":"            if profile_name in self.b_conf.config[\u0027profiles\u0027]:"},{"line_number":72,"context_line":"                profile \u003d self.b_conf.config[\u0027profiles\u0027][profile_name]"},{"line_number":73,"context_line":"                logger.debug(\"read in profile \u0027%s\u0027: %s\", profile_name, profile)"},{"line_number":74,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_98782af4","line":71,"in_reply_to":"da6ed579_589cf2bf","updated":"2016-01-13 19:53:41.000000000","message":"Done","commit_id":"13f0e03bc9dd8e1b509b77a116d930280b64dece"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"18da12cb782a98da401f1309ead06a3867124fd9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def _get_profile(self, profile_name):"},{"line_number":83,"context_line":"        if profile_name not in self.b_conf.config[\u0027profiles\u0027]:"},{"line_number":84,"context_line":"            raise utils.ProfileNotFound(self.b_conf.config_file, profile_name)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            profile \u003d self.b_conf.config[\u0027profiles\u0027][profile_name]"},{"line_number":87,"context_line":"            logger.debug(\"read in profile \u0027%s\u0027: %s\", profile_name, profile)"},{"line_number":88,"context_line":"            return profile"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_69bec6d5","line":85,"updated":"2016-01-13 20:50:29.000000000","message":"We don\u0027t need an else here. If the profile name is not in the dictionary, the raise will short-circuit the logic.","commit_id":"bc59e8c6fc1c07660699278e4f3d3d4744f44d28"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"44f1063bb31f4fb0ee9cbfe493fb55252f98a778","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def _get_profile(self, profile_name):"},{"line_number":83,"context_line":"        if profile_name not in self.b_conf.config[\u0027profiles\u0027]:"},{"line_number":84,"context_line":"            raise utils.ProfileNotFound(self.b_conf.config_file, profile_name)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            profile \u003d self.b_conf.config[\u0027profiles\u0027][profile_name]"},{"line_number":87,"context_line":"            logger.debug(\"read in profile \u0027%s\u0027: %s\", profile_name, profile)"},{"line_number":88,"context_line":"            return profile"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_09b70a87","line":85,"in_reply_to":"da6ed579_69bec6d5","updated":"2016-01-13 21:05:35.000000000","message":"Done","commit_id":"bc59e8c6fc1c07660699278e4f3d3d4744f44d28"}]}
