)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"7584e172d92c65ebdfa7e19ad94df9fcc60535d7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Kelsey \u003ctim.kelsey@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-02 13:25:14 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ld config compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This converts legacy config data into the new config format. By"},{"line_number":10,"context_line":"converting it all upfront we save having to add supporting logic"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a5de9d1_ca3b8a37","line":7,"updated":"2016-02-02 16:51:38.000000000","message":"ld as in the linker or ld as in Old?","commit_id":"923f50d6c53a6bda540ce1071defe4048311f4a2"}],"bandit/core/config.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"dc87488317b9d140c7eaa65da8cbb9955af3a4d1","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            self._config \u003d yaml.safe_load(f)"},{"line_number":56,"context_line":"            if self._config:"},{"line_number":57,"context_line":"                self.convert_legacy_config()"},{"line_number":58,"context_line":"                self.validate_profiles()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_6054f5c9","line":56,"updated":"2016-02-02 17:21:31.000000000","message":"Can anything inside this if block generate a YAMLError? If not, let\u0027s move it outside of that exception block because it\u0027s only hiding what can trigger that exception. Let\u0027s move this to look something like:\n\n\n    try:\n        self._config \u003d yaml.safe_load(f)\n    except yaml.YAMLError:\n        raise ...\n\n    if self._config:\n        self.convert_legacy_config()\n        self.validate_profiles()","commit_id":"3e3bdd08d46b988293f46eb4830f88017ae8334c"}],"bandit/core/test_set.py":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"7eebcc38e89e30a00422d2e240b110d652475610","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        bl_imports \u003d config.get_setting(\u0027blacklist_imports\u0027)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if bl_imports:"},{"line_number":113,"context_line":"            bl_imports \u003d bl_imports[\u0027bad_import_sets\u0027]"},{"line_number":114,"context_line":"            for item in bl_imports:  # patch up the message format"},{"line_number":115,"context_line":"                item[\u0027message\u0027] \u003d item[\u0027message\u0027].replace(\u0027{module}\u0027, \u0027{name}\u0027)"},{"line_number":116,"context_line":"            blacklist.setdefault(\u0027Import\u0027, []).extend(bl_imports)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_46023071","line":113,"updated":"2016-01-26 16:34:06.000000000","message":"Try, Except?","commit_id":"1a64466745e0b551b96a2ea335560f4b91e2b6ac"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"7eebcc38e89e30a00422d2e240b110d652475610","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            blacklist.setdefault(\u0027Call\u0027, []).extend(bl_imports)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if bl_calls:"},{"line_number":121,"context_line":"            bl_calls \u003d bl_calls[\u0027bad_name_sets\u0027]"},{"line_number":122,"context_line":"            for item in bl_calls:  # patch up the message format"},{"line_number":123,"context_line":"                item[\u0027message\u0027] \u003d item[\u0027message\u0027].replace(\u0027{func}\u0027, \u0027{name}\u0027)"},{"line_number":124,"context_line":"            blacklist.setdefault(\u0027Call\u0027, []).extend(bl_calls)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_86082893","line":121,"updated":"2016-01-26 16:34:06.000000000","message":"do you need Try, Except here for KeyError?","commit_id":"1a64466745e0b551b96a2ea335560f4b91e2b6ac"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"c9e599398e9883b9069d271a73b81e894bb37ab4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            blacklist.setdefault(\u0027Call\u0027, []).extend(bl_imports)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if bl_calls:"},{"line_number":121,"context_line":"            bl_calls \u003d bl_calls[\u0027bad_name_sets\u0027]"},{"line_number":122,"context_line":"            for item in bl_calls:  # patch up the message format"},{"line_number":123,"context_line":"                item[\u0027message\u0027] \u003d item[\u0027message\u0027].replace(\u0027{func}\u0027, \u0027{name}\u0027)"},{"line_number":124,"context_line":"            blacklist.setdefault(\u0027Call\u0027, []).extend(bl_calls)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_263a9ce8","line":121,"in_reply_to":"9a68dd71_266cdc07","updated":"2016-01-26 16:38:56.000000000","message":"ok, but since we don\u0027t have it now I just don\u0027t want to dump tracebacks","commit_id":"1a64466745e0b551b96a2ea335560f4b91e2b6ac"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"321f54be8fa2f8c787dfd1ce71c9624edab57034","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            blacklist.setdefault(\u0027Call\u0027, []).extend(bl_imports)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if bl_calls:"},{"line_number":121,"context_line":"            bl_calls \u003d bl_calls[\u0027bad_name_sets\u0027]"},{"line_number":122,"context_line":"            for item in bl_calls:  # patch up the message format"},{"line_number":123,"context_line":"                item[\u0027message\u0027] \u003d item[\u0027message\u0027].replace(\u0027{func}\u0027, \u0027{name}\u0027)"},{"line_number":124,"context_line":"            blacklist.setdefault(\u0027Call\u0027, []).extend(bl_calls)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_266cdc07","line":121,"in_reply_to":"9a68dd71_86082893","updated":"2016-01-26 16:38:07.000000000","message":"I guess we could add that, but I\u0027m not sure it\u0027s needed. I think a config validation step should be added to handle all such situation (bad ID/names, bad data etc).","commit_id":"1a64466745e0b551b96a2ea335560f4b91e2b6ac"}]}
