)]}'
{"barbican_tempest_plugin/plugin.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"7e3b9bb23d43bb3d84a5e230de48c3ec21e3ca51","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        v1_params \u003d {"},{"line_number":41,"context_line":"            \u0027name\u0027: \u0027secret_v1\u0027,"},{"line_number":42,"context_line":"            \u0027service_version\u0027: \u0027secret.v1\u0027,"},{"line_number":43,"context_line":"            \u0027module_path\u0027: \u0027barbican_tempest_plugin.services.secret.json\u0027,"},{"line_number":44,"context_line":"            \u0027client_names\u0027: [\u0027SecretClient\u0027],"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":"        return [v1_params]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_4502c570","line":43,"updated":"2017-01-03 15:34:57.000000000","message":"The Barbican API has more resources we need to test than just the Secrets API. I think you can avoid some confusion by changing the path to barbican_tempest_plugin.services.key_manager.json.","commit_id":"49e569b9b17c04722b4c8e1e504778183c963fbb"}],"barbican_tempest_plugin/services/secret/json/secret_client.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"7e3b9bb23d43bb3d84a5e230de48c3ec21e3ca51","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        post_body \u003d {"},{"line_number":32,"context_line":"            \"secrets\": kwargs"},{"line_number":33,"context_line":"        }"},{"line_number":34,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":35,"context_line":"        resp, body \u003d self.post(\"v1/secrets\", body)"},{"line_number":36,"context_line":"        self.expected_success(201, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_c53075eb","line":33,"updated":"2017-01-03 15:34:57.000000000","message":"I don\u0027t think the POST method to create a secret works this way. Perhaps you are confusing it with the response to the GET method? See:\n\nhttp://docs.openstack.org/developer/barbican/api/reference/secrets.html","commit_id":"49e569b9b17c04722b4c8e1e504778183c963fbb"}],"barbican_tempest_plugin/tests/api/base.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"7e3b9bb23d43bb3d84a5e230de48c3ec21e3ca51","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class BaseSecretTest(test.BaseTestCase):"},{"line_number":26,"context_line":"    \"\"\"Base class for all api tests.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    # Why do I have to be an admin to create secrets? No idea..."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_f2dd3d15","line":25,"updated":"2017-01-03 15:34:57.000000000","message":"Should this be called something else (maybe BaseKeyManagerTest)? Barbican has other API resources besides the Secrets resource.","commit_id":"49e569b9b17c04722b4c8e1e504778183c963fbb"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"e72f4d57e937640fe7e7ad630e7b2e155d72bc52","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class BaseKeyManagerTest(test.BaseTestCase):"},{"line_number":26,"context_line":"    \"\"\"Base class for all api tests.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    # Why do I have to be an admin to create secrets? No idea..."},{"line_number":29,"context_line":"    credentials \u003d (\u0027admin\u0027, )"},{"line_number":30,"context_line":"    client_manager \u003d clients.Clients"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_ad848c5d","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":64},"updated":"2017-01-09 01:49:50.000000000","message":"Users with the \"creator\" role can also create secrets, though it doesn\u0027t seem very tempest-like to add roles to a user for the test.","commit_id":"215abbd2f4d8aa302aa4f28cf6b768c0f7e5d72f"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"523aee15586437051cde1c0ce2edcde4d96dd06b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class BaseKeyManagerTest(test.BaseTestCase):"},{"line_number":26,"context_line":"    \"\"\"Base class for all api tests.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    # Why do I have to be an admin to create secrets? No idea..."},{"line_number":29,"context_line":"    credentials \u003d (\u0027admin\u0027, )"},{"line_number":30,"context_line":"    client_manager \u003d clients.Clients"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_65cd4286","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":64},"in_reply_to":"ba5201f7_97c42360","updated":"2017-01-09 15:49:11.000000000","message":"That might be possible, though I\u0027d say the user should be deleted after. Cleaning up after itself is one of Tempest\u0027s design principles: https://github.com/openstack/tempest#design-principles\n\nHere\u0027s an example from Barbican\u0027s DevStack plugin for creating a user with the creator role: https://github.com/openstack/barbican/blob/master/devstack/lib/barbican#L240-L268 using the command line.\n\nDo you have access to other tempest clients? It looks like there\u0027s already a client to do this in the main tempest: https://github.com/openstack/tempest/blob/422ded886232067a393ec8fc4971580525e41ffe/tempest/api/identity/admin/v2/test_roles.py#L61-L77","commit_id":"215abbd2f4d8aa302aa4f28cf6b768c0f7e5d72f"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"6a6f5663315614e9f7c1aa2dd086f09f6f83ef49","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class BaseKeyManagerTest(test.BaseTestCase):"},{"line_number":26,"context_line":"    \"\"\"Base class for all api tests.\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    # Why do I have to be an admin to create secrets? No idea..."},{"line_number":29,"context_line":"    credentials \u003d (\u0027admin\u0027, )"},{"line_number":30,"context_line":"    client_manager \u003d clients.Clients"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_97c42360","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":64},"in_reply_to":"ba5201f7_ad848c5d","updated":"2017-01-09 12:35:47.000000000","message":"Is there a way we can create a tempest user specifically for these tests and add the creator role?","commit_id":"215abbd2f4d8aa302aa4f28cf6b768c0f7e5d72f"}],"barbican_tempest_plugin/tests/api/test_secrets.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"7e3b9bb23d43bb3d84a5e230de48c3ec21e3ca51","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class SecretsTest(base.BaseSecretTest):"},{"line_number":20,"context_line":"    \"\"\"Secrets API tests.\"\"\""},{"line_number":21,"context_line":"    def test_create_delete_secret(self):"},{"line_number":22,"context_line":"        sec \u003d self.secret_client.create_secret()"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        # Barbican returns an URL instead of a UUID?"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_654c2943","line":21,"updated":"2017-01-03 15:34:57.000000000","message":"I would like to see this test with a secret with an actual payload, or change the name of this test to reflect that this secret is empty.","commit_id":"49e569b9b17c04722b4c8e1e504778183c963fbb"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"7e3b9bb23d43bb3d84a5e230de48c3ec21e3ca51","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        # Barbican returns an URL instead of a UUID?"},{"line_number":25,"context_line":"        sec_url \u003d sec[\u0027secret_ref\u0027]"},{"line_number":26,"context_line":"        uuid \u003d sec_url.split(\u0027/\u0027)[-1]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        self.secret_client.delete_secret(uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_320d0591","line":26,"updated":"2017-01-03 15:34:57.000000000","message":"I would recommend putting this in its own function. You\u0027ll need to do this to get UUIDs from every href the Barbican API returns.","commit_id":"49e569b9b17c04722b4c8e1e504778183c963fbb"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"523aee15586437051cde1c0ce2edcde4d96dd06b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        uuid \u003d self._get_uuid(sec[\u0027secret_ref\u0027])"},{"line_number":36,"context_line":"        self.secret_client.delete_secret(uuid)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_create_delete_symmetric_key(self):"},{"line_number":39,"context_line":"        password \u003d b\"password\""},{"line_number":40,"context_line":"        salt \u003d os.urandom(16)"},{"line_number":41,"context_line":"        kdf \u003d PBKDF2HMAC("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_e5dbf21f","line":38,"updated":"2017-01-09 15:49:11.000000000","message":"Is there some sort of a cleanup mechanism? For example in this Keystone test, it adds a cleanup statement for the object that\u0027s created in case it doesn\u0027t get deleted by the test: https://github.com/openstack/tempest/blob/422ded886232067a393ec8fc4971580525e41ffe/tempest/api/identity/admin/v2/test_roles.py#L61-L77","commit_id":"215abbd2f4d8aa302aa4f28cf6b768c0f7e5d72f"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"05d0d4cbbe346efb7ca3ed1a6925ebb922d07208","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class SecretsTest(base.BaseKeyManagerTest):"},{"line_number":29,"context_line":"    \"\"\"Secrets API tests.\"\"\""},{"line_number":30,"context_line":"    def _get_uuid(self, href):"},{"line_number":31,"context_line":"        return href.split(\u0027/\u0027)[-1]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_create_delete_empty_secret(self):"},{"line_number":34,"context_line":"        sec \u003d self.create_secret()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_14d62927","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":34},"updated":"2017-01-10 17:19:53.000000000","message":"This is also defined in base.py as a global function. Is this just a duplicate? Or vice versa?","commit_id":"74061dd53c2ea876a41d32294367b54587f868da"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"86bfc66e9fa613dd2ded75887a09aef8dc8108c6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class SecretsTest(base.BaseKeyManagerTest):"},{"line_number":29,"context_line":"    \"\"\"Secrets API tests.\"\"\""},{"line_number":30,"context_line":"    def _get_uuid(self, href):"},{"line_number":31,"context_line":"        return href.split(\u0027/\u0027)[-1]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_create_delete_empty_secret(self):"},{"line_number":34,"context_line":"        sec \u003d self.create_secret()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_1a95733f","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":34},"in_reply_to":"ba5201f7_14d62927","updated":"2017-01-10 17:23:59.000000000","message":"Yes this is a duplicate left over from the previous patch set. I\u0027ll resolve it in the next patch set.","commit_id":"74061dd53c2ea876a41d32294367b54587f868da"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"c7b36a42531b98391e060fa96967dcd269a0f088","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class SecretsTest(base.BaseKeyManagerTest):"},{"line_number":29,"context_line":"    \"\"\"Secrets API tests.\"\"\""},{"line_number":30,"context_line":"    def _get_uuid(self, href):"},{"line_number":31,"context_line":"        return href.split(\u0027/\u0027)[-1]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_create_delete_empty_secret(self):"},{"line_number":34,"context_line":"        sec \u003d self.create_secret()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_fab8af77","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":34},"in_reply_to":"ba5201f7_1a95733f","updated":"2017-01-10 17:31:28.000000000","message":"Actually, doesn\u0027t it need to be duplicated in order to be in the proper scope? SecretsTest can\u0027t access _get_uuid from its global definition in BaseKeyManagerTest and vice versa.","commit_id":"74061dd53c2ea876a41d32294367b54587f868da"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"905b4a622bdb640ceb7bfe54ccc7a7a5b3f5b167","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class SecretsTest(base.BaseKeyManagerTest):"},{"line_number":29,"context_line":"    \"\"\"Secrets API tests.\"\"\""},{"line_number":30,"context_line":"    def _get_uuid(self, href):"},{"line_number":31,"context_line":"        return href.split(\u0027/\u0027)[-1]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_create_delete_empty_secret(self):"},{"line_number":34,"context_line":"        sec \u003d self.create_secret()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_a3a414a6","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":34},"in_reply_to":"ba5201f7_f4f51eed","updated":"2017-01-11 14:43:18.000000000","message":"Oh, duh. Done.","commit_id":"74061dd53c2ea876a41d32294367b54587f868da"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"f05456e3d8d7d1f6888bcbeb9f81961e8bca45b7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class SecretsTest(base.BaseKeyManagerTest):"},{"line_number":29,"context_line":"    \"\"\"Secrets API tests.\"\"\""},{"line_number":30,"context_line":"    def _get_uuid(self, href):"},{"line_number":31,"context_line":"        return href.split(\u0027/\u0027)[-1]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_create_delete_empty_secret(self):"},{"line_number":34,"context_line":"        sec \u003d self.create_secret()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_f4f51eed","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":34},"in_reply_to":"ba5201f7_fab8af77","updated":"2017-01-10 19:39:33.000000000","message":"Can\u0027t you do: base._get_uuid(...)?","commit_id":"74061dd53c2ea876a41d32294367b54587f868da"}]}
