)]}'
{"barbican_tempest_plugin/tests/api/base.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"3180cfc81090aad3fd303c053bf5fb3c3ff15165","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from cryptography.hazmat.primitives import hashes"},{"line_number":21,"context_line":"from cryptography.hazmat.primitives.kdf.pbkdf2 import PBKDF2HMAC"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from barbican_tempest_plugin.services.key_manager.v1.json.containers_client \\"},{"line_number":24,"context_line":"    import ContainersClient"},{"line_number":25,"context_line":"from barbican_tempest_plugin.services.key_manager.v1.json.metadata_client \\"},{"line_number":26,"context_line":"    import MetadataClient"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_b213dc5b","line":23,"updated":"2016-12-30 22:37:02.000000000","message":"This import statement will fail (along with the ones below) because there aren\u0027t \"__init__.py\" files in the key_manager, v1, and json directories.","commit_id":"56e04e53e3cd9b0e5c3073c5c0677e68c0c17698"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"3180cfc81090aad3fd303c053bf5fb3c3ff15165","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    return decorator"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class BaseBarbicanTest(api_version_utils.BaseMicroversionTest,"},{"line_number":60,"context_line":"                       test.BaseTestCase):"},{"line_number":61,"context_line":"    \"\"\"Base class for Barbican API tests.\"\"\""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_f21d6467","line":59,"updated":"2016-12-30 22:37:02.000000000","message":"There\u0027s also a \"BaseSecretTest\" in the https://review.openstack.org/#/c/409725/ patch -- should this inherit from that instead of test.BaseTestCase (since it claims to be the base class for all api tests)?","commit_id":"56e04e53e3cd9b0e5c3073c5c0677e68c0c17698"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"3180cfc81090aad3fd303c053bf5fb3c3ff15165","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def setup_clients(cls):"},{"line_number":65,"context_line":"        super(BaseBarbicanTest, cls).setup_clients()"},{"line_number":66,"context_line":"        cls.containers_client \u003d ContainersClient()"},{"line_number":67,"context_line":"        cls.metadata_client \u003d MetadataClient()"},{"line_number":68,"context_line":"        cls.quotas_client \u003d QuotasClient()"},{"line_number":69,"context_line":"        cls.secrets_client \u003d SecretsClient()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_5252b014","line":66,"updated":"2016-12-30 22:37:02.000000000","message":"The ContainersClient inherits from the tempest.lib.common RestClient, which requires an \"auth_provider,\" \"service,\" and \"region\" upon initialization (see https://github.com/openstack/tempest/blob/master/tempest/lib/common/rest_client.py#L79)\n\nSince it looks like you\u0027re going off of the ironic_tempest_plugin, it looks like the ironic client was initialized here: https://github.com/openstack/ironic/blob/master/ironic_tempest_plugin/clients.py#L45","commit_id":"56e04e53e3cd9b0e5c3073c5c0677e68c0c17698"}]}
