)]}'
{"barbican_tempest_plugin/services/key_manager/json/container_client.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"8e714b3b73edf258f79a50de4f14727f3a7d8520","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ContainerClient(rest_client.RestClient):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_containers(self, **kwargs):"},{"line_number":29,"context_line":"        uri \u003d \"v1/containers\""},{"line_number":30,"context_line":"        if kwargs:"},{"line_number":31,"context_line":"            uri +\u003d \"?%s\" % urllib.urlencode(kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_1660c334","line":28,"updated":"2017-01-11 13:28:25.000000000","message":"Maybe call this list_containers? That would differentiate it from the following method and keep it consistent with the Secrets client.","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"c07349f1e4779dfc4fb9b0773af08ddfd693f9f3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ContainerClient(rest_client.RestClient):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_containers(self, **kwargs):"},{"line_number":29,"context_line":"        uri \u003d \"v1/containers\""},{"line_number":30,"context_line":"        if kwargs:"},{"line_number":31,"context_line":"            uri +\u003d \"?%s\" % urllib.urlencode(kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_0cffd601","line":28,"in_reply_to":"ba5201f7_1660c334","updated":"2017-01-11 13:42:04.000000000","message":"Done","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"8e714b3b73edf258f79a50de4f14727f3a7d8520","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        response, body \u003d self.get(uri)"},{"line_number":34,"context_line":"        self.expected_success(200, response.status)"},{"line_number":35,"context_line":"        return response, json.loads(body)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_container(self, uuid):"},{"line_number":38,"context_line":"        uri \u003d \"v1/containers/%s\" % uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_76a2ef4c","line":35,"updated":"2017-01-11 13:28:25.000000000","message":"Is there any reason we need to return both response and body here? In the Secrets client we are generally only returning the parsed body.","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"3219104524fb7f46631de2ba9bbbc85b8785fe8e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        response, body \u003d self.get(uri)"},{"line_number":34,"context_line":"        self.expected_success(200, response.status)"},{"line_number":35,"context_line":"        return response, json.loads(body)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_container(self, uuid):"},{"line_number":38,"context_line":"        uri \u003d \"v1/containers/%s\" % uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_27b913cc","line":35,"in_reply_to":"ba5201f7_67f6bbfa","updated":"2017-01-11 13:55:35.000000000","message":"Done","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"c07349f1e4779dfc4fb9b0773af08ddfd693f9f3","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        response, body \u003d self.get(uri)"},{"line_number":34,"context_line":"        self.expected_success(200, response.status)"},{"line_number":35,"context_line":"        return response, json.loads(body)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_container(self, uuid):"},{"line_number":38,"context_line":"        uri \u003d \"v1/containers/%s\" % uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_8cce6681","line":35,"in_reply_to":"ba5201f7_76a2ef4c","updated":"2017-01-11 13:42:04.000000000","message":"This version of the client mimics the BaremetalClient in the ironic_tempest_plugin repo (see https://github.com/openstack/ironic/blob/master/ironic_tempest_plugin/services/baremetal/base.py) which returns both. I\u0027m not sure if the tests that leverage the clients would ever need/want access to the actual response, so I return both.\n\nI\u0027m fine with changing this to just return the body if we decide that that\u0027s sufficient.","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"5a99ac8e52d5707e3c2d317374bdefec74807d18","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        response, body \u003d self.get(uri)"},{"line_number":34,"context_line":"        self.expected_success(200, response.status)"},{"line_number":35,"context_line":"        return response, json.loads(body)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_container(self, uuid):"},{"line_number":38,"context_line":"        uri \u003d \"v1/containers/%s\" % uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_67f6bbfa","line":35,"in_reply_to":"ba5201f7_8cce6681","updated":"2017-01-11 13:48:21.000000000","message":"Let\u0027s just return the body for simplicity\u0027s sake for now.","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"8e714b3b73edf258f79a50de4f14727f3a7d8520","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.expected_success(204, response.status)"},{"line_number":56,"context_line":"        return response, json.loads(body)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def add_secret_to_container(self, uuid, **kwargs):"},{"line_number":59,"context_line":"        content_header \u003d {\"X-Project-Id\": self.tenant_id}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        uri \u003d \"v1/containers/%s/secrets\" % uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_b11b811b","line":58,"updated":"2017-01-11 13:28:25.000000000","message":"I think add_secret_to_container(self, container_uuid, secret_uuid, **kwargs) is preferable. You need a secret uuid to call this method, so it shouldn\u0027t really be kwarg. Also, this way the user only has to know the secret_uuid and is not responsible for constructing the secret_ref themselves.","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"c07349f1e4779dfc4fb9b0773af08ddfd693f9f3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.expected_success(204, response.status)"},{"line_number":56,"context_line":"        return response, json.loads(body)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def add_secret_to_container(self, uuid, **kwargs):"},{"line_number":59,"context_line":"        content_header \u003d {\"X-Project-Id\": self.tenant_id}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        uri \u003d \"v1/containers/%s/secrets\" % uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_eced32b8","line":58,"in_reply_to":"ba5201f7_b11b811b","updated":"2017-01-11 13:42:04.000000000","message":"Good point. Done.","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"8e714b3b73edf258f79a50de4f14727f3a7d8520","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return response, json.loads(body)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def add_secret_to_container(self, uuid, **kwargs):"},{"line_number":59,"context_line":"        content_header \u003d {\"X-Project-Id\": self.tenant_id}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        uri \u003d \"v1/containers/%s/secrets\" % uuid"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_71859905","line":59,"updated":"2017-01-11 13:28:25.000000000","message":"I\u0027m curious as to why this is necessary. It seems like the container uuid should be sufficient / more specific than the project ID. Not saying you should change anything here, just curious.","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"8e714b3b73edf258f79a50de4f14727f3a7d8520","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.expected_success(201, response.status)"},{"line_number":69,"context_line":"        return response, json.loads(body)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def delete_secret_from_container(self, uuid, **kwargs):"},{"line_number":72,"context_line":"        content_header \u003d {\"X-Project-Id\": self.tenant_id}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        uri \u003d \"v1/containers/%s/secrets\" % uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_d1ad6589","line":71,"updated":"2017-01-11 13:28:25.000000000","message":"Same thing here, this should take the container and secret uuids as params.","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"c07349f1e4779dfc4fb9b0773af08ddfd693f9f3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.expected_success(201, response.status)"},{"line_number":69,"context_line":"        return response, json.loads(body)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def delete_secret_from_container(self, uuid, **kwargs):"},{"line_number":72,"context_line":"        content_header \u003d {\"X-Project-Id\": self.tenant_id}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        uri \u003d \"v1/containers/%s/secrets\" % uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_cc778e00","line":71,"in_reply_to":"ba5201f7_d1ad6589","updated":"2017-01-11 13:42:04.000000000","message":"Done","commit_id":"06bd6494b76f80e016fcf8e92235391e2a2423a1"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"1cc8e2b77817e8471cf17bd3b371db4dbe21030b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.expected_success(204, response.status)"},{"line_number":56,"context_line":"        return"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def add_secret_to_container(self, container_id, secret_id, **kwargs):"},{"line_number":59,"context_line":"        uri \u003d \"v1/containers/%s/secrets\" % container_id"},{"line_number":60,"context_line":"        kwargs[\u0027secret_ref\u0027] \u003d \"%s/v1/secrets/%s\" % ("},{"line_number":61,"context_line":"            self.auth_provider.base_url({\"service\": \"key-manager\"}),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_0aee3c8b","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":73},"updated":"2017-01-12 16:04:55.000000000","message":"Turns out you don\u0027t need to specify the X-Project-Id header here afterall. Setting the header here prevented the content-type header from getting added. No idea if the X-Project-Id header is added automatically higher up.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"45778e725d78942f59003bd7afc8e87ab01430df","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.expected_success(204, response.status)"},{"line_number":56,"context_line":"        return"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def add_secret_to_container(self, container_id, secret_id, **kwargs):"},{"line_number":59,"context_line":"        uri \u003d \"v1/containers/%s/secrets\" % container_id"},{"line_number":60,"context_line":"        kwargs[\u0027secret_ref\u0027] \u003d \"%s/v1/secrets/%s\" % ("},{"line_number":61,"context_line":"            self.auth_provider.base_url({\"service\": \"key-manager\"}),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_2d795a94","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":73},"in_reply_to":"9a57fde8_0aee3c8b","updated":"2017-01-12 16:15:16.000000000","message":"Nice. Good catch. I\u0027d guess that it gets added somewhere in Tempest\u0027s Rest Client.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"}],"barbican_tempest_plugin/tests/api/base.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"23e44787723d9f71767f82b2ad6312b7b6b91af0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        super(BaseKeyManagerTest, cls).setup_clients()"},{"line_number":61,"context_line":"        os \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":62,"context_line":"        cls.secret_client \u003d os.secret_v1.SecretClient(service\u003d\u0027key-manager\u0027)"},{"line_number":63,"context_line":"        cls.container_client \u003d os.secret_v1.ContainerClient("},{"line_number":64,"context_line":"            service\u003d\u0027key-manager\u0027"},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @classmethod"},{"line_number":68,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_144994b7","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":9},"updated":"2017-01-11 15:37:46.000000000","message":"I don\u0027t fully appreciate yet why we\u0027re going through \u0027BaseKeyManagerTest.os_admin\u0027 to get to the clients; I haven\u0027t found an \u0027os_admin\u0027 attribute yet. I just copied the above line, so this may be wrong.","commit_id":"b72e490d910d80fd17c027dac4effdc0f961ee01"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"1cc8e2b77817e8471cf17bd3b371db4dbe21030b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    @classmethod"},{"line_number":74,"context_line":"    def resource_cleanup(cls):"},{"line_number":75,"context_line":"        try:"},{"line_number":76,"context_line":"            for secret_uuid in list(cls.created_objects[\u0027secret\u0027]):"},{"line_number":77,"context_line":"                cls.delete_secret(secret_uuid)"},{"line_number":78,"context_line":"            for container_uuid in list(cls.created_objects[\u0027container\u0027]):"},{"line_number":79,"context_line":"                cls.delete_container(container_uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_ea4658be","line":76,"range":{"start_line":76,"start_character":31,"end_line":76,"end_character":66},"updated":"2017-01-12 16:04:55.000000000","message":"Gotta use a copy of the set here for iteration \u0027cause we\u0027re removing IDs from the original set in the loop itself.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"45778e725d78942f59003bd7afc8e87ab01430df","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    @classmethod"},{"line_number":74,"context_line":"    def resource_cleanup(cls):"},{"line_number":75,"context_line":"        try:"},{"line_number":76,"context_line":"            for secret_uuid in list(cls.created_objects[\u0027secret\u0027]):"},{"line_number":77,"context_line":"                cls.delete_secret(secret_uuid)"},{"line_number":78,"context_line":"            for container_uuid in list(cls.created_objects[\u0027container\u0027]):"},{"line_number":79,"context_line":"                cls.delete_container(container_uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_cd90ce98","line":76,"range":{"start_line":76,"start_character":31,"end_line":76,"end_character":66},"in_reply_to":"9a57fde8_ea4658be","updated":"2017-01-12 16:15:16.000000000","message":"Yup I hit this bug yesterday and I was debating whether to put the fix in a separate patch or not. Doing it here is fine in my opinion.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"}],"barbican_tempest_plugin/tests/api/test_containers.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"1cc8e2b77817e8471cf17bd3b371db4dbe21030b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertIn(\u0027updated\u0027, container, container)"},{"line_number":60,"context_line":"        self.assertIn(\u0027creator_id\u0027, container, container)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Leave the container behind to get cleaned up by infra."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_add_to_delete_from_container(self):"},{"line_number":65,"context_line":"        # Create a container to test against."}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_6aa42857","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":64},"updated":"2017-01-12 16:04:55.000000000","message":"This ensures we\u0027re can clean up after ourselves automatically. We test delete_container in the next test.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"45778e725d78942f59003bd7afc8e87ab01430df","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertIn(\u0027updated\u0027, container, container)"},{"line_number":60,"context_line":"        self.assertIn(\u0027creator_id\u0027, container, container)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Leave the container behind to get cleaned up by infra."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_add_to_delete_from_container(self):"},{"line_number":65,"context_line":"        # Create a container to test against."}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_adf54a84","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":64},"in_reply_to":"9a57fde8_6aa42857","updated":"2017-01-12 16:15:16.000000000","message":"Fine by me. The comment probably isn\u0027t necessary. I\u0027m kind of surprised that a comment without code after it isn\u0027t a pep8 error of some sort.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"29aa8f8c0c2076ea82524d1bb0b3ce7360284f41","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertIn(\u0027updated\u0027, container, container)"},{"line_number":60,"context_line":"        self.assertIn(\u0027creator_id\u0027, container, container)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Leave the container behind to get cleaned up by infra."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_add_to_delete_from_container(self):"},{"line_number":65,"context_line":"        # Create a container to test against."}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_8054cd54","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":64},"in_reply_to":"9a57fde8_adf54a84","updated":"2017-01-12 16:35:45.000000000","message":"I thought about leaving it out but I figured it would help any future dev understand that the lack of a delete_container call here isn\u0027t a bug.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"1cc8e2b77817e8471cf17bd3b371db4dbe21030b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            self.assertIn(secret_id, (secret1_id, secret2_id))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # Remove the secrets from the container"},{"line_number":107,"context_line":"        self.container_client.delete_secret_from_container("},{"line_number":108,"context_line":"            container_id,"},{"line_number":109,"context_line":"            secret1_id"},{"line_number":110,"context_line":"        )"},{"line_number":111,"context_line":"        self.container_client.delete_secret_from_container("},{"line_number":112,"context_line":"            container_id,"},{"line_number":113,"context_line":"            secret2_id"},{"line_number":114,"context_line":"        )"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Confirm that the container is empty"},{"line_number":117,"context_line":"        body \u003d self.container_client.get_container(container_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_eaa7384d","line":114,"range":{"start_line":107,"start_character":0,"end_line":114,"end_character":9},"updated":"2017-01-12 16:04:55.000000000","message":"We leave these secrets behind to ensure we can clean up after ourselves.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"29aa8f8c0c2076ea82524d1bb0b3ce7360284f41","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            self.assertIn(secret_id, (secret1_id, secret2_id))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # Remove the secrets from the container"},{"line_number":107,"context_line":"        self.container_client.delete_secret_from_container("},{"line_number":108,"context_line":"            container_id,"},{"line_number":109,"context_line":"            secret1_id"},{"line_number":110,"context_line":"        )"},{"line_number":111,"context_line":"        self.container_client.delete_secret_from_container("},{"line_number":112,"context_line":"            container_id,"},{"line_number":113,"context_line":"            secret2_id"},{"line_number":114,"context_line":"        )"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Confirm that the container is empty"},{"line_number":117,"context_line":"        body \u003d self.container_client.get_container(container_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_40d105cd","line":114,"range":{"start_line":107,"start_character":0,"end_line":114,"end_character":9},"in_reply_to":"9a57fde8_6d88c2e8","updated":"2017-01-12 16:35:45.000000000","message":"Yes, the secrets have been removed from the container but still exist in the key manager as independent entities.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"45778e725d78942f59003bd7afc8e87ab01430df","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            self.assertIn(secret_id, (secret1_id, secret2_id))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # Remove the secrets from the container"},{"line_number":107,"context_line":"        self.container_client.delete_secret_from_container("},{"line_number":108,"context_line":"            container_id,"},{"line_number":109,"context_line":"            secret1_id"},{"line_number":110,"context_line":"        )"},{"line_number":111,"context_line":"        self.container_client.delete_secret_from_container("},{"line_number":112,"context_line":"            container_id,"},{"line_number":113,"context_line":"            secret2_id"},{"line_number":114,"context_line":"        )"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Confirm that the container is empty"},{"line_number":117,"context_line":"        body \u003d self.container_client.get_container(container_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a57fde8_6d88c2e8","line":114,"range":{"start_line":107,"start_character":0,"end_line":114,"end_character":9},"in_reply_to":"9a57fde8_eaa7384d","updated":"2017-01-12 16:15:16.000000000","message":"By \"behind\" you mean, still in the key manager, correct? To be 100% clear to other reviewers, removing a secret from a container does not remove them from the key manager.","commit_id":"7be3f7e13c83abd5fcd53eb4d19a09f76881b61f"}]}
