)]}'
{"barbican_tempest_plugin/services/key_manager/json/__init__.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"3a5f0e5c92fcdbb1252257bd9f9c9687db763978","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    import ConsumerClient"},{"line_number":17,"context_line":"from barbican_tempest_plugin.services.key_manager.json.container_client \\"},{"line_number":18,"context_line":"    import ContainerClient"},{"line_number":19,"context_line":"from barbican_tempest_plugin.services.key_manager.json.metadata_client \\"},{"line_number":20,"context_line":"    import SecretMetadataClient"},{"line_number":21,"context_line":"from barbican_tempest_plugin.services.key_manager.json.secret_client \\"},{"line_number":22,"context_line":"    import SecretClient"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a461143_7bfaa444","line":19,"range":{"start_line":19,"start_character":55,"end_line":19,"end_character":70},"updated":"2017-01-30 15:14:26.000000000","message":"Should this also be updated (and the file renamed) to be \"secret_metadata_client\" for consistency?","commit_id":"27991ed116b3181f1e73e73a05fac11aa7c1b1d4"}],"barbican_tempest_plugin/services/key_manager/json/metadata_client.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"5dc73dabc997b3da8198f9d18c912f90c92fd247","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Johns Hopkins University Applied Physics Laboratory"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_7f38fb3d","line":1,"updated":"2017-01-27 22:05:57.000000000","message":"2017","commit_id":"0a29d0ee5c564c20c5c0e69c60d090ca6e2ca244"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"b95480ae946e7af67d2de43e00b6ab7028debe21","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class MetadataClient(rest_client.RestClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_secret_metadata(self, secret_id):"},{"line_number":27,"context_line":"        resp, body \u003d self.get(\"v1/secrets/%s/metadata\" % secret_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_8d1b011b","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":20},"updated":"2017-01-26 16:30:16.000000000","message":"What do you think about calling this SecretMetadataClient?  In the barbican docs, it\u0027s referred to as \u0027secret metadata\u0027, rather than just \u0027metadata\u0027.","commit_id":"0a29d0ee5c564c20c5c0e69c60d090ca6e2ca244"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"5dc73dabc997b3da8198f9d18c912f90c92fd247","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class MetadataClient(rest_client.RestClient):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_secret_metadata(self, secret_id):"},{"line_number":27,"context_line":"        resp, body \u003d self.get(\"v1/secrets/%s/metadata\" % secret_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_5f333f62","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":20},"in_reply_to":"3a461143_8d1b011b","updated":"2017-01-27 22:05:57.000000000","message":"I agree, especially given the naming of the methods.","commit_id":"0a29d0ee5c564c20c5c0e69c60d090ca6e2ca244"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"5dc73dabc997b3da8198f9d18c912f90c92fd247","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.expected_success(201, resp.status)"},{"line_number":53,"context_line":"        return self._parse_resp(body)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def update_metadata(self, secret_id, key, value):"},{"line_number":56,"context_line":"        uri \u003d \"v1/secrets/{uuid}/metadata/{key}\".format(uuid\u003dsecret_id,"},{"line_number":57,"context_line":"                                                        key\u003dkey)"},{"line_number":58,"context_line":"        body_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_1f2d37fe","line":55,"updated":"2017-01-27 22:05:57.000000000","message":"All the other methods use \"secret\" before \"metadata\" -- it might be good to update this one to be \"update_secret_metadata\" instead.","commit_id":"0a29d0ee5c564c20c5c0e69c60d090ca6e2ca244"}],"barbican_tempest_plugin/tests/api/base.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"3a5f0e5c92fcdbb1252257bd9f9c9687db763978","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        cls.container_client \u003d os.secret_v1.ContainerClient("},{"line_number":66,"context_line":"            service\u003d\u0027key-manager\u0027"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":"        cls.metadata_client \u003d os.secret_v1.SecretMetadataClient("},{"line_number":69,"context_line":"            service\u003d\u0027key-manager\u0027"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        cls.secret_client \u003d os.secret_v1.SecretClient(service\u003d\u0027key-manager\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a461143_bbbdec69","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":27},"updated":"2017-01-30 15:14:26.000000000","message":"Should this be called \"cls.secret_metadata_client\"?","commit_id":"27991ed116b3181f1e73e73a05fac11aa7c1b1d4"}],"barbican_tempest_plugin/tests/api/test_metadata.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"5dc73dabc997b3da8198f9d18c912f90c92fd247","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Johns Hopkins Applied Physics Lab"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_9f4127ac","line":1,"updated":"2017-01-27 22:05:57.000000000","message":"2017","commit_id":"0a29d0ee5c564c20c5c0e69c60d090ca6e2ca244"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"3a5f0e5c92fcdbb1252257bd9f9c9687db763978","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from barbican_tempest_plugin.tests.api import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class MetadataTest(base.BaseKeyManagerTest):"},{"line_number":20,"context_line":"    \"\"\"Metadata API test\"\"\""},{"line_number":21,"context_line":"    def test_metadata(self):"},{"line_number":22,"context_line":"        # Create a secret"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a461143_7b7f04ab","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":18},"updated":"2017-01-30 15:14:26.000000000","message":"Should this be \"SecretMetadataTest\" (and the file name updated to \"test_secret_metadata\")?","commit_id":"27991ed116b3181f1e73e73a05fac11aa7c1b1d4"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"3a5f0e5c92fcdbb1252257bd9f9c9687db763978","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class MetadataTest(base.BaseKeyManagerTest):"},{"line_number":20,"context_line":"    \"\"\"Metadata API test\"\"\""},{"line_number":21,"context_line":"    def test_metadata(self):"},{"line_number":22,"context_line":"        # Create a secret"},{"line_number":23,"context_line":"        sec \u003d self.create_secret()"},{"line_number":24,"context_line":"        uuid \u003d base._get_uuid(sec[\u0027secret_ref\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a461143_bb4b2c86","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":21},"updated":"2017-01-30 15:14:26.000000000","message":"test_secret_metadata","commit_id":"27991ed116b3181f1e73e73a05fac11aa7c1b1d4"}]}
