)]}'
{"barbican_tempest_plugin/tests/scenario/barbican_manager.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"8aa3515a290650137300137e32ba7dbd8cac7efa","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        LOG.debug(\"Creating an encryption type for volume type: %s\", type_id)"},{"line_number":182,"context_line":"        client.create_encryption_type("},{"line_number":183,"context_line":"            type_id, provider\u003dprovider, key_size\u003dkey_size, cipher\u003dcipher,"},{"line_number":184,"context_line":"            control_location\u003dcontrol_location)[\u0027encryption\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_f7d85b1e","line":184,"range":{"start_line":184,"start_character":46,"end_line":184,"end_character":60},"updated":"2017-03-29 20:07:02.000000000","message":"Is there a need to index into the result of the call to client.create_encryption_type? Is this meant to trigger an exception if the key isn\u0027t present? If not, this should be removed.","commit_id":"e3e87e314c2e42abdde76f2d05fdc2ab46aa686e"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"edf94294ee5830eb9f63c987a59d6bf1e73e8ced","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        LOG.debug(\"Creating an encryption type for volume type: %s\", type_id)"},{"line_number":182,"context_line":"        client.create_encryption_type("},{"line_number":183,"context_line":"            type_id, provider\u003dprovider, key_size\u003dkey_size, cipher\u003dcipher,"},{"line_number":184,"context_line":"            control_location\u003dcontrol_location)[\u0027encryption\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_9736af02","line":184,"range":{"start_line":184,"start_character":46,"end_line":184,"end_character":60},"in_reply_to":"ffe62b97_f7d85b1e","updated":"2017-03-29 20:16:12.000000000","message":"Weird. I don\u0027t know why that was there. Removed in current patch.","commit_id":"e3e87e314c2e42abdde76f2d05fdc2ab46aa686e"}],"barbican_tempest_plugin/tests/scenario/manager.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"5e0ccd2167b1af1d3d6a8a71dc5664efd58e5d49","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                                            private_key\u003dprivate_key)"},{"line_number":349,"context_line":"        if dev_name is not None:"},{"line_number":350,"context_line":"            ssh_client.make_fs(dev_name)"},{"line_number":351,"context_line":"            ssh_client.exec_command(\u0027sudo mount /dev/%s %s\u0027 % (dev_name,"},{"line_number":352,"context_line":"                                                               mount_path))"},{"line_number":353,"context_line":"        cmd_timestamp \u003d \u0027sudo sh -c \"date \u003e %s/timestamp; sync\"\u0027 % mount_path"},{"line_number":354,"context_line":"        ssh_client.exec_command(cmd_timestamp)"},{"line_number":355,"context_line":"        timestamp \u003d ssh_client.exec_command(\u0027sudo cat %s/timestamp\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"ffe62b97_9d86cd65","line":352,"range":{"start_line":351,"start_character":12,"end_line":352,"end_character":75},"updated":"2017-03-29 23:05:25.000000000","message":"NIT: I know that this was just copied/pasted from the old manager.py, but could just call `ssh_client.mount` here\n\n  ssh_client.mount(dev_name, mount_path)","commit_id":"53f4fea68b111452ec54774649dadeb3ba4b52cd"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"5e0ccd2167b1af1d3d6a8a71dc5664efd58e5d49","unresolved":false,"context_lines":[{"line_number":358,"context_line":"            ssh_client.exec_command(\u0027sudo umount %s\u0027 % mount_path)"},{"line_number":359,"context_line":"        return timestamp"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def get_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":362,"context_line":"                      private_key\u003dNone):"},{"line_number":363,"context_line":"        ssh_client \u003d self.get_remote_client(ip_address,"},{"line_number":364,"context_line":"                                            private_key\u003dprivate_key)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ffe62b97_fd7a7921","line":361,"updated":"2017-03-29 23:05:25.000000000","message":"NIT: If we care about minimizing the number of functions, we could add a boolean argument called `create` to `get_timestamp` which would allow us to only call `sudo sh -c \"date \u003e %s/timestamp; sync` if `create` is True.","commit_id":"53f4fea68b111452ec54774649dadeb3ba4b52cd"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"74b8e562abeb6a2dde58c5e152d34813f0faf05c","unresolved":false,"context_lines":[{"line_number":358,"context_line":"            ssh_client.exec_command(\u0027sudo umount %s\u0027 % mount_path)"},{"line_number":359,"context_line":"        return timestamp"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def get_timestamp(self, ip_address, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":362,"context_line":"                      private_key\u003dNone):"},{"line_number":363,"context_line":"        ssh_client \u003d self.get_remote_client(ip_address,"},{"line_number":364,"context_line":"                                            private_key\u003dprivate_key)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ffe62b97_ee94fd8c","line":361,"in_reply_to":"ffe62b97_fd7a7921","updated":"2017-03-30 01:35:27.000000000","message":"I\u0027d say probably better to leave these as-is, because hopefully it\u0027s just temporary to have these copy-pasted methods here -- I706e256fe4e224e44532ea0ce2c81495791ec97f mentions the switch back to tempest imports should happen after the tempest manager is refactored","commit_id":"53f4fea68b111452ec54774649dadeb3ba4b52cd"}],"barbican_tempest_plugin/tests/scenario/test_volume_encryption.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"f63498b52e8eaac7091dad65924aa18d45c2c256","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @decorators.idempotent_id(\u002789165fb4-5534-4b9d-8429-97ccffb8f86f\u0027)"},{"line_number":48,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":49,"context_line":"    def test_encrypted_cinder_volumes_luks(self):"},{"line_number":50,"context_line":"        img_uuid \u003d self.sign_and_upload_image()"},{"line_number":51,"context_line":"        server \u003d self.create_server(name\u003d\u0027signed_img_server\u0027,"},{"line_number":52,"context_line":"                                    image_id\u003dimg_uuid,"},{"line_number":53,"context_line":"                                    wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_97420b0f","line":50,"updated":"2017-03-08 21:19:45.000000000","message":"Does it make sense to rely on image signing working in order for volume encryption tests to be run?","commit_id":"c78f61bd38782a1342f6744070f3127276b287aa"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"0836be7ec05a7a7d851894459dcc8453773d8901","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @decorators.idempotent_id(\u002789165fb4-5534-4b9d-8429-97ccffb8f86f\u0027)"},{"line_number":48,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":49,"context_line":"    def test_encrypted_cinder_volumes_luks(self):"},{"line_number":50,"context_line":"        img_uuid \u003d self.sign_and_upload_image()"},{"line_number":51,"context_line":"        server \u003d self.create_server(name\u003d\u0027signed_img_server\u0027,"},{"line_number":52,"context_line":"                                    image_id\u003dimg_uuid,"},{"line_number":53,"context_line":"                                    wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_682776b6","line":50,"in_reply_to":"9a30ddce_97420b0f","updated":"2017-03-08 23:00:46.000000000","message":"The way that nova is currently configured to use image signing, image signing is either on for every image or off for every image based on a configuration option.  If we wanted to avoid image signing, we\u0027d have to create a new gate with the image signing turned off (since we need image signing turned on for other barbican tempest plugin tests).\n\nSigning the image here can be removed once it\u0027s possible to turn image signing on/off on a per-instance basis (using flavors).  It might be good to add a comment here to that effect.","commit_id":"c78f61bd38782a1342f6744070f3127276b287aa"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"f63498b52e8eaac7091dad65924aa18d45c2c256","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027nova.volume.encryptors.\u0027"},{"line_number":55,"context_line":"                                              \u0027luks.LuksEncryptor\u0027,"},{"line_number":56,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":57,"context_line":"        self.attach_detach_volume(server, volume)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027cbc752ed-b716-4727-910f-956ccf965723\u0027)"},{"line_number":60,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_57d4131f","line":57,"updated":"2017-03-08 21:19:45.000000000","message":"Would it be worth it to assert that the attaching and detaching were successful? Does being able to attach and detach the volume equate to a working encrypted volume?","commit_id":"c78f61bd38782a1342f6744070f3127276b287aa"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"0836be7ec05a7a7d851894459dcc8453773d8901","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027nova.volume.encryptors.\u0027"},{"line_number":55,"context_line":"                                              \u0027luks.LuksEncryptor\u0027,"},{"line_number":56,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":57,"context_line":"        self.attach_detach_volume(server, volume)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027cbc752ed-b716-4727-910f-956ccf965723\u0027)"},{"line_number":60,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_e83b66cf","line":57,"in_reply_to":"9a30ddce_57d4131f","updated":"2017-03-08 23:00:46.000000000","message":"I agree.  Would it be possible to try to write something to the volume, or otherwise confirm it is successfully attached?","commit_id":"c78f61bd38782a1342f6744070f3127276b287aa"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"07246f9c8f6551c4685dc7cb05f29b65ca465a2c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027nova.volume.encryptors.\u0027"},{"line_number":55,"context_line":"                                              \u0027luks.LuksEncryptor\u0027,"},{"line_number":56,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"},{"line_number":57,"context_line":"        self.attach_detach_volume(server, volume)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027cbc752ed-b716-4727-910f-956ccf965723\u0027)"},{"line_number":60,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_3ad19efc","line":57,"in_reply_to":"9a30ddce_e83b66cf","updated":"2017-03-14 18:22:30.000000000","message":"@Jackie and Brianna: The new test writes a file on each volume before detaching.","commit_id":"c78f61bd38782a1342f6744070f3127276b287aa"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"12f2152dfa9aa797847f04522c010d3c39708aca","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Write a timestamp to volume"},{"line_number":48,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":49,"context_line":"        self.create_timestamp(server_ip,"},{"line_number":50,"context_line":"                              private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Detach volume"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a1ff146_944f9e91","line":49,"updated":"2017-03-15 15:46:36.000000000","message":"By default, create_timestamp() writes to \"/mnt\". Is that the encrypted volume in these test cases? Should we check that a valid timestamp is returned and/or that we can\u0027t read an encrypted timestamp?","commit_id":"4e3e41782cf442f261ee121d8aa2c84a146da5e8"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"a64be2bd5b4b1ba75ce260319e3beff96d958f37","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Write a timestamp to volume"},{"line_number":48,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":49,"context_line":"        self.create_timestamp(server_ip,"},{"line_number":50,"context_line":"                              private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Detach volume"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a1ff146_b748eb88","line":49,"in_reply_to":"3a1ff146_06645647","updated":"2017-03-16 15:36:48.000000000","message":"Looks like if we pass in the pre-configured device name as dev_name it will mount the volume and we want and write to it [1]. We can read from the volume through the ssh connection we\u0027re making, but that doesn\u0027t prove anything about the encryption really. Accessing the volume via reading a backing file on the storage host isn\u0027t feasible.\n\n1.https://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L638","commit_id":"4e3e41782cf442f261ee121d8aa2c84a146da5e8"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"e0373fd5f75ac7b47acce8e9853603e1d029de05","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Write a timestamp to volume"},{"line_number":48,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":49,"context_line":"        self.create_timestamp(server_ip,"},{"line_number":50,"context_line":"                              private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Detach volume"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a1ff146_06645647","line":49,"in_reply_to":"3a1ff146_944f9e91","updated":"2017-03-15 21:00:53.000000000","message":"+1 for Jackie\u0027s points.\n\ncreate_timestamp writes to /mnt by default [1].\n\nnova_volume_attach mounts at /dev/\u003cvalue from conf file\u003e [2], and the default value for the conf file is \u0027vdb\u0027 [3].\n\nPerhaps all you need to do is change mount_path for create_timestamp to be \"/dev/%s\" % CONF.compute.volume_device_name ?  I don\u0027t think you need to mess with dev_name since the volume is already attached.\n\nAlso, I think writing the timestamp to the volume provides a lot more value if we can also try to read from the volume,  but I have no suggestions for how to do that (since I\u0027m assuming that involves finding the backing file on the filesystem?)\n\n1. https://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L632\n\n2. https://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L495-L496\n\n3. https://github.com/openstack/tempest/blob/master/tempest/config.py#L292","commit_id":"4e3e41782cf442f261ee121d8aa2c84a146da5e8"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"cf6758764b3ee7b53197ea98589a69e6d6ad806d","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Write a timestamp to volume"},{"line_number":48,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":49,"context_line":"        self.create_timestamp(server_ip,"},{"line_number":50,"context_line":"                              private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Detach volume"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_5863961a","line":49,"in_reply_to":"3a1ff146_b748eb88","updated":"2017-03-18 02:54:04.000000000","message":"Can you mimic what\u0027s done in the documented volume encryption tests [1] and create, write to, and read from both, unencrypted and encrypted, volumes? Writing to and reading from the unencrypted volume will prove that writing to and reading from a volume works (i.e., you can actually read from it). Writing to and reading from the encrypted volume will then prove that encryption is working (i.e., you cannot read from the volume).\n\n1. https://docs.openstack.org/mitaka/config-reference/block-storage/volume-encryption.html","commit_id":"4e3e41782cf442f261ee121d8aa2c84a146da5e8"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"49e96a80deced49fb70aadc7131c42a61a47fd55","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Write a timestamp to volume"},{"line_number":48,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":49,"context_line":"        self.create_timestamp(server_ip,"},{"line_number":50,"context_line":"                              dev_name\u003dCONF.compute.volume_device_name,"},{"line_number":51,"context_line":"                              private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Detach volume"},{"line_number":54,"context_line":"        self.nova_volume_detach(server, attached_volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_52c3aa38","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":65},"updated":"2017-03-23 16:48:26.000000000","message":"Can we read the returned value to verify that a generated timestamp can actually be read?","commit_id":"ed2167651f17e814a82d4ffa0448c4ff59a02eee"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"a1882d449d1df108a7a18e29b97b0326e86fde5c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # Attach volume"},{"line_number":45,"context_line":"        attached_volume \u003d self.nova_volume_attach(server, volume)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Write a timestamp to volume"},{"line_number":48,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":49,"context_line":"        self.create_timestamp(server_ip,"},{"line_number":50,"context_line":"                              dev_name\u003dCONF.compute.volume_device_name,"},{"line_number":51,"context_line":"                              private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Detach volume"},{"line_number":54,"context_line":"        self.nova_volume_detach(server, attached_volume)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_1b30f7e7","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":65},"updated":"2017-03-27 21:09:04.000000000","message":"Jackie had a comment on the last patch here about checking the return value.\n\nJust to make sure I\u0027m understanding this correctly, the benefit of attaching, writing a timestamp, and detaching over just attaching and detaching is pretty minimal -- it\u0027s just one small extra check that things are working correctly?  It doesn\u0027t seem to add a whole, whole lot unless we were able to run `strings` on the disk manually to make sure it was encrypted correctly, which you\u0027ve commented earlier is not really feasible.","commit_id":"bf41d0afde55e655c41b5724c3d4509202a66ea8"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"a6b6338862b8f284d3fe8fb5508fdb0e8feffe87","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # Attach volume"},{"line_number":45,"context_line":"        attached_volume \u003d self.nova_volume_attach(server, volume)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Write a timestamp to volume"},{"line_number":48,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":49,"context_line":"        self.create_timestamp(server_ip,"},{"line_number":50,"context_line":"                              dev_name\u003dCONF.compute.volume_device_name,"},{"line_number":51,"context_line":"                              private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Detach volume"},{"line_number":54,"context_line":"        self.nova_volume_detach(server, attached_volume)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_c68072c2","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":65},"in_reply_to":"ffe62b97_1b30f7e7","updated":"2017-03-27 21:30:17.000000000","message":"Yes. Writing a timestamp is just a means to check that the instance is able to read and write the attached volume. It\u0027s not meant to test the encryption.","commit_id":"bf41d0afde55e655c41b5724c3d4509202a66ea8"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"bea600c9f6540d4da8f865c0c5ada6882cd6fc8b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumeEncryptionTest(barbican_manager.BarbicanScenarioTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def skip_checks(cls):"},{"line_number":30,"context_line":"        super(VolumeEncryptionTest, cls).skip_checks()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_d94ee236","line":27,"updated":"2017-03-28 21:15:12.000000000","message":"Could you please add a docstring here or on the individual tests below, like\n\nhttps://github.com/openstack/tempest/blob/39f9363fdddfdbd9ffe260f0f120f29aa21603d4/tempest/scenario/test_encrypted_cinder_volumes.py#L26-L37","commit_id":"f02c4628f4996872b682ba0a314b7e04cfd1d446"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"bea600c9f6540d4da8f865c0c5ada6882cd6fc8b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Write a timestamp to volume"},{"line_number":48,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":49,"context_line":"        self.create_timestamp(server_ip,"},{"line_number":50,"context_line":"                              dev_name\u003dCONF.compute.volume_device_name,"},{"line_number":51,"context_line":"                              private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Detach volume"},{"line_number":54,"context_line":"        self.nova_volume_detach(server, attached_volume)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_e628e197","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":65},"updated":"2017-03-28 21:15:12.000000000","message":"Jackie had a comment on patchset 6 about checking the value of the timestamp, and I agree.  Following the pattern from other tests that use create_timestamp [1], this could be:\n\n  timestamp \u003d self.create_timestamp(server_ip,\n                                    dev_name\u003dCONF.compute.volume_device_name,\n                                    private_key\u003dkeypair[\u0027private_key\u0027])\n\n  timestamp2 \u003d self.get_timestamp(server_ip,\n                                  dev_name\u003dCONF.compute.volume_device_name,\n                                  private_key\u003dkeypair[\u0027private_key\u0027])\n\n  self.assertEqual(timestamp, timestamp2)\n\n\n\n\n1. https://github.com/openstack/tempest/search?utf8\u003d%E2%9C%93\u0026q\u003dcreate_timestamp\u0026type\u003d","commit_id":"f02c4628f4996872b682ba0a314b7e04cfd1d446"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"02c9810a5382f8ca5a90ace16f0ba8ef3902b09f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Write a timestamp to volume"},{"line_number":48,"context_line":"        server_ip \u003d self.get_server_ip(server)"},{"line_number":49,"context_line":"        self.create_timestamp(server_ip,"},{"line_number":50,"context_line":"                              dev_name\u003dCONF.compute.volume_device_name,"},{"line_number":51,"context_line":"                              private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Detach volume"},{"line_number":54,"context_line":"        self.nova_volume_detach(server, attached_volume)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_d33fbd84","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":65},"in_reply_to":"ffe62b97_e628e197","updated":"2017-03-29 13:51:43.000000000","message":"Done. Added a get_timestamp call to attach_detach_volume.","commit_id":"f02c4628f4996872b682ba0a314b7e04cfd1d446"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"4ce0c0f2b5d940a6695677e05a95a840566f112d","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumeEncryptionTest(barbican_manager.BarbicanScenarioTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def skip_checks(cls):"},{"line_number":30,"context_line":"        super(VolumeEncryptionTest, cls).skip_checks()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ffe62b97_c6becbac","line":27,"updated":"2017-03-29 19:07:59.000000000","message":"Copying over my comment from patchset 8:\n\n  Could you please add a docstring here or on the individual \n  tests below, like\n  https://github.com/openstack/tempest/blob/39f9363fdddfdbd9ffe260f0f120f29aa21603d4/tempest/scenario/test_encrypted_cinder_volumes.py#L26-L37\n\nThe image signing scenario had docstrings, too:\n\nhttps://github.com/openstack/barbican-tempest-plugin/blob/master/barbican_tempest_plugin/tests/scenario/test_image_signing.py#L32-L42","commit_id":"7b9dbd145098f515a1a6ae682d0a679ed73e7394"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"e45929f3b30765638c7d585347c2c81a627f0839","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumeEncryptionTest(barbican_manager.BarbicanScenarioTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def skip_checks(cls):"},{"line_number":30,"context_line":"        super(VolumeEncryptionTest, cls).skip_checks()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ffe62b97_3cd34a06","line":27,"in_reply_to":"ffe62b97_c6becbac","updated":"2017-03-29 19:48:26.000000000","message":"Done. Sorry the original comment slipped my mind.","commit_id":"7b9dbd145098f515a1a6ae682d0a679ed73e7394"}]}
